Re: [PR] nimble/host: Initial Broadcast Source implementation [mynewt-nimble]

2023-11-16 Thread via GitHub
KKopyscinski commented on PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#issuecomment-1814330084 Added sample application for broadcast, fixed minor bug in ble_iso.c. Build check (all apps) is failing, seems to me app tries to be built with ll, but was designed for two cor

Re: [PR] nimble/host: Initial Broadcast Source implementation [mynewt-nimble]

2023-11-16 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1395604096 ## nimble/host/services/auracast/src/ble_svc_auracast.c: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] nimble/host: Initial Broadcast Source implementation [mynewt-nimble]

2023-11-16 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1395603739 ## nimble/host/services/auracast/syscfg.yml: ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814248204 `max_peers` parameter passed to `ble_store_util_bonded_peers` is set to `1` which means `ble_store_iterate` will stop iterating after 1st matched peer. There's no need for

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814239868 > This function removes 1 bond which is 1st on the returned list and thus it only needs to retrieve that single bond. There's no need to retrieve all bonded devices only to pi

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814110559 This function removes 1 bond which is 1st on the returned list and thus it only needs to retrieve that single bond. There's no need to retrieve all bonded devices only to

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1813983309 > what exactly was the issue? original code retrieves only 1 address so it looks fine. - Changes were made to accommodate a maximum of BLE_STORE_MAX_BONDS bonds. Previo