Re: [PR] nimble/host: Avoid slave instance reset inside extract_cb [mynewt-nimble]

2024-05-08 Thread via GitHub
rahult-github commented on PR #1773: URL: https://github.com/apache/mynewt-nimble/pull/1773#issuecomment-2101963861 Hi @sjanc , have pushed new version to have a separate API. This will ensure existing code remains same to avoid any race condition. Please have a look -- This is an auto

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100707861 AutoPTS Bot results: Failed testsMESHMESH/NODE/BCN/SNB/BV-01-C FAIL -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100692241 Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100690719 after 16:17:45. -- This is an automated message from the Apache Git Service. To re

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
sjanc commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100690719 #AutoPTS run mynewt MESH/NODE/BCN/SNB/BV-01-C -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] nimble/controller: Add Channel Sounding setup phase [mynewt-nimble]

2024-05-08 Thread via GitHub
sjanc commented on code in PR #1765: URL: https://github.com/apache/mynewt-nimble/pull/1765#discussion_r1594083001 ## nimble/controller/src/ble_ll_cs.c: ## @@ -26,75 +26,956 @@ #include "controller/ble_ll_conn.h" #include "controller/ble_ll_hci.h" #include "controller/ble_ll_

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100648482 AutoPTS Bot results: Failed testsMESHMESH/NODE/CFG/AKL/BV-02-C FAIL -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100634058 Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100341558 after 15:54:59. -- This is an automated message from the Apache Git Service. To re

Re: [PR] nimble/host: Avoid slave instance reset inside extract_cb [mynewt-nimble]

2024-05-08 Thread via GitHub
rahult-github commented on code in PR #1773: URL: https://github.com/apache/mynewt-nimble/pull/1773#discussion_r1594059291 ## nimble/host/src/ble_gap.c: ## @@ -924,6 +923,11 @@ ble_gap_adv_finished(uint8_t instance, int reason, uint16_t conn_handle, ble_gap_event_listener_

Re: [PR] Add support for PACS autopts tests [mynewt-nimble]

2024-05-08 Thread via GitHub
szymon-czapracki commented on code in PR #1747: URL: https://github.com/apache/mynewt-nimble/pull/1747#discussion_r1593987991 ## apps/bttester/src/btp_pacs.c: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] nimble/host: Avoid slave instance reset inside extract_cb [mynewt-nimble]

2024-05-08 Thread via GitHub
sjanc commented on code in PR #1773: URL: https://github.com/apache/mynewt-nimble/pull/1773#discussion_r1593967346 ## nimble/host/src/ble_gap.c: ## @@ -924,6 +923,11 @@ ble_gap_adv_finished(uint8_t instance, int reason, uint16_t conn_handle, ble_gap_event_listener_call(&ev

[PR] apps/auracast_usb: broadcast improvements [mynewt-nimble]

2024-05-08 Thread via GitHub
KKopyscinski opened a new pull request, #1776: URL: https://github.com/apache/mynewt-nimble/pull/1776 this commit: - adds fix for crash on to much/corrupted data on USD - adds support for all LC3 samplerates (besides 44.1kHz - unsupported) - fixes broadcast with HCI feedback disabled

Re: [PR] nimble/host: Zero initialize buffer after allocation [mynewt-nimble]

2024-05-08 Thread via GitHub
rahult-github commented on PR #1687: URL: https://github.com/apache/mynewt-nimble/pull/1687#issuecomment-2100388705 Hello @sjanc , please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100349329 AutoPTS Bot failed: Build and flash step failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
codecoup-tester commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100345547 Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100341558 after 13:19:23. -- This is an automated message from the Apache Git Service. To re

Re: [PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
sjanc commented on PR #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775#issuecomment-2100341558 #AutoPTS run mynewt MESH/NODE/CFG/AKL/BV-02-C -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] nimble/host: Fix legacy advertising API with EXT_ADV enabled [mynewt-nimble]

2024-05-08 Thread via GitHub
sjanc opened a new pull request, #1775: URL: https://github.com/apache/mynewt-nimble/pull/1775 Configured advertisign instance is required in order to set advertising data when extended advertising HCI is used. Since when legacy PDU are in use we can set both AD and SCAN_RSP we can easily p