[GitHub] [mynewt-core] m-gorecki opened a new pull request, #2916: Update depracted clock source settings

2022-12-23 Thread GitBox
m-gorecki opened a new pull request, #2916: URL: https://github.com/apache/mynewt-core/pull/2916 XTAL_32768, XTAL_RC, XTAL_32786_SYNTH are now depracted and we should use MCU_LFCLK_SOURCE setting instead. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2915: apps: Allow stub/full implementation of packages in syscfg

2022-12-22 Thread GitBox
apache-mynewt-bot commented on PR #2915: URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1362706516 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] benpicco commented on pull request #859: Enable NimBLE on Dialog CMAC

2022-12-21 Thread GitBox
benpicco commented on PR #859: URL: https://github.com/apache/mynewt-nimble/pull/859#issuecomment-1361683313 Hi, do you think this could also be used for the DA1458x MCU family or are the differences too big? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] sjanc merged pull request #2914: Enable instruction cache by default on nrf5x

2022-12-21 Thread GitBox
sjanc merged PR #2914: URL: https://github.com/apache/mynewt-core/pull/2914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2914: Enable instruction cache by default on nrf5x

2022-12-21 Thread GitBox
apache-mynewt-bot commented on PR #2914: URL: https://github.com/apache/mynewt-core/pull/2914#issuecomment-1361021350 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-newtmgr] sjanc commented on issue #178: Failed to upload image over BLE using zephyr

2022-12-19 Thread GitBox
sjanc commented on issue #178: URL: https://github.com/apache/mynewt-newtmgr/issues/178#issuecomment-1357792055 nope, although I think we should add that option to that PR before it gets merged -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [mynewt-newtmgr] m-gorecki commented on a diff in pull request #192: Fix not working MTU exchange on newer versions of mac

2022-12-19 Thread GitBox
m-gorecki commented on code in PR #192: URL: https://github.com/apache/mynewt-newtmgr/pull/192#discussion_r1052005242 ## newtmgr/bll/bll_common.go: ## @@ -53,18 +53,25 @@ func exchangeMtu(cln ble.Client, preferredMtu uint16) (uint16, error) { break

[GitHub] [mynewt-newtmgr] ble0 commented on issue #178: Failed to upload image over BLE using zephyr

2022-12-19 Thread GitBox
ble0 commented on issue #178: URL: https://github.com/apache/mynewt-newtmgr/issues/178#issuecomment-1357357484 i can try that, is it possible if I can change the MTU in the command line instead of recompiling? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-newtmgr] sjanc commented on issue #178: Failed to upload image over BLE using zephyr

2022-12-19 Thread GitBox
sjanc commented on issue #178: URL: https://github.com/apache/mynewt-newtmgr/issues/178#issuecomment-1357355094 Hi, If you are using Mac than you may hit issue that seems to happen on latest MacOS... For some (yet unknown) reason reported MTU on latest MacOS makes no sense (lib

[GitHub] [mynewt-newtmgr] sjanc commented on a diff in pull request #192: Fix not working MTU exchange on newer versions of mac

2022-12-19 Thread GitBox
sjanc commented on code in PR #192: URL: https://github.com/apache/mynewt-newtmgr/pull/192#discussion_r1051981408 ## newtmgr/bll/bll_common.go: ## @@ -53,18 +53,25 @@ func exchangeMtu(cln ble.Client, preferredMtu uint16) (uint16, error) { break

[GitHub] [mynewt-newtmgr] ble0 commented on issue #178: Failed to upload image over BLE using zephyr

2022-12-19 Thread GitBox
ble0 commented on issue #178: URL: https://github.com/apache/mynewt-newtmgr/issues/178#issuecomment-1357328695 @AnanthJaisankar the problem also happened to me, do you have a solution that works? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1422: nimble/ll: Make default Resolve List size match HW supported size

2022-12-15 Thread GitBox
apache-mynewt-bot commented on PR #1422: URL: https://github.com/apache/mynewt-nimble/pull/1422#issuecomment-1353555436 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1422: nimble/ll: Make default Resolve List size match HW supported size

2022-12-15 Thread GitBox
sjanc opened a new pull request, #1422: URL: https://github.com/apache/mynewt-nimble/pull/1422 There is no point in defaulting to 4 if HW can do more. Make BLE_LL_RESOLV_LIST_SIZE configure by PHYs instead of LL. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [mynewt-nimble] bvdberg opened a new issue, #1421: When using COC server and send is stalled, disconnects are not detected

2022-12-14 Thread GitBox
bvdberg opened a new issue, #1421: URL: https://github.com/apache/mynewt-nimble/issues/1421 We have an NRF5340 device running Nimble Peripheral. It has a COC server and a GATT server. We connect from a PC application and the device starts streaming data to the PC. Sometimes we get a

[GitHub] [mynewt-nimble] sjanc merged pull request #1420: nimble/host: Add helper macros to set interval min / max for perdiodic adv

2022-12-13 Thread GitBox
sjanc merged PR #1420: URL: https://github.com/apache/mynewt-nimble/pull/1420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1420: nimble/host: Add helper macros to set interval min / max for perdiodic adv

2022-12-13 Thread GitBox
apache-mynewt-bot commented on PR #1420: URL: https://github.com/apache/mynewt-nimble/pull/1420#issuecomment-1349586152 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1415: nimble/drivers/fem: Add support for nRF21540

2022-12-13 Thread GitBox
andrzej-kaczmarek merged PR #1415: URL: https://github.com/apache/mynewt-nimble/pull/1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-13 Thread GitBox
sjanc merged PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-13 Thread GitBox
apache-mynewt-bot commented on PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-134653 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1420: nimble/host: Add helper macros to set interval min / max for perdiodic adv

2022-12-13 Thread GitBox
apache-mynewt-bot commented on PR #1420: URL: https://github.com/apache/mynewt-nimble/pull/1420#issuecomment-1348487589 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-12 Thread GitBox
andrzej-kaczmarek commented on code in PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#discussion_r1046748612 ## nimble/drivers/fem/sky66112/include/sky66112/sky66112.h: ## @@ -30,6 +30,8 @@ extern "C" { void sky66112_tx_hp_mode(uint8_t enabled); void

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-12 Thread GitBox
andrzej-kaczmarek commented on code in PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#discussion_r1046745228 ## nimble/drivers/fem/sky66112/src/sky66112.c: ## @@ -145,6 +149,18 @@ sky66112_tx_bypass(uint8_t enabled) } } +#if

[GitHub] [mynewt-nimble] rahult-github opened a new pull request, #1420: nimble/host: Add helper macros to set interval min / max for perdiodic adv

2022-12-12 Thread GitBox
rahult-github opened a new pull request, #1420: URL: https://github.com/apache/mynewt-nimble/pull/1420 This PR adds support to define macro for setting periodic adv interval . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-12 Thread GitBox
apache-mynewt-bot commented on PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1347775742 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc merged pull request #1419: porting/examples: Fix build error on linux

2022-12-12 Thread GitBox
sjanc merged PR #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newtmgr] m-gorecki commented on pull request #192: Fix not working MTU exchange on newer versions of mac

2022-12-12 Thread GitBox
m-gorecki commented on PR #192: URL: https://github.com/apache/mynewt-newtmgr/pull/192#issuecomment-1346435829 @ccollins476ad I know this is dirty hack, but we had no better idea to fix this. This way image upload over ble at least works (unless the boards MTU turns out to be less than

[GitHub] [mynewt-newtmgr] m-gorecki opened a new pull request, #192: Fix not working MTU exchange on newer versions of mac

2022-12-12 Thread GitBox
m-gorecki opened a new pull request, #192: URL: https://github.com/apache/mynewt-newtmgr/pull/192 It seems like on newer versions of mac (e.g. Monterey) fix with looping three times to get right MTU doesn't work. Also for some strange reason default TxMTU is set to 17 instead of 23. So

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1419: porting/examples: Fix build error on linux

2022-12-09 Thread GitBox
apache-mynewt-bot commented on PR #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419#issuecomment-1344977713 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1419: porting/examples: Fix build error on linux

2022-12-09 Thread GitBox
apache-mynewt-bot commented on PR #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419#issuecomment-1344636863 ## Style check fail: Payload was too large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1419: porting/examples: Fix build error on linux

2022-12-09 Thread GitBox
apache-mynewt-bot commented on PR #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419#issuecomment-1344415990 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc commented on pull request #1419: porting/examples: Fix build error on linux

2022-12-09 Thread GitBox
sjanc commented on PR #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419#issuecomment-1344250220 @timoxd7 FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1419: porting/examples: Fix build error on linux

2022-12-09 Thread GitBox
sjanc opened a new pull request, #1419: URL: https://github.com/apache/mynewt-nimble/pull/1419 Since 'using namespace std' was removed from public header it is needed to explicitly use it when using std::list -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1402: nimble/host : Feature GATT Caching

2022-12-08 Thread GitBox
IshaESP commented on code in PR #1402: URL: https://github.com/apache/mynewt-nimble/pull/1402#discussion_r1044157927 ## porting/nimble/include/nimble/storage_port.h: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-08 Thread GitBox
IshaESP commented on code in PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044153414 ## nimble/host/include/host/ble_gatt.h: ## @@ -476,8 +477,15 @@ int ble_gatts_notify_custom(uint16_t conn_handle, uint16_t att_handle, /** * Deprecated.

[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-08 Thread GitBox
IshaESP commented on code in PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044152797 ## nimble/host/include/host/ble_hs.h: ## @@ -184,6 +184,22 @@ extern "C" { /** CSRK distibution and LinkKey are not supported */ +/** + * @} + */ + +/** + *

[GitHub] [mynewt-core] kasjer merged pull request #2913: loramac: fix broken rx1 interval

2022-12-08 Thread GitBox
kasjer merged PR #2913: URL: https://github.com/apache/mynewt-core/pull/2913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-08 Thread GitBox
apache-mynewt-bot commented on PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1342827087 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-08 Thread GitBox
apache-mynewt-bot commented on PR #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418#issuecomment-1342801099 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1418: nimble/fem: Add runtime default antenna selection to SKY66112

2022-12-08 Thread GitBox
sjanc opened a new pull request, #1418: URL: https://github.com/apache/mynewt-nimble/pull/1418 This allows to configure default antenna at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-nimble] SumeetSingh19 opened a new issue, #1417: Connection handle is 0xFFFF in attribute access callback when ble_gatts_notify() is called.

2022-12-08 Thread GitBox
SumeetSingh19 opened a new issue, #1417: URL: https://github.com/apache/mynewt-nimble/issues/1417 Whenever the server application calls `ble_gatts_notify` there is a characteristic read event (`access_cb`) and the connection handle passed to that event is 0x. The issue exists

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-06 Thread GitBox
apache-mynewt-bot commented on PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1339759682 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc merged pull request #1414: nimble/ll: Simplify DTM RX test

2022-12-05 Thread GitBox
sjanc merged PR #1414: URL: https://github.com/apache/mynewt-nimble/pull/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1415: nimble/drivers/fem: Add support for nRF21540

2022-12-05 Thread GitBox
apache-mynewt-bot commented on PR #1415: URL: https://github.com/apache/mynewt-nimble/pull/1415#issuecomment-1337191455 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1414: nimble/ll: Simplify DTM RX test

2022-12-05 Thread GitBox
apache-mynewt-bot commented on PR #1414: URL: https://github.com/apache/mynewt-nimble/pull/1414#issuecomment-1337134897 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1402: nimble/host : Feature GATT Caching

2022-12-05 Thread GitBox
sjanc commented on code in PR #1402: URL: https://github.com/apache/mynewt-nimble/pull/1402#discussion_r1026165457 ## apps/advertiser/pkg.yml: ## @@ -31,3 +31,4 @@ pkg.deps: - "@apache-mynewt-nimble/nimble/host" - "@apache-mynewt-nimble/nimble/host/util" -

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-05 Thread GitBox
sjanc commented on code in PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1039423505 ## nimble/host/include/host/ble_hs.h: ## @@ -184,6 +184,22 @@ extern "C" { /** CSRK distibution and LinkKey are not supported */ +/** + * @} + */ + +/** + *

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2913: loramac: fix broken rx1 interval

2022-12-03 Thread GitBox
apache-mynewt-bot commented on PR #2913: URL: https://github.com/apache/mynewt-core/pull/2913#issuecomment-1336194484 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2913: loramac: fix broken rx1 interval

2022-12-03 Thread GitBox
apache-mynewt-bot commented on PR #2913: URL: https://github.com/apache/mynewt-core/pull/2913#issuecomment-1336193059 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] danielkucera opened a new pull request, #2913: loramac: fix broken join1 interval

2022-12-03 Thread GitBox
danielkucera opened a new pull request, #2913: URL: https://github.com/apache/mynewt-core/pull/2913 `lora_mac_process_radio_rx_timeout` is called from `lora_mac_process_rx_win2_timeout` which is triggered when RX2/join2 window starts. The problem here is that there still can be unfinished

[GitHub] [mynewt-nimble] vovagorodok opened a new issue, #1416: LOG_LEVEL defines collision

2022-12-01 Thread GitBox
vovagorodok opened a new issue, #1416: URL: https://github.com/apache/mynewt-nimble/issues/1416 At `log_common.h` we have defined: ``` #define LOG_LEVEL_DEBUG(0) #define LOG_LEVEL_INFO (1) #define LOG_LEVEL_WARN (2) #define LOG_LEVEL_ERROR(3) #define

[GitHub] [mynewt-nimble] sjanc merged pull request #1413: nimble/phy/nrf5x: Implement NRF5340 errata 158

2022-12-01 Thread GitBox
sjanc merged PR #1413: URL: https://github.com/apache/mynewt-nimble/pull/1413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-01 Thread GitBox
apache-mynewt-bot commented on PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1333671337 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1413: nimble/phy/nrf5x: Implement NRF5340 errata 158

2022-12-01 Thread GitBox
apache-mynewt-bot commented on PR #1413: URL: https://github.com/apache/mynewt-nimble/pull/1413#issuecomment-1333655929 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1412: nimble/ll/css: Fix updating css list

2022-12-01 Thread GitBox
andrzej-kaczmarek merged PR #1412: URL: https://github.com/apache/mynewt-nimble/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1415: nimble/drivers/fem: Add support for nRF21540

2022-12-01 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1415: URL: https://github.com/apache/mynewt-nimble/pull/1415 This adds support for nRF21540 FEM. FEM is controlled via GPIOs, there's no support for SPI. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-12-01 Thread GitBox
apache-mynewt-bot commented on PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1333426313 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc merged pull request #1411: nimble/ll: Fix adding peripheral connections to CSS list

2022-12-01 Thread GitBox
sjanc merged PR #1411: URL: https://github.com/apache/mynewt-nimble/pull/1411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer merged pull request #2912: os/kernel: Add scheduler locking functionality

2022-12-01 Thread GitBox
kasjer merged PR #2912: URL: https://github.com/apache/mynewt-core/pull/2912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1414: nimble/ll: Simplify DTM RX test

2022-11-30 Thread GitBox
apache-mynewt-bot commented on PR #1414: URL: https://github.com/apache/mynewt-nimble/pull/1414#issuecomment-1332807548 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1413: nimble/phy/nrf5x: Implement NRF5340 errata 158

2022-11-30 Thread GitBox
apache-mynewt-bot commented on PR #1413: URL: https://github.com/apache/mynewt-nimble/pull/1413#issuecomment-1332805487 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1414: nimble/ll: Simplify DTM RX test

2022-11-30 Thread GitBox
sjanc opened a new pull request, #1414: URL: https://github.com/apache/mynewt-nimble/pull/1414 DTM test uses fixed frequency and PHY mode so there is no need to re-configure those after every packet reception. It is enough to just restart scanning. -- This is an automated message from

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1413: nimble/phy/nrf5x: Implement NRF5340 errata 158

2022-11-30 Thread GitBox
sjanc opened a new pull request, #1413: URL: https://github.com/apache/mynewt-nimble/pull/1413 Trim values shall be loaded after if toggling power. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-11-30 Thread GitBox
apache-mynewt-bot commented on PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1332046627 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2912: os/kernel: Add scheduler locking functionality

2022-11-29 Thread GitBox
apache-mynewt-bot commented on PR #2912: URL: https://github.com/apache/mynewt-core/pull/2912#issuecomment-1330696471 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] kasjer opened a new pull request, #2912: os/kernel: Add scheduler locking functionality

2022-11-29 Thread GitBox
kasjer opened a new pull request, #2912: URL: https://github.com/apache/mynewt-core/pull/2912 This change add possibility to lock task scheduling temporarily. Pair of functions os_sched_suspend/os_sched_resume is added to allow task switching to be suspended while interrupts are still

[GitHub] [mynewt-core] kasjer merged pull request #2911: fs/fcb2: fix missing unlock of mutex in getprev

2022-11-29 Thread GitBox
kasjer merged PR #2911: URL: https://github.com/apache/mynewt-core/pull/2911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1412: nimble/ll/css: Fix updating css list

2022-11-25 Thread GitBox
apache-mynewt-bot commented on PR #1412: URL: https://github.com/apache/mynewt-nimble/pull/1412#issuecomment-1327516280 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1412: nimble/ll/css: Fix updating css list

2022-11-25 Thread GitBox
apache-mynewt-bot commented on PR #1412: URL: https://github.com/apache/mynewt-nimble/pull/1412#issuecomment-1327503499 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1412: nimble/ll/css: Fix updating css list

2022-11-25 Thread GitBox
andrzej-kaczmarek opened a new pull request, #1412: URL: https://github.com/apache/mynewt-nimble/pull/1412 If connsm is already on css list and has slot index changed, the list may not be sorted properly so in some case item was not re-inseterd properly. To make things simpler, let's just

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1411: nimble/ll: Fix adding peripheral connections to CSS list

2022-11-25 Thread GitBox
apache-mynewt-bot commented on PR #1411: URL: https://github.com/apache/mynewt-nimble/pull/1411#issuecomment-1327425090 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1411: nimble/ll: Fix adding peripheral connections to CSS list

2022-11-24 Thread GitBox
apache-mynewt-bot commented on PR #1411: URL: https://github.com/apache/mynewt-nimble/pull/1411#issuecomment-1326615886 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1411: nimble/ll: Fix adding peripheral connections to CSS list

2022-11-24 Thread GitBox
sjanc opened a new pull request, #1411: URL: https://github.com/apache/mynewt-nimble/pull/1411 Only central role connections should be added to that list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-nimble] sjanc merged pull request #1410: nimble/host: Enabled LE Power control event mask if feature is enabled

2022-11-23 Thread GitBox
sjanc merged PR #1410: URL: https://github.com/apache/mynewt-nimble/pull/1410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1410: nimble/host: Enabled LE Power control event mask if feature is enabled

2022-11-23 Thread GitBox
apache-mynewt-bot commented on PR #1410: URL: https://github.com/apache/mynewt-nimble/pull/1410#issuecomment-1325546248 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] rahult-github commented on pull request #1410: nimble/host: Enabled LE Power control event mask if feature is enabled

2022-11-23 Thread GitBox
rahult-github commented on PR #1410: URL: https://github.com/apache/mynewt-nimble/pull/1410#issuecomment-1325236816 @sjanc , PTAL . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1410: nimble/host: Enabled LE Power control event mask if feature is enabled

2022-11-23 Thread GitBox
apache-mynewt-bot commented on PR #1410: URL: https://github.com/apache/mynewt-nimble/pull/1410#issuecomment-1325170003 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] rahult-github opened a new pull request, #1410: nimble/host: Enabled LE Power control event mask if feature is enabled

2022-11-23 Thread GitBox
rahult-github opened a new pull request, #1410: URL: https://github.com/apache/mynewt-nimble/pull/1410 If LE Power Control feature is enabled, then host should get relevant events. This PR enables event mask associated with Power control feature. -- This is an automated message from the

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

2022-11-22 Thread GitBox
sjanc commented on code in PR #1403: URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1029095005 ## nimble/host/include/host/ble_gatt.h: ## @@ -476,8 +477,15 @@ int ble_gatts_notify_custom(uint16_t conn_handle, uint16_t att_handle, /** * Deprecated. Should

[GitHub] [mynewt-nimble] sjanc merged pull request #1409: nimble/ll: Require 257 bytes HCI events when enabling fake dual-mode

2022-11-22 Thread GitBox
sjanc merged PR #1409: URL: https://github.com/apache/mynewt-nimble/pull/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc merged pull request #1405: Removes global min/max definition & global std namespace selection

2022-11-22 Thread GitBox
sjanc merged PR #1405: URL: https://github.com/apache/mynewt-nimble/pull/1405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc closed pull request #1408: nimble/phy/nrf5x: Allow to use named pins for radio debug

2022-11-22 Thread GitBox
sjanc closed pull request #1408: nimble/phy/nrf5x: Allow to use named pins for radio debug URL: https://github.com/apache/mynewt-nimble/pull/1408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1409: nimble/ll: Require 257 bytes HCI events when enabling fake dual-mode

2022-11-21 Thread GitBox
apache-mynewt-bot commented on PR #1409: URL: https://github.com/apache/mynewt-nimble/pull/1409#issuecomment-1322309571 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1409: nimble/ll: Require 257 bytes HCI events when enabling fake dual-mode

2022-11-21 Thread GitBox
sjanc opened a new pull request, #1409: URL: https://github.com/apache/mynewt-nimble/pull/1409 Some BR/EDR commands eg. Read Local Name command have fixed (max allowed HCI event size) return values. If event size is smaller it results in assert. -- This is an automated message from the

[GitHub] [mynewt-newt] sjanc closed issue #494: Not able to build blinky with newt 1.9.0 and newt 1.10.0

2022-11-21 Thread GitBox
sjanc closed issue #494: Not able to build blinky with newt 1.9.0 and newt 1.10.0 URL: https://github.com/apache/mynewt-newt/issues/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-newt] sjanc merged pull request #495: Handle cpu count zero reported on raspberry pi

2022-11-21 Thread GitBox
sjanc merged PR #495: URL: https://github.com/apache/mynewt-newt/pull/495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-newt] m-gorecki opened a new pull request, #496: Don't do shallow clone on default

2022-11-21 Thread GitBox
m-gorecki opened a new pull request, #496: URL: https://github.com/apache/mynewt-newt/pull/496 Default shallow clone option was causing some issues, so it is better to keep it as opt-in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-core] tcpipchip commented on issue #1405: SPI fails on STM32L0

2022-11-19 Thread GitBox
tcpipchip commented on issue #1405: URL: https://github.com/apache/mynewt-core/issues/1405#issuecomment-1321006102 How can I enable SPI debug ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2911: fs/fcb2: fix missing unlock of mutex in getprev

2022-11-19 Thread GitBox
apache-mynewt-bot commented on PR #2911: URL: https://github.com/apache/mynewt-core/pull/2911#issuecomment-1320935331 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] blocksebastian opened a new pull request, #2911: fs/fcb2: fix missing unlock of mutex in getprev

2022-11-19 Thread GitBox
blocksebastian opened a new pull request, #2911: URL: https://github.com/apache/mynewt-core/pull/2911 on reaching oldest item the mutex does not get unlocked due directly returning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1408: nimble/phy/nrf5x: Allow to use named pins for radio debug

2022-11-18 Thread GitBox
sjanc opened a new pull request, #1408: URL: https://github.com/apache/mynewt-nimble/pull/1408 This allows to use LED_1 etc for GPIO debug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-newt] andrzej-kaczmarek commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-18 Thread GitBox
andrzej-kaczmarek commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1319864536 So if this is used for unit tests (i.e. `newt test`) perhaps a better idea is to introduce mock packages that can be added to unit tests build only and they will replace

[GitHub] [mynewt-newt] frippertronics commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-18 Thread GitBox
frippertronics commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1319829438 _flash_map_ was just an arbitrarily chosen package to test this out with, this is also the case for other packages. For many cases it would be beneficial to use a combination of

[GitHub] [mynewt-newt] uwej711 opened a new pull request, #495: Handle cpu count zero reported on raspberry pi

2022-11-17 Thread GitBox
uwej711 opened a new pull request, #495: URL: https://github.com/apache/mynewt-newt/pull/495 This fixes https://github.com/apache/mynewt-newt/issues/494 On my Raspberry Pi 4 Model B the cpu count is reported as 0 from shirou/gopsutil cpu.Counts without an error which then sets the

[GitHub] [mynewt-newt] andrzej-kaczmarek commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-17 Thread GitBox
andrzej-kaczmarek commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1318758339 Just a quick thought: ``` andk@x1n:~/devel/mynewt$ newt target revdep blinky Reverse dependency graph (dependee <-- [dependers]): --- 8< --- *

[GitHub] [mynewt-newt] frippertronics commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-17 Thread GitBox
frippertronics commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1318638840 Ideally I would use [CMock](https://github.com/ThrowTheSwitch/CMock) but getting newt to call ruby to generate mocks during compilation seems a bit more difficult than using

[GitHub] [mynewt-newt] frippertronics commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-17 Thread GitBox
frippertronics commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1318634755 Thanks for the response. What I want to do is be able to isolate modules from their dependencies when unit testing through mocking. I could create stubs specifically for

[GitHub] [mynewt-nimble] uis246 commented on issue #1226: Support more SoCs

2022-11-17 Thread GitBox
uis246 commented on issue #1226: URL: https://github.com/apache/mynewt-nimble/issues/1226#issuecomment-1318621954 CC2541 is used in HM-10 modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mynewt-newt] andrzej-kaczmarek commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-17 Thread GitBox
andrzej-kaczmarek commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1318596132 I don't this options makes sense. The packages are included in build via explicit dependencies from other packages, so having an option to allow any package to remove an

[GitHub] [mynewt-newt] frippertronics commented on pull request #493: newt: Add pkg.ign_pkgs to skip certain packages when linking

2022-11-17 Thread GitBox
frippertronics commented on PR #493: URL: https://github.com/apache/mynewt-newt/pull/493#issuecomment-1318527210 I'll add the required documentation once this method of ignoring packages, or an alternative, has been approved. -- This is an automated message from the Apache Git Service.

[GitHub] [mynewt-nimble] sjanc commented on pull request #1406: nimble/ll: Fix compile errors

2022-11-16 Thread GitBox
sjanc commented on PR #1406: URL: https://github.com/apache/mynewt-nimble/pull/1406#issuecomment-1316607738 alright, but please fix CI failures (some static functions are left unused if public are ifdeffed) -- This is an automated message from the Apache Git Service. To respond to the

<    1   2   3   4   5   6   7   8   9   10   >