[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-14 Thread GitBox
kasjer commented on code in PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849#discussion_r897346720 ## hw/drivers/sensors/lsm6dsl/src/lsm6dsl_shell.c: ## @@ -80,6 +80,21 @@ static const reg_name_t reg_name[] = { { .addr = 0x5f, .regname = "MD2_CFG" }, }; +/*

[GitHub] [mynewt-nimble] kasjer commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-14 Thread GitBox
kasjer commented on code in PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897305306 ## nimble/transport/apollo3/src/apollo3_ble_hci.c: ## @@ -40,10 +40,10 @@ typedef enum { /* Structure for holding outgoing HCI packets. */ typedef struct { u

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-14 Thread GitBox
apache-mynewt-bot commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-119204 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/tran

[GitHub] [mynewt-nimble] t3zeng commented on pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

2022-06-14 Thread GitBox
t3zeng commented on PR #1276: URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1155534787 @sjanc @kasjer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [mynewt-core] sjanc commented on pull request #2850: mempool: Fix OS_MEMPOOL_SIZE when OS_MEMPOOL_GUARD is on

2022-06-14 Thread GitBox
sjanc commented on PR #2850: URL: https://github.com/apache/mynewt-core/pull/2850#issuecomment-1155275107 https://github.com/apache/mynewt-core/pull/2340 for some background @hbcam FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2850: mempool: Fix OS_MEMPOOL_SIZE when OS_MEMPOOL_GUARD is on

2022-06-14 Thread GitBox
apache-mynewt-bot commented on PR #2850: URL: https://github.com/apache/mynewt-core/pull/2850#issuecomment-1155184832 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] kasjer opened a new pull request, #2850: mempool: Fix OS_MEMPOOL_SIZE when OS_MEMPOOL_GUARD is on

2022-06-14 Thread GitBox
kasjer opened a new pull request, #2850: URL: https://github.com/apache/mynewt-core/pull/2850 OS_MEMPOOL_SIZE returned incorrect memory size for mpool buffer when OS_MEMPOOL_GUARD was enabled. OS_MEMPOOL_GUARD requires extra space between memory blocks and OS_MEMPOOL_SIZE (and OS_MEM

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-14 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1155135245 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/cont

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-14 Thread GitBox
sjanc commented on code in PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#discussion_r896489467 ## nimble/controller/src/ble_ll_conn_hci.c: ## @@ -955,6 +955,15 @@ ble_ll_conn_hci_update(const uint8_t *cmdbuf, uint8_t len) return BLE_ERR_UNK_CONN_ID;

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1275: apps/blehci: Allow log/full implementation in syscfg

2022-06-14 Thread GitBox
apache-mynewt-bot commented on PR #1275: URL: https://github.com/apache/mynewt-nimble/pull/1275#issuecomment-1154838041 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] kasjer opened a new pull request, #1275: apps/blehci: Allow log/full implementation in syscfg

2022-06-14 Thread GitBox
kasjer opened a new pull request, #1275: URL: https://github.com/apache/mynewt-nimble/pull/1275 blehci had log/stub hardwired in application. Now it can be swtiched to log/full in target if needed. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-13 Thread GitBox
apache-mynewt-bot commented on PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1154591205 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: nimble/ll: Fixes for connection strict scheduling

2022-06-13 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1154544725 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/cont

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: [dnm] nimble/ll: Fix new conn scheduling with css

2022-06-13 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1154542819 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/cont

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-13 Thread GitBox
apache-mynewt-bot commented on PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1154392279 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/se

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1274: tools/hci_throughput: additional HCI cmds, PHY fixes

2022-06-13 Thread GitBox
apache-mynewt-bot commented on PR #1274: URL: https://github.com/apache/mynewt-nimble/pull/1274#issuecomment-1154032052 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1274: tools/hci_throughput: additional HCI cmds, PHY fixes

2022-06-13 Thread GitBox
jrotkiewicz opened a new pull request, #1274: URL: https://github.com/apache/mynewt-nimble/pull/1274 Added Read Supported Features, Read Local Commands cmds. Fixed TX octets error info. Fixed setting PHY. @andrzej-kaczmarek @sjanc -- This is an automated message from the A

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2849: sensors/lsm6dsl: add tilt function

2022-06-10 Thread GitBox
apache-mynewt-bot commented on PR #2849: URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1152832570 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/se

[GitHub] [mynewt-core] JustineKH opened a new pull request, #2849: sensors/lsm6dsl: add tilt function

2022-06-10 Thread GitBox
JustineKH opened a new pull request, #2849: URL: https://github.com/apache/mynewt-core/pull/2849 Adding absolute and relative tilt functionality. Extending lsm6dsl_shell dump to include bankA and bankB registers. Fixed LSM6DSL_SHUB_REG_ACCESS_MASK bit mask. -- This is an automated me

[GitHub] [mynewt-nimble] ocESP commented on pull request #1252: Support for read and write suggested datalen cmds

2022-06-09 Thread GitBox
ocESP commented on PR #1252: URL: https://github.com/apache/mynewt-nimble/pull/1252#issuecomment-1151965050 Hello @sjanc, 1. write suggested datalen command - By default the data length is 27 bytes. If we suggest larger data length values, more data could be sent in a single tra

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: [dnm] nimble/ll: Fix new conn scheduling with css

2022-06-09 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1151481116 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/cont

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1244: nimble/ll: Add more HCI commands for fake dual-mode

2022-06-09 Thread GitBox
andrzej-kaczmarek merged PR #1244: URL: https://github.com/apache/mynewt-nimble/pull/1244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [mynewt-nimble] haukepetersen merged pull request #1272: controller: use OS specific PRNG for RIOT builds

2022-06-08 Thread GitBox
haukepetersen merged PR #1272: URL: https://github.com/apache/mynewt-nimble/pull/1272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1272: controller: use OS specific PRNG for RIOT builds

2022-06-08 Thread GitBox
haukepetersen commented on PR #1272: URL: https://github.com/apache/mynewt-nimble/pull/1272#issuecomment-1150711470 All green -> go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: [dnm] nimble/ll: Fix new conn scheduling with css

2022-06-08 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1149998617 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: [dnm] nimble/ll: Fix new conn scheduling with css

2022-06-08 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1149953881 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1273: [dnm] nimble/ll: Fix new conn scheduling with css

2022-06-08 Thread GitBox
apache-mynewt-bot commented on PR #1273: URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1149873215 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2848: mcu/nrf52: Handle APROTECT

2022-06-08 Thread GitBox
apache-mynewt-bot commented on PR #2848: URL: https://github.com/apache/mynewt-core/pull/2848#issuecomment-1149861673 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/mcu/nordic

[GitHub] [mynewt-core] kasjer opened a new pull request, #2848: mcu/nrf52: Handle APROTECT

2022-06-08 Thread GitBox
kasjer opened a new pull request, #2848: URL: https://github.com/apache/mynewt-core/pull/2848 Newest hardware revisions of NRF52840, NRF52810 (and others) now have access port protection enabled by default. To enable debugger use after reset nrf52_handle_approtect() should be cal

[GitHub] [mynewt-newt] andrzej-kaczmarek merged pull request #479: flashmap: Define more symbols in sysflash.h

2022-06-08 Thread GitBox
andrzej-kaczmarek merged PR #479: URL: https://github.com/apache/mynewt-newt/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [mynewt-newt] andrzej-kaczmarek opened a new pull request, #479: flashmap: Define more symbols in sysflash.h

2022-06-08 Thread GitBox
andrzej-kaczmarek opened a new pull request, #479: URL: https://github.com/apache/mynewt-newt/pull/479 sysflash.h will now have more symbols defined for each flash area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-core] kasjer merged pull request #2847: nrf5340: Remove misleading comment

2022-06-07 Thread GitBox
kasjer merged PR #2847: URL: https://github.com/apache/mynewt-core/pull/2847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1272: controller: use OS specific PRNG for RIOT builds

2022-06-07 Thread GitBox
apache-mynewt-bot commented on PR #1272: URL: https://github.com/apache/mynewt-nimble/pull/1272#issuecomment-1148663413 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] haukepetersen opened a new pull request, #1272: controller: use OS specific PRNG for RIOT builds

2022-06-07 Thread GitBox
haukepetersen opened a new pull request, #1272: URL: https://github.com/apache/mynewt-nimble/pull/1272 Currently the controller is using jrand48() to generate pseudo random numbers. For RIOT builds this commit switches to the RIOT build-in PRNG API, as this has two benefits: i) it saves

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2847: nrf5340: Remove misleading comment

2022-06-07 Thread GitBox
apache-mynewt-bot commented on PR #2847: URL: https://github.com/apache/mynewt-core/pull/2847#issuecomment-1148547412 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] kasjer opened a new pull request, #2847: nrf5340: Remove misleading comment

2022-06-07 Thread GitBox
kasjer opened a new pull request, #2847: URL: https://github.com/apache/mynewt-core/pull/2847 Comment about erratas 33, 34 was valid only for first drop of NRF52832. For NRF5340 erratas with those numbers exists but are not applicable here. -- This is an automated message from the A

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-06 Thread GitBox
apache-mynewt-bot commented on PR #2846: URL: https://github.com/apache/mynewt-core/pull/2846#issuecomment-1148144144 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/drivers/se

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-06 Thread GitBox
apache-mynewt-bot commented on PR #2846: URL: https://github.com/apache/mynewt-core/pull/2846#issuecomment-1148141235 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] benmccrea commented on pull request #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-06 Thread GitBox
benmccrea commented on PR #2846: URL: https://github.com/apache/mynewt-core/pull/2846#issuecomment-1148140875 @vrahane Thanks. I added bmp390 to the pkg.yml file. I also fixed a bug (chip ID test is done in 2 other places). -- This is an automated message from the Apache Git Service. To r

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-03 Thread GitBox
apache-mynewt-bot commented on PR #2846: URL: https://github.com/apache/mynewt-core/pull/2846#issuecomment-1146367943 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] benmccrea opened a new pull request, #2846: sensors/bmp388: Add compatibility for bmp390

2022-06-03 Thread GitBox
benmccrea opened a new pull request, #2846: URL: https://github.com/apache/mynewt-core/pull/2846 Allow sensors/bmp388 driver to accept the bmp390 chip ID. The Bosch BMP390 an updated pressure sensor which is compatible with the older BMP388. The only difference from a driver perspect

[GitHub] [mynewt-core] kasjer merged pull request #2832: sys/log: Add easy full/stub selector

2022-06-03 Thread GitBox
kasjer merged PR #2832: URL: https://github.com/apache/mynewt-core/pull/2832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[GitHub] [mynewt-mcumgr] t3zeng commented on issue #161: SMP notifications corrupted on apollo3

2022-06-02 Thread GitBox
t3zeng commented on issue #161: URL: https://github.com/apache/mynewt-mcumgr/issues/161#issuecomment-1145429381 Adding to the above, I set up some checks and increased the size of the task stack to 8192 words OS_CTX_SW_STACK_CHECK: 1 OS_MEMPOOL_CHECK: 1 OS_MEMPOOL_GUARD: 1 OS_MEM

[GitHub] [mynewt-nimble] sjanc commented on pull request #1252: Support for read and write suggested datalen cmds

2022-06-02 Thread GitBox
sjanc commented on PR #1252: URL: https://github.com/apache/mynewt-nimble/pull/1252#issuecomment-1144778415 Hi, Could you describe your usecases for those? While I can see case for setting default values from application, I don't see any usecase for reading those... -- This is an

[GitHub] [mynewt-nimble] haukepetersen merged pull request #1249: porting: fix npl to allow NimBLE version bump in RIOT

2022-06-02 Thread GitBox
haukepetersen merged PR #1249: URL: https://github.com/apache/mynewt-nimble/pull/1249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [mynewt-mcumgr] t3zeng commented on issue #161: SMP notifications corrupted on apollo3

2022-05-31 Thread GitBox
t3zeng commented on issue #161: URL: https://github.com/apache/mynewt-mcumgr/issues/161#issuecomment-1143052658 Hey guys, you can reproduce this by running the bleprph app and then try to perform an image read. Repro steps: 1. Load bleprph app onto apollo3 evb and boot up 2. On

[GitHub] [mynewt-mcumgr] simonratner commented on issue #161: SMP notifications corrupted on apollo3

2022-05-31 Thread GitBox
simonratner commented on issue #161: URL: https://github.com/apache/mynewt-mcumgr/issues/161#issuecomment-1143015680 cc @t3zeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [mynewt-mcumgr] simonratner opened a new issue, #161: SMP notifications corrupted on apollo3

2022-05-31 Thread GitBox
simonratner opened a new issue, #161: URL: https://github.com/apache/mynewt-mcumgr/issues/161 SMP notifications used to deliver SMP responses over BLE transport are corrupted on the [apollo3_evb](https://github.com/apache/mynewt-core/tree/master/hw/bsp/apollo3_evb). Below is a sample

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1271: L2CAP COC: added buffers for incoming SDU

2022-05-31 Thread GitBox
apache-mynewt-bot commented on PR #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271#issuecomment-1142433422 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nimble/host

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1271: L2CAP COC: added buffers for incoming SDU

2022-05-31 Thread GitBox
jrotkiewicz opened a new pull request, #1271: URL: https://github.com/apache/mynewt-nimble/pull/1271 This allows to process more data while receiving another. @sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [mynewt-newtmgr] niclas-ats opened a new pull request, #191: nmp decode: allow registration of custom response handlers

2022-05-31 Thread GitBox
niclas-ats opened a new pull request, #191: URL: https://github.com/apache/mynewt-newtmgr/pull/191 This PR allows the to use custom smp commands (e.g. using the peruser group). The implementation of the commands is not part of this PR since Go allowed me to extend the the library without f

[GitHub] [mynewt-core] kasjer merged pull request #2845: tinyusb/msc_fat_view: Fix missing else in pre-processor

2022-05-30 Thread GitBox
kasjer merged PR #2845: URL: https://github.com/apache/mynewt-core/pull/2845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2845: tinyusb/msc_fat_view: Fix missing else in pre-processor

2022-05-30 Thread GitBox
apache-mynewt-bot commented on PR #2845: URL: https://github.com/apache/mynewt-core/pull/2845#issuecomment-1140852564 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2845: tinyusb/msc_fat_view: Fix missing else in pre-processor

2022-05-30 Thread GitBox
apache-mynewt-bot commented on PR #2845: URL: https://github.com/apache/mynewt-core/pull/2845#issuecomment-1140837603 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] kasjer opened a new pull request, #2845: tinyusb/msc_fat_view: Fix missing else in pre-processor

2022-05-30 Thread GitBox
kasjer opened a new pull request, #2845: URL: https://github.com/apache/mynewt-core/pull/2845 HUGE_FILE_SIZE could be re-defined due to missing else -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [mynewt-nimble] ocESP commented on pull request #1252: Support for read and write suggested datalen cmds

2022-05-30 Thread GitBox
ocESP commented on PR #1252: URL: https://github.com/apache/mynewt-nimble/pull/1252#issuecomment-1140785099 @sjanc, Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mynewt-nimble] kasjer merged pull request #1270: tools/hci_throughput: Added NRF53 targets, README fix

2022-05-27 Thread GitBox
kasjer merged PR #1270: URL: https://github.com/apache/mynewt-nimble/pull/1270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynew

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1270: tools/hci_throughput: Added NRF53 targets, README fix

2022-05-27 Thread GitBox
apache-mynewt-bot commented on PR #1270: URL: https://github.com/apache/mynewt-nimble/pull/1270#issuecomment-1139698876 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1270: tools/hci_throughput: Added NRF53 targets, README fix

2022-05-27 Thread GitBox
jrotkiewicz opened a new pull request, #1270: URL: https://github.com/apache/mynewt-nimble/pull/1270 @sjanc @kasjer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [mynewt-core] kasjer merged pull request #2844: tinyusb/msc_fat_view: Fix huge file specification

2022-05-27 Thread GitBox
kasjer merged PR #2844: URL: https://github.com/apache/mynewt-core/pull/2844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[GitHub] [mynewt-nimble] sjanc merged pull request #1269: tools/hci_throughput: fix redundant targets

2022-05-27 Thread GitBox
sjanc merged PR #1269: URL: https://github.com/apache/mynewt-nimble/pull/1269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1269: tools/hci_throughput: fix redundant targets

2022-05-27 Thread GitBox
apache-mynewt-bot commented on PR #1269: URL: https://github.com/apache/mynewt-nimble/pull/1269#issuecomment-1139532754 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1269: tools/hci_throughput: fix redundant targets

2022-05-27 Thread GitBox
jrotkiewicz opened a new pull request, #1269: URL: https://github.com/apache/mynewt-nimble/pull/1269 @sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2844: tinyusb/msc_fat_view: Fix huge file specification

2022-05-27 Thread GitBox
apache-mynewt-bot commented on PR #2844: URL: https://github.com/apache/mynewt-core/pull/2844#issuecomment-1139509151 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] kasjer opened a new pull request, #2844: tinyusb/msc_fat_view: Fix huge file specification

2022-05-27 Thread GitBox
kasjer opened a new pull request, #2844: URL: https://github.com/apache/mynewt-core/pull/2844 Huge file size handling from syscfg had typo and incorrect condition resulting in huge file always taking most of the free spece. Now huge file size can have size specified by the user. -- T

[GitHub] [mynewt-nimble] sjanc merged pull request #1268: nrf5340: avoid have 2 interrupts for each IPC message

2022-05-27 Thread GitBox
sjanc merged PR #1268: URL: https://github.com/apache/mynewt-nimble/pull/1268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1268: nrf5340: avoid have 2 interrupts for each IPC message

2022-05-27 Thread GitBox
apache-mynewt-bot commented on PR #1268: URL: https://github.com/apache/mynewt-nimble/pull/1268#issuecomment-1139343029 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1268: nrf5340: avoid have 2 interrupts for each IPC message

2022-05-26 Thread GitBox
bvdberg opened a new pull request, #1268: URL: https://github.com/apache/mynewt-nimble/pull/1268 The IPC messages are written in 2 parts: the cmd byte and the rest. It is unneccesary to already interrupt the other core for the first byte, since it will be interrupted by the 2nd write al

[GitHub] [mynewt-nimble] sjanc merged pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-26 Thread GitBox
sjanc merged PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-core] kasjer merged pull request #2843: mcu/nrf5340: Increase interrupt stack size

2022-05-26 Thread GitBox
kasjer merged PR #2843: URL: https://github.com/apache/mynewt-core/pull/2843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-26 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1138629601 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2843: mcu/nrf5340: Increase interrupt stack size

2022-05-26 Thread GitBox
apache-mynewt-bot commented on PR #2843: URL: https://github.com/apache/mynewt-core/pull/2843#issuecomment-1138621513 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-nimble] jrotkiewicz commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-26 Thread GitBox
jrotkiewicz commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1138606618 sjanc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [mynewt-core] kasjer opened a new pull request, #2843: mcu/nrf5340: Increase interrupt stack size

2022-05-26 Thread GitBox
kasjer opened a new pull request, #2843: URL: https://github.com/apache/mynewt-core/pull/2843 512 bytes seems to be insufficient for interrupt stack. Stack increased to 768 bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [mynewt-core] sjanc merged pull request #2839: nrf5340: avoid have 2 interrupts for each IPC message

2022-05-26 Thread GitBox
sjanc merged PR #2839: URL: https://github.com/apache/mynewt-core/pull/2839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.a

[GitHub] [mynewt-nimble] sjanc merged pull request #1266: nimble/host/ble_sm: add restriciton for SC Only

2022-05-26 Thread GitBox
sjanc merged PR #1266: URL: https://github.com/apache/mynewt-nimble/pull/1266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] KKopyscinski commented on a diff in pull request #1266: nimble/host/ble_sm: add restriciton for SC Only

2022-05-26 Thread GitBox
KKopyscinski commented on code in PR #1266: URL: https://github.com/apache/mynewt-nimble/pull/1266#discussion_r882483765 ## nimble/host/syscfg.yml: ## @@ -104,6 +104,7 @@ syscfg.defs: value: 0 restrictions: - 'BLE_SM_SC_LVL == 4 if 1' +

[GitHub] [mynewt-nimble] sjanc merged pull request #1091: apps/bttester: add lost bond event

2022-05-26 Thread GitBox
sjanc merged PR #1091: URL: https://github.com/apache/mynewt-nimble/pull/1091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] sjanc merged pull request #1265: host/ble_att_srv: fix ble_att_svr_check_perms for SC Only mode

2022-05-26 Thread GitBox
sjanc merged PR #1265: URL: https://github.com/apache/mynewt-nimble/pull/1265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1266: nimble/host/ble_sm: add restriciton for SC Only

2022-05-26 Thread GitBox
sjanc commented on code in PR #1266: URL: https://github.com/apache/mynewt-nimble/pull/1266#discussion_r882480436 ## nimble/host/syscfg.yml: ## @@ -104,6 +104,7 @@ syscfg.defs: value: 0 restrictions: - 'BLE_SM_SC_LVL == 4 if 1' +- BLE_S

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2842: da1469x: Specify custom location of da1469x_flash_loader

2022-05-25 Thread GitBox
apache-mynewt-bot commented on PR #2842: URL: https://github.com/apache/mynewt-core/pull/2842#issuecomment-1137544067 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2842: da1469x: Specify custom location of da1469x_flash_loader

2022-05-25 Thread GitBox
andrzej-kaczmarek commented on PR #2842: URL: https://github.com/apache/mynewt-core/pull/2842#issuecomment-1137433160 BSP is definitely not a good place to have this configured - it should be in some common package for MCU as otherwise syscfg has to be defined for each BSP separately

[GitHub] [mynewt-core] jrotkiewicz commented on pull request #2842: da1469x: Specify custom location of da1469x_flash_loader

2022-05-25 Thread GitBox
jrotkiewicz commented on PR #2842: URL: https://github.com/apache/mynewt-core/pull/2842#issuecomment-1137389375 @kasjer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-core] jrotkiewicz opened a new pull request, #2842: da1469x: Specify custom location of da1469x_flash_loader

2022-05-25 Thread GitBox
jrotkiewicz opened a new pull request, #2842: URL: https://github.com/apache/mynewt-core/pull/2842 User may now use the mynewt value FLASH_LOADER_TARGET in bootloader target to specify the da1469x_flash_loader target location. -- This is an automated message from the Apache Git Service.

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-25 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1137104611 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-25 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1137028994 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-25 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1136976257 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1249: porting: fix npl to allow NimBLE version bump in RIOT

2022-05-24 Thread GitBox
haukepetersen commented on PR #1249: URL: https://github.com/apache/mynewt-nimble/pull/1249#issuecomment-1136809787 squashed, will merge as soon as we have https://github.com/RIOT-OS/RIOT/pull/18029 sorted out - shouldn't be long... -- This is an automated message from the Apache Git Serv

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-24 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1136336816 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1249: porting: fix npl to allow NimBLE version bump in RIOT

2022-05-24 Thread GitBox
haukepetersen commented on PR #1249: URL: https://github.com/apache/mynewt-nimble/pull/1249#issuecomment-1135668218 rebased and tried again to fix the style issue pointed out by the style check... Will squash once the style check is happy :-) -- This is an automated message from the Apach

[GitHub] [mynewt-core] bvdberg commented on pull request #2839: nrf5340: avoid have 2 interrupts for each IPC message

2022-05-23 Thread GitBox
bvdberg commented on PR #2839: URL: https://github.com/apache/mynewt-core/pull/2839#issuecomment-1135436174 I made all the changes, new it should be perfect ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [mynewt-nimble] Kampi closed issue #1258: Bug: ".../nimble/host/include/host/ble_uuid.h:97:9: error: expected primary-expression before '.' token"

2022-05-23 Thread GitBox
Kampi closed issue #1258: Bug: ".../nimble/host/include/host/ble_uuid.h:97:9: error: expected primary-expression before '.' token" URL: https://github.com/apache/mynewt-nimble/issues/1258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] Kampi commented on issue #1258: Bug: ".../nimble/host/include/host/ble_uuid.h:97:9: error: expected primary-expression before '.' token"

2022-05-23 Thread GitBox
Kampi commented on issue #1258: URL: https://github.com/apache/mynewt-nimble/issues/1258#issuecomment-1135421581 Can be closed. The solution is accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-23 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1134837986 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-core] agross-korg merged pull request #2827: da1469x: hal_flash: Autodetect and configure flash

2022-05-23 Thread GitBox
agross-korg merged PR #2827: URL: https://github.com/apache/mynewt-core/pull/2827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@my

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1267: tools/hci_throughput: Initial version of the HCI throughput tester

2022-05-23 Thread GitBox
apache-mynewt-bot commented on PR #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267#issuecomment-1134694947 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] sjanc merged pull request #1259: [FIX] Wrong structure format used by the BLE_UUIDy_INIT macros

2022-05-23 Thread GitBox
sjanc merged PR #1259: URL: https://github.com/apache/mynewt-nimble/pull/1259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[GitHub] [mynewt-nimble] jrotkiewicz opened a new pull request, #1267: Initial version of the HCI throughput tester

2022-05-23 Thread GitBox
jrotkiewicz opened a new pull request, #1267: URL: https://github.com/apache/mynewt-nimble/pull/1267 This PR is still in progress. Python tool for measuring throughput over BLE on Linux. User provides HCI indexes of connected controllers, the tool configures them and starts throughpu

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1259: [FIX] Wrong structure format used by the BLE_UUIDy_INIT macros

2022-05-20 Thread GitBox
apache-mynewt-bot commented on PR #1259: URL: https://github.com/apache/mynewt-nimble/pull/1259#issuecomment-1133549609 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [mynewt-nimble] kasjer commented on a diff in pull request #1259: [FIX] Wrong structure format used by the BLE_UUIDy_INIT macros

2022-05-20 Thread GitBox
kasjer commented on code in PR #1259: URL: https://github.com/apache/mynewt-nimble/pull/1259#discussion_r878564857 ## nimble/host/include/host/ble_uuid.h: ## @@ -82,20 +82,26 @@ typedef union { #define BLE_UUID16_INIT(uuid16) \ {

<    6   7   8   9   10   11   12   13   14   15   >