sjanc commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1257649898
"LL should call it and then calculate actual TX power or RSSI using that
value and also RF path compensation, if set by host"
this is other way around, only FEM can calculate
andrzej-kaczmarek commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1257632703
The "current" solution will call FEM API which will set tx power via phy.
Proposed solution will call FEM API to obtain tx power and set it via phy - I
suspect this will
sjanc commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1257603683
The thing is that FEM might not have fixed gain, ie in SKY66112 TX gain
depends on SKY configuration _and_ input power, so LL will have to iterate (?)
to match expected output power
sjanc merged PR #1366:
URL: https://github.com/apache/mynewt-nimble/pull/1366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeffrizzo opened a new issue, #30:
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/30
Summary: Under MacOS 10.15 (Catalina), x86_64, it won't install with go 1.19
or 1.18 (see below), with go 1.17 it installs, but won't run (see below).
Under go 1.16 (which is deprecated!), things
apache-mynewt-bot commented on PR #1366:
URL: https://github.com/apache/mynewt-nimble/pull/1366#issuecomment-1256163829
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1368:
URL: https://github.com/apache/mynewt-nimble/pull/1368#issuecomment-1255461873
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek opened a new pull request, #1368:
URL: https://github.com/apache/mynewt-nimble/pull/1368
If CRC does not match on AUX_CONNECT_RSP, we should cancel already scheduled
connection as otherwise there will be spurious connection timeout as scheduler
will run uninitialized
apache-mynewt-bot commented on PR #1367:
URL: https://github.com/apache/mynewt-nimble/pull/1367#issuecomment-1255286029
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek commented on code in PR #1366:
URL: https://github.com/apache/mynewt-nimble/pull/1366#discussion_r977804332
##
README.md:
##
@@ -105,6 +105,15 @@ Implements a simple BLE peripheral that supports the Nordic
UART / Serial Port Emulation service
andrzej-kaczmarek opened a new pull request, #1367:
URL: https://github.com/apache/mynewt-nimble/pull/1367
This is follow up on 8447ec2969. We allow peer RPA to be used in the same
way as identity address if we do not have peer IRK, so we also need to update
checks for AUX_CONNECT_RSP.
apache-mynewt-bot commented on PR #1366:
URL: https://github.com/apache/mynewt-nimble/pull/1366#issuecomment-1255102488
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc commented on issue #1315:
URL: https://github.com/apache/mynewt-nimble/issues/1315#issuecomment-1254805846
Bluetooth host is CPU agnostic, for controller we support Nordic (nRF51,
nRF52, nRF5340) and Dialog DA1469x (dialog_cmac)
chrysn commented on issue #1315:
URL: https://github.com/apache/mynewt-nimble/issues/1315#issuecomment-1254741329
Yeah, that looks good, thanks.
Is there any hardware support that resides out-of-tree? Or is there a
current list of in-tree supported hardware to reference? (It
sjanc commented on issue #1315:
URL: https://github.com/apache/mynewt-nimble/issues/1315#issuecomment-1254736064
Something like this maybe? https://github.com/apache/mynewt-nimble/pull/1366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
sjanc opened a new pull request, #1366:
URL: https://github.com/apache/mynewt-nimble/pull/1366
Point to know external projects that use NimBLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kasjer merged PR #2882:
URL: https://github.com/apache/mynewt-core/pull/2882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2882:
URL: https://github.com/apache/mynewt-core/pull/2882#issuecomment-1254320790
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #488:
URL: https://github.com/apache/mynewt-newt/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer opened a new pull request, #2882:
URL: https://github.com/apache/mynewt-core/pull/2882
All interrupts used same register set and that made interrupt code take more
time since more registers needed to be save.
Commit 808115b9530b059ff9b6a12fc5b988f87e540710 enabled interrupts
apache-mynewt-bot commented on PR #1365:
URL: https://github.com/apache/mynewt-nimble/pull/1365#issuecomment-1254026085
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #1364:
URL: https://github.com/apache/mynewt-nimble/pull/1364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #1364:
URL: https://github.com/apache/mynewt-nimble/pull/1364#issuecomment-1253873003
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
bvdberg opened a new pull request, #1365:
URL: https://github.com/apache/mynewt-nimble/pull/1365
2 (cleanup) refactors and one fix for includes for non-mynewt targets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andrzej-kaczmarek opened a new pull request, #1364:
URL: https://github.com/apache/mynewt-nimble/pull/1364
LNA was not enabled properly if RX was started "now".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
andrzej-kaczmarek opened a new pull request, #488:
URL: https://github.com/apache/mynewt-newt/pull/488
config and transient packages do not have any code by design, so there's no
need to include them in build. This should fix the problem when package becomes
transient at some point but .a
andrzej-kaczmarek merged PR #1362:
URL: https://github.com/apache/mynewt-nimble/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #1362:
URL: https://github.com/apache/mynewt-nimble/pull/1362#issuecomment-1252817750
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
kasjer merged PR #2881:
URL: https://github.com/apache/mynewt-core/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2881:
URL: https://github.com/apache/mynewt-core/pull/2881#issuecomment-1252290039
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1252093161
so I thought it over and I think it should work a bit different:
- LL should always set TX power instead of relying on FEM to do this
- we should have API to get
kasjer merged PR #2879:
URL: https://github.com/apache/mynewt-core/pull/2879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer merged PR #2877:
URL: https://github.com/apache/mynewt-core/pull/2877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #1362:
URL: https://github.com/apache/mynewt-nimble/pull/1362#issuecomment-1251738435
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #2879:
URL: https://github.com/apache/mynewt-core/pull/2879#issuecomment-1251660085
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
kasjer opened a new pull request, #2881:
URL: https://github.com/apache/mynewt-core/pull/2881
Write-back-allocate, while slightly more efficient, makes finding some
errors very hard to find, when place of crash is connected to actual invalid
address by cache line only.
danimasa opened a new issue, #1363:
URL: https://github.com/apache/mynewt-nimble/issues/1363
How can I create `ble_gatt_chr_def` dynamically at runtime?
All the examples show a static array of `ble_gatt_svc_def` already with the
characteristics. In my case I'll only kwown the
kasjer opened a new pull request, #2880:
URL: https://github.com/apache/mynewt-core/pull/2880
lwipopts.h is a header that is included by lwip stack. It has various
configuration options.
Repository options may not be best for customer application. To allow for
configuration option
andrzej-kaczmarek opened a new pull request, #1362:
URL: https://github.com/apache/mynewt-nimble/pull/1362
Some functions are never used by LL and can be considered private so let's
make them static.
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #1361:
URL: https://github.com/apache/mynewt-nimble/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer opened a new pull request, #2879:
URL: https://github.com/apache/mynewt-core/pull/2879
NRF5340 has dedicated audio clock that allows for more precise audio
frequencies then 32MHz oscillator only.
NRF5340 also supports 32 bits sample slots.
This add support ACLK.
For
sjanc merged PR #2875:
URL: https://github.com/apache/mynewt-core/pull/2875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer merged PR #2876:
URL: https://github.com/apache/mynewt-core/pull/2876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2878:
URL: https://github.com/apache/mynewt-core/pull/2878#issuecomment-1250235007
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2878:
URL: https://github.com/apache/mynewt-core/pull/2878#issuecomment-1250226563
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
kasjer opened a new pull request, #2878:
URL: https://github.com/apache/mynewt-core/pull/2878
net_test_socket could be created twice leading to memory leak now whenever
'socket' command is executed it closes previous socket first.
bind/listen/connect check if socket is created first
apache-mynewt-bot commented on PR #1361:
URL: https://github.com/apache/mynewt-nimble/pull/1361#issuecomment-1250145152
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2877:
URL: https://github.com/apache/mynewt-core/pull/2877#issuecomment-1249940113
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
kasjer opened a new pull request, #2877:
URL: https://github.com/apache/mynewt-core/pull/2877
Prefetch is not available only on Revision A.
Prefetch was enabled only for Revision Z.
Now revisions 1,2,4,Y also can have prefetch enabled.
--
This is an automated message from the Apache
apache-mynewt-bot commented on PR #2876:
URL: https://github.com/apache/mynewt-core/pull/2876#issuecomment-1249089543
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
kasjer opened a new pull request, #2876:
URL: https://github.com/apache/mynewt-core/pull/2876
Some nrfx functionality uses NRFX_STATIC_ASSERT and NRFX_ATOMIC_
functions.
Those were not provided in mynewt even though they are present in Nordic
nrfx_glue.h template.
Now
AJMB opened a new issue, #1360:
URL: https://github.com/apache/mynewt-nimble/issues/1360
The current version does not support enforcing encryption when configuring a
notify characteristic.
This is something I need for my project and so I added it to get things
working.
I think
apache-mynewt-bot commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1248240377
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #2875:
URL: https://github.com/apache/mynewt-core/pull/2875#issuecomment-1248179370
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #2874:
URL: https://github.com/apache/mynewt-core/pull/2874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc opened a new pull request, #2875:
URL: https://github.com/apache/mynewt-core/pull/2875
GCC 12 reports following error:
Compiling repos/apache-mynewt-core/sys/log/full/src/log_level.c Error:
repos/apache-mynewt-core/sys/log/full/src/log.c: In function
apache-mynewt-bot commented on PR #2874:
URL: https://github.com/apache/mynewt-core/pull/2874#issuecomment-1248000654
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359#issuecomment-1247924369
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #487:
URL: https://github.com/apache/mynewt-newt/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc opened a new pull request, #1359:
URL: https://github.com/apache/mynewt-nimble/pull/1359
This allows to provide custom TX power setting and rounding functions which
can take into account FEM configuration. Since this is highly dependend on HW
configuration (FEM type and mode, BPFs,
kasjer merged PR #2873:
URL: https://github.com/apache/mynewt-core/pull/2873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andrzej-kaczmarek opened a new pull request, #487:
URL: https://github.com/apache/mynewt-newt/pull/487
Use 'newt target list'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andrzej-kaczmarek merged PR #486:
URL: https://github.com/apache/mynewt-newt/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andrzej-kaczmarek merged PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc commented on code in PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#discussion_r969708922
##
nimble/drivers/nrf5x/src/nrf53/phy.c:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
apache-mynewt-bot commented on PR #2873:
URL: https://github.com/apache/mynewt-core/pull/2873#issuecomment-1245950963
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
kasjer commented on code in PR #2873:
URL: https://github.com/apache/mynewt-core/pull/2873#discussion_r970040312
##
hw/mcu/microchip/pic32mz/src/hal_flash.c:
##
@@ -104,23 +104,45 @@ pic32mz_flash_read(const struct hal_flash *dev, uint32_t
address,
return 0;
}
+/**
+ *
sjanc commented on issue #2857:
URL: https://github.com/apache/mynewt-core/issues/2857#issuecomment-1245154140
I don't think we have PDF documentation unfortunatelly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sjanc commented on code in PR #1346:
URL: https://github.com/apache/mynewt-nimble/pull/1346#discussion_r969359358
##
apps/pairing_central/src/main.c:
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
sjanc commented on code in PR #2873:
URL: https://github.com/apache/mynewt-core/pull/2873#discussion_r969226890
##
hw/mcu/microchip/pic32mz/src/hal_flash.c:
##
@@ -104,23 +104,45 @@ pic32mz_flash_read(const struct hal_flash *dev, uint32_t
address,
return 0;
}
+/**
+ *
apache-mynewt-bot commented on PR #2873:
URL: https://github.com/apache/mynewt-core/pull/2873#issuecomment-1244611647
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
kasjer merged PR #2867:
URL: https://github.com/apache/mynewt-core/pull/2867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer opened a new pull request, #2873:
URL: https://github.com/apache/mynewt-core/pull/2873
This fixes:
- unaligned address writes that are not needed (FCB uses unaligned writes).
- writes that are not multiply of 4 are now allowed
- flash read uses uncached segment to avoid wrong
andrzej-kaczmarek merged PR #1357:
URL: https://github.com/apache/mynewt-nimble/pull/1357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc merged PR #2872:
URL: https://github.com/apache/mynewt-core/pull/2872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andrzej-kaczmarek commented on PR #1344:
URL: https://github.com/apache/mynewt-nimble/pull/1344#issuecomment-1244081031
fixed in https://github.com/apache/mynewt-nimble/pull/1354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andrzej-kaczmarek closed pull request #1344: nimble/phy: Fix fem enable timings
URL: https://github.com/apache/mynewt-nimble/pull/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
apache-mynewt-bot commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1244047280
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2872:
URL: https://github.com/apache/mynewt-core/pull/2872#issuecomment-1243897067
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1243860089
@haukepetersen fyi, this needs to be updated in RIOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kasjer merged PR #2868:
URL: https://github.com/apache/mynewt-core/pull/2868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc opened a new pull request, #2872:
URL: https://github.com/apache/mynewt-core/pull/2872
This was recently renamed from plna to fem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sjanc merged PR #2871:
URL: https://github.com/apache/mynewt-core/pull/2871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc opened a new pull request, #2871:
URL: https://github.com/apache/mynewt-core/pull/2871
Non-executable scripts prevents newt commands to work correctly on linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sjanc commented on code in PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#discussion_r968080803
##
nimble/drivers/nrf5x/src/phy_priv.h:
##
@@ -67,6 +67,7 @@ void phy_fem_enable_pa(void);
#endif
#if PHY_USE_FEM_LNA
void phy_fem_enable_lna(void);
+void
apache-mynewt-bot commented on PR #1356:
URL: https://github.com/apache/mynewt-nimble/pull/1356#issuecomment-1243371364
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1243365451
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek opened a new pull request, #1356:
URL: https://github.com/apache/mynewt-nimble/pull/1356
Dummy FEM stubs PA and/or LNA APIs so it's possible to test FEM code with
out actualy FEM driver. Only PA/LNA-enable lines are active.
--
This is an automated message from the
sjanc merged PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc commented on code in PR #1349:
URL: https://github.com/apache/mynewt-nimble/pull/1349#discussion_r968046512
##
nimble/controller/include/controller/ble_ll_sched.h:
##
@@ -90,7 +97,12 @@ typedef void (*sched_remove_cb_func)(struct
ble_ll_sched_item *sch);
*/
struct
sjanc commented on code in PR #1349:
URL: https://github.com/apache/mynewt-nimble/pull/1349#discussion_r968046512
##
nimble/controller/include/controller/ble_ll_sched.h:
##
@@ -90,7 +97,12 @@ typedef void (*sched_remove_cb_func)(struct
ble_ll_sched_item *sch);
*/
struct
apache-mynewt-bot commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1242934962
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
andrzej-kaczmarek commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1242934745
rebased on https://github.com/apache/mynewt-nimble/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andrzej-kaczmarek merged PR #1355:
URL: https://github.com/apache/mynewt-nimble/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241843770
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241836640
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1241824494
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1355:
URL: https://github.com/apache/mynewt-nimble/pull/1355#issuecomment-1241803824
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek opened a new pull request, #1355:
URL: https://github.com/apache/mynewt-nimble/pull/1355
We should call txend before transition as otherwise called code may mess up
transition.
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1354:
URL: https://github.com/apache/mynewt-nimble/pull/1354#issuecomment-1241416793
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
501 - 600 of 20572 matches
Mail list logo
