apache-mynewt-bot commented on PR #2856:
URL: https://github.com/apache/mynewt-core/pull/2856#issuecomment-1167639163
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
sjanc opened a new pull request, #162:
URL: https://github.com/apache/mynewt-mcumgr/pull/162
Hash len is 32 bytes.
repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:
In function ‘img_mgmt_read_info’:
repos/apache-mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt.c:122:9:
sjanc opened a new pull request, #2856:
URL: https://github.com/apache/mynewt-core/pull/2856
Werror=stringop-overflow= seems to be now enabled by default on GCC 11.
repos/apache-mynewt-core/net/ip/native_sockets/src/native_sock.c: In
function ‘native_sock_mn_addr_to_addr’:
re
kasjer commented on PR #480:
URL: https://github.com/apache/mynewt-newt/pull/480#issuecomment-1167335114
Works correct when @@ is used, tested with @@bin that can be used in
pkg.lflags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kasjer merged PR #481:
URL: https://github.com/apache/mynewt-newt/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.ap
kasjer opened a new pull request, #2855:
URL: https://github.com/apache/mynewt-core/pull/2855
RAM_SIZE was always taken from bps.h.
With trust zone in place it may be that the bootloader
had limited RAM assigned in linker scripts.
This may happen when MCU_BOOT_MEASURED_STARTUP is use
apache-mynewt-bot commented on PR #2855:
URL: https://github.com/apache/mynewt-core/pull/2855#issuecomment-1167053315
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/mcu/nordic
sjanc merged PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt
sjanc commented on code in PR #1271:
URL: https://github.com/apache/mynewt-nimble/pull/1271#discussion_r907058949
##
nimble/host/src/ble_l2cap_coc.c:
##
@@ -40,6 +41,10 @@ static os_membuf_t ble_l2cap_coc_srv_mem[
static struct os_mempool ble_l2cap_coc_srv_pool;
+static str
sjanc merged PR #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt
andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1166976101
Host supported features can be set by `HCI LE Set Host Feature`. NimBLE host
does not have support for connection subrating so it does not set that bit.
--
This is
kasjer opened a new pull request, #481:
URL: https://github.com/apache/mynewt-newt/pull/481
Code checked existence of "name" field in yaml file
and when not found reports that "filename" was missing.
Now correct missing filed is reported.
--
This is an automated message from the
bvdberg commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166917530
rebased on update master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
apache-mynewt-bot commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166916139
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
sada45 opened a new issue, #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291
Hi!
I have tried the connection subrating in the Spec 5.3 and may found an issue.
Before the central sends the `SUBRATE_IND`, it will check wether the
peripheral has the `BLE_LL_FEAT_CONN_SUBRATI
ynyn1996 commented on issue #1285:
URL: https://github.com/apache/mynewt-nimble/issues/1285#issuecomment-1166712141
The public and private keys used by Ble Mesh during network distribution are
automatically generated after the device is powered on and stored in global
variables. They are no
mtm509 closed issue #1277: bt_mesh_init等函数参数指针判空问题
URL: https://github.com/apache/mynewt-nimble/issues/1277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
andrzej-kaczmarek closed issue #1289: g_ble_ll_conn_params.central_chan_map
needs to be removed from
apache-mynewt-nimble/nimble/controller/src/ble_ll_adv.c:1380
URL: https://github.com/apache/mynewt-nimble/issues/1289
--
This is an automated message from the Apache Git Service.
To respond t
andrzej-kaczmarek merged PR #1290:
URL: https://github.com/apache/mynewt-nimble/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
andrzej-kaczmarek merged PR #2854:
URL: https://github.com/apache/mynewt-core/pull/2854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
kasjer merged PR #2848:
URL: https://github.com/apache/mynewt-core/pull/2848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.
apache-mynewt-bot commented on PR #1290:
URL: https://github.com/apache/mynewt-nimble/pull/1290#issuecomment-1165475257
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek merged PR #1286:
URL: https://github.com/apache/mynewt-nimble/pull/1286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
andrzej-kaczmarek commented on issue #1289:
URL: https://github.com/apache/mynewt-nimble/issues/1289#issuecomment-1165454881
https://github.com/apache/mynewt-nimble/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
t3zeng opened a new issue, #1289:
URL: https://github.com/apache/mynewt-nimble/issues/1289
The central_chan_map seems to have been removed from `struct
ble_ll_conn_global_params` so it should no longer be referenced
```
Error: repos/apache-mynewt-nimble/nimble/controller/src/ble_ll
bvdberg commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165411741
I'm not sure about that. I see that at start, all connections you define
(Max-Connections) get created and the timer also.
They are never freed, since the Max number of connection
andrzej-kaczmarek merged PR #1282:
URL: https://github.com/apache/mynewt-nimble/pull/1282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
andrzej-kaczmarek merged PR #1281:
URL: https://github.com/apache/mynewt-nimble/pull/1281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
andrzej-kaczmarek merged PR #1283:
URL: https://github.com/apache/mynewt-nimble/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
andrzej-kaczmarek merged PR #1284:
URL: https://github.com/apache/mynewt-nimble/pull/1284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
sjanc commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165306690
I'm fine with having this hotfixed as is (although the leak will stil be
present on each HCI reset call, right?)
in long term I think we need to expand npl api so that every ini
apache-mynewt-bot commented on PR #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1165298125
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek merged PR #1287:
URL: https://github.com/apache/mynewt-nimble/pull/1287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
sjanc commented on issue #1285:
URL: https://github.com/apache/mynewt-nimble/issues/1285#issuecomment-1165273552
Hello,
This forum is international so please use English when reporting issues
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
apache-mynewt-bot commented on PR #1288:
URL: https://github.com/apache/mynewt-nimble/pull/1288#issuecomment-1165228605
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
KKopyscinski opened a new pull request, #1288:
URL: https://github.com/apache/mynewt-nimble/pull/1288
This contains 2 commits:
1. rename BLE_SM_SC_LVL to BLE_SM_LVL - this is not SC only setting, but
legacy one too
2. Check for SC in pairing request when in SC Only mode
--
This is a
apache-mynewt-bot commented on PR #2854:
URL: https://github.com/apache/mynewt-core/pull/2854#issuecomment-1164864676
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
apache-mynewt-bot commented on PR #1287:
URL: https://github.com/apache/mynewt-nimble/pull/1287#issuecomment-1164862240
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
apache-mynewt-bot commented on PR #1286:
URL: https://github.com/apache/mynewt-nimble/pull/1286#issuecomment-1164546528
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek opened a new pull request, #1286:
URL: https://github.com/apache/mynewt-nimble/pull/1286
If direct address was an RPA and controller was not able to resolve it,
the direct address type in extended advertising report shall be set to
0xFE.
This fixes LL/SCN/DDI/BV
ynyn1996 opened a new issue, #1285:
URL: https://github.com/apache/mynewt-nimble/issues/1285
Ble
Mesh在配网阶段使用的公私钥在设备上电后主动生成，并保存在全局变量里，后续并未释放。是否需要遵循密钥安全管理，使用完后清除密钥对，在每次使用时再生成？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kasjer merged PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.
apache-mynewt-bot commented on PR #1284:
URL: https://github.com/apache/mynewt-nimble/pull/1284#issuecomment-1163566268
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
apache-mynewt-bot commented on PR #1283:
URL: https://github.com/apache/mynewt-nimble/pull/1283#issuecomment-1163534507
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek opened a new pull request, #1284:
URL: https://github.com/apache/mynewt-nimble/pull/1284
Rename BLE_LL_MFRG_ID to more readable BLE_LL_MANUFACTURER_ID and change
default value to id assigned to Apache Foundation (0x0B65).
--
This is an automated message from the Apache
andrzej-kaczmarek opened a new pull request, #1283:
URL: https://github.com/apache/mynewt-nimble/pull/1283
Need to skip conn interval checks if css is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mgagic commented on issue #1052:
URL: https://github.com/apache/mynewt-nimble/issues/1052#issuecomment-1163088870
Hi @flonas955, any luck with this? I think I'm facing the exact same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
andrzej-kaczmarek merged PR #1273:
URL: https://github.com/apache/mynewt-nimble/pull/1273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
t3zeng commented on code in PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851#discussion_r903720138
##
hw/mcu/ambiq/apollo3/src/hal_flash.c:
##
@@ -168,6 +168,32 @@ apollo3_flash_write(const struct hal_flash *dev, uint32_t
address,
return rc;
}
+static int
apache-mynewt-bot commented on PR #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1163019577
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
apache-mynewt-bot commented on PR #1273:
URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1163017791
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/cont
sjanc merged PR #1274:
URL: https://github.com/apache/mynewt-nimble/pull/1274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt
sjanc merged PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt
apache-mynewt-bot commented on PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1162157516
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
apache-mynewt-bot commented on PR #1282:
URL: https://github.com/apache/mynewt-nimble/pull/1282#issuecomment-1162078858
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek opened a new pull request, #1282:
URL: https://github.com/apache/mynewt-nimble/pull/1282
In rare cases it's possible that 1st connection event is fired before LL
processed new connection, thus its state is set to idle. In such case we
can just skip the event and LL wil
apache-mynewt-bot commented on PR #1281:
URL: https://github.com/apache/mynewt-nimble/pull/1281#issuecomment-1161784411
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek opened a new pull request, #1281:
URL: https://github.com/apache/mynewt-nimble/pull/1281
It's possible that scheduled aux is being received while scan sm is
being disabled. In such case aux should not be processed since it cannot
be handled properly anyway.
--
This
sjanc commented on issue #1277:
URL: https://github.com/apache/mynewt-nimble/issues/1277#issuecomment-1161522158
Hello,
This forum is international so please use English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
andrzej-kaczmarek merged PR #2853:
URL: https://github.com/apache/mynewt-core/pull/2853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
kasjer commented on code in PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851#discussion_r902209722
##
hw/mcu/ambiq/apollo3/src/hal_flash.c:
##
@@ -168,6 +168,32 @@ apollo3_flash_write(const struct hal_flash *dev, uint32_t
address,
return rc;
}
+static int
kasjer merged PR #2852:
URL: https://github.com/apache/mynewt-core/pull/2852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.
wes3 merged PR #2825:
URL: https://github.com/apache/mynewt-core/pull/2825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.ap
apache-mynewt-bot commented on PR #2853:
URL: https://github.com/apache/mynewt-core/pull/2853#issuecomment-1160634336
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
apache-mynewt-bot commented on PR #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1160624944
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andrzej-kaczmarek opened a new pull request, #2853:
URL: https://github.com/apache/mynewt-core/pull/2853
Need to include syscfg.h since it uses MYNEWT_VAL_CHOICE().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
andrzej-kaczmarek commented on PR #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280#issuecomment-1160520414
why this is defined in phy instead of controller pkg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sjanc opened a new pull request, #1280:
URL: https://github.com/apache/mynewt-nimble/pull/1280
This commit makes LL stack size configurable. Depending on compiler and
platform default value may not be enough. It was reported that on nRF52840
90 words is not enough even if Ext Adv is dis
sjanc opened a new issue, #1279:
URL: https://github.com/apache/mynewt-nimble/issues/1279
CI should build babblesim targets and eventually also execute tests via edtt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
apache-mynewt-bot commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1160012674
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
bvdberg opened a new pull request, #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278
Every time a connection is made, the ble_npl_callout_init() is done.
This causes a timer creation in some NPL cases (eg. FreeRTOS).
The alloc behaviour of auth_pyld_timer is now in sync wit
apache-mynewt-bot commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1159225064
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
benmccrea merged PR #2846:
URL: https://github.com/apache/mynewt-core/pull/2846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@myne
apache-mynewt-bot commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1159047040
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/tran
t3zeng commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1158957273
> It would not hurt to fix style check complaints
Oh sorry, I thought it would apply itself. What's the easiest way to apply
it? I was just going to copy it in as a patch and a
apache-mynewt-bot commented on PR #2852:
URL: https://github.com/apache/mynewt-core/pull/2852#issuecomment-1158914418
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kasjer commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1158877690
It would not hurt to fix style check complaints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kasjer opened a new pull request, #2852:
URL: https://github.com/apache/mynewt-core/pull/2852
Main stack is now filled with pattern at startup for
better control of stack usage.
Signed-off-by: Jerzy Kasenberg
--
This is an automated message from the Apache Git Service.
To respon
apache-mynewt-bot commented on PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1156886227
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/mcu/ambiq/
t3zeng commented on PR #2851:
URL: https://github.com/apache/mynewt-core/pull/2851#issuecomment-1156884661
@kasjer @sjanc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
t3zeng opened a new pull request, #2851:
URL: https://github.com/apache/mynewt-core/pull/2851
Ambiq's internal flash writing functionality does not allow for direct flash
to flash memory transfers. This change handles situations like that by
transferring to an intermediary ram buffer.
--
kasjer merged PR #2849:
URL: https://github.com/apache/mynewt-core/pull/2849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.
apache-mynewt-bot commented on PR #2849:
URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1156684742
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/drivers/se
apache-mynewt-bot commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156672583
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/tran
apache-mynewt-bot commented on PR #1273:
URL: https://github.com/apache/mynewt-nimble/pull/1273#issuecomment-1156592372
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/cont
t3zeng commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156488759
> I would change first line of commit message(s) to reflect that changes are
for apollo transport and are not a general fixes.
No probs, I have added apollo3 to the commit mess
apache-mynewt-bot commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156411150
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/tran
jrotkiewicz commented on code in PR #1273:
URL: https://github.com/apache/mynewt-nimble/pull/1273#discussion_r897885422
##
nimble/controller/src/ble_ll_ctrl.c:
##
@@ -416,6 +419,18 @@ ble_ll_ctrl_conn_upd_make(struct ble_ll_conn_sm *connsm,
uint8_t *pyld,
instant = connsm-
kasjer commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156356897
I would change first line of commit message(s) to reflect that changes are
for apollo transport and are not a general fixes.
--
This is an automated message from the Apache Git Ser
t3zeng commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897856568
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om)
{
struct os_mbuf *x;
int rc = 0;
+
mtm509 commented on issue #1277:
URL: https://github.com/apache/mynewt-nimble/issues/1277#issuecomment-1156215724
bt_mesh_init 等众多向用户提供的接口，指针参数都没有判空
比如还有cfg_cli.h中很多接口，也没有对指针参数判空
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mtm509 opened a new issue, #1277:
URL: https://github.com/apache/mynewt-nimble/issues/1277
bt_mesh_init等好多向用户提供的接口，指针参数好多都没有判空
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
kasjer commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1156120929
change verified to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
andrzej-kaczmarek commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897652865
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om)
{
struct os_mbuf *x;
in
kasjer commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897587417
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om)
{
struct os_mbuf *x;
int rc = 0;
+
kasjer merged PR #2850:
URL: https://github.com/apache/mynewt-core/pull/2850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.
t3zeng commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897508630
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om)
{
struct os_mbuf *x;
int rc = 0;
+
apache-mynewt-bot commented on PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#issuecomment-1155949458
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/tran
t3zeng commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897505075
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -275,16 +255,22 @@ apollo3_ble_hci_acl_tx(struct os_mbuf *om)
{
struct os_mbuf *x;
int rc = 0;
+
t3zeng commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897504887
##
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##
@@ -40,10 +40,10 @@ typedef enum {
/* Structure for holding outgoing HCI packets. */
typedef struct {
u
901 - 1000 of 8011 matches
Mail list logo
