[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

2023-02-01 Thread via GitHub
sjanc commented on code in PR #2915: URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1093231836 ## sys/console/syscfg.yml: ## @@ -17,10 +17,17 @@ # syscfg.defs: -CONSOLE_MODE: -description: Which console to use +CONSOLE_IMPLEMENTATION: +

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

2023-01-16 Thread GitBox
sjanc commented on code in PR #2915: URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071116754 ## apps/bleprph_oic/syscfg.yml: ## @@ -25,6 +25,10 @@ syscfg.defs: value: 0 syscfg.vals: +CONSOLE_MODE: full Review Comment: I'm fine with