utzig commented on a change in pull request #2181: [RFC] sys/config: Extended
callbacks
URL: https://github.com/apache/mynewt-core/pull/2181#discussion_r378362675
##########
File path: sys/config/include/config/config.h
##########
@@ -157,14 +162,40 @@ struct conf_handler {
* The name of the conifguration item/subtree
*/
char *ch_name;
+
+ /**
+ * Whether to use the extended callbacks.
+ * 0=standard
+ * 1=extended
+ */
+ uint8_t ch_ext : 1;
Review comment:
I think this should rather be `bool`, although it would not be a problem to
use a bitfield in practice, unless someone wrote a configuration to flash and
moved that flash to a CPU with different endiannes! :-P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
