[GitHub] [mynewt-core] vrahane commented on issue #1694: [DO NOT MERGE]LP5523 Engine pr_instruction fix

2019-03-19 Thread GitBox
vrahane commented on issue #1694: [DO NOT MERGE]LP5523 Engine pr_instruction fix URL: https://github.com/apache/mynewt-core/pull/1694#issuecomment-474521454 @JustineKH Now that you have opened the other two PR's closing this one. -

[GitHub] [mynewt-core] vrahane commented on issue #1694: [DO NOT MERGE]LP5523 Engine pr_instruction fix

2019-03-18 Thread GitBox
vrahane commented on issue #1694: [DO NOT MERGE]LP5523 Engine pr_instruction fix URL: https://github.com/apache/mynewt-core/pull/1694#issuecomment-474086794 @JustineKH you should be creating two separate PRs for these, one for imgr stuff and one for lp5523 driver. Also, it seems that you ar