[GitHub] [mynewt-mcumgr] ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr

2020-03-03 Thread GitBox
ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr URL: https://github.com/apache/mynewt-mcumgr/pull/65#issuecomment-594033011 > The calculation happens once per file transfer. I think this is better then calculating the value as preprocessor constant. But th

[GitHub] [mynewt-mcumgr] ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr

2020-02-28 Thread GitBox
ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr URL: https://github.com/apache/mynewt-mcumgr/pull/65#issuecomment-592579304 Others have already approved this and I don't want to be a nuisance, but I still don't understand why this fix is Zephyr-specific. I

[GitHub] [mynewt-mcumgr] ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr

2020-02-21 Thread GitBox
ccollins476ad commented on issue #65: fs_mgmt: Fix file download for Zephyr URL: https://github.com/apache/mynewt-mcumgr/pull/65#issuecomment-589751706 @de-nordic could you please explain the issue in a bit more detail? Would setting `FS_MGMT_DL_CHUNK_SIZE` to a suitable value solve the pr