[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183559883 Checking SN in `ble_ll_conn_rx_isr_end` does only mean that previously txd PDU was acked, but the spec does not say anything about acking, it just states that a valid

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183554896 The spec does not say anything about acking, it just states that a valid non-empty PDU has to be txd/rxd: `has_nonempty_pdu` is updated in `ble_ll_conn_rx_d

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183325249 @sada45 I reworked continuation events handling a bit more, it should be easier to understand now and I believe it should now be handled properly. let me know how it

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182943669 @sada45 good catch, thanks. I created a fix for both https://github.com/apache/mynewt-nimble/pull/1297. I still need to validate those more carefully since appa

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-06-27 Thread GitBox
andrzej-kaczmarek commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1166976101 Host supported features can be set by `HCI LE Set Host Feature`. NimBLE host does not have support for connection subrating so it does not set that bit. -- This is