[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183854288 Yes, that sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183349582 @andrzej-kaczmarek I have some doubts that wether the `has_nonempty_pdu` should be set before or after the packet is acked. For me, I update the `last_data_pdu` in `ble_ll_con

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-13 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182959619 I am happy that helps! I take a look at the fix. I think there is one more bug. When checking the continuation number, it should ignore the connection events before the la

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-12 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182782695 Besides, currentlly, the `connsm->last_pdu_event` will be updated once received a PDU no matter it is empty or not. However, this value should be only be updated if there is d

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-12 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1181833269 I test the connection subrating but find the `Continuation Number` does not work. I think I find the reason. In the function `ble_ll_conn_next_event()` in `ble_ll_conn.c`, Li

[GitHub] [mynewt-nimble] sada45 commented on issue #1291: The connection subrating needs CONN_SUBRATING_HOST feature

2022-07-09 Thread GitBox
sada45 commented on issue #1291: URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1179503065 Thanks for your reply! I'll just use the connection subrating with link-layer APIs for now. Here I found another question. If the BLE works in the noisy RF environment,