mkiiskila commented on a change in pull request #501: Fix warning for clicker
and wifire boards
URL: https://github.com/apache/mynewt-core/pull/501#discussion_r135573764
##########
File path: hw/bsp/pic32mz2048_wi-fire/src/hal_bsp.c
##########
@@ -212,7 +212,7 @@ hal_bsp_init(void)
#if MYNEWT_VAL(UART_3)
rc = os_dev_create((struct os_dev *) &os_bsp_uart3, "uart3",
- OS_DEV_INIT_PRIMARY, 0, uart_hal_init, &uart4_cfg);
+ OS_DEV_INIT_PRIMARY, 0, uart_hal_init, (void *)&uart4_cfg);
Review comment:
These void * typecasts of arguments are not needed for
os_dev_create()/hal_spi_init(), as the function prototype already has declared
that argument as void *.
I recommend not adding them, as they're not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
