[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-465047089 @ccollins476ad @utzig Any update? T

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-430568633 @MitterdorferMathias As you can read actually there are 2 bug-fix way. In both metadata of data and

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-427144649 @ccollins476ad You are right - I miss the iteration range. Sorry for false alarm. What do you thi

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-426966897 @ccollins476ad - I just looked at the nffs_gc() code https://github.com/apache/mynewt-nffs/blob/mast

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-426945006 so `struct nffs_deleted_inode` need to know where overridden inode is - so need to add a reference t

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-426577045 So deleted inode record are not GC properly as i understand - I think if we apply my proposition of

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-425891856 Lest assume that NFFS will try to avoid make holes in inode ID range - this mean that it will use on

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-425884162 Thanks for elaboration - you are right in your analyze. What you propose will increase wear le

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-424266543 In consequence at some point of execution call `rc = nffs_restore_object(&disk_object);` returns FS_

[GitHub] nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset.

nvlsianpu commented on issue #10: NFFS can store a valid file-system instance which is unrecoverable after reset. URL: https://github.com/apache/mynewt-nffs/issues/10#issuecomment-424023300 @carlescufi @andrzej-kaczmarek Any comments on that. I will try to resolve the issue soon, is there