sjanc closed pull request #2925: Use exact commit sha for GH Actions that are
not certified
URL: https://github.com/apache/mynewt-core/pull/2925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
apache-mynewt-bot commented on PR #2925:
URL: https://github.com/apache/mynewt-core/pull/2925#issuecomment-1398187378
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
bvdberg commented on issue #1421:
URL: https://github.com/apache/mynewt-nimble/issues/1421#issuecomment-1398186397
Nothing is logged in the device. The PC side detects a connection drop (and
starts trying to re-connect). The Device (Nimble) side doesn't log anything
special. The device is
sjanc opened a new pull request, #2925:
URL: https://github.com/apache/mynewt-core/pull/2925
ASF policy requires to use exact sha instead of tags for actions that are
not certified by Github or ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1398159988
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc merged PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1398099934
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2924:
URL: https://github.com/apache/mynewt-core/pull/2924#issuecomment-1397998787
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
kasjer opened a new pull request, #2924:
URL: https://github.com/apache/mynewt-core/pull/2924
TIMER_3, TIMER_4 and TIMER_5 were referenced at code stm32_periph.c yet
there were not definitions for them.
This just adds missing definitions.
--
This is an automated message from the
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397996704
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397991343
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397975025
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1397965509
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397737066
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397695268
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397623248
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc commented on PR #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432#issuecomment-1397621556
verified locally with act
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sjanc opened a new pull request, #1432:
URL: https://github.com/apache/mynewt-nimble/pull/1432
This adds:
- building all test targets on Linux
- runing 'newt test all'
- building dummy and Linux ports
--
This is an automated message from the Apache Git Service.
To respond to
sjanc opened a new issue, #1431:
URL: https://github.com/apache/mynewt-nimble/issues/1431
Should be implemented after migration to GH Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sjanc opened a new issue, #1430:
URL: https://github.com/apache/mynewt-nimble/issues/1430
- [ ] build test targets on Linux
- [ ] build test targets on Windows
- [ ] build ports on Linux
- [ ] style check
--
This is an automated message from the Apache Git Service.
To
sjanc opened a new issue, #2923:
URL: https://github.com/apache/mynewt-core/issues/2923
- [ ] newt test all
- [ ] blinky build for all BSPs
- [ ] build test targets on Linux
- [ ] build test targets on Windows
- [ ] style check
- [ ] RAT check
--
This is an automated
apache-mynewt-bot commented on PR #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429#issuecomment-1397221924
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc opened a new pull request, #1429:
URL: https://github.com/apache/mynewt-nimble/pull/1429
Those were removed from headers to avoid conflicts with C++. Until we
convert codebase to MIN/MAX macros just define those where needed.
This was affecting RIOT port.
--
This is an
rymanluk commented on issue #1421:
URL: https://github.com/apache/mynewt-nimble/issues/1421#issuecomment-1397101306
Do you possibly have any logs to share?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1397061936
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396809082
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396655797
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396583877
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1396582342
tested locally with 'act'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1396493840
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1396446087
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
rymanluk merged PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1387382113
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387374434
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
IshaESP commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387115322
Hi @sjanc ,
Can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
IshaESP opened a new pull request, #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428
If application is going to send data more than MTU size using
ble_gattc_write_long(), after sending first batch of data of MTU size the
offset gets incremented by (MTU -
sjanc merged PR #20:
URL: https://github.com/apache/mynewt-nffs/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc opened a new pull request, #20:
URL: https://github.com/apache/mynewt-nffs/pull/20
ASF is moving away from Travis towards GithubAction. Since this repo is
mostly abandonned for now just disable travis. If needed (unlikely) we can add
GHA in future.
--
This is an automated message
apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1385573128
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
Rubeer commented on issue #1170:
URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1384268778
I have a similar application. One problem is that BLE_GAP_EVENT_NOTIFY_TX
is not called at a helpful time.
It seems to be called directly from inside the send function (e.g.
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1384077057
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2922:
URL: https://github.com/apache/mynewt-core/pull/2922#issuecomment-1384076192
## RAT Report (2023-01-16 13:38:26)
## New files with unknown licenses
*
andrzej-kaczmarek merged PR #2918:
URL: https://github.com/apache/mynewt-core/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer commented on code in PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#discussion_r1071123581
##
hw/mcu/nordic/nrf51xxx/syscfg.yml:
##
@@ -97,32 +97,49 @@ syscfg.defs:
description: 'reference mV in VDD if used'
value: 0
-# The XTAL_xxx
kasjer commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071117722
##
apps/bleprph_oic/syscfg.yml:
##
@@ -25,6 +25,10 @@ syscfg.defs:
value: 0
syscfg.vals:
+CONSOLE_MODE: full
Review Comment:
I would deprecate
sjanc commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1071116754
##
apps/bleprph_oic/syscfg.yml:
##
@@ -25,6 +25,10 @@ syscfg.defs:
value: 0
syscfg.vals:
+CONSOLE_MODE: full
Review Comment:
I'm fine with
apache-mynewt-bot commented on PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427#issuecomment-1383870947
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #2921:
URL: https://github.com/apache/mynewt-core/pull/2921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kasjer commented on code in PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#discussion_r1067124630
##
hw/bsp/nucleo-h723zg/bsp.yml:
##
@@ -0,0 +1,72 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
apache-mynewt-bot commented on PR #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427#issuecomment-1381695239
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1381685268
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2921:
URL: https://github.com/apache/mynewt-core/pull/2921#issuecomment-1381646337
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
rymanluk opened a new pull request, #1427:
URL: https://github.com/apache/mynewt-nimble/pull/1427
Fixing false possitive compiler error
/home/rymek/projects/bletiny_proj/repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:456:12:
error: array subscript is outside array
andrzej-kaczmarek opened a new pull request, #2921:
URL: https://github.com/apache/mynewt-core/pull/2921
If high voltage mode is used, we should also enable DCDC on VREGH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
apache-mynewt-bot commented on PR #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426#issuecomment-1381400815
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
SumeetSingh19 opened a new pull request, #1426:
URL: https://github.com/apache/mynewt-nimble/pull/1426
Added new feature to send and receive multi handle value notifications.
Spec: ATT_MULTIPLE_HANDLE_VALUE_NTF (Vol 3, Part F, 3.4.7.4)
--
This is an automated message from the Apache
szenglein-gessler opened a new issue, #165:
URL: https://github.com/apache/mynewt-mcumgr/issues/165
Hi,
Is there an implementation that helps me create and parse SMP messages for a
client? Could I use this library for that purpose?
I want to send SMP/mcumgr commands without
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1379966011
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1379239271
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1378836922
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1378792885
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1066725095
##
nimble/host/include/host/ble_hs.h:
##
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ *
m-gorecki opened a new pull request, #498:
URL: https://github.com/apache/mynewt-newt/pull/498
Now using the command "target copy" will copy the field pkg.deps into the
destination target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
andrzej-kaczmarek merged PR #2920:
URL: https://github.com/apache/mynewt-core/pull/2920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #2920:
URL: https://github.com/apache/mynewt-core/pull/2920#issuecomment-1376514245
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek opened a new pull request, #2920:
URL: https://github.com/apache/mynewt-core/pull/2920
We need to request hfxo via API to make sure ref is held all the time,
otherwise any other request/release will stop hfxo and thus break lfsynth.
--
This is an automated message from
vovagorodok commented on issue #1416:
URL: https://github.com/apache/mynewt-nimble/issues/1416#issuecomment-1374537886
What do You think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sjanc merged PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjanc merged PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
novumdun closed pull request #1406: nimble/ll: Fix compile errors
URL: https://github.com/apache/mynewt-nimble/pull/1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sjanc merged PR #496:
URL: https://github.com/apache/mynewt-newt/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
m-gorecki commented on code in PR #192:
URL: https://github.com/apache/mynewt-newtmgr/pull/192#discussion_r1052005242
##
newtmgr/bll/bll_common.go:
##
@@ -53,18 +53,25 @@ func exchangeMtu(cln ble.Client, preferredMtu uint16)
(uint16, error) {
break
apache-mynewt-bot commented on PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#issuecomment-1371466198
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
tannewt commented on code in PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#discussion_r1061871362
##
nimble/controller/syscfg.yml:
##
@@ -537,6 +537,15 @@ syscfg.defs:
range: 1..257
value: 32
+BLE_LL_CONN_EVENT_END_MARGIN:
+
apache-mynewt-bot commented on PR #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425#issuecomment-1371045875
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc opened a new pull request, #1425:
URL: https://github.com/apache/mynewt-nimble/pull/1425
This works by allowing to shorten connection event end time by specified
number of us. This value should be tuned only after measuring performance as
depends on various factors like build
sjanc closed pull request #1422: nimble/ll: Make default Resolve List size
match HW supported size
URL: https://github.com/apache/mynewt-nimble/pull/1422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
apache-mynewt-bot commented on PR #2919:
URL: https://github.com/apache/mynewt-core/pull/2919#issuecomment-1369080223
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
m-gorecki opened a new pull request, #2919:
URL: https://github.com/apache/mynewt-core/pull/2919
This adds initial Nucleo-H723ZG BSP and STM32H723ZG MCU support, but it uses
new feature implemented to Newt, which is ability to download external
repositories that do not contain project.yml
m-gorecki closed pull request #2910: Add initial STM32H723ZG MCU support
URL: https://github.com/apache/mynewt-core/pull/2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
m-gorecki opened a new pull request, #497:
URL: https://github.com/apache/mynewt-newt/pull/497
This allows to download external repos like SDK packages, which do not
contain project.yml files. Now we do not have to keep all of the SDKs in
apache-mynewt-core repository. This also allows to
apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367924434
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367909628
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#issuecomment-1367909371
## RAT Report (2022-12-30 13:05:51)
## New files with unknown licenses
*
apache-mynewt-bot commented on PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#issuecomment-1367896872
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1367392464
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1366804586
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1366794889
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
sjanc opened a new pull request, #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424
If new DLE parameters were matching default values DLE update procedure was
not started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
apache-mynewt-bot commented on PR #1406:
URL: https://github.com/apache/mynewt-nimble/pull/1406#issuecomment-1366427081
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apache-mynewt-bot commented on PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#issuecomment-1363899489
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
andrzej-kaczmarek merged PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andrzej-kaczmarek commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1056253553
##
apps/bleprph_oic/pkg.yml:
##
@@ -30,10 +30,10 @@ pkg.deps:
- "@apache-mynewt-nimble/nimble/host/services/gatt"
-
apache-mynewt-bot commented on PR #2918:
URL: https://github.com/apache/mynewt-core/pull/2918#issuecomment-1363857242
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjanc commented on code in PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#discussion_r1056244315
##
nimble/drivers/nrf5x/src/ble_phy.c:
##
@@ -1096,6 +1096,11 @@ ble_phy_tx_end_isr(void)
tx_time = NRF_TIMER0->CC[2] + tifs;
/* Adjust for delay
apache-mynewt-bot commented on PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917#issuecomment-1363847144
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2917:
URL: https://github.com/apache/mynewt-core/pull/2917#issuecomment-1363837027
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#issuecomment-1363833962
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
apache-mynewt-bot commented on PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#issuecomment-1363732947
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 20572 matches
Mail list logo