[GitHub] jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command

2017-05-30 Thread git
jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command URL: https://github.com/apache/incubator-mynewt-core/pull/281#discussion_r119246771 ## File path: mgmt/imgmgr/src/imgmgr.c ## @@ -223,6 +228,70 @@ imgr_f

[GitHub] jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command

2017-05-30 Thread git
jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command URL: https://github.com/apache/incubator-mynewt-core/pull/281#discussion_r119246721 ## File path: sys/flash_map/include/flash_map/flash_map.h ## @@ -41,6

[GitHub] jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command

2017-05-30 Thread git
jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command URL: https://github.com/apache/incubator-mynewt-core/pull/281#discussion_r119244439 ## File path: sys/flash_map/include/flash_map/flash_map.h ## @@ -41,6

[GitHub] jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command

2017-05-30 Thread git
jacobrosenthal commented on a change in pull request #281: imgmgr: add erase command, remove erase from upload command URL: https://github.com/apache/incubator-mynewt-core/pull/281#discussion_r119244347 ## File path: sys/flash_map/src/flash_map.c ## @@ -21,6 +21,7 @@ #in