[
https://issues.apache.org/jira/browse/NETBEANS-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Thiel closed NETBEANS-5797.
-------------------------------------
Fix Version/s: 12.5
Resolution: Fixed
works in 12.5
> Refactoring: Introduce Constant for String
> ------------------------------------------
>
> Key: NETBEANS-5797
> URL: https://issues.apache.org/jira/browse/NETBEANS-5797
> Project: NetBeans
> Issue Type: Bug
> Components: java - Refactoring
> Affects Versions: 12.4
> Reporter: Christian Thiel
> Priority: Critical
> Fix For: 12.5
>
>
> Mark a String in a java-class that occures multiple times. Attempt to
> refactor (introduce constant) fails with following exception:
> SEVERE [org.openide.util.Exceptions]
> java.lang.ClassCastException: class
> com.sun.tools.javac.tree.JCTree$JCMethodInvocation cannot be cast to class
> com.sun.tools.javac.tree.JCTree$JCBlock
> (com.sun.tools.javac.tree.JCTree$JCMethodInvocation and
> com.sun.tools.javac.tree.JCTree$JCBlock are in unnamed module of loader
> org.netbeans.StandardModule$OneModuleClassLoader @50a9ba2b)
> at com.sun.tools.javac.comp.AttrRecover.doRecovery(AttrRecover.java:161)
> at com.sun.tools.javac.comp.Attr.attribStat(Attr.java:767)
> at com.sun.tools.javac.comp.Attr.attribStats(Attr.java:784)
> at com.sun.tools.javac.comp.Attr.visitBlock(Attr.java:1487)
> at org.netbeans.lib.nbjavac.services.NBAttr.visitBlock(NBAttr.java:76)
> at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1062)
> at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:681)
> at
> com.sun.tools.javac.comp.DeferredAttr.attribSpeculative(DeferredAttr.java:527)
> at com.sun.tools.javac.comp.Attr.attribToTree(Attr.java:432)
> at com.sun.tools.javac.comp.Attr.attribStatToTree(Attr.java:423)
> at com.sun.tools.javac.api.JavacTrees.attribStatToTree(JavacTrees.java:1013)
> at com.sun.tools.javac.api.JavacTrees.getAttrContext(JavacTrees.java:972)
> at com.sun.tools.javac.api.JavacTrees.getScope(JavacTrees.java:833)
> at com.sun.tools.javac.api.JavacTrees.getScope(JavacTrees.java:172)
> at
> org.netbeans.modules.java.hints.introduce.IntroduceFieldFix$Worker.run(IntroduceFieldFix.java:318)
> at
> org.netbeans.modules.java.hints.introduce.IntroduceFieldFix$Worker.run(IntroduceFieldFix.java:179)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:673)
> at org.netbeans.api.java.source.JavaSource$1.run(JavaSource.java:663)
> at org.netbeans.api.java.source.JavaSource$MultiTask.run(JavaSource.java:502)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
> at
> org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
> at
> org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
> at
> org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
> at
> org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
> at
> org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
> at
> org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
> at
> org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
> at
> org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:452)
> at
> org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:423)
> at
> org.netbeans.api.java.source.JavaSource.runModificationTask(JavaSource.java:684)
> at
> org.netbeans.modules.java.hints.introduce.IntroduceFieldFix.implement(IntroduceFieldFix.java:163)
> at
> org.netbeans.modules.java.hints.introduce.IntroduceConstantFix.implement(IntroduceConstantFix.java:48)
> [catch] at org.netbeans.modules.editor.hints.HintsUI$1.run(HintsUI.java:810)
> at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> at
> org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> at
> org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
> WARNING [org.openide.filesystems.Ordering]: Not all children in Actions/Edit/
> marked with the position attribute: [bookmark-history-popup-next.instance,
> bookmark-history-popup-previous.instance, bookmark-next.instance,
> bookmark-previous.instance, bookmark-toggle.instance,
> clear-document-bookmarks.instance,
> org-netbeans-core-ui-options-filetypes-OpenAsAction.instance,
> org-netbeans-core-ui-sysopen-SystemOpenAction.instance,
> org-netbeans-modules-editor-ExportHtmlAction.instance,
> org-netbeans-modules-editor-autosave-ToggleAutoSaveAction.instance,
> org-netbeans-modules-editor-bookmarks-ui-BookmarksViewOpenAction.instance,
> org-netbeans-modules-java-navigation-actions-ShowHierarchyAction.instance,
> org-netbeans-modules-java-navigation-actions-ShowHierarchyAtCaretAction.instance,
> org-netbeans-modules-java-navigation-actions-ShowMembersAction.instance,
> org-netbeans-modules-java-navigation-actions-ShowMembersAtCaretAction.instance,
> org-netbeans-modules-jumpto-symbol-GoToSymbol.instance,
> org-netbeans-modules-jumpto-type-GoToType.instance,
> org-netbeans-modules-php-editor-nav-hierarchy-ShowPhpClassHierarchyAction.instance,
> org-netbeans-modules-quicksearch-QuickSearchAction.instance,
> org-netbeans-modules-search-FindInFilesAction.instance,
> org-netbeans-modules-search-ReplaceInFilesAction.instance,
> org-netbeans-modules-spring-beans-jumpto-type-GoToBean.instance,
> org-netbeans-modules-utilities-CopyPathToClipboard.instance,
> org-openide-actions-CopyAction.instance,
> org-openide-actions-CutAction.instance,
> org-openide-actions-DeleteAction.instance,
> org-openide-actions-FindAction.instance,
> org-openide-actions-GotoAction.instance,
> org-openide-actions-PasteAction.instance,
> org-openide-actions-RedoAction.instance,
> org-openide-actions-ReplaceAction.instance,
> org-openide-actions-UndoAction.instance], but some are:
> [org-netbeans-modules-linetools-actions-MatchCase.instance,
> org-netbeans-modules-linetools-actions-RemoveDuplicateLines.instance]
> WARNING [org.netbeans.modules.options.keymap.LayersBridge]: Invalid shortcut:
> org.openide.loaders.XMLDataObject@2e464773[MultiFileObject@21cf24c1[Actions/Help/master-help.xml]]
> SEVERE [global]
> java.lang.AssertionError: Unsupported removeType=RETAIN_LAST_CARET in nested
> transaction
> at
> org.netbeans.api.editor.caret.EditorCaret.runTransaction(EditorCaret.java:1689)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:577)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:546)
> at
> org.netbeans.modules.uihandler.SubmitPanel.propertyChange(SubmitPanel.java:161)
> at
> java.desktop/java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:341)
> at
> java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:333)
> at
> java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:266)
> at org.openide.explorer.ExplorerManager$2.run(ExplorerManager.java:866)
> at
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEvent(NbMutexEventProvider.java:97)
> at
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.readAccess(NbMutexEventProvider.java:72)
> at
> org.netbeans.modules.openide.util.LazyMutexImplementation.readAccess(LazyMutexImplementation.java:66)
> at org.openide.util.Mutex.readAccess(Mutex.java:241)
> at org.openide.explorer.ExplorerManager.fireInAWT(ExplorerManager.java:863)
> at
> org.openide.explorer.ExplorerManager$1AtomicSetSelectedNodes.fire(ExplorerManager.java:269)
> at
> org.openide.explorer.ExplorerManager.setSelectedNodes(ExplorerManager.java:280)
> at
> org.netbeans.modules.uihandler.SubmitPanel.caretUpdate(SubmitPanel.java:180)
> at
> java.desktop/javax.swing.text.JTextComponent.fireCaretUpdate(JTextComponent.java:412)
> at
> java.desktop/javax.swing.text.JTextComponent$MutableCaretEvent.fire(JTextComponent.java:4489)
> at
> java.desktop/javax.swing.text.JTextComponent$MutableCaretEvent.stateChanged(JTextComponent.java:4511)
> at org.netbeans.api.editor.caret.EditorCaret$6.run(EditorCaret.java:1733)
> at
> org.netbeans.modules.editor.lib2.view.ViewUtils.runInEDT(ViewUtils.java:413)
> at
> org.netbeans.api.editor.caret.EditorCaret.fireStateChanged(EditorCaret.java:1742)
> at
> org.netbeans.api.editor.caret.EditorCaret.runTransaction(EditorCaret.java:1664)
> at org.netbeans.api.editor.caret.EditorCaret.moveDot(EditorCaret.java:634)
> at org.netbeans.api.editor.caret.EditorCaret.moveDot(EditorCaret.java:604)
> at org.netbeans.editor.BaseKit$EndAction.actionPerformed(BaseKit.java:3697)
> at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:322)
> at
> org.netbeans.spi.editor.AbstractEditorAction.actionPerformed(AbstractEditorAction.java:445)
> at
> org.netbeans.editor.BaseKit$KitCompoundAction.actionPerformed(BaseKit.java:1954)
> at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:322)
> at
> org.netbeans.spi.editor.AbstractEditorAction.actionPerformed(AbstractEditorAction.java:445)
> at
> java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
> at
> java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2900)
> at
> java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2948)
> at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2862)
> at java.desktop/java.awt.Component.processEvent(Component.java:6413)
> at java.desktop/java.awt.Container.processEvent(Container.java:2263)
> at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5012)
> at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
> at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
> at
> java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1950)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:870)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1139)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1009)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:835)
> at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4893)
> at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
> at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2764)
> at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
> at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
> at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
> at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
> at
> java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
> at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
> at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
> at
> java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
> at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
> at
> org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136)
> [catch] at
> java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
> at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
> SEVERE [global]
> java.lang.AssertionError: Unsupported removeType=RETAIN_LAST_CARET in nested
> transaction
> at
> org.netbeans.api.editor.caret.EditorCaret.runTransaction(EditorCaret.java:1689)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:577)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:546)
> at
> org.netbeans.modules.uihandler.SubmitPanel.propertyChange(SubmitPanel.java:161)
> at
> java.desktop/java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:341)
> at
> java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:333)
> at
> java.desktop/java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:266)
> at org.openide.explorer.ExplorerManager$2.run(ExplorerManager.java:866)
> at
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEvent(NbMutexEventProvider.java:97)
> at
> org.netbeans.modules.openide.util.NbMutexEventProvider$Event.readAccess(NbMutexEventProvider.java:72)
> at
> org.netbeans.modules.openide.util.LazyMutexImplementation.readAccess(LazyMutexImplementation.java:66)
> at org.openide.util.Mutex.readAccess(Mutex.java:241)
> at org.openide.explorer.ExplorerManager.fireInAWT(ExplorerManager.java:863)
> at
> org.openide.explorer.ExplorerManager$1AtomicSetSelectedNodes.fire(ExplorerManager.java:269)
> at
> org.openide.explorer.ExplorerManager.setSelectedNodes(ExplorerManager.java:280)
> at
> org.netbeans.modules.uihandler.SubmitPanel.caretUpdate(SubmitPanel.java:180)
> at
> java.desktop/javax.swing.text.JTextComponent.fireCaretUpdate(JTextComponent.java:412)
> at
> java.desktop/javax.swing.text.JTextComponent$MutableCaretEvent.fire(JTextComponent.java:4489)
> at
> java.desktop/javax.swing.text.JTextComponent$MutableCaretEvent.stateChanged(JTextComponent.java:4511)
> at org.netbeans.api.editor.caret.EditorCaret$6.run(EditorCaret.java:1733)
> at
> org.netbeans.modules.editor.lib2.view.ViewUtils.runInEDT(ViewUtils.java:413)
> at
> org.netbeans.api.editor.caret.EditorCaret.fireStateChanged(EditorCaret.java:1742)
> at
> org.netbeans.api.editor.caret.EditorCaret.runTransaction(EditorCaret.java:1664)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:577)
> at org.netbeans.api.editor.caret.EditorCaret.setDot(EditorCaret.java:546)
> at org.netbeans.editor.BaseKit$BeginAction.actionPerformed(BaseKit.java:3664)
> at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:322)
> at
> org.netbeans.spi.editor.AbstractEditorAction.actionPerformed(AbstractEditorAction.java:445)
> at
> org.netbeans.editor.BaseKit$KitCompoundAction.actionPerformed(BaseKit.java:1954)
> at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:322)
> at
> org.netbeans.spi.editor.AbstractEditorAction.actionPerformed(AbstractEditorAction.java:445)
> at
> java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810)
> at
> java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2900)
> at
> java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2948)
> at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2862)
> at java.desktop/java.awt.Component.processEvent(Component.java:6413)
> at java.desktop/java.awt.Container.processEvent(Container.java:2263)
> at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5012)
> at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
> at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
> at
> java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1950)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:870)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1139)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1009)
> at
> java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:835)
> at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4893)
> at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
> at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2764)
> at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)
> at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
> at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
> at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
> at
> java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
> at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
> at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
> at
> java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
> at
> java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
> at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
> at
> org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136)
> [catch] at
> java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
> at
> java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
> at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
