[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020783#comment-15020783
]
ASF subversion and git services commented on NIFI-1086:
---
Commit cdd2c
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020782#comment-15020782
]
Tony Kurc commented on NIFI-1086:
-
Tested with NIFI-1196 patch and the template on that tic
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020761#comment-15020761
]
Tony Kurc commented on NIFI-1086:
-
checkstyle/rat/tests are not problems. "integration" tes
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020743#comment-15020743
]
Tony Kurc commented on NIFI-1086:
-
patch applies clean. changes appear to address [~aldrin]
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020737#comment-15020737
]
Tony Kurc commented on NIFI-1086:
-
I'll have some review time in a couple hours.
> Refacto
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020692#comment-15020692
]
Joseph Percivall commented on NIFI-1086:
That all makes sense. I can put up a patch
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013011#comment-15013011
]
Aldrin Piri commented on NIFI-1086:
---
Spent the last couple hours reviewing everything one
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012996#comment-15012996
]
ASF subversion and git services commented on NIFI-1086:
---
Commit 8c232
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012979#comment-15012979
]
Tony Kurc commented on NIFI-1086:
-
[~joewitt] - I was on the fence about this, as there are
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011047#comment-15011047
]
Joseph Witt commented on NIFI-1086:
---
If it is a until as described sounds like it should
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011042#comment-15011042
]
Joseph Percivall commented on NIFI-1086:
Also with the next patch I post I will be
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011030#comment-15011030
]
Aldrin Piri commented on NIFI-1086:
---
Pending the result of NIFI-1168 as this is very depe
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007361#comment-15007361
]
Joseph Percivall commented on NIFI-1086:
Agreed. I'll leave the functionality how i
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007353#comment-15007353
]
Aldrin Piri commented on NIFI-1086:
---
Yeah... that is awkward. Schemes to then only emit
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007341#comment-15007341
]
Joseph Percivall commented on NIFI-1086:
In regards to creating a flowfile when the
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007257#comment-15007257
]
Joseph Percivall commented on NIFI-1086:
That's true for the OkHttpClient but I'm t
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007221#comment-15007221
]
Joseph Percivall commented on NIFI-1086:
Sorry I am not thinking clearly, you're ri
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007146#comment-15007146
]
Aldrin Piri commented on NIFI-1086:
---
OkClient's isSuccessful excludes 300 as per
{code}
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006981#comment-15006981
]
Joseph Percivall commented on NIFI-1086:
I'd be ok with making a request flowfile w
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005617#comment-15005617
]
Aldrin Piri commented on NIFI-1086:
---
In creating NIFI-1168, I was wondering what your tho
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005528#comment-15005528
]
Aldrin Piri commented on NIFI-1086:
---
Overall changes look good. I think we're almost the
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004469#comment-15004469
]
Joseph Percivall commented on NIFI-1086:
Thanks for the review! I will address each
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002972#comment-15002972
]
Aldrin Piri commented on NIFI-1086:
---
-1
Build, contrib, and tests all check out.
Issues
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002479#comment-15002479
]
Aldrin Piri commented on NIFI-1086:
---
[~JDP10101] Patch doesn't seem to apply with latest
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002468#comment-15002468
]
Aldrin Piri commented on NIFI-1086:
---
Reviewing
> Refactor InvokeHttp
> -
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998692#comment-14998692
]
Joseph Percivall commented on NIFI-1086:
The core of 1133 is that when the status r
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995071#comment-14995071
]
Joseph Percivall commented on NIFI-1086:
I will be submitting a patch for review fo
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986135#comment-14986135
]
Joseph Percivall commented on NIFI-1086:
It appears the handler for POST was only c
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986105#comment-14986105
]
Matt Gilman commented on NIFI-1086:
---
Contrib-check passes, the recently updated and more
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981022#comment-14981022
]
Joseph Percivall commented on NIFI-1086:
OkHttp allows for Digest Authentication in
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981020#comment-14981020
]
Joseph Percivall commented on NIFI-1086:
Should be able to knock this out during th
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981019#comment-14981019
]
Joseph Percivall commented on NIFI-1086:
Will be able to address most if not all of
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981017#comment-14981017
]
Joseph Percivall commented on NIFI-1086:
During the refactor can address this issue
[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981015#comment-14981015
]
Joseph Percivall commented on NIFI-1086:
In order to know there is no breaking chan
34 matches
Mail list logo
