[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975411#comment-14975411
]
Mark Payne commented on NIFI-447:
-
[~JPercivall] this patch won't apply against master. Can
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976493#comment-14976493
]
ASF subversion and git services commented on NIFI-447:
--
Commit af19053a
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976492#comment-14976492
]
ASF subversion and git services commented on NIFI-447:
--
Commit 07238c79
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976495#comment-14976495
]
Mark Payne commented on NIFI-447:
-
Thanks [~JPercivall]. Another solid contribution! Pushed
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730944#comment-14730944
]
Joseph Percivall commented on NIFI-447:
---
I'm working on this now.
Should the literal
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730952#comment-14730952
]
Mark Payne commented on NIFI-447:
-
[~JPercivall]: I would say yes, it makes sense. Good catc
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731233#comment-14731233
]
Joseph Percivall commented on NIFI-447:
---
[~markap14]: Why shouldn't we have linewise o
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731240#comment-14731240
]
Mark Payne commented on NIFI-447:
-
I can't argue that we shouldn't. Though if we are going t
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731248#comment-14731248
]
Joseph Percivall commented on NIFI-447:
---
Yup, that's exactly what I was thinking
> Ad
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731310#comment-14731310
]
Joseph Percivall commented on NIFI-447:
---
In the case where we are appending and a line
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731330#comment-14731330
]
Mark Payne commented on NIFI-447:
-
Agreed. That's the route that I would take.
> Add "Repla
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731563#comment-14731563
]
Joseph Percivall commented on NIFI-447:
---
I created an initial patch. I wasn't sure of
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876722#comment-14876722
]
Mark Payne commented on NIFI-447:
-
[~JPercivall] - For the Replacement Strategy property des
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947038#comment-14947038
]
Mark Payne commented on NIFI-447:
-
Hey [~JPercivall] was just looking over this patch. I thi
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947884#comment-14947884
]
Mark Payne commented on NIFI-447:
-
[~JPercivall] it looks like you mentioned Michael Payne i
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947972#comment-14947972
]
Joseph Percivall commented on NIFI-447:
---
Whops sorry Michael
[~markap14] Ah that's a
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948648#comment-14948648
]
Mark Payne commented on NIFI-447:
-
Joe,
When we create a PropertyDescriptor, the "name" of
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949283#comment-14949283
]
Mark Payne commented on NIFI-447:
-
I replaced the existing patch because i found that Replac
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950319#comment-14950319
]
Matt Gilman commented on NIFI-447:
--
Just giving a quick review and noticed a few style issu
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957725#comment-14957725
]
Mark Payne commented on NIFI-447:
-
[~mcgilman] - I'm not sure what you were looking at, but
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957730#comment-14957730
]
Matt Gilman commented on NIFI-447:
--
[~markap14] and when I said the 0001 patch, what I actu
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958087#comment-14958087
]
Mark Payne commented on NIFI-447:
-
[~mcgilman] Now I follow you. The funky method names are
[
https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958181#comment-14958181
]
Joseph Percivall commented on NIFI-447:
---
I can update the filenames. Do you want me to
23 matches
Mail list logo
