[
https://issues.apache.org/jira/browse/NIFI-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597936#comment-14597936
]
Mark Payne commented on NIFI-34:
--------------------------------
I would actually argue that these are both okay. No reason that we need to
build the objects ahead of time and return immutable objects. Some may consider
that a best practice, but I usually construct a new List/Set each time, because
I believe the code is cleaner and easier to understand. It's also fairly common
to write a processor where one or both of these are dynamic.
> Mock Framework should provide option to detect common bad practices/bugs
> ------------------------------------------------------------------------
>
> Key: NIFI-34
> URL: https://issues.apache.org/jira/browse/NIFI-34
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Priority: Minor
>
> Mock Framework should detect common errors such as:
> * Processor has member variable that is a PropertyDescriptor, but the
> PropertyDescriptor isn't returned in the list of supported property
> descriptors.
> * Processor has member variable that is a Relationship, but the Relationship
> isn't returned in the Set of Relationships.
> * Processor has multiple properties or relationships as member variables with
> the same name.
> * No META-INF/services file
> * META-INF/services file doesn't contain the Component's Fully Qualified
> Class Name
> * No @CapabilityDescription annotation
> * No @Tags annotation
> Mock Framework should automatically detect these things and fail the unit
> test unless checking is disabled. This requires building an object that
> allows developer to enable/disable each of these checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
