xiaoxiang781216 opened a new pull request #228: drivers/Kconfig: move if/endif
to subfolder Kconfig
URL: https://github.com/apache/incubator-nuttx/pull/228
and make ARCH_HAVE_XXX option always selectable by moving out of if/endif
Signed-off-by: Xiang Xiao
--
xiaoxiang781216 commented on a change in pull request #217: Refine Kconfig
under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376686006
##
File path: drivers/Kconfig
##
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-co
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 81f1133 ELF64 support (#220)
81f1133 is
masayuki2009 commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583653259
I've modified the code and pushed with -f.
And tested with the following environments
(32bit cpu) spresense:elf, spresense:posix_spawn, spresense:m
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr220
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/pr220 by this push:
new 468ea84 ELF64 support (#220)
468ea84 is d
patacongo merged pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch pr220
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
at e21c30c arch/arm/include/stm32f010g0/chip.h: correct wrong #if
defined to fix build break (#227)
No new rev
patacongo commented on a change in pull request #217: Refine Kconfig under
drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376644228
##
File path: drivers/Kconfig
##
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-config A
patacongo commented on a change in pull request #217: Refine Kconfig under
drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376642907
##
File path: drivers/Kconfig
##
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-config A
patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583502128
We all agreed to support these Inviolable principles when we started this
project together.
T
patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583501897
I don't think the "making things easier" is a argument for not following the
coding style. That is spelled out in the Inviolables:
53 o Personal or
patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583500778
I think we should follow the coding standard, but I have no problem with
incorporating the PR as it is. Feel free to merge it.
--
davids5 merged pull request #227: arch/arm/include/stm32f010g0/chip.h: correct
wrong #if defined to fix…
URL: https://github.com/apache/incubator-nuttx/pull/227
This is an automated message from the Apache Git Service.
To re
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new e21c30c arch/arm/include/stm32f010g0/
liuguo09 opened a new pull request #227: arch/arm/include/stm32f010g0/chip.h:
correct wrong #if defined to fix…
URL: https://github.com/apache/incubator-nuttx/pull/227
… build break
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/include/arch/stm32f0l0g0/chip.h:53:42
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git
The following commit(s) were added to refs/heads/master by this push:
new 742e0da Get the full direct
xiaoxiang781216 commented on issue #56: Ensure all source code end with one and
only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583460007
> Have you considered just enabling the pre commit hook that comes with git
that checks for the sort of thing
xiaoxiang781216 commented on issue #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225#issuecomment-583457186
> The only risk in this is the this will change the time and order in which
MCU resources are initialized. I cannot think of any problems in this, but is
davids5 commented on issue #56: Ensure all source code end with one and only
one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583455737
Have you considered just enabling the pre commit hook that comes with git
that checks for the sort of thing?
---
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git
The following commit(s) were added to refs/heads/master by this push:
new 384af2d Call testbuild.sh w
xiaoxiang781216 commented on issue #56: Ensure all source code end with one and
only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583453267
@patacongo should we reconsider this patch again? the consistence is most
important thing for coding sandard:
xiaoxiang781216 commented on issue #56: Ensure all source code end with one and
only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583450422
> @xiaoxiang781216 is this safe on all types of files?
@davids5 I remove all binary file from the commi
xiaoxiang781216 commented on issue #56: Ensure all source code end with one and
only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583449362
> "is this safe on all types of files?" It is inappropriate on the .txt file
that needs the newline for visua
xiaoxiang781216 commented on a change in pull request #56: Ensure all source
code end with one and only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#discussion_r376444329
##
File path: examples/elf/tests/helloxx/.gitignore
##
@@ -2,4 +2,4 @@ hel
xiaoxiang781216 commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583441002
> Yes, but it is not a standard.
>
> I don't know what the answer is. I understand what you are saying, but if
we ignore the coding standard, then I t
patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583417902
Yes, but it is not a standard.
I don't know what the answer is. I understand what you are saying, but if we
ignore the coding standard, then I think we are
xiaoxiang781216 edited a comment on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583416696
> someday
But this is a defacto standard used in all POSIX variant, should we follow
the well established convention?
xiaoxiang781216 commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583416696
> someday
But this is a defacto standard, should we follow the well established
convention?
-
patacongo commented on issue #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225#issuecomment-583413930
Sorry about the close and re-open, I clicked the wrong button.
This is an automated message fr
xiaoxiang781216 opened a new pull request #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225
Reorder the irq and timer initializition as commit 0863e771a99553e
suggestion:
Since the tickless mode timer is very special, one solution might be to
1. Renam
patacongo closed pull request #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
patacongo commented on issue #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225#issuecomment-583413153
The only risk in this is the this will change the time and order in which
MCU resources are initialized. I cannot think of any problems in this, but is
it al
patacongo commented on issue #56: Ensure all source code end with one and only
one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583403450
"is this safe on all types of files?" It is inappropriate on the .txt file
that needs the newline for visual spaci
patacongo closed pull request #56: Ensure all source code end with one and only
one newline
URL: https://github.com/apache/incubator-nuttx-apps/pull/56
This is an automated message from the Apache Git Service.
To respond to
patacongo commented on a change in pull request #56: Ensure all source code end
with one and only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#discussion_r376404535
##
File path: examples/elf/tests/helloxx/.gitignore
##
@@ -2,4 +2,4 @@ hello++1
patacongo commented on a change in pull request #56: Ensure all source code end
with one and only one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#discussion_r376403770
##
File path: examples/cromfs/cromfs/testdir2/TheThreeLittlePigs.txt
##
@@ -14,4
davids5 commented on issue #56: Ensure all source code end with one and only
one newline
URL:
https://github.com/apache/incubator-nuttx-apps/pull/56#issuecomment-583396552
@xiaoxiang781216 is this safe on all types of files?
xiaoxiang781216 opened a new pull request #56: Ensure all source code end with
one and only one newline
URL: https://github.com/apache/incubator-nuttx-apps/pull/56
by this command:
git ls-files -z | while IFS= read -rd '' f; do tail -c1 < "$f" | read -r _
|| echo >> "$f"; done
Si
xiaoxiang781216 opened a new pull request #226: Ensure all source code end with
one and only one newline
URL: https://github.com/apache/incubator-nuttx/pull/226
by this command:
git ls-files -z | while IFS= read -rd '' f; do tail -c1 < "$f" | read -r _
|| echo >> "$f"; done
Signe
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3b311ab tools/testbuild.sh: use function to call make and fail handle
in common
add b216d91 drivers/n
masayuki2009 commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583384773
@patacongo Thanks for the comment regarding coding standard. Now I'm
preparing new patch sets which @xiaoxiang781216 pointed out. Perhaps, I need
one more day.
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8d5b33235fdd7b8b792b7423aab42ce7dc04968e
Author: Xiang Xiao
AuthorDate: Wed Feb 5 16:24:54 2020 +0800
Remove
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 134da2c272018b703895bdceeca5fa236b13eafd
Author: Xiang Xiao
AuthorDate: Wed Feb 5 17:14:30 2020 +0800
Refine
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 526fa7b77359c38ac21d2856c7f5d3baf365ec08
Author: Xiang Xiao
AuthorDate: Wed Feb 5 23:52:37 2020 +0800
Trigge
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit db542520f93d9da6e481cf6f46c7ce410a53f941
Author: Xiang Xiao
AuthorDate: Wed Feb 5 17:52:26 2020 +0800
Unify
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2e6de18c403801ebca6f60221310fb6e522f9141
Author: Xiang Xiao
AuthorDate: Wed Feb 5 16:12:53 2020 +0800
Split
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 386b2d834ad4c1f655fa544dfc1ea6f7fa66f72b
Author: Xiang Xiao
AuthorDate: Wed Feb 5 22:04:34 2020 +0800
telnet
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3b311ab tools/testbuild.sh: use function to call make and fail handle
in common
new 2e6de18 Split comm
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e3158730265cbfc454deb5d1051d41d41da7e498
Author: Xiang Xiao
AuthorDate: Wed Feb 5 17:57:58 2020 +0800
Remove
patacongo merged pull request #215: Improve telnet driver
URL: https://github.com/apache/incubator-nuttx/pull/215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch pr215
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
at 3b311ab tools/testbuild.sh: use function to call make and fail handle
in common
No new revisions were added
patacongo edited a comment on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583380800
"Please note that some typedefs such as Elf32_xxx, Elf64_xxx, Elf_xxx still
violate NuttX conding standard." Those are the names used in other elf header
patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583380800
"Please note that some typedefs such as Elf32_xxx, Elf64_xxx, Elf_xxx still
violate NuttX conding standard." Those are the names used in other elf header
files.
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 499607d S32K add support for Nxp drone boards (#224)
add 3b311ab tools/testbuild.sh: use functio
Ouss4 merged pull request #221: tools/testbuild.sh: use function to call make
and fail handle in common
URL: https://github.com/apache/incubator-nuttx/pull/221
This is an automated message from the Apache Git Service.
To res
davids5 commented on issue #224: S32K add support for Nxp drone boards
URL: https://github.com/apache/incubator-nuttx/pull/224#issuecomment-583377679
Build tested and run through Nxstyle.
Thank you @PetervdPerk-NXP and @jarivanewijk for the great work and being so
diligent on the S
davids5 merged pull request #224: S32K add support for Nxp drone boards
URL: https://github.com/apache/incubator-nuttx/pull/224
This is an automated message from the Apache Git Service.
To respond to the message, please log o
davids5 commented on a change in pull request #224: S32K add support for Nxp
drone boards
URL: https://github.com/apache/incubator-nuttx/pull/224#discussion_r376365899
##
File path: arch/arm/src/s32k1xx/hardware/s32k1xx_rtc.h
##
@@ -0,0 +1,93 @@
+/*
davids5 commented on a change in pull request #224: S32K add support for Nxp
drone boards
URL: https://github.com/apache/incubator-nuttx/pull/224#discussion_r376365695
##
File path: arch/arm/src/s32k1xx/hardware/s32k1xx_rtc.h
##
@@ -0,0 +1,93 @@
+/*
davids5 commented on a change in pull request #224: S32K add support for Nxp
drone boards
URL: https://github.com/apache/incubator-nuttx/pull/224#discussion_r376365695
##
File path: arch/arm/src/s32k1xx/hardware/s32k1xx_rtc.h
##
@@ -0,0 +1,93 @@
+/*
davids5 closed pull request #160: Nxp drone boards
URL: https://github.com/apache/incubator-nuttx/pull/160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
davids5 commented on issue #160: Nxp drone boards
URL: https://github.com/apache/incubator-nuttx/pull/160#issuecomment-583368004
This PR was split into 3 PR. Close in Favor if #224
imxrt added missing i2c prescale mask #222 Merged
Kinetis renamed TJA1100 to TJA110X registers #223
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d79e673 imxrt added missing i2c presc
davids5 merged pull request #222: imxrt added missing i2c prescale mask
URL: https://github.com/apache/incubator-nuttx/pull/222
This is an automated message from the Apache Git Service.
To respond to the message, please log o
davids5 merged pull request #223: Kinetis renamed TJA1100 to TJA110X registers
URL: https://github.com/apache/incubator-nuttx/pull/223
This is an automated message from the Apache Git Service.
To respond to the message, pleas
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 513475c Kinetis renamed TJA1100 to TJ
masayuki2009 commented on a change in pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#discussion_r376357543
##
File path: binfmt/libelf/libelf_bind.c
##
@@ -326,8 +367,181 @@ static int elf_relocate(FAR struct elf_loadinfo_s
*loadin
masayuki2009 commented on a change in pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#discussion_r376355930
##
File path: include/elf_common.h
##
@@ -0,0 +1,214 @@
+/***
xiaoxiang781216 commented on a change in pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#discussion_r376336057
##
File path: binfmt/libelf/libelf_bind.c
##
@@ -326,8 +367,181 @@ static int elf_relocate(FAR struct elf_loadinfo_s
*loa
xiaoxiang781216 commented on a change in pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#discussion_r376333574
##
File path: include/elf_common.h
##
@@ -0,0 +1,214 @@
+/
xiaoxiang781216 opened a new pull request #225: Timer improvement
URL: https://github.com/apache/incubator-nuttx/pull/225
Reorder the irq and timer initializition as commit 0863e771a99553e
suggestion:
Since the tickless mode timer is very special, one solution might be to
1. Renam
PetervdPerk-NXP opened a new pull request #224: S32K add support for Nxp drone
boards
URL: https://github.com/apache/incubator-nuttx/pull/224
Based on #160 splitted up to kinetis, imxrt & s32k
This is an automated message fro
PetervdPerk-NXP opened a new pull request #223: Kinetis renamed TJA1100 to
TJA110X registers
URL: https://github.com/apache/incubator-nuttx/pull/223
Based on #160 splitted up to kinetis, imxrt & s32k
This is an automated mess
PetervdPerk-NXP opened a new pull request #222: imxrt added missing i2c
prescale mask
URL: https://github.com/apache/incubator-nuttx/pull/222
Based on #160 splitted up to kinetis, imxrt & s32k
This is an automated message fro
liuguo09 opened a new pull request #221: tools/testbuild.sh: use function to
call make and fail handle in common
URL: https://github.com/apache/incubator-nuttx/pull/221
Change-Id: I50cbc335254be0f2388b4bb6af8a874e74ba98c2
Signed-off-by: liuhaitao
---
75 matches
Mail list logo