[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
Ouss4 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395968633 ## File path: tools/configure.sh ## @@ -168,16 +164,25 @@ fi src_config=${configpath}/defconfig dest_config="${TOPDIR}/.config" +

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
Ouss4 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395968672 ## File path: tools/configure.sh ## @@ -168,16 +164,25 @@ fi src_config=${configpath}/defconfig dest_config="${TOPDIR}/.config" +

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket

2020-03-20 Thread GitBox
yamt commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395967568 ## File path: arch/sim/src/sim/up_head.c ## @@ -77,6 +78,8 @@ static char g_logbuffer[4096]; in

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change

2020-03-20 Thread GitBox
xiaoxiang781216 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change URL: https://github.com/apache/incubator-nuttx-apps/pull/128#issuecomment-602002218 > @xiaoxiang781216 Let me confirm. In my understanding, this PR is not to fix a bug but to optimize t

[GitHub] [incubator-nuttx] Ouss4 merged pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 merged pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[incubator-nuttx] branch master updated: Add support for Litex VexRiscV.

2020-03-20 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d450f5c Add support for Litex Vex

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on issue #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601998784 @davids5 do you have any more concern? If not, please help merge this PR, thanks. This is an

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395964124 ## File path: arch/sim/src/sim/up_head.c ## @@ -77,6 +78,8 @@ static char g_logbuffer[4

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #597: sim: Make SIM_NETDEV_TAP depends on LINUX||WINDOWS

2020-03-20 Thread GitBox
xiaoxiang781216 merged pull request #597: sim: Make SIM_NETDEV_TAP depends on LINUX||WINDOWS URL: https://github.com/apache/incubator-nuttx/pull/597 This is an automated message from the Apache Git Service. To respond to the

[incubator-nuttx] branch master updated: sim: Make SIM_NETDEV_TAP depends on LINUX||WINDOWS

2020-03-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9b88ecc sim: Make SIM_NETDEV_TAP de

[GitHub] [incubator-nuttx] yamt opened a new pull request #599: sim: Add a CLI option to override vpnkit socket

2020-03-20 Thread GitBox
yamt opened a new pull request #599: sim: Add a CLI option to override vpnkit socket URL: https://github.com/apache/incubator-nuttx/pull/599 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx] yamt closed pull request #598: sim: Add a CLI option to override vpnkit socket

2020-03-20 Thread GitBox
yamt closed pull request #598: sim: Add a CLI option to override vpnkit socket URL: https://github.com/apache/incubator-nuttx/pull/598 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] yamt opened a new pull request #598: sim: Add a CLI option to override vpnkit socket

2020-03-20 Thread GitBox
yamt opened a new pull request #598: sim: Add a CLI option to override vpnkit socket URL: https://github.com/apache/incubator-nuttx/pull/598 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx] yamt opened a new pull request #597: sim: Make SIM_NETDEV_TAP depends on LINUX||WINDOWS

2020-03-20 Thread GitBox
yamt opened a new pull request #597: sim: Make SIM_NETDEV_TAP depends on LINUX||WINDOWS URL: https://github.com/apache/incubator-nuttx/pull/597 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #123: Fix parallel build

2020-03-20 Thread GitBox
xiaoxiang781216 closed pull request #123: Fix parallel build URL: https://github.com/apache/incubator-nuttx-apps/pull/123 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601795244 I think the PR looks good and is ready to merge. Let's give some time for anyone that wants to add any review. When merging, I'd like to squash the 5

[GitHub] [incubator-nuttx] patacongo commented on issue #596: Add intree board config to test the relative CUSTOM board tooling

2020-03-20 Thread GitBox
patacongo commented on issue #596: Add intree board config to test the relative CUSTOM board tooling URL: https://github.com/apache/incubator-nuttx/issues/596#issuecomment-601775902 > Adding a config will insure this does not continue to happen And breakage of custom board configurat

[GitHub] [incubator-nuttx] davids5 opened a new issue #596: Add intree board config to test the relative CUSTOM board tooling

2020-03-20 Thread GitBox
davids5 opened a new issue #596: Add intree board config to test the relative CUSTOM board tooling URL: https://github.com/apache/incubator-nuttx/issues/596 See https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601745637 for Context In the past and recently changes in

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on issue #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601745637 > > Any Idea on how to add an test case in this repo, for a relative path custom board? > > There is no real requirement that the test case be truly a

[GitHub] [incubator-nuttx] patacongo commented on issue #594: Tools refine

2020-03-20 Thread GitBox
patacongo commented on issue #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601742637 > > > Any Idea on how to add an test case in this repo, for a relative path custom board? There is no real requirement that the test

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395690203 ## File path: arch/risc-v/src/litex/hardware/litex_plic.h ## @@ -0,0 +1,35 @@ +/***

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395678532 ## File path: arch/risc-v/src/litex/hardware/litex_plic.h ## @@ -0,0 +1,34 @@ +/***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on issue #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601720989 > Any Idea on how to add an test case in this repo, for a relative path custom board? We can let the relative path point to the normal location: boa

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395654841 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395652215 ## File path: .gitignore ## @@ -29,4 +29,4 @@ core /.cproject /.project /tags -/TAGS +/TAGS Review com

[GitHub] [incubator-nuttx] aenrbes commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
aenrbes commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395650578 ## File path: .gitignore ## @@ -29,4 +29,4 @@ core /.cproject /.project /tags -/TAGS +/TAGS Review comment:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395650520 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395628518 ## File path: .gitignore ## @@ -29,4 +29,4 @@ core /.cproject /.project /tags -/TAGS +/TAGS Review com

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395645131 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395643988 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395627278 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean

[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
davids5 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601685210 @justinmclean - Does you answer imply that the information given was incorrect or the contributor has it wrong or were you just giving an alternate sou

[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
davids5 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601684165 @Ouss4 - Thank you for the direct links! > We may want to add Github's templates for PRs/Issues. Maybe we bring this to the dev list for a discu

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395606863 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] justinmclean commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
justinmclean commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601673984 Please refer to [1] which contains the correct text. 1. https://www.apache.org/legal/src-headers.html#headers --

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
patacongo edited a comment on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239 The required form, the "template", is in the appendix to the coding standard.

[GitHub] [incubator-nuttx] patacongo commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
patacongo commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239 The required form, the "teplate", is in the teplate to the coding standard. This is a

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395591711 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 edited a comment on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889 @aenrbes New files need to have an Apache license. Kconfig, README and auto generated files like defconfig don't need a license. Note that the l

[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889 @aenrbs New files need to have an Apache license. Kconfig, README and auto generated files like defconfig don't need a license. Note that the license h

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395579851 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean

[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
davids5 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601651338 @Ouss4 do we have a Github PR/Issue template (and access to it) we can add all this info to? --

[GitHub] [incubator-nuttx] aenrbes edited a comment on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
aenrbes edited a comment on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755 @Ouss4 Thank you, does this mean I need to change all submitted files like that templates does?

[GitHub] [incubator-nuttx] aenrbes commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
aenrbes commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755 @Ouss4 Thank you, does this means I need to change all submitted files like that templates does? --

[GitHub] [incubator-nuttx] Ouss4 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601645329 A template for the Apache license? Here is one https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_getcpu.c The LICENSE file al

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #594: Tools refine

2020-03-20 Thread GitBox
davids5 commented on a change in pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395565487 ## File path: tools/Makefile.unix ## @@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig gconfig: do_gconfig clean_context

[GitHub] [incubator-nuttx] davids5 commented on issue #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
davids5 commented on issue #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601636436 @aenrbes Nice! Since this is a new contribution (all new files) the licences needs to be the Apache one (@Ouss4 is there a template or instructi

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395554042 ## File path: .gitignore ## @@ -30,3 +30,5 @@ core /.project /tags /TAGS +.vscode/settings.json +.vscode/c_cpp_prope

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #127: Nightly parallel build fix for elf/posix_spawn/module build break

2020-03-20 Thread GitBox
masayuki2009 commented on issue #127: Nightly parallel build fix for elf/posix_spawn/module build break URL: https://github.com/apache/incubator-nuttx-apps/pull/127#issuecomment-601624248 > @masayuki2009 I cannot reproduce the same error by adding sleep in mksymtab.sh. > But I found th

[incubator-nuttx-apps] branch master updated: example/module: update SYMTAB_SRC dependency to fix FSROOT not populated

2020-03-20 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new b27d694 example/module: update

[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #129: example/module: update SYMTAB_SRC dependency to fix FSROOT not populated

2020-03-20 Thread GitBox
masayuki2009 merged pull request #129: example/module: update SYMTAB_SRC dependency to fix FSROOT not populated URL: https://github.com/apache/incubator-nuttx-apps/pull/129 This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #127: Nightly parallel build fix for elf/posix_spawn/module build break

2020-03-20 Thread GitBox
liuguo09 commented on issue #127: Nightly parallel build fix for elf/posix_spawn/module build break URL: https://github.com/apache/incubator-nuttx-apps/pull/127#issuecomment-601592180 @masayuki2009 I cannot reproduce the same error by adding sleep in mksymtab.sh. But I found there is s

[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #129: example/module: update SYMTAB_SRC dependency to fix FSROOT not populated

2020-03-20 Thread GitBox
liuguo09 opened a new pull request #129: example/module: update SYMTAB_SRC dependency to fix FSROOT not populated URL: https://github.com/apache/incubator-nuttx-apps/pull/129 In parallel build, for example maix-bit:module config, it reports: nm: 'a.out': No such file This is caused by

[GitHub] [incubator-nuttx] aenrbes opened a new pull request #595: Support for Litex VexRiscV

2020-03-20 Thread GitBox
aenrbes opened a new pull request #595: Support for Litex VexRiscV URL: https://github.com/apache/incubator-nuttx/pull/595 Add initial support for Litex with softcore CPU VexRiscV SoC [LiteX's website](https://github.com/enjoy-digital/litex), device drivers such as GPIO/I2C/SPI are missing

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #128: Makefile don't change symtab_apps.c timestamp if no any change

2020-03-20 Thread GitBox
xiaoxiang781216 opened a new pull request #128: Makefile don't change symtab_apps.c timestamp if no any change URL: https://github.com/apache/incubator-nuttx-apps/pull/128 Signed-off-by: Xiang Xiao Change-Id: I55576aec46bd057bc98cf2b6579d7ac96446ae27 ---

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #594: Tools refine

2020-03-20 Thread GitBox
xiaoxiang781216 opened a new pull request #594: Tools refine URL: https://github.com/apache/incubator-nuttx/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #593: NETWORK-VPNKIT.txt: Fix a typo

2020-03-20 Thread GitBox
xiaoxiang781216 merged pull request #593: NETWORK-VPNKIT.txt: Fix a typo URL: https://github.com/apache/incubator-nuttx/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-nuttx] branch master updated: NETWORK-VPNKIT.txt: Fix a typo

2020-03-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5d5878d NETWORK-VPNKIT.txt: Fix a t