Ouss4 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395968633
##
File path: tools/configure.sh
##
@@ -168,16 +164,25 @@ fi
src_config=${configpath}/defconfig
dest_config="${TOPDIR}/.config"
+
Ouss4 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395968672
##
File path: tools/configure.sh
##
@@ -168,16 +164,25 @@ fi
src_config=${configpath}/defconfig
dest_config="${TOPDIR}/.config"
+
yamt commented on a change in pull request #599: sim: Add a CLI option to
override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395967568
##
File path: arch/sim/src/sim/up_head.c
##
@@ -77,6 +78,8 @@ static char g_logbuffer[4096];
in
xiaoxiang781216 commented on issue #128: Makefile don't change symtab_apps.c
timestamp if no any change
URL:
https://github.com/apache/incubator-nuttx-apps/pull/128#issuecomment-602002218
> @xiaoxiang781216 Let me confirm. In my understanding, this PR is not to
fix a bug but to optimize t
Ouss4 merged pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d450f5c Add support for Litex Vex
xiaoxiang781216 commented on issue #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601998784
@davids5 do you have any more concern? If not, please help merge this PR,
thanks.
This is an
xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI
option to override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395964124
##
File path: arch/sim/src/sim/up_head.c
##
@@ -77,6 +78,8 @@ static char g_logbuffer[4
xiaoxiang781216 merged pull request #597: sim: Make SIM_NETDEV_TAP depends on
LINUX||WINDOWS
URL: https://github.com/apache/incubator-nuttx/pull/597
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9b88ecc sim: Make SIM_NETDEV_TAP de
yamt opened a new pull request #599: sim: Add a CLI option to override vpnkit
socket
URL: https://github.com/apache/incubator-nuttx/pull/599
This is an automated message from the Apache Git Service.
To respond to the message
yamt closed pull request #598: sim: Add a CLI option to override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/598
This is an automated message from the Apache Git Service.
To respond to the message, pleas
yamt opened a new pull request #598: sim: Add a CLI option to override vpnkit
socket
URL: https://github.com/apache/incubator-nuttx/pull/598
This is an automated message from the Apache Git Service.
To respond to the message
yamt opened a new pull request #597: sim: Make SIM_NETDEV_TAP depends on
LINUX||WINDOWS
URL: https://github.com/apache/incubator-nuttx/pull/597
This is an automated message from the Apache Git Service.
To respond to the mess
xiaoxiang781216 closed pull request #123: Fix parallel build
URL: https://github.com/apache/incubator-nuttx-apps/pull/123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601795244
I think the PR looks good and is ready to merge. Let's give some time for
anyone that wants to add any review.
When merging, I'd like to squash the 5
patacongo commented on issue #596: Add intree board config to test the relative
CUSTOM board tooling
URL: https://github.com/apache/incubator-nuttx/issues/596#issuecomment-601775902
> Adding a config will insure this does not continue to happen
And breakage of custom board configurat
davids5 opened a new issue #596: Add intree board config to test the relative
CUSTOM board tooling
URL: https://github.com/apache/incubator-nuttx/issues/596
See
https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601745637 for
Context
In the past and recently changes in
xiaoxiang781216 commented on issue #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601745637
> > Any Idea on how to add an test case in this repo, for a relative path
custom board?
>
> There is no real requirement that the test case be truly a
patacongo commented on issue #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601742637
>
>
> Any Idea on how to add an test case in this repo, for a relative path
custom board?
There is no real requirement that the test
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395690203
##
File path: arch/risc-v/src/litex/hardware/litex_plic.h
##
@@ -0,0 +1,35 @@
+/***
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395678532
##
File path: arch/risc-v/src/litex/hardware/litex_plic.h
##
@@ -0,0 +1,34 @@
+/***
xiaoxiang781216 commented on issue #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#issuecomment-601720989
> Any Idea on how to add an test case in this repo, for a relative path
custom board?
We can let the relative path point to the normal location:
boa
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395654841
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
xiaoxiang781216 commented on a change in pull request #595: Support for Litex
VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395652215
##
File path: .gitignore
##
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review com
aenrbes commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395650578
##
File path: .gitignore
##
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review comment:
xiaoxiang781216 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395650520
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean
xiaoxiang781216 commented on a change in pull request #595: Support for Litex
VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395628518
##
File path: .gitignore
##
@@ -29,4 +29,4 @@ core
/.cproject
/.project
/tags
-/TAGS
+/TAGS
Review com
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395645131
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395643988
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
xiaoxiang781216 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395627278
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601685210
@justinmclean - Does you answer imply that the information given was
incorrect or the contributor has it wrong or were you just giving an alternate
sou
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601684165
@Ouss4 - Thank you for the direct links!
> We may want to add Github's templates for PRs/Issues. Maybe we bring this
to the dev list for a discu
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395606863
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
justinmclean commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601673984
Please refer to [1] which contains the correct text.
1. https://www.apache.org/legal/src-headers.html#headers
--
patacongo edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239
The required form, the "template", is in the appendix to the coding standard.
patacongo commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601669239
The required form, the "teplate", is in the teplate to the coding standard.
This is a
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395591711
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
Ouss4 edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889
@aenrbes New files need to have an Apache license. Kconfig, README and auto
generated files like defconfig don't need a license.
Note that the l
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601657889
@aenrbs New files need to have an Apache license. Kconfig, README and auto
generated files like defconfig don't need a license.
Note that the license h
xiaoxiang781216 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395579851
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601651338
@Ouss4 do we have a Github PR/Issue template (and access to it) we can add
all this info to?
--
aenrbes edited a comment on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755
@Ouss4 Thank you, does this mean I need to change all submitted files like
that templates does?
aenrbes commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601648755
@Ouss4 Thank you, does this means I need to change all submitted files like
that templates does?
--
Ouss4 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601645329
A template for the Apache license?
Here is one
https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_getcpu.c
The LICENSE file al
davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395565487
##
File path: tools/Makefile.unix
##
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
davids5 commented on issue #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#issuecomment-601636436
@aenrbes Nice!
Since this is a new contribution (all new files) the licences needs to be
the Apache one (@Ouss4 is there a template or instructi
Ouss4 commented on a change in pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595#discussion_r395554042
##
File path: .gitignore
##
@@ -30,3 +30,5 @@ core
/.project
/tags
/TAGS
+.vscode/settings.json
+.vscode/c_cpp_prope
masayuki2009 commented on issue #127: Nightly parallel build fix for
elf/posix_spawn/module build break
URL:
https://github.com/apache/incubator-nuttx-apps/pull/127#issuecomment-601624248
> @masayuki2009 I cannot reproduce the same error by adding sleep in
mksymtab.sh.
> But I found th
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new b27d694 example/module: update
masayuki2009 merged pull request #129: example/module: update SYMTAB_SRC
dependency to fix FSROOT not populated
URL: https://github.com/apache/incubator-nuttx-apps/pull/129
This is an automated message from the Apache Git Se
liuguo09 commented on issue #127: Nightly parallel build fix for
elf/posix_spawn/module build break
URL:
https://github.com/apache/incubator-nuttx-apps/pull/127#issuecomment-601592180
@masayuki2009 I cannot reproduce the same error by adding sleep in
mksymtab.sh.
But I found there is s
liuguo09 opened a new pull request #129: example/module: update SYMTAB_SRC
dependency to fix FSROOT not populated
URL: https://github.com/apache/incubator-nuttx-apps/pull/129
In parallel build, for example maix-bit:module config, it reports:
nm: 'a.out': No such file
This is caused by
aenrbes opened a new pull request #595: Support for Litex VexRiscV
URL: https://github.com/apache/incubator-nuttx/pull/595
Add initial support for Litex with softcore CPU VexRiscV SoC [LiteX's
website](https://github.com/enjoy-digital/litex), device drivers such as
GPIO/I2C/SPI are missing
xiaoxiang781216 opened a new pull request #128: Makefile don't change
symtab_apps.c timestamp if no any change
URL: https://github.com/apache/incubator-nuttx-apps/pull/128
Signed-off-by: Xiang Xiao
Change-Id: I55576aec46bd057bc98cf2b6579d7ac96446ae27
---
xiaoxiang781216 opened a new pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiaoxiang781216 merged pull request #593: NETWORK-VPNKIT.txt: Fix a typo
URL: https://github.com/apache/incubator-nuttx/pull/593
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 5d5878d NETWORK-VPNKIT.txt: Fix a t
58 matches
Mail list logo