xiaoxiang781216 edited a comment on pull request #963:
URL: https://github.com/apache/incubator-nuttx/pull/963#issuecomment-623251247
> There is an entry in the top-level TODO called "INTERNAL VERSIONS OF USER
FUNCTIONS" at line 212 (at present). Does these changes resolve those? I think
n
xiaoxiang781216 commented on pull request #963:
URL: https://github.com/apache/incubator-nuttx/pull/963#issuecomment-623251247
Yes, the caller need modify to call the internal interface which is the
final one.
This is an aut
btashton commented on issue #954:
URL: https://github.com/apache/incubator-nuttx/issues/954#issuecomment-623226092
Ok I think I fully understand what is going on here. The dangling allocated
holder is the one allocated by `sem_post`.
From `sem_post()`
```
if (stcb !=
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 252f58f sched/sched/sched_get_sta
patacongo opened a new pull request #964:
URL: https://github.com/apache/incubator-nuttx/pull/964
## Summary
The sched_get_stackinfo() interface was just added. However, it occurs to
me that it is a dangerous feature and could lead to security problems. In FLAT
and PROTECTED modes
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 00933cf sched/sched: Add sched_g
patacongo commented on pull request #963:
URL: https://github.com/apache/incubator-nuttx/pull/963#issuecomment-623188604
There is an entry in the top-level TODO called "INTERNAL VERSIONS OF USER
FUNCTIONS" at line 212 (at present). Does these changes resolve those? I
think not. These a
btashton commented on issue #954:
URL: https://github.com/apache/incubator-nuttx/issues/954#issuecomment-623188117
@patacongo If I place a breakpoint at the end of the waiter function this is
what I see on the first hit (thread 1). The semaphore still had thread 1 in
its holder. I see th
xiaoxiang781216 opened a new pull request #963:
URL: https://github.com/apache/incubator-nuttx/pull/963
## Summary
## Impact
## Testing
This is an automated message from the Apache Git Service.
To respon
patacongo commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623179784
> does that sound reasonable?
I am not really fully up to speed on this discussion. What you say seems
reasonable to me. Let's let @xiaoxiang781216 make the fina
patacongo edited a comment on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623178027
I just submitted PR #962 that implements the first baby step: A common API
to get the stack address.
In order to be compatible with standard TLS, the data
patacongo edited a comment on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623178027
I just submitted PR #962 that implements the first baby step: A common API
to get the stack address.
In order to be compatible with standard TLS, the data
patacongo commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623178027
I just submitted PR #962 that implements the first baby step: A common API
to get the stack address.
In order to be compatible with standard TLS, the data must be
patacongo commented on a change in pull request #952:
URL: https://github.com/apache/incubator-nuttx/pull/952#discussion_r419156366
##
File path: libs/libc/misc/lib_ioctl.c
##
@@ -102,7 +102,7 @@ int ioctl(int fd, int req, ...)
* discover cases where something worse happens
patacongo edited a comment on pull request #962:
URL: https://github.com/apache/incubator-nuttx/pull/962#issuecomment-623175266
One nxstyle complaint is normal and to be expected:
syscall/syscall_stublookup.c:433:3: warning: #include outside of
'Included Files' section
Thi
patacongo edited a comment on pull request #962:
URL: https://github.com/apache/incubator-nuttx/pull/962#issuecomment-623175266
One nxstyle complete is normal and to be expected:
syscall/syscall_stublookup.c:433:3: warning: #include outside of
'Included Files' section
This
patacongo commented on pull request #962:
URL: https://github.com/apache/incubator-nuttx/pull/962#issuecomment-623175266
Once nxstyle complete is normal and to be expected:
syscall/syscall_stublookup.c:433:3: warning: #include outside of 'Included
Files' section
This is a ca
patacongo opened a new pull request #962:
URL: https://github.com/apache/incubator-nuttx/pull/962
## Summary
The new OS interface, sched_get_stackinfo() combines two pthread-specific
interfaces into a single generic interface. The existing
pthread_get_stackaddr_np() and pthread_get
btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623170407
Ok pushed the change. I did notice that we are missing a lot of va_end
calls. I added it to this function that I changed, but we should probably look
at the other functi
btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623163844
After reading this
https://stackoverflow.com/questions/8047362/is-gcc-mishandling-a-pointer-to-a-va-list-passed-to-a-function/8048892#8048892
I am more inclined to just
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 31607f76276c990e423c78ccb03156aeb315cebb
Author: raiden00pl
AuthorDate: Sun Apr 26 20:25:06 2020 +0200
fi
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7b0ee05c49affb5cff36ae22688ad4f7bb5e1a8f
Author: raiden00pl
AuthorDate: Sun Apr 26 20:22:57 2020 +0200
bo
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e2a32668573a4e7feeec173d67167e05391f8bbb
Author: raiden00pl
AuthorDate: Sun Apr 26 20:21:37 2020 +0200
ar
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 534ba2cc18062da617e8edb9acc79f3f301cc483
Author: raiden00pl
AuthorDate: Mon Apr 27 20:52:06 2020 +0200
ar
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f03ed73f91676933d56d699b68228e93ca63ba22
Author: raiden00pl
AuthorDate: Sun May 3 15:03:30 2020 +0200
arc
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5857c48b2ea940889d3c6526e77d49ec38266039
Author: raiden00pl
AuthorDate: Mon Apr 27 19:51:21 2020 +0200
ar
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b3a1aef77302e5bcf57850ee8cd20c1ea7b3d95d
Author: raiden00pl
AuthorDate: Sun May 3 14:28:00 2020 +0200
arc
acassis commented on pull request #960:
URL: https://github.com/apache/incubator-nuttx/pull/960#issuecomment-623162596
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from d4bf61c x86_64: Set kernel entry to 1M to avoid EPT Violation
new e2a3266 arch/arm/src/stm32/stm32_a
xiaoxiang781216 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623159639
> > ? We talked about and API to get the stack base address. Are you
planning to use that?
> > I think we should simplify the system calls in that case
>
patacongo commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623156821
> ? We talked about and API to get the stack base address. Are you planning
to use that?
>
> I think we should simplify the system calls in that case
I will
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d4bf61c x86_64: Set kernel entry to 1M
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8d1a0c2761c0a104afcd7802765f99b386b03482
Author: Xiang Xiao
AuthorDate: Sun May 3 19:33:42 2020 +0800
binfm
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4c680bfadc20847190e34729f3dd7f22f7d7dee6
Author: Xiang Xiao
AuthorDate: Sun May 3 17:02:31 2020 +0800
fs/vf
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4b5360362e29583bdb2adf353f0f915112374cec
Author: Xiang Xiao
AuthorDate: Sun May 3 17:38:48 2020 +0800
fs/vf
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6418d13b922f96dd7bc02d46fb68bf7245d0c013
Author: Xiang Xiao
AuthorDate: Sun May 3 11:33:55 2020 +0800
fs/vf
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a2f6dc9b7ca3312eeecda2639122b0c158d7778c
Author: Xiang Xiao
AuthorDate: Sun May 3 20:02:48 2020 +0800
errno
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 3c84278aa742e398115c724f87e29fb1fe91758f
Author: Xiang Xiao
AuthorDate: Sun May 3 19:56:49 2020 +0800
sched
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1bab5b6 arch/arm/: Rename up_intstack_* to arm_intstack_*
new 7980673 fs/vfs: Add nx_seek function
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5c748cea2ad986ca674d562f049c8e4902dd58f6
Author: Xiang Xiao
AuthorDate: Sun May 3 19:40:02 2020 +0800
sched
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7980673b590c3ac5893afe59510a45bbea1c7984
Author: Xiang Xiao
AuthorDate: Sun May 3 01:25:16 2020 +0800
fs/vf
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 65308eabb4aed7c12febcc5276e4148a0d241d3a
Author: Xiang Xiao
AuthorDate: Sun May 3 16:17:44 2020 +0800
fs/vf
xiaoxiang781216 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623155212
> I will merge this now, but I have a few questions. This still feels like a
work in progress. The new nx_ versions of the functions are not prototyped in
header f
patacongo commented on pull request #944:
URL: https://github.com/apache/incubator-nuttx/pull/944#issuecomment-623155242
I don't know anything about the x86_64 so cannot provide any technical
review. But basic on the work that you have done and upon your stong
arguments, I will continue w
patacongo commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623154535
I will merge this now, but I have a few questions. This still feels like a
work in progress. The new nx_ versions of the functions are not prototyped in
header files.
btashton commented on pull request #944:
URL: https://github.com/apache/incubator-nuttx/pull/944#issuecomment-623154634
I have tested it on both simulators and it works for me. Prior to this
change getting QEMU to work was very unreliable. The Linux kernel also
decompresses to the 1M mark
xiaoxiang781216 commented on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623154003
But from
https://pubs.opengroup.org/onlinepubs/009604599/functions/ioctl.html:
The arg argument represents additional information that is needed by this
specific STR
xiaoxiang781216 edited a comment on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623154003
But from
https://pubs.opengroup.org/onlinepubs/009604599/functions/ioctl.html:
The arg argument represents additional information that is needed by this
speci
raiden00pl commented on pull request #960:
URL: https://github.com/apache/incubator-nuttx/pull/960#issuecomment-623153093
Yes, my mistake. It should be fine now
This is an automated message from the Apache Git Service.
To res
btashton commented on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623151984
Duplicate of #959
This is an automated message from the Apache Git Service.
To respond to the message, please
btashton commented on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623151915
I'll mark this as a duplicate so we can track it in your more detailed
ticket.
Duplicate of #959
This is
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1bab5b6 arch/arm/: Rename up_intstack
patacongo edited a comment on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623149173
We went through this same discussion involving the wdog wdparm_t type some
time back. There was a Rube Goldberg-ish proposal to copy all of the data into
an array of
acassis commented on pull request #960:
URL: https://github.com/apache/incubator-nuttx/pull/960#issuecomment-623150210
Hi Mateusz,
It is reporting some a compilation error:
chip/stm32_adc.c:656:20: error: initialization of 'void (*)(struct
stm32_adc_dev_s *, uint32_t)' {aka 'void (*)(
patacongo commented on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623149173
We went through this same discussion involving the wdot wdparm_t type some
time back. There was a Rube Goldberg-ish proposal to copy all of the data into
an array of type wd
patacongo commented on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623148705
i think that only works for x86. It would not work in the most general
case. For example, an 8-bit processor which has all of the data on a
byte-aligned, 8-bit wide stack.
patacongo commented on pull request #961:
URL: https://github.com/apache/incubator-nuttx/pull/961#issuecomment-623148255
There are several expected nxstyle errors in this change. These are in the
header files arch/arm/src/lc23450/chip.h and arch/arm/src/imx6/chip.h. Those
header files co
patacongo opened a new pull request #961:
URL: https://github.com/apache/incubator-nuttx/pull/961
## Summary
The naming standard at
https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ requires that all
architecture-private functions begin with the name of the arch, not up_.
btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623146530
> > @patacongo
> > It looks like we do check for x86_64 in the sim
> >
> > ```
> > #elif defined(CONFIG_ARCH_SIM) && (defined(CONFIG_HOST_X86) ||
defined(CONF
btashton commented on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623144852
I'm not sure that there is an issue here now that we just make sure int
fits in unsigned long.
(Normally)
For x86_64:
unsigned long is 8 bytes
int is 4 bytes
raiden00pl opened a new pull request #960:
URL: https://github.com/apache/incubator-nuttx/pull/960
## Summary
This PR adds new operations to the STM32 ADC low-level interface:
- setup and shutdown can be called without access to upper-half ADC
- EXTSEL/JEXTSEL configuration
#
patacongo edited a comment on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623134975
> Can we change this debug assert to `sizeof(int) <= sizeof(unsigned long) `
without causing issues?
This could actually cause issues, couldn't it? But there ar
patacongo edited a comment on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623141540
Hmmm... this is an Issue, not a PR. I guess I didn't need to create another
issue. But we do need to discuss general variadic ioctl() issues as a separate
topic. I
patacongo edited a comment on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623142416
Reverting back to the old, single argument IOCTL interface would solve all
of the issues. Perhaps it is too soon to make the change of commit c3b0848?
Should we reve
patacongo commented on issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959#issuecomment-623142416
Reverting back to the old, single argument IOCTL interface would solve all
of the issues. Perhaps it is too soon to make the change of commit c3b0848?
-
patacongo commented on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623141375
i just create Issue #959 to address the problems that I see and the only
solution that I see.
This is an aut
patacongo commented on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623141540
Hmmm... this is an Issue, not a PR. I guess I didn't need to create another
issue.
This is an automated
patacongo opened a new issue #959:
URL: https://github.com/apache/incubator-nuttx/issues/959
## History
For many years, ioctl() was non-standard function not described in any POSIX
documents. The typical prototype was:
int ioctl(int fd, int cmd, unsigned long arg);
xiaoxiang781216 commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623138344
> @patacongo
> It looks like we do check for x86_64 in the sim
>
> ```
> #elif defined(CONFIG_ARCH_SIM) && (defined(CONFIG_HOST_X86) ||
defined(CONFIG_
xiaoxiang781216 commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623137815
> I am wondering why we do not see these issues on the x86_64-based
simulation. Same architecture, same tools, real hardware. The ostest runs with
no failures on t
xiaoxiang781216 commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419127094
##
File path: libs/libc/stdio/lib_vasprintf.c
##
@@ -58,7 +58,7 @@
#define ap1 ap
#define ap2 ap
-#if defined(CONFIG_ARCH_X86)
+#if defi
xiaoxiang781216 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623135866
> @xiaoxiang781216 if you are planning to use TLS, can we please make sure
the all fo the existing TLS is compatible with any new TLS functionality? We
talked abou
patacongo commented on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623134975
> Can we change this debug assert to `sizeof(int) <= sizeof(unsigned long) `
without causing issues?
This could actually cause issues, couldn't it? But there are a lot
patacongo commented on issue #956:
URL: https://github.com/apache/incubator-nuttx/issues/956#issuecomment-623132513
There are other issues with z80 and z180: I have not verified that they
build correctly with the latest configurations that always assume we can pass
structures as arguments
btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623131430
@patacongo
It looks like we do check for x86_64 in the sim
#elif defined(CONFIG_ARCH_SIM) && (defined(CONFIG_HOST_X86) ||
defined(CONFIG_HOST_X86_64))
# def
btashton edited a comment on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623131430
@patacongo
It looks like we do check for x86_64 in the sim
```
#elif defined(CONFIG_ARCH_SIM) && (defined(CONFIG_HOST_X86) ||
defined(CONFIG_HOST_X86_64)
patacongo edited a comment on issue #956:
URL: https://github.com/apache/incubator-nuttx/issues/956#issuecomment-623130664
The refers only VARARGS are used in preprocessor macros. Like in debug.h:
104 #ifdef CONFIG_CPP_HAVE_VARARGS
138 # define _info(format, ...) \
xiaoxiang781216 commented on issue #956:
URL: https://github.com/apache/incubator-nuttx/issues/956#issuecomment-623131099
Thanks, got the CONFIG_CPP_HAVE_VARARGS meaning.
This is an automated message from the Apache Git Servi
patacongo edited a comment on issue #956:
URL: https://github.com/apache/incubator-nuttx/issues/956#issuecomment-623130664
The refers only VARARGS are used in preprocessor macros. Like in debug.h:
104 #ifdef CONFIG_CPP_HAVE_VARARGS
138 # define _info(format, ...) \
patacongo commented on issue #956:
URL: https://github.com/apache/incubator-nuttx/issues/956#issuecomment-623130664
The refers only VARARGS are used in preprocessor macros. Like in debug.h:
104 #ifdef CONFIG_CPP_HAVE_VARARGS
138 # define _info(format, ...) \
139
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f09e58f Update libs/libc/misc/lib_ioctl.c
new 01d32a2 arch/arm/stm32, stm32f7, stm32l4: Rename u
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 01d32a2b22a4ea0aa6e199f488fff9a809e56181
Author: Gregory Nutt
AuthorDate: Sun May 3 08:35:35 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit da4c597b5fb0628da3bb23de831ba2cd3e59144c
Author: Gregory Nutt
AuthorDate: Sun May 3 08:47:28 2020 -0600
patacongo commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957#issuecomment-623128826
@xiaoxiang781216 if you are planning to use TLS, can we please make sure the
all fo the existing TLS is compatible with any new TLS functionality? We
talked about and A
patacongo edited a comment on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623127526
I have used it many times with the simulation. In fact, all OS features are
developed on the simulation and the sim:ostest configuration runs with no
problems.
patacongo commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623127526
I have used it many times with the simulation. In fact, all OS features are
developed on the simulation and the sim:ostest configuration runs with no
problems.
T
btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623124545
Does the ps command work on the sim when compiled with x86_64? That is
where I hit this.
This is an au
btashton commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419116009
##
File path: libs/libc/stdio/lib_vasprintf.c
##
@@ -58,7 +58,7 @@
#define ap1 ap
#define ap2 ap
-#if defined(CONFIG_ARCH_X86)
+#if defined(CON
patacongo commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623123568
I am wondering why we do not see these issues on the x86_64-based
simulation. Same architecture, same tools, real hardware. The ostest runs
with no failures on that pl
btashton commented on issue #954:
URL: https://github.com/apache/incubator-nuttx/issues/954#issuecomment-623121565
But sem_post is never called by thread 1 and so when it exits it remains
attached to the semaphore which leads to the wrong behavior.
---
patacongo opened a new pull request #958:
URL: https://github.com/apache/incubator-nuttx/pull/958
## Summary
The naming standard at
https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ requires that all
MCU-private functions begin with the name of the MCU, not up_.
Th
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 6204e10 x86_64: Add nsh configuration with procfs bringup
new 4e7d59f Fix debug assert in ioctl to che
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4e7d59f6bcb770202f27fb5787274771fdd37b44
Author: Brennan Ashton
AuthorDate: Sat May 2 20:25:35 2020 -0700
F
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f09e58fe73a5f47c7d88060e942c983c04f2116b
Author: patacongo
AuthorDate: Sun May 3 07:48:32 2020 -0600
Update
patacongo commented on pull request #944:
URL: https://github.com/apache/incubator-nuttx/pull/944#issuecomment-623113478
Should I will wait for approval from Yang ChungFan (SonicYang). I have no
technical expertise with x86_64 to evaluate the change.
-
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6204e10 x86_64: Add nsh configuration w
patacongo commented on issue #954:
URL: https://github.com/apache/incubator-nuttx/issues/954#issuecomment-623112494
> I will have to look at the code later, but I think I disagree. The caller
of sem_wait gets to wait at the elevated priority, but once it receives the
semaphore, it must NOT
patacongo removed a comment on issue #954:
URL: https://github.com/apache/incubator-nuttx/issues/954#issuecomment-623103956
I will have to look at the code later, but I think I disagree. The caller
of sem_wait gets to wait at the elevated priority, but once it receives the
semaphore, it m
xiaoxiang781216 opened a new pull request #957:
URL: https://github.com/apache/incubator-nuttx/pull/957
## Summary
Will be used in the furture patch to clean up errno usage
## Impact
No
## Testing
xiaoxiang781216 commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419053662
##
File path: libs/libc/stdio/lib_vasprintf.c
##
@@ -58,7 +58,7 @@
#define ap1 ap
#define ap2 ap
-#if defined(CONFIG_ARCH_X86)
+#if defi
1 - 100 of 107 matches
Mail list logo
