jerpelea commented on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-645190392
@v01d Please add commit messages for all commits
This is an automated message from the Apache Git Serv
YuuichiNakamura opened a new pull request #1260:
URL: https://github.com/apache/incubator-nuttx/pull/1260
## Summary
Only fixing styles.
## Impact
None.
## Testing
This is an automated message from
raiden00pl commented on pull request #1248:
URL: https://github.com/apache/incubator-nuttx/pull/1248#issuecomment-645180373
I'm not sure if this is the correct behavior. Shouldn't we return an error
when a given period is not achievable?
This is the case where the function argument is o
sebastianene07 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r441303412
##
File path: arch/sim/src/sim/up_releasepending.c
##
@@ -114,7 +118,11 @@ void up_release_pending(void)
/* Then switch contex
sebastianene07 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r441303412
##
File path: arch/sim/src/sim/up_releasepending.c
##
@@ -114,7 +118,11 @@ void up_release_pending(void)
/* Then switch contex
yamt commented on issue #1137:
URL:
https://github.com/apache/incubator-nuttx/issues/1137#issuecomment-645166781
> Does sched_lock equivalent to preempt_disable?
ideally it should be, if i read @patacongo's comment correctly.
it would allow us to replace sched_lock gradually.
xiaoxiang781216 edited a comment on issue #1137:
URL:
https://github.com/apache/incubator-nuttx/issues/1137#issuecomment-645153945
> i have two comments
>
> * to me, enter_critical_section() is another primitive with unclear
semantics. are you interested in more fine grained locking
xiaoxiang781216 commented on issue #1137:
URL:
https://github.com/apache/incubator-nuttx/issues/1137#issuecomment-645153945
> i have two comments
>
> * to me, enter_critical_section() is another primitive with unclear
semantics. are you interested in more fine grained locking? or, d
xiaoxiang781216 merged pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on pull request #301:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/301#issuecomment-645152490
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, p
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new fed7a53 system: nxrecorder: Re
yamt commented on issue #1137:
URL:
https://github.com/apache/incubator-nuttx/issues/1137#issuecomment-645138739
i have two comments
* to me, enter_critical_section() is another primitive with unclear
semantics. are you interested in more fine grained locking? or, do you think
the
masayuki2009 commented on pull request #301:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/301#issuecomment-645116787
Hi @xiaoxiang781216,
I refactored nxrecorder.c
This is an automated message from the
masayuki2009 opened a new pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301
## Summary
- This PR removes redundant code regarding audio buffer configuration in
nxrecorder.c
- The approach is the same as
https://github.com/apache/incubator-nuttx-apps/
yamt commented on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-645082080
for this specific case (_Exit), as it's a part of the standards, it's more
appropriate to make nxstyle itself know, IMO.
--
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 56fa98f sched: Avoid call up_initial_st
patacongo merged pull request #1255:
URL: https://github.com/apache/incubator-nuttx/pull/1255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
acassis edited a comment on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-645018299
Ok, it worked on 48MHz MSI.
These are the modification I did:
https://pastebin.com/00PW2cvL
Pasting code here doesn't work, even using the "Ins
acassis edited a comment on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-645018299
Ok, it worked on 48MHz MSI.
These are the modification I did:
`diff --git a/boards/arm/stm32l4/nucleo-l476rg/include/nucleo-l476rg.h
b/boards/arm/stm
acassis edited a comment on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-645018299
Ok, it worked on 48MHz MSI.
These are the modification I did:
diff --git a/boards/arm/stm32l4/nucleo-l476rg/include/nucleo-l476rg.h
b/boards/arm/stm3
acassis commented on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-645018299
Ok, it worked on 48MHz MSI.
These are the modification I did:
This is an automated messag
Ouss4 merged pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 4f044a4 system/sched_note/no
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 69e97c1 sched/sched/sched_note.c:
Ouss4 merged pull request #1259:
URL: https://github.com/apache/incubator-nuttx/pull/1259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
patacongo edited a comment on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-644957144
>
>
> Maybe nxstyle could be extended to recognize some special comment that
instructs to ignore a line (or at least a given rule for that line)
This
patacongo commented on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-644957144
>
>
> Maybe nxstyle could be extended to recognize some special comment that
instructs to ignore a line (or at least a given rule for that line)
This has bee
patacongo edited a comment on pull request #300:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifi
patacongo edited a comment on pull request #300:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifi
patacongo edited a comment on pull request #300:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifi
v01d commented on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-644950528
Maybe nxstyle could be extended to recognize some special comment that
instructs to ignore a line (or at least a given rule for that line)
v01d commented on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-644949223
You can also try other frequencies, but if you're using I2C, I think only
other clock option is 16MHz since otherwise I2C timings are not yet defined.
But UART should work.
v01d commented on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-644948366
I usually use nsh config for testing. Anyway, clock selection requires
editing the board header file. You should change the option at the top so that
MSI is used. Then, ins
patacongo commented on pull request #300:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifier foun
acassis commented on pull request #1252:
URL: https://github.com/apache/incubator-nuttx/pull/1252#issuecomment-644945027
Hi Matias, do you have a defconfig that I could use to test it on
nucleo-l476rg board?
This is an autom
patacongo opened a new pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300
## Summary
Add support for decoding interrupt and system call instrumentation
## Impact
None other than to system/sched_note/note_main.c.
## Testing
Teste
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ede6225c72fc55d1dea3f10e7494627c86493e3a
Author: Peter van der Perk
AuthorDate: Tue Jun 16 16:46:23 2020 +0200
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4eecf8561fc17eef67649029631108e261abbf73
Author: Peter van der Perk
AuthorDate: Tue Jun 16 16:26:41 2020 +0200
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit efbe4c89e2522fce7dbf1bf6d048da117676e743
Author: Peter van der Perk
AuthorDate: Thu Jun 4 11:24:20 2020 +0200
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6a19f037564966b6cbe4007083986500366a8c03
Author: Peter van der Perk
AuthorDate: Tue Jun 16 19:05:46 2020 +0200
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4fd506e include/nuttx/sched_note.h: nxstyle fixes.
new 4eecf85 FlexCAN interrupt fixes, old compiler
acassis merged pull request #1258:
URL: https://github.com/apache/incubator-nuttx/pull/1258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 662bd5e49abd75070a90fb981697d1767b3a1155
Author: Peter van der Perk
AuthorDate: Mon Jun 15 15:22:15 2020 +0200
patacongo opened a new pull request #1259:
URL: https://github.com/apache/incubator-nuttx/pull/1259
## Summary
A previous PR added interrupt and system call scheduler notes. This PR
addresses buffering support for those notes.
## Impact
There should be none. Not reall
acassis commented on pull request #1258:
URL: https://github.com/apache/incubator-nuttx/pull/1258#issuecomment-644898376
> @acassis, you're right C89 style initialization is better. I've pushed a
new commit.
Thank you for your modification Peter!
---
PetervdPerk-NXP commented on pull request #1258:
URL: https://github.com/apache/incubator-nuttx/pull/1258#issuecomment-644896516
@acassis, you're right C89 style initialization is better. I've pushed a new
commit.
This is an
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ed9532e31f8d2b41d66e865fe59d76ca9ea789c7
Author: Gregory Nutt
AuthorDate: Tue Jun 16 08:02:03 2020 -0600
acassis merged pull request #1256:
URL: https://github.com/apache/incubator-nuttx/pull/1256
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit df2bc1e4c36b3f706cce83c075659339e27027db
Author: Yuuichi Nakamura
AuthorDate: Tue Jun 16 07:57:49 2020 -0600
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from dde25b0 tools/nxstyle: Fix AddressSanitizer error
new df2bc1e Add syscall and irqhandler hooks in sc
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4fd506efaac9634cedb8838932261d3ebac9d551
Author: Gregory Nutt
AuthorDate: Tue Jun 16 08:22:59 2020 -0600
acassis commented on a change in pull request #1258:
URL: https://github.com/apache/incubator-nuttx/pull/1258#discussion_r440985785
##
File path: arch/arm/src/s32k1xx/s32k1xx_flexcan.c
##
@@ -979,7 +982,7 @@ static void s32k1xx_txdone(FAR void *arg)
/* Process TX completions
patacongo commented on pull request #1255:
URL: https://github.com/apache/incubator-nuttx/pull/1255#issuecomment-644854780
Need to fill out these sections in the PR description:
Summary
Impact
Testing
This is
patacongo merged pull request #1257:
URL: https://github.com/apache/incubator-nuttx/pull/1257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
PetervdPerk-NXP opened a new pull request #1258:
URL: https://github.com/apache/incubator-nuttx/pull/1258
## Summary
Fixes compile error with older compiler for FlexCAN & SocketCAN
FlexCAN don't disable interrupt but only remove masks TX MB interrupts
S32K1XX: Emulated EEPROM block
xiaoxiang781216 opened a new pull request #1257:
URL: https://github.com/apache/incubator-nuttx/pull/1257
=
==2474==ERROR: AddressSanitizer: stack-buffer-underflow on address
0x7fffb7e59b5f at pc 0x561fffec79f6 bp 0x7fffb7e5
patacongo opened a new pull request #1256:
URL: https://github.com/apache/incubator-nuttx/pull/1256
## Summary
This PR brings in the system call and interrupt instrumentation from
https://github.com/YuuichiNakamura/incubator-nuttx (feature/task-tracer branch).
## Impact
xiaoxiang781216 opened a new pull request #1255:
URL: https://github.com/apache/incubator-nuttx/pull/1255
Signed-off-by: Xiang Xiao
Change-Id: Iaf5d4bcc915fbe842e9356ea6416f0af869ab116
## Summary
## Impact
## Testing
xiaoxiang781216 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r440861878
##
File path: arch/sim/include/irq.h
##
@@ -44,6 +44,10 @@
* Included Files
**
sebastianene07 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r440854838
##
File path: arch/sim/include/irq.h
##
@@ -44,6 +44,10 @@
* Included Files
***
xiaoxiang781216 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r440822441
##
File path: arch/sim/include/irq.h
##
@@ -44,6 +44,10 @@
* Included Files
**
sebastianene07 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r440806239
##
File path: arch/sim/include/irq.h
##
@@ -44,6 +44,10 @@
* Included Files
***
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 66052f7 mkstemp: Only look at the t
xiaoxiang781216 merged pull request #1254:
URL: https://github.com/apache/incubator-nuttx/pull/1254
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 2282310 system: nxrecorder: Ad
xiaoxiang781216 merged pull request #299:
URL: https://github.com/apache/incubator-nuttx-apps/pull/299
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yamt opened a new pull request #1254:
URL: https://github.com/apache/incubator-nuttx/pull/1254
## Summary
mkstemp: Only look at the trailing Xs as it's stated in the standards.
The original code look at the first Xs. It can end up with
an unexpected behavior, if a template c
masayuki2009 opened a new pull request #299:
URL: https://github.com/apache/incubator-nuttx-apps/pull/299
## Summary
- This PR lets nxrecorder create a new file with O_TUNC option.
## Impact
- This PR affects nxrecorder only.
## Testing
- I tested this PR w
68 matches
Mail list logo
