xiaoxiang781216 commented on pull request #4243:
URL: https://github.com/apache/incubator-nuttx/pull/4243#issuecomment-888035782
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
anjianjun opened a new pull request #4243:
URL: https://github.com/apache/incubator-nuttx/pull/4243
Signed-off-by: anjianjun
mmcsd_sdio.c
Send cmd0 just once to Increased compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the m
xiaoxiang781216 merged pull request #4035:
URL: https://github.com/apache/incubator-nuttx/pull/4035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a0c3a0923a17cacafecdceb4bd4522011ac435ad
Author: Jiuzhu Dong
AuthorDate: Fri Jun 25 14:24:45 2021 +0800
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from bb63afd Documentation/bl602: Update some imformation; Add
partition.toml in tool/bl602
new a0c3a09
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 855c78bb9dc48d4f2655257fb7ee01ff9c456cbc
Author: Jiuzhu Dong
AuthorDate: Sat Jun 19 17:29:30 2021 +0800
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 00854f0f94704735301fdfe801a448e8a0e443d9
Author: Jiuzhu Dong
AuthorDate: Mon Jul 12 20:58:03 2021 +0800
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 23d87ff9df116f0f43465a13adc2fbe720fc3466
Author: Jiuzhu Dong
AuthorDate: Mon Jul 26 10:36:13 2021 +0800
xiaoxiang781216 merged pull request #4242:
URL: https://github.com/apache/incubator-nuttx/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new bb63afd Documentation/bl602: Update
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677955436
##
File path: drivers/wireless/ieee80211/bcm43xxx/Kconfig
##
@@ -101,4 +101,12 @@ config IEEE80211_BROADCOM_NINTERFACES
default 1
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677954749
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 merged pull request #4239:
URL: https://github.com/apache/incubator-nuttx/pull/4239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3c393d6 drivers/mmcsd:fix build error of debug
add cdbfacc risc-v/esp32-c3: Adds systimer support
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 857414e xtensa/esp32: expose SPI2 as a char driver
add 3c393d6 drivers/mmcsd:fix build error of de
xiaoxiang781216 merged pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
SunJun8 opened a new pull request #4242:
URL: https://github.com/apache/incubator-nuttx/pull/4242
## Summary
- Documentation/bl602: Update some imformation;
- Add partition.toml in tool/bl602
## Impact
None
## Testing
- Compile ok
- Run demo ok
--
This is
patacongo edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887956710
> Another idea, now a bit more elegant than the previous one: we may create
a `/proc/boot` entry, and trigger the required actions via the previously
proposed `
patacongo edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887956710
> Another idea, now a bit more elegant than the previous one: we may create
a `/proc/boot` entry, and trigger the required actions via the previously
proposed `
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887956710
> Another idea, now a bit more elegant than the previous one: we may create
a `/proc/boot` entry, and trigger the required actions via the previously
proposed `up_boot
nealef opened a new issue #4241:
URL: https://github.com/apache/incubator-nuttx/issues/4241
### Summary ###
I have encountered a couple of floating point operation problems.
* `fmod()` returns incorrect value
* `log(x)` never returns for specific values of x (see comment in
https:
gustavonihei commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887917686
Another idea, now a bit more elegant than the previous one: we may create a
`/proc/boot` entry, and trigger the required actions via the previously
proposed `up_boo
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new a9c196d Publishing web
nealef commented on pull request #4115:
URL: https://github.com/apache/incubator-nuttx/pull/4115#issuecomment-887909341
Using this code the operation `log(318.0)` still loops infinitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
calling a new MTDIOC command for an `ioctl` on the file descriptor of the MTD
partiti
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
calling a new MTDIOC command for an `ioctl` on the file descriptor of the MTD
partiti
saramonteiro commented on a change in pull request #4239:
URL: https://github.com/apache/incubator-nuttx/pull/4239#discussion_r677756645
##
File path: arch/risc-v/src/esp32c3/esp32c3_tim.c
##
@@ -341,19 +426,35 @@ static void esp32c3_tim_getcounter(FAR struct
esp32c3_tim_dev_s
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677733304
##
File path: boards/arm/stm32/emw3162/scripts/ld.script
##
@@ -45,11 +45,16 @@ SECTIONS
*(.fixup)
*(.gnu.warning)
-.
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
calling a new MTDIOC command for an `ioctl` on the file descriptor of the MTD
partiti
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
calling a new MTDIOC command for an `ioctl` on the file descriptor of the MTD
partiti
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677698367
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
calling a new MTDIOC command for an `ioctl` on the file descriptor of the MTD
partiti
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
creating a new MTDIOC `ioctl` on the file descriptor of the MTD partition that
contai
gustavonihei commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887729633
One (crazy?) idea I've had: instead of relying on `boardctl`, how about
creating a new MTDIOC `ioctl` on the file descriptor of the MTD partition that
contains the
gustavonihei commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887726983
> > Board-specific IOCs do not need to be shared. They are private. Shared
IOCs are not board-specific, There can be no discussion of sharing private
things.
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887725347
A wiki page summarizing a bootloader roadmap would be preferable. It is
impossible to evaluate these ad hoc changes with no idea of what we are trying
to accomplish.S
xiaoxiang781216 edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887702003
> There are several small bootloaders that I wrote for the SAMA5Dx in the
tree. But I did an odd thing, I put the entire bootloader in the board/src
dire
xiaoxiang781216 edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887702003
> There are several small bootloaders that I wrote for the SAMA5Dx in the
tree. But I did an odd thing, I put the entire bootloader in the board/src
dire
xiaoxiang781216 commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887702003
> There are several small bootloaders that I wrote for the SAMA5Dx in the
tree. But I did an odd thing, I put the entire bootloader in the board/src
directory s
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677661977
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_bdc.c
##
@@ -48,30 +48,30 @@
* Private Types
**
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677653089
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677653089
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677653089
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677653089
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677653089
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677649214
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_bdc.c
##
@@ -48,30 +48,30 @@
* Private Types
**
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677648641
##
File path: boards/arm/stm32/emw3162/scripts/ld.script
##
@@ -45,11 +45,16 @@ SECTIONS
*(.fixup)
*(.gnu.warning)
-
xiaoxiang781216 merged pull request #4240:
URL: https://github.com/apache/incubator-nuttx/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 9fc8069 adc: add ioctl command to get the number of configured
channels
add 857414e xtensa/esp32:
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887640165
There are several small bootloaders that I wrote for the SAMA5Dx in the
tree. But I did an odd thing, I put the entire bootloader in the board/src
directory so the wh
acassis commented on a change in pull request #4239:
URL: https://github.com/apache/incubator-nuttx/pull/4239#discussion_r677551236
##
File path: arch/risc-v/src/esp32c3/esp32c3_tim.c
##
@@ -341,19 +426,35 @@ static void esp32c3_tim_getcounter(FAR struct
esp32c3_tim_dev_s *dev
xiaoxiang781216 commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887598705
> > How do you suggest that an application performs the loading and
execution of the next application image?
>
> I would suggest using BOARDIOC_IOCTL. That
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677348955
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677537261
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677546437
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
xiaoxiang781216 edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887532317
> A few days ago, Xiomi added they one application-specific, boot-related
BOARDIOC, PR #4191
>
> This is really getting out of hand quickly. We need
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677537261
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
saramonteiro opened a new pull request #4240:
URL: https://github.com/apache/incubator-nuttx/pull/4240
## Summary
This MR exposes SPI2 as a character driver on ESP32.
## Impact
Board logic of esp32 Dev Kitc
## Test
There is an SPI DMA test on our internal r
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677514319
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677504311
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const
xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677504311
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677504222
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677504222
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677504311
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677504222
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677504311
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677490236
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
saramonteiro opened a new pull request #4239:
URL: https://github.com/apache/incubator-nuttx/pull/4239
## Summary
This MR:
- Adds systimer support under the same generic timer API.
- Makes `rt_timer` rely on this added systimer.
## Impact
From now on, we have the
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677490236
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677490236
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677488280
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 edited a comment on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-887535579
Please the nxstyle warning due the heavy maco used in include/nuttx/tree.h:
```
include/nuttx/tree.h:317:23: error: Multiple data definitions
inclu
xiaoxiang781216 commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-887535579
Please the nxstyle warning due the heavy maco used in include/nuttx/tree.h:
include/nuttx/tree.h:317:23: error: Multiple data definitions
include/nut
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677474836
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
xiaoxiang781216 edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887532317
> A few days ago, Xiomi added they one application-specific, boot-related
BOARDIOC, PR #4191
>
> This is really getting out of hand quickly. We need
xiaoxiang781216 edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887532317
> A few days ago, Xiomi added they one application-specific, boot-related
BOARDIOC, PR #4191
>
> This is really getting out of hand quickly. We need
xiaoxiang781216 commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887532317
> A few days ago, Xiomi added they one application-specific, boot-related
BOARDIOC, PR #4191
>
> This is really getting out of hand quickly. We need to do
xiaoxiang781216 commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887528500
If we want to write a general application which isn't to specific to some
board( and then lock to a specific vendor), we need standardized IOCTL. There
isn't dif
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677463503
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677463503
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677460368
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 commented on pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#issuecomment-887519951
Please reorg your patch:
```
git remote add apache g...@github.com:apache/incubator-nuttx.git
git fetch apache
git checkout master
git branch -D xia
xiaoxiang781216 commented on a change in pull request #4237:
URL: https://github.com/apache/incubator-nuttx/pull/4237#discussion_r677454493
##
File path: drivers/mmcsd/mmcsd_debug.c
##
@@ -166,5 +164,6 @@ void mmcsd_dmpcsd(FAR const uint8_t *csd, uint8_t cardtype)
finfo("
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887511252
A few days ago, Xiomi added they one application-specific, boot-related
BOARDIOC, PR #4191
This is really getting out of hand quickly. We need to do something
xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677446091
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const
gustavonihei commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887494626
> > How do you suggest that an application performs the loading and
execution of the next application image?
>
> I would suggest using BOARDIOC_IOCTL. That al
patacongo edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887482585
> How do you suggest that an application performs the loading and execution
of the next application image?
I would suggest using BOARDIOC_IOCTL. That all
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887482585
> How do you suggest that an application performs the loading and execution
of the next application image?
I would suggest using BOARDIOC_IOCTL. That allows boa
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887473322
> We really need to avoid adding application-specific BOARDIOC values. That
is why BOARDIOC_IOCTL was create: In order to keep this project-specific trash
fr
gustavonihei edited a comment on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887473322
> We really need to avoid adding application-specific BOARDIOC values. That
is why BOARDIOC_IOCTL was create: In order to keep this project-specific trash
fr
gustavonihei commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887473322
> We really need to avoid adding application-specific BOARDIOC values. That
is why BOARDIOC_IOCTL was create: In order to keep this project-specific trash
from accu
patacongo commented on pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#issuecomment-887470207
We really need to avoid adding application-specific BOARDIOC values. That
is why BOARDIOC_IOCTL was create: In order to keep this project-specific trash
from accumul
patacongo commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677396508
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDI
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677350110
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677348955
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to manage SDIO
xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677327171
##
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##
@@ -110,13 +111,22 @@ struct bcmf_sdio_dev_s
/* Structure used to mana
xiaoxiang781216 opened a new pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238
## Summary
- Replace all __attribute__((aligned(x)) with aligned_data(x)
- Replace all __attribute__((section(x)) with locate_data(x)
## Impact
Same as before aft
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677315552
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
gustavonihei commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677315552
##
File path: include/nuttx/board.h
##
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const cha
1 - 100 of 106 matches
Mail list logo
