jerpelea opened a new pull request #983:
URL: https://github.com/apache/incubator-nuttx-apps/pull/983
## Summary
This is a runtime library for inference Neural Network created
by Neural Network Libraries.
Project git: https://github.com/sony/nnabla-c-runtime
It is almost
jerpelea closed pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
jerpelea commented on pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#issuecomment-1021949141
moved to apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
pkarashchenko opened a new pull request #5344:
URL: https://github.com/apache/incubator-nuttx/pull/5344
## Summary
Fix garbage collector option to linker for ez80
## Impact
ez80 users
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To
pkarashchenko commented on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1021919737
@xiaoxiang781216 I will explore the discussion and also start thinking how
this can be done. Thank you!
--
This is an automated message from the Apache Git Serv
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r792352722
##
File path: Kconfig
##
@@ -2032,6 +2032,10 @@ menu "Open Asymmetric Multi Processing"
source "openamp/Kconfig"
endmenu
+menu "Neural Networ
xiaoxiang781216 commented on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1021890450
> Changes works fine to me. The point that I was stating about involving
linker via compiler is next. We can link program either with
>
> ```
> arm-non
pkarashchenko commented on a change in pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#discussion_r792311962
##
File path: arch/arm/src/arm/Toolchain.defs
##
@@ -103,21 +103,12 @@ OBJDUMP = $(CROSSDEV)objdump
# Add the builtin library
-EXTRA_LI
a-lunev commented on a change in pull request #5252:
URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r792317926
##
File path: net/tcp/tcp_send_buffered.c
##
@@ -355,10 +355,39 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
a-lunev commented on a change in pull request #5252:
URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r792317926
##
File path: net/tcp/tcp_send_buffered.c
##
@@ -355,10 +355,39 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
a-lunev commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792306532
##
File path: net/tcp/tcp_send_unbuffered.c
##
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct
net_driver_s *dev,
a-lunev commented on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021855885
The PR is still draft. To be continued ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
a-lunev commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792306532
##
File path: net/tcp/tcp_send_unbuffered.c
##
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct
net_driver_s *dev,
This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 2a6de30 net/tcp: transformed NET_TCP_F
anchao merged pull request #5341:
URL: https://github.com/apache/incubator-nuttx/pull/5341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
anchao commented on pull request #5341:
URL: https://github.com/apache/incubator-nuttx/pull/5341#issuecomment-1021835915
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
masayuki2009 commented on pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021833025
Let me re-run all the jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
masayuki2009 edited a comment on pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021829817
Hmm, I don't know why 'Build / Linux (risc-v)' failed.
```
unzip: cannot find zipfile directory in one of chip/v1.9.1-ble-test.zip or
masayuki2009 commented on pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021829817
Hmm, I don't know why 'Build / Linux (risc-v)' failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
masayuki2009 commented on a change in pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792291485
##
File path: Makefile
##
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_instal
xiaoxiang781216 commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792285654
##
File path: net/tcp/tcp_send_unbuffered.c
##
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct
net_driver_s *dev,
xiaoxiang781216 commented on a change in pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#discussion_r792282163
##
File path: arch/arm/src/arm/Toolchain.defs
##
@@ -103,21 +103,12 @@ OBJDUMP = $(CROSSDEV)objdump
# Add the builtin library
-EXTRA_
xiaoxiang781216 commented on pull request #934:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/934#issuecomment-1021814035
@nandojve could you fix the follow warning:
```
Error:
/home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/examples/mcuboot/swap_test/vers
xiaoxiang781216 commented on a change in pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792278983
##
File path: Makefile
##
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_ins
a-lunev removed a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n
and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput
(unbuffe
masayuki2009 commented on a change in pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792261630
##
File path: import/Make.defs
##
@@ -74,6 +74,12 @@ else
LDLIBPATH = -L $(TOPDIR)$(DELIM)libs
endif
+# Link with user libraries
+
pkarashchenko commented on a change in pull request #982:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792259532
##
File path: import/Make.defs
##
@@ -74,6 +74,12 @@ else
LDLIBPATH = -L $(TOPDIR)$(DELIM)libs
endif
+# Link with user libraries
+
masayuki2009 commented on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1021772287
```
xtensa_reprioritizertr.c:(.text.up_reprioritize_rtr+0x72): undefined
reference to `xtensa_switchcontext'
```
--
This is an automated message from t
masayuki2009 opened a new pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982
## Summary
- I noticed that applications made by 'make import' contain
undefined symbols such as printf for CONFIG_BUILD_KERNEL=y
- This commit fixes this issue by adding
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new c8d4630 Publishing web
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8be9cb9 net/tcp/sendfile: notify the device driver of the
availability of TX data on TCP retransmission (
acassis merged pull request #5342:
URL: https://github.com/apache/incubator-nuttx/pull/5342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
yamt commented on a change in pull request #5252:
URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r792211285
##
File path: net/tcp/tcp_send_buffered.c
##
@@ -355,10 +355,39 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
AlanRosenthal commented on a change in pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#discussion_r792173427
##
File path: arch/arm/src/arm/Toolchain.defs
##
@@ -103,21 +103,12 @@ OBJDUMP = $(CROSSDEV)objdump
# Add the builtin library
-EXTRA_LI
Ouss4 merged pull request #981:
URL: https://github.com/apache/incubator-nuttx-apps/pull/981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 3c55638 examples/chrono: fix
a-lunev edited a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n
and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput
(unbuffer
a-lunev edited a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n
and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput
(unbuffer
a-lunev commented on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config this patch increases the
TCP throughput (unbuffered TX path) from 205 Kbit/s up to about 432 Mbit/s.
However, I am not
xiaoxiang781216 commented on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1021507148
@pkarashchenko the CI pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
xiaoxiang781216 commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r791994316
##
File path: include/nuttx/sched.h
##
@@ -656,6 +656,10 @@ struct tcb_s
sem_t *waitsem;/* Semaphore ID waiti
a-lunev opened a new pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xiaoxiang781216 opened a new pull request #5342:
URL: https://github.com/apache/incubator-nuttx/pull/5342
## Summary
it's important to know the perf count frequency
## Impact
New API
## Testing
--
This is an automated message from the Apache Git Service.
To res
a-lunev commented on a change in pull request #5311:
URL: https://github.com/apache/incubator-nuttx/pull/5311#discussion_r791990302
##
File path: net/tcp/tcp_sendfile.c
##
@@ -264,15 +275,42 @@ static uint16_t sendfile_eventhandler(FAR struct
net_driver_s *dev,
goto
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 7e748e6 net/tcp/tcp_sendfile: optimized out sendfile_txnotify()
function
add 8be9cb9 net/tcp/send
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4b6ca94 board/Board.mk: Make romfs_img 4 byte aligned
add 7e748e6 net/tcp/tcp_sendfile: optimized
xiaoxiang781216 merged pull request #5339:
URL: https://github.com/apache/incubator-nuttx/pull/5339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #5340:
URL: https://github.com/apache/incubator-nuttx/pull/5340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
a-lunev opened a new pull request #5341:
URL: https://github.com/apache/incubator-nuttx/pull/5341
## Summary
Transformed NET_TCP_FAST_RETRANSMIT_WATERMARK option from integer to boolean
(to enable / disable the TCP Fast Retransmit algorithm).
According to RFC 5681 (3.2) the TCP Fa
a-lunev opened a new pull request #5340:
URL: https://github.com/apache/incubator-nuttx/pull/5340
## Summary
Notify the device driver of the availability of TX data on TCP
retransmission (as well as on sending normal TCP packets).
## Impact
TCP sendfile
## Testin
xiaoxiang781216 commented on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1021413933
> I think with such approach we are becoming link order dependent. But let's
wait CI to finish
> IMO the only correct way to handle this is to involve lin
acassis commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791922216
##
File path: Kconfig
##
@@ -2032,6 +2032,10 @@ menu "Open Asymmetric Multi Processing"
source "openamp/Kconfig"
endmenu
+menu "Neural Network
a-lunev opened a new pull request #5339:
URL: https://github.com/apache/incubator-nuttx/pull/5339
## Summary
sendfile_txnotify() function in tcp_sendfile.c was excessive. There is the
same tcp_send_txnotify() function in tcp_send.c.
## Impact
TCP sendfile
## Test
acassis commented on pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#issuecomment-1021400495
@jerpelea as you said that want to add more libs, I suggest to take a look
on this listing:
https://acassis.wordpress.com/2019/01/29/machine-learning-for-microcontrolle
no1wudi commented on a change in pull request #5330:
URL: https://github.com/apache/incubator-nuttx/pull/5330#discussion_r791399675
##
File path: boards/Board.mk
##
@@ -36,7 +36,7 @@ $(ETCSRC): $(RCRAWS) $(RCOBJS)
$(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw))) \
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791817942
##
File path: nn/Kconfig
##
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-lan
acassis commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020459911
@davids5 I think it could be voted since it was defined by others. If you
search here in the github history you will find the commit from me that I
unintentionally merg
anchao commented on pull request #5328:
URL: https://github.com/apache/incubator-nuttx/pull/5328#issuecomment-1020861345
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
pkarashchenko commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791528634
##
File path: arch/arm/src/arm/arm_tcbinfo.c
##
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/
AlanRosenthal commented on issue #5255:
URL:
https://github.com/apache/incubator-nuttx/issues/5255#issuecomment-1020414135
Please run `V=1 make --context`. it might be a lot of output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pkarashchenko commented on a change in pull request #5333:
URL: https://github.com/apache/incubator-nuttx/pull/5333#discussion_r791491502
##
File path: drivers/timers/arch_alarm.c
##
@@ -204,7 +204,7 @@ void up_alarm_set_lowerhalf(FAR struct oneshot_lowerhalf_s
*lower)
*
olegk0 commented on issue #5324:
URL:
https://github.com/apache/incubator-nuttx/issues/5324#issuecomment-1020427240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
anchao commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791459952
##
File path: sched/sched/sched_critmonitor.c
##
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save the st
pkarashchenko merged pull request #5333:
URL: https://github.com/apache/incubator-nuttx/pull/5333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhuyanlinzyl commented on pull request #5261:
URL: https://github.com/apache/incubator-nuttx/pull/5261#issuecomment-1020801767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
masayuki2009 edited a comment on pull request #5329:
URL: https://github.com/apache/incubator-nuttx/pull/5329#issuecomment-1020653406
Hmm, I don't know why the 'Build /Linux (risc-v)' failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
davids5 edited a comment on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once
a review has been done the author can merge it?
2
xiaoxiang781216 commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r791676894
##
File path: arch/sim/src/sim/up_uart.c
##
@@ -31,12 +31,16 @@
#include "up_internal.h"
-#if defined(USE_DEVCONSOLE) || CONFIG_SIM_U
pussuw commented on a change in pull request #5322:
URL: https://github.com/apache/incubator-nuttx/pull/5322#discussion_r791024780
##
File path: arch/risc-v/src/common/riscv_pmp.c
##
@@ -44,6 +58,361 @@
reg |= attr << (offset * PMP_CFG_BITS_CNT); \
} while(0);
+#d
xiaoxiang781216 merged pull request #5329:
URL: https://github.com/apache/incubator-nuttx/pull/5329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
pkarashchenko commented on a change in pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331#discussion_r791427199
##
File path: sched/sched/sched_critmonitor.c
##
@@ -280,7 +280,6 @@ void nxsched_resume_critmon(FAR struct tcb_s *tcb)
/* Yes.. Save
xiaoxiang781216 merged pull request #980:
URL: https://github.com/apache/incubator-nuttx-apps/pull/980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
olegk0 edited a comment on issue #5324:
URL:
https://github.com/apache/incubator-nuttx/issues/5324#issuecomment-1020485549
> what command are you running?
make
make clean
as I understand it, he swears when there is an additional parameter through
a space
$(shel
zhuyanlinzyl closed pull request #5261:
URL: https://github.com/apache/incubator-nuttx/pull/5261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
yamt commented on a change in pull request #5252:
URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r791448848
##
File path: net/tcp/tcp_send_buffered.c
##
@@ -355,10 +355,39 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
xiaoxiang781216 commented on a change in pull request #5330:
URL: https://github.com/apache/incubator-nuttx/pull/5330#discussion_r791400330
##
File path: boards/Board.mk
##
@@ -36,7 +36,7 @@ $(ETCSRC): $(RCRAWS) $(RCOBJS)
$(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw)
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791838798
##
File path: nn/Kconfig
##
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.t
masayuki2009 commented on pull request #5329:
URL: https://github.com/apache/incubator-nuttx/pull/5329#issuecomment-1020653406
Hmm, I don't know why the 'Build /Linux (risc-v) failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pkarashchenko commented on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1020945939
I think with such approach we are becoming link order dependent. But let's
wait CI to finish
--
This is an automated message from the Apache Git Service.
To res
a-lunev commented on a change in pull request #5252:
URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r791664829
##
File path: net/tcp/tcp_send_buffered.c
##
@@ -355,10 +355,39 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
xiaoxiang781216 merged pull request #5334:
URL: https://github.com/apache/incubator-nuttx/pull/5334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791687694
##
File path: arch/arm/src/arm/arm_tcbinfo.c
##
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/**
jerpelea commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r791871531
##
File path: arch/sim/src/sim/up_uart.c
##
@@ -31,12 +31,16 @@
#include "up_internal.h"
-#if defined(USE_DEVCONSOLE) || CONFIG_SIM_UART_NUM
anchao commented on pull request #5333:
URL: https://github.com/apache/incubator-nuttx/pull/5333#issuecomment-1020925288
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
anchao merged pull request #5311:
URL: https://github.com/apache/incubator-nuttx/pull/5311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
davids5 commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once
a review has been done the author can merge it?
2) If on
pussuw commented on pull request #5322:
URL: https://github.com/apache/incubator-nuttx/pull/5322#issuecomment-1020875777
I squashed about half of the commits, please let me know if you wish for me
to squash more!
--
This is an automated message from the Apache Git Service.
To respond to
pkarashchenko merged pull request #5330:
URL: https://github.com/apache/incubator-nuttx/pull/5330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Ouss4 commented on pull request #5329:
URL: https://github.com/apache/incubator-nuttx/pull/5329#issuecomment-1020657586
> Hmm, I don't know why the 'Build /Linux (risc-v)' failed.
Seems we had a connection issue when downloading ESP32-C3 libraries "curl:
(56) OpenSSL SSL_read: Connec
acassis commented on pull request #5327:
URL: https://github.com/apache/incubator-nuttx/pull/5327#issuecomment-1021158119
Thank you @anchao I just saw you closed this PR, did you find some issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
AlanRosenthal commented on issue #5324:
URL:
https://github.com/apache/incubator-nuttx/issues/5324#issuecomment-1020413399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pkarashchenko commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020793633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
xiaoxiang781216 merged pull request #5322:
URL: https://github.com/apache/incubator-nuttx/pull/5322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
AlanRosenthal commented on pull request #5309:
URL: https://github.com/apache/incubator-nuttx/pull/5309#issuecomment-1020763140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
zhuyanlinzyl edited a comment on pull request #5261:
URL: https://github.com/apache/incubator-nuttx/pull/5261#issuecomment-1020801767
hi, @Ouss4 .
You advice is very good, I upload a new patch, use `swint` to switch
context. Please review again.
thx.
By the way, testing OK in
xiaoxiang781216 commented on pull request #5321:
URL: https://github.com/apache/incubator-nuttx/pull/5321#issuecomment-1021129132
Yes, the correct and elegant approach is pass the initial parameter through
constructor, like what we have done in this PR.
--
This is an automated message fr
pkarashchenko commented on a change in pull request #5330:
URL: https://github.com/apache/incubator-nuttx/pull/5330#discussion_r791396070
##
File path: boards/Board.mk
##
@@ -36,7 +36,7 @@ $(ETCSRC): $(RCRAWS) $(RCOBJS)
$(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw)))
anchao commented on pull request #5311:
URL: https://github.com/apache/incubator-nuttx/pull/5311#issuecomment-1020926046
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
acassis commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r791681134
##
File path: arch/sim/Kconfig
##
@@ -422,28 +422,87 @@ endchoice
endif
+menu "Simulated UART"
+
config SIM_UART_NUMBER
- int "The num
xiaoxiang781216 merged pull request #5331:
URL: https://github.com/apache/incubator-nuttx/pull/5331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
1 - 100 of 177 matches
Mail list logo
