[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
pkarashchenko commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136832406 > > One question from my side. Do we expect multi-instance of wifi driver? If not, then maybe we can just have a global semaphore pointer and use that on/atexit? > >

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
xiaoxiang781216 commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136821725 Task tls is disabled by default.:( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] 01/02: esp32-devkitc: Add an example config wamr + wasi

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1b9694ab982efc68ce4e60bba4c4a6a66e77f96a Author: YAMAMOTO Takashi AuthorDate: Wed May 25 12:14:14 2022 +0900

[incubator-nuttx] branch master updated (b4392f7323 -> 5d03e1a3b4)

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from b4392f7323 xtensa/esp32: Fix leak of semaphores created by Wi-Fi kernel thread new 1b9694ab98 esp32-

[incubator-nuttx] 02/02: esp32-devkitc: Document wamr_wasi_debug config

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5d03e1a3b44d6f3d1d532e3aa42f479e8fee0a21 Author: YAMAMOTO Takashi AuthorDate: Wed May 25 12:33:03 2022 +0900

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6323: esp32: Add an example config for wamr and littlefs

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #6323: URL: https://github.com/apache/incubator-nuttx/pull/6323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6320: use rmutex inside of all repeated implementation

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6320: URL: https://github.com/apache/incubator-nuttx/pull/6320#discussion_r881249717 ## drivers/rptun/rptun.c: ## @@ -210,54 +209,12 @@ static METAL_DECLARE_LIST(g_rptun_priv); static int rptun_lock(void) Review Comment: ```suggestio

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r881247563 ## libs/libc/stdlib/lib_atexit.c: ## @@ -0,0 +1,221 @@ +/ + * libs/libc/stdlib/lib_ate

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r881247728 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(void)

[GitHub] [incubator-nuttx] shizacat opened a new pull request, #6324: Fix stm32 pwm HAVE_ADVTIM

2022-05-24 Thread GitBox
shizacat opened a new pull request, #6324: URL: https://github.com/apache/incubator-nuttx/pull/6324 ## Summary Architecture: STM32/stm32f103 If used PWM on general timers, it will call the exception in https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/stm32/stm

[GitHub] [incubator-nuttx] yamt opened a new pull request, #6323: esp32: Add an example config for wamr and littlefs

2022-05-24 Thread GitBox
yamt opened a new pull request, #6323: URL: https://github.com/apache/incubator-nuttx/pull/6323 ## Summary esp32: Add an example config for wamr and littlefs ## Impact just a new config ## Testing tested with esp32-devkitc -- This is an automated message from the Apa

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request, #1172: interpreters/wamr/Kconfig: enable text heap when necessary

2022-05-24 Thread GitBox
yamt opened a new pull request, #1172: URL: https://github.com/apache/incubator-nuttx-apps/pull/1172 ## Summary aot requires executable memory. make it explicit in Kconfig. ## Impact ## Testing tested on esp32 -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] yamt commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
yamt commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136692762 my config had TLS_TASK_NELEM=0 and i got a bit surprised by this change breaking the build. does Kconfig have a way to solve this kind of things in a bit more user friendly way?

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1168: ostest:priority_inheritance Added priority restoration test

2022-05-24 Thread GitBox
masayuki2009 commented on PR #1168: URL: https://github.com/apache/incubator-nuttx-apps/pull/1168#issuecomment-1136638837 I noticed that `qemu-intel64:ostest` causes a deadlock. ``` SeaBIOS (version rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org) iPXE (http://ipxe.org) 00

[incubator-nuttx] 02/03: risc-v/esp32c3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 18d74dbea0bc151c34e3751089229c537743cea2 Author: Gustavo Henrique Nihei AuthorDate: Tue May 24 12:49:03 2022

[incubator-nuttx] 03/03: xtensa/esp32: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b4392f7323d4e0a1605118bde510d0d0b8632dc6 Author: Gustavo Henrique Nihei AuthorDate: Tue May 24 12:43:38 2022

[incubator-nuttx] 01/03: Revert "risc-v/esp32c3: Use onexit to free thread private semaphore"

2022-05-24 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b2d77c0e9c43b8bb5e95f230c6832bce4a40627a Author: Gustavo Henrique Nihei AuthorDate: Tue May 24 12:41:18 2022

[incubator-nuttx] branch master updated (4b308f6cbd -> b4392f7323)

2022-05-24 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 4b308f6cbd mutex/recursive: minor style fix new b2d77c0e9c Revert "risc-v/esp32c3: Use onexit to free

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
masayuki2009 merged PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1b39f27b512cbb1fc294b70e0e70a67d0092b98d docs: 4b308f6cbd5e354433ca28485cd47b1c3f5154b5

2022-05-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0997aff Publishing web

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880924914 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C" +{ +#el

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#discussion_r880902276 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1338,41 +1334,40 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_ge

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
gustavonihei commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136370907 > Do we expect multi-instance of wifi driver? No, the Wi-Fi driver does not expect to be initialized more than once. -- This is an automated message from the Apache G

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
gustavonihei commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136361775 The Wi-Fi library creates a new semaphore for every thread that performs connection operations, so we cannot have a global pointer. Since these semaphores are thread-local,

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#discussion_r880882952 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1338,41 +1334,40 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_g

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
pkarashchenko commented on PR #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322#issuecomment-1136342940 One question from my side. Do we expect multi-instance of wifi driver? If not, then maybe we can just have a global semaphore pointer and use that on/atexit? I mean I do

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880863649 ## arch/xtensa/src/esp32s3/esp32s3_spi.h: ## @@ -0,0 +1,170 @@ +/ + * arch/xtens

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880862101 ## arch/xtensa/src/esp32s3/esp32s3_spi.c: ## @@ -0,0 +1,1219 @@ +/ + * arch/xten

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880858644 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880858216 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880858011 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880857847 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880854568 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880854796 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880854278 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -517,6 +533,72 @@ config ESP32S3_GPIO_IRQ ---help--- Enable support for interrupting GPIO

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880819553 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(void)

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880814703 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request, #6322: ESP32/ESP32-C3: Fix leak of semaphores created by Wi-Fi kernel thread

2022-05-24 Thread GitBox
gustavonihei opened a new pull request, #6322: URL: https://github.com/apache/incubator-nuttx/pull/6322 ## Summary This PR intends to provide an alternative solution to the fix provide on https://github.com/apache/incubator-nuttx/pull/4092 for **ESP32-C3**, and extend it to the **ESP32**

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880792923 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C"

[incubator-nuttx] branch master updated (12469dd15e -> 4b308f6cbd)

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 12469dd15e SSD1306: Added option to force reconfigure display after power off add 4b308f6cbd mutex/r

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6321: mutex/recursive: minor style fix

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #6321: URL: https://github.com/apache/incubator-nuttx/pull/6321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880785525 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880781745 ## arch/xtensa/src/esp32s3/esp32s3_spi.c: ## @@ -0,0 +1,1219 @@ +/ + * arch/xte

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880780443 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C"

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880777877 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880771616 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C" +{ +#el

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
acassis commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880763576 ## arch/xtensa/src/esp32s3/esp32s3_spi.c: ## @@ -0,0 +1,1219 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-24 Thread GitBox
acassis commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r880761466 ## arch/xtensa/src/esp32s3/esp32s3_spi.c: ## @@ -0,0 +1,1219 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880664542 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C"

[GitHub] [incubator-nuttx] davids5 commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-24 Thread GitBox
davids5 commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1136143229 @pkarashchenko - I have to get a few things off my plate and then I can circle back to test this. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880720448 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(void)

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880691328 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880664542 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C"

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880659335 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdlib/lib_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880659033 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C

[incubator-nuttx] branch master updated (247a13cc02 -> 12469dd15e)

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 247a13cc02 include:add recursive lock add 12469dd15e SSD1306: Added option to force reconfigure displ

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6319: SSD1306: Added option to force reconfigure display after power off

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #6319: URL: https://github.com/apache/incubator-nuttx/pull/6319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-24 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1136071691 The ostest seems to pass, but it contain really few tests related to priority inheritance only. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880653074 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdlib/lib_

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6320: use rmutex inside of all repeated implementation

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6320: URL: https://github.com/apache/incubator-nuttx/pull/6320#discussion_r880655857 ## drivers/1wire/1wire.c: ## @@ -221,37 +219,7 @@ static int onewire_pm_prepare(FAR struct pm_callback_s *cb, int domain, int onewire_sem_wait(FAR stru

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880655401 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/st

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6321: mutex/recursive: minor style fix

2022-05-24 Thread GitBox
pkarashchenko commented on PR #6321: URL: https://github.com/apache/incubator-nuttx/pull/6321#issuecomment-1136068053 Thank you for fixing this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880653074 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdlib/lib_

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6321: mutex/recursive: minor style fix

2022-05-24 Thread GitBox
anchao opened a new pull request, #6321: URL: https://github.com/apache/incubator-nuttx/pull/6321 ## Summary mutex/recursive: minor style fix ## Impact N/A ## Testing ci check -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880650295 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdl

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880647143 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdl

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880645496 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdl

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880564818 ## arch/arm/include/irq.h: ## @@ -55,4 +60,91 @@ # include #endif +#ifndef __ASSEMBLY__ + +#ifdef __cplusplus +#define EXTERN extern "C" +extern "C"

[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #6320: use rmutex inside of all repeated implementation

2022-05-24 Thread GitBox
anjiahao1 opened a new pull request, #6320: URL: https://github.com/apache/incubator-nuttx/pull/6320 Signed-off-by: anjiahao ## Impact maybe Slightly reduced szie and increased speed ## Testing CI -- This is an automated message from the Apache Git Service. To respond to t

[incubator-nuttx-apps] 04/04: webclient: Require a port in proxy string

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit f7b0ad4b74298bd6b2445a19573f285738fbd495 Author: YAMAMOTO Takashi AuthorDate: Mon May 23 15:08:21 2022

[incubator-nuttx-apps] branch master updated (562db060b -> f7b0ad4b7)

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 562db060b interpreters/wamr/Kconfig: Mention limitations about wasi new 4f4f4da52 webclient: Sep

[incubator-nuttx-apps] 03/04: webclient: Implement proxy

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 4798f01449bf3727c62bf35a89109bd4c2254071 Author: YAMAMOTO Takashi AuthorDate: Mon May 23 14:58:34 2022

[incubator-nuttx-apps] 02/04: webclient: Add proxy setting in webclient_context

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 41aee40a2ce36432ad0266f5f35b1a414ecf856c Author: YAMAMOTO Takashi AuthorDate: Mon May 23 14:01:44 2022

[incubator-nuttx-apps] 01/04: webclient: Separate wget_target_s from wget_s

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 4f4f4da526e43c5331b381a788af15cf6285d048 Author: YAMAMOTO Takashi AuthorDate: Mon May 16 11:40:04 2022

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1170: webclient: implement basic proxy

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1155: interpreters/wamr/Kconfig: Add an option to enable wasi libc

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #1155: URL: https://github.com/apache/incubator-nuttx-apps/pull/1155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated (1d216fde9 -> 562db060b)

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 1d216fde9 import/Make.defs: Add -noincstd++ new 90e164b70 interpreters/wamr/Kconfig: Add an opti

[incubator-nuttx-apps] 02/02: interpreters/wamr/Kconfig: Mention limitations about wasi

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 562db060b79b3cbbc4aaff3c256aae5e798d434e Author: YAMAMOTO Takashi AuthorDate: Tue May 24 10:08:50 2022

[incubator-nuttx-apps] 01/02: interpreters/wamr/Kconfig: Add an option to enable wasi libc

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 90e164b708f5303618a8951f0c95fa90be9d9b2b Author: YAMAMOTO Takashi AuthorDate: Wed Apr 27 13:23:05 2022

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880593328 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(void)

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880588800 ## arch/z80/include/irq.h: ## @@ -32,4 +32,33 @@ #include #include +#ifndef __ASSEMBLY__ +# include +# include "chip/switch.h" Review Comment: let me

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880588465 ## libs/libc/stdlib/lib_atexit.c: ## @@ -0,0 +1,221 @@ +/ + * libs/libc/stdlib/lib_ate

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880588227 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/st

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880587393 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdl

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880584266 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_g

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880583197 ## libs/libc/stdlib/lib_atexit.c: ## @@ -0,0 +1,221 @@ +/ + * libs/libc/stdli

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880579658 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdlib/lib_

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6279: include:add recursive lock

2022-05-24 Thread GitBox
xiaoxiang781216 merged PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880565480 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880563592 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880559079 ## arch/or1k/include/irq.h: ## @@ -37,4 +42,80 @@ #include +/ + * Public Data +

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6286: arch: inline up_interrupt_context()

2022-05-24 Thread GitBox
anchao commented on code in PR #6286: URL: https://github.com/apache/incubator-nuttx/pull/6286#discussion_r880558736 ## arch/sim/include/irq.h: ## @@ -50,20 +50,39 @@ struct xcptcontext void *sigdeliver; /* Actual type is sig_deliver_t */ jmp_buf regs; }; + +#ifdef __cplu

[incubator-nuttx] branch master updated: include:add recursive lock

2022-05-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 247a13cc02 include:add recursive loc

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880553612 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,56 @@ +/ + * libs/libc/stdl

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880542816 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880542816 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880538729 ## libs/libc/stdlib/lib_exit.c: ## @@ -22,13 +22,38 @@ * Included Files / +#incl

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL

2022-05-24 Thread GitBox
xiaoxiang781216 commented on code in PR #6315: URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r880530846 ## drivers/lcd/ssd1306_base.c: ## @@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power) { /* Configu

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
pkarashchenko commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880527543 ## libs/libc/stdlib/lib_exit.c: ## @@ -22,13 +22,38 @@ * Included Files /

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-24 Thread GitBox
gustavonihei commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r880520920 ## arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c: ## @@ -1339,20 +1340,23 @@ static int IRAM_ATTR wifi_is_in_isr(void) static void *esp_thread_semphr_get(

  1   2   >