[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940961938 ## system/nsh/nsh_main.c: ## @@ -127,7 +127,8 @@ int main(int argc, FAR char *argv[]) nsh_initialize(); -#if defined(CONFIG_NSH_TELNET) && !

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208975732 > > It's easy to get vtbl in libnsh. > > @xiaoxiang781216 Hmm, I'm still confusing. Do you mean that we should use `nsh_newconsole()` `nsh_session()` `nsh_exit

[GitHub] [incubator-nuttx] qbazd commented on issue #6796: NUCLEO-L4R5ZI - SDMMC - SDIO - no communication on CMD line

2022-08-08 Thread GitBox
qbazd commented on issue #6796: URL: https://github.com/apache/incubator-nuttx/issues/6796#issuecomment-1208968443 Hi, I've reached out to google, and here is the nice [L4+ vs L4 comparison](https://www.stmicroelectronics.com.cn/content/ccc/resource/training/technical/product_training/group

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208913336 >It's easy to get vtbl in libnsh. @xiaoxiang781216 Hmm, I'm still confusing. Do you mean that we should use `nsh_newconsole()` `nsh_session()` `nsh_exit()` to

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940888720 ## system/telnetd/telnetd.c: ## @@ -0,0 +1,61 @@ +/ + * apps/system/telnet

[incubator-nuttx] 01/02: arch/stm32f7: rename PWM complementary output pins from CHxN to CHxNOUT (always output)

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit fd02855c63854f0c30d36217f13d37c19f686fb9 Author: raiden00pl AuthorDate: Sat Aug 6 15:41:48 2022 +0200 a

[incubator-nuttx] branch master updated (050ce3e0d3 -> a05db5299e)

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 050ce3e0d3 kinetis:spi remove ttype & do cache ops new fd02855c63 arch/stm32f7: rename PWM complement

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6809: arch/stm32f7: port PWM driver from arch/stm32

2022-08-08 Thread GitBox
xiaoxiang781216 merged PR #6809: URL: https://github.com/apache/incubator-nuttx/pull/6809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208902556 > I'm a bit confusing. As you can see in > > https://github.com/apache/incubator-nuttx-apps/blob/e04333c986a47ec03ccb83e985f520fe30e3f1b6/nshlib/nsh_parse.c#L1

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940884532 ## system/nsh/nsh_main.c: ## @@ -127,7 +127,8 @@ int main(int argc, FAR char *argv[]) nsh_initialize(); -#if defined(CONFIG_NSH_TELNET) && !def

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208892445 > > @xiaoxiang781216 Could you review this PR again? > > Let's summary my proposal: > > 1. Move examples/telnetd to system/telnetd I will remove

[GitHub] [incubator-nuttx] Donny9 commented on pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#issuecomment-1208882933 > @Donny9, @xiaoxiang781216 - What was the motivation for this change? > > For a change of this size nature all the file system will need to tested and result posted as well.

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940866098 ## libs/libc/dirent/lib_telldir.c: ## @@ -61,15 +56,11 @@ off_t telldir(FAR DIR *dirp) { - struct fs_dirent_s *idir = (struct fs_dirent_s *)dirp; - - if (!i

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940869322 ## system/telnetd/telnetd.c: ## @@ -0,0 +1,61 @@ +/ + * apps/system/tel

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940869322 ## system/telnetd/telnetd.c: ## @@ -0,0 +1,61 @@ +/ + * apps/system/tel

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6806: libc: Implement memfd on top of tmpfs

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6806: URL: https://github.com/apache/incubator-nuttx/pull/6806#discussion_r940866622 ## include/sys/memfd.h: ## @@ -0,0 +1,72 @@ +/ + * include/sys/memfd.h + * +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6806: libc: Implement memfd on top of tmpfs

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6806: URL: https://github.com/apache/incubator-nuttx/pull/6806#discussion_r940867964 ## libs/libc/misc/lib_memfd.c: ## @@ -0,0 +1,51 @@ +/ + * libs/libc/misc/lib_

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6804: mm/mempool: support mempool and show mempool info in procfs

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6804: URL: https://github.com/apache/incubator-nuttx/pull/6804#discussion_r940867552 ## mm/mempool/mempool.c: ## @@ -0,0 +1,316 @@ +/ + * mm/mempool/mempool.c + * + * Lice

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6806: libc: Implement memfd on top of tmpfs

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6806: URL: https://github.com/apache/incubator-nuttx/pull/6806#discussion_r940866622 ## include/sys/memfd.h: ## @@ -0,0 +1,72 @@ +/ + * include/sys/memfd.h + * +

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940867307 ## system/telnetd/telnetd.c: ## @@ -0,0 +1,61 @@ +/ + * apps/system/telnet

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6806: libc: Implement memfd on top of tmpfs

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6806: URL: https://github.com/apache/incubator-nuttx/pull/6806#discussion_r940866622 ## include/sys/memfd.h: ## @@ -0,0 +1,72 @@ +/ + * include/sys/memfd.h + * +

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940866098 ## libs/libc/dirent/lib_telldir.c: ## @@ -61,15 +56,11 @@ off_t telldir(FAR DIR *dirp) { - struct fs_dirent_s *idir = (struct fs_dirent_s *)dirp; - - if (!i

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208875452 > @xiaoxiang781216 Could you review this PR again? Let's summary my proposal: 1. Move examples/telnetd to system/telnetd 2. Change telnetd_start to te

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940863797 ## fs/vfs/fs_dir.c: ## @@ -0,0 +1,607 @@ +/ + * fs/vfs/fs_dir.c + * + * Licensed to th

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940861954 ## fs/binfs/fs_binfs.c: ## @@ -63,9 +72,12 @@ static int binfs_fstat(FAR const struct file *filep, FAR struct stat *buf); stati

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940861881 ## fs/binfs/fs_binfs.c: ## @@ -63,9 +72,12 @@ static int binfs_fstat(FAR const struct file *filep, FAR struct stat *buf); stati

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940861801 ## fs/fat/fs_fat32.h: ## @@ -1054,8 +1067,9 @@ EXTERN intfat_allocatedirentry(struct fat_mountpt_s *fs, struct fat_dirinf

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940860998 ## libs/libc/dirent/lib_dirfd.c: ## @@ -0,0 +1,65 @@ +/ + * libs/libc/dirent/lib_dirfd

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
Donny9 commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940860920 ## libs/libc/dirent/lib_telldir.c: ## @@ -61,15 +56,11 @@ off_t telldir(FAR DIR *dirp) { - struct fs_dirent_s *idir = (struct fs_dirent_s *)dirp; - - if (!i

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6804: mm/mempool: support mempool and show mempool info in procfs

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6804: URL: https://github.com/apache/incubator-nuttx/pull/6804#discussion_r940858208 ## mm/mempool/mempool.c: ## @@ -0,0 +1,316 @@ +/ + * mm/mempool/mempool.c + * +

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940855300 ## system/telnetd/telnetd.c: ## @@ -0,0 +1,61 @@ +/ + * apps/system/tel

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6806: libc: Implement memfd on top of tmpfs

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6806: URL: https://github.com/apache/incubator-nuttx/pull/6806#discussion_r940855231 ## libs/libc/misc/lib_memfd.c: ## @@ -0,0 +1,51 @@ +/ + * libs/libc/misc/lib_me

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6815: pic32mx: add option to disable JTAG at runtime

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r940853842 ## arch/mips/src/pic32mx/pic32mx_lowinit.c: ## @@ -155,6 +156,60 @@ static inline void pic32mx_cache(void) asm("\tmtc0 %0,$16,0\n" : : "r" (regval)); }

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r940852286 ## netutils/telnetd/telnetd_daemon.c: ## @@ -316,6 +307,33 @@ static int telnetd_daemon(int argc, FAR char *argv[]) close(drvrfd);

[GitHub] [incubator-nuttx] rm5248 opened a new pull request, #6815: pic32mx: add option to disable JTAG at runtime

2022-08-08 Thread GitBox
rm5248 opened a new pull request, #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815 ## Summary Add a new option to optionally disable JTAG at runtime. Defaults to enabling JTAG at runtime as that is the state the processor comes up in. This only affects 3xx/4xx/5x

[incubator-nuttx] 02/03: kinetis:[lp]serial remove ttype & do cache ops

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 22580584d2c401cf2cd7b96c9d477b3c3dd6e2bb Author: David Sidrane AuthorDate: Wed Jun 8 10:16:48 2022 -0700

[incubator-nuttx] 01/03: Kinetis:edma Cleanup

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7a7a01153b1198bde73f8472134899e1ebac4a87 Author: David Sidrane AuthorDate: Tue May 31 09:02:26 2022 -0700

[incubator-nuttx] 03/03: kinetis:spi remove ttype & do cache ops

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 050ce3e0d37d6158ce2d520f57f2e706f040e776 Author: David Sidrane AuthorDate: Wed Jun 8 12:28:02 2022 -0700

[incubator-nuttx] branch master updated (20b9cc37d5 -> 050ce3e0d3)

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 20b9cc37d5 net/local:Make local send multi-thread safe new 7a7a01153b Kinetis:edma Cleanup new 2

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6813: Kinetis EDMA update

2022-08-08 Thread GitBox
xiaoxiang781216 merged PR #6813: URL: https://github.com/apache/incubator-nuttx/pull/6813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] btashton commented on pull request #6800: Use GCC for LD on MIPS processors

2022-08-08 Thread GitBox
btashton commented on PR #6800: URL: https://github.com/apache/incubator-nuttx/pull/6800#issuecomment-1208847975 At least a while back I ran some testing under qemu. But looks like you might have also been on that thread. https://lists.apache.org/thread/hk8gdtr495qbl2fg4yx1gfotm319np

[GitHub] [incubator-nuttx] rm5248 commented on pull request #6800: Use GCC for LD on MIPS processors

2022-08-08 Thread GitBox
rm5248 commented on PR #6800: URL: https://github.com/apache/incubator-nuttx/pull/6800#issuecomment-1208824454 As far as I am aware, all of the PIC32 processors are always little-endian, so it seems that if there is a problem with the big vs. little endian that is a problem with the compile

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6807: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread GitBox
xiaoxiang781216 commented on PR #6807: URL: https://github.com/apache/incubator-nuttx/pull/6807#issuecomment-1208790204 Yes, if they don't use uorb wrapper here: https://github.com/apache/incubator-nuttx-apps/tree/master/system/uorb -- This is an automated message from the Apache Git Se

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 20b9cc37d5923949c5dd024b96a547e018232956

2022-08-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e549845 Publishing web

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1254: Modify telnetd

2022-08-08 Thread GitBox
masayuki2009 commented on PR #1254: URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208691964 @xiaoxiang781216 Could you review this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6814: s32k1 EDMA clean up and loop support

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6814: URL: https://github.com/apache/incubator-nuttx/pull/6814#discussion_r940572868 ## arch/arm/src/s32k1xx/s32k1xx_edma.c: ## @@ -623,8 +607,18 @@ static int s32k1xx_edma_interrupt(int irq, void *context, void *arg) /* Terminate

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#discussion_r940564389 ## fs/binfs/fs_binfs.c: ## @@ -63,9 +72,12 @@ static int binfs_fstat(FAR const struct file *filep, FAR struct stat *buf);

[GitHub] [incubator-nuttx] davids5 opened a new pull request, #6814: s32k1 EDMA clean up and loop support

2022-08-08 Thread GitBox
davids5 opened a new pull request, #6814: URL: https://github.com/apache/incubator-nuttx/pull/6814 ## Summary 1. Added DMAMUX for S32k146 2. Fixed missing comment S32K1XX_DMAMUX_CHCFG macro 3. EDMA Fix access violation causing resets and hardfaults due to 32 bit access to 8 bit

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6813: Kinetis EDMA update

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6813: URL: https://github.com/apache/incubator-nuttx/pull/6813#discussion_r940561035 ## arch/arm/src/kinetis/kinetis_edma.c: ## @@ -636,7 +610,15 @@ static int kinetis_edma_interrupt(int irq, void *context, void *arg) /* Terminate

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6807: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread GitBox
pkarashchenko commented on PR #6807: URL: https://github.com/apache/incubator-nuttx/pull/6807#issuecomment-1208469258 @xiaoxiang781216 is this a breaking change? I mean from out of tree users. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] davids5 opened a new pull request, #6813: Kinetis EDMA update

2022-08-08 Thread GitBox
davids5 opened a new pull request, #6813: URL: https://github.com/apache/incubator-nuttx/pull/6813 ## Summary This PR cleans up the Kinetis EDMA code and makes it functional 1. Header file clean up 2. HW TCD reset of DLASTSGA is 32 Bits. 3. HW TCD definition now matches HW

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6810: arch/stm32f7: port ADC driver from arch/stm32

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6810: URL: https://github.com/apache/incubator-nuttx/pull/6810#discussion_r940526322 ## arch/arm/src/stm32f7/stm32_adc.c: ## @@ -1073,37 +1340,27 @@ static void adc_rccreset(struct stm32_dev_s *priv, bool reset) { uint32_t adcbit; -

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6810: arch/stm32f7: port ADC driver from arch/stm32

2022-08-08 Thread GitBox
pkarashchenko commented on code in PR #6810: URL: https://github.com/apache/incubator-nuttx/pull/6810#discussion_r940524818 ## arch/arm/src/stm32f7/hardware/stm32f72xx73xx_adc.h: ## @@ -372,8 +372,10 @@ #define ADC_JSQR_JSQ3_MASK (0x1f << ADC_JSQR_JSQ3_SHIFT) #define

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6812: net/local: Remove the sync preamble from datagram

2022-08-08 Thread GitBox
xiaoxiang781216 opened a new pull request, #6812: URL: https://github.com/apache/incubator-nuttx/pull/6812 ## Summary since pipe is a reliable transport, the sync just waste the space and time ## Impact More fast ## Testing Pass internal test -- This is an automa

[incubator-nuttx-apps] branch master updated: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new e04333c98 driver/sensor: rename

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1257: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread GitBox
xiaoxiang781216 merged PR #1257: URL: https://github.com/apache/incubator-nuttx-apps/pull/1257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx] branch master updated: net/local:Make local send multi-thread safe

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 20b9cc37d5 net/local:Make local send

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
xiaoxiang781216 merged PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6811: arch/arm/src/stm32f7: port FOC driver from arch/stm32

2022-08-08 Thread GitBox
raiden00pl opened a new pull request, #6811: URL: https://github.com/apache/incubator-nuttx/pull/6811 ## Summary arch/arm/src/stm32f7: port FOC driver from arch/stm32 depends on https://github.com/apache/incubator-nuttx/pull/6809 and https://github.com/apache/incubator-nuttx/pull/6

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6810: arch/stm32f7: port ADC driver from arch/stm32

2022-08-08 Thread GitBox
raiden00pl opened a new pull request, #6810: URL: https://github.com/apache/incubator-nuttx/pull/6810 ## Summary arch/arm/src/stm32f7: port ADC driver from arch/stm32 This change adds support for the following features: - injected channels (default: 0) - ADC resolution (defaul

[GitHub] [incubator-nuttx] davids5 commented on issue #6796: NUCLEO-L4R5ZI - SDMMC - SDIO - no communication on CMD line

2022-08-08 Thread GitBox
davids5 commented on issue #6796: URL: https://github.com/apache/incubator-nuttx/issues/6796#issuecomment-1208065319 Ok Good hear! Now the question is":Is the L4+ just marketing hype or different IP? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
XinStellaris commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940176427 ## net/local/local_sendmsg.c: ## @@ -196,7 +196,15 @@ static ssize_t local_send(FAR struct socket *psock, /* Send the packet */ + re

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940171364 ## net/local/local_sendmsg.c: ## @@ -196,7 +196,15 @@ static ssize_t local_send(FAR struct socket *psock, /* Send the packet */ +

[GitHub] [incubator-nuttx] qbazd commented on issue #6796: NUCLEO-L4R5ZI - SDMMC - SDIO - no communication on CMD line

2022-08-08 Thread GitBox
qbazd commented on issue #6796: URL: https://github.com/apache/incubator-nuttx/issues/6796#issuecomment-1208043754 @davids5, I exacly went that road H7 have same registers as L4+. I went further and have some preliminary results. But eventualy L4+ will have different config variables th

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
XinStellaris commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940155519 ## net/local/local_conn.c: ## @@ -128,6 +128,16 @@ FAR struct local_conn_s *local_alloc(void) nxsem_init(&conn->lc_donesem, 0, 0); nxsem_set_p

[incubator-nuttx] branch master updated: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c4bed9eae9 driver/sensor: rename /de

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6807: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread GitBox
xiaoxiang781216 merged PR #6807: URL: https://github.com/apache/incubator-nuttx/pull/6807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] 02/02: libc/err: Add _func suffix to avoid the the penitential symbol collision

2022-08-08 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 16d858f3ee21f68b1e9ce8fab6ecd99525695aae Author: Xiang Xiao AuthorDate: Mon Aug 8 02:22:10 2022 +0800 lib

[incubator-nuttx] 01/02: libc: Remove CONFIG_LIBC_ERR

2022-08-08 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e26d8759d0a48547b9d0c05aa170fe3e943252cf Author: Xiang Xiao AuthorDate: Mon Aug 8 00:25:58 2022 +0800 lib

[incubator-nuttx] branch master updated (dd718e78f7 -> 16d858f3ee)

2022-08-08 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from dd718e78f7 Fix typos new e26d8759d0 libc: Remove CONFIG_LIBC_ERR new 16d858f3ee libc/err: Add _fun

[GitHub] [incubator-nuttx] davids5 merged pull request #6805: libc: Remove CONFIG_LIBC_ERR

2022-08-08 Thread GitBox
davids5 merged PR #6805: URL: https://github.com/apache/incubator-nuttx/pull/6805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-08 Thread GitBox
xiaoxiang781216 commented on PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#issuecomment-1208014948 > @Donny9, @xiaoxiang781216 - What was the motivation for this change? > 1. From the design perspective, directory is also a file(https://en.wikipedia.org/wiki/E

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #6809: arch/stm32f7: port PWM driver from arch/stm32

2022-08-08 Thread GitBox
raiden00pl commented on PR #6809: URL: https://github.com/apache/incubator-nuttx/pull/6809#issuecomment-1208010774 FYI @robertobucher, this PR adds complementary outputs for STM32F7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] acassis commented on pull request #6800: Use GCC for LD on MIPS processors

2022-08-08 Thread GitBox
acassis commented on PR #6800: URL: https://github.com/apache/incubator-nuttx/pull/6800#issuecomment-1208009917 Thank you @rm5248 !! @xiaoxiang781216 maybe the issue is caused by incompatibility with pinguino after this change. But since Robert is also using little endian, but issue could b

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6809: arch/stm32f7: port PWM driver from arch/stm32

2022-08-08 Thread GitBox
raiden00pl opened a new pull request, #6809: URL: https://github.com/apache/incubator-nuttx/pull/6809 ## Summary - arch/stm32f7: rename PWM complementary output pins from CHxN to CHxNOUT (always output) - arch/arm/src/stm32f7: port PWM driver from arch/stm32 This change adds sup

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940130894 ## net/local/local_conn.c: ## @@ -128,6 +128,16 @@ FAR struct local_conn_s *local_alloc(void) nxsem_init(&conn->lc_donesem, 0, 0); nxsem_se

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
XinStellaris commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940101666 ## net/local/local_sendmsg.c: ## @@ -334,6 +334,16 @@ static ssize_t local_sendto(FAR struct socket *psock, goto errout_with_halfduplex; } +

[GitHub] [incubator-nuttx] davids5 commented on issue #6796: NUCLEO-L4R5ZI - SDMMC - SDIO - no communication on CMD line

2022-08-08 Thread GitBox
davids5 commented on issue #6796: URL: https://github.com/apache/incubator-nuttx/issues/6796#issuecomment-1207954297 This may be an IP versioning issues (SDMMCv1 vs SDMMCv2.) Or just some clocking. If it is just clocking the solution is using ifdef based on CONFIG_STM32L4_SDMMC. If it is a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808#discussion_r940084340 ## net/local/local_sendmsg.c: ## @@ -334,6 +334,16 @@ static ssize_t local_sendto(FAR struct socket *psock, goto errout_with_halfduplex; }

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1257: driver/sensor: rename /dev/sensor -> /dev/uorb

2022-08-08 Thread GitBox
xiaoxiang781216 commented on code in PR #1257: URL: https://github.com/apache/incubator-nuttx-apps/pull/1257#discussion_r940082423 ## testing/sensortest/sensortest.c: ## @@ -214,7 +214,7 @@ static void usage(void) printf("\tdefault: 0\n"); printf(" Commands:

[GitHub] [incubator-nuttx] davids5 commented on pull request #6781: Multiple improvements for stm32wl5 board nucleo-stm32wl5jc

2022-08-08 Thread GitBox
davids5 commented on PR #6781: URL: https://github.com/apache/incubator-nuttx/pull/6781#issuecomment-1207942616 > but there would be tons of #ifdefs, changing anything would trigger anxiety to anyone - because it could break other stm32 ports. It already is this way and it is the wro

[GitHub] [incubator-nuttx] XinStellaris opened a new pull request, #6808: net/local:Make local udp send multi-thread safe

2022-08-08 Thread GitBox
XinStellaris opened a new pull request, #6808: URL: https://github.com/apache/incubator-nuttx/pull/6808 Signed-off-by: 田昕 ## Summary When multiple threads sends data through one local udp socket, data may be garbled due to lack of sem. ## Impact local socket ## Te

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #6781: Multiple improvements for stm32wl5 board nucleo-stm32wl5jc

2022-08-08 Thread GitBox
raiden00pl commented on PR #6781: URL: https://github.com/apache/incubator-nuttx/pull/6781#issuecomment-1207934684 > And I don't really think there will be any order in stm32 ports :) There are too much small changes between chips, even stm32wl5 which is supposed to be stm32l4 + cm0 had dif

[GitHub] [incubator-nuttx] mlyszczek commented on pull request #6781: Multiple improvements for stm32wl5 board nucleo-stm32wl5jc

2022-08-08 Thread GitBox
mlyszczek commented on PR #6781: URL: https://github.com/apache/incubator-nuttx/pull/6781#issuecomment-1207838081 > I don't think that splitted Kconfig is a good idea at the moment. STM32 ports are already a complete mess, the maintenance and keeping changes between STM32 ports in sync is a