Re: [PR] sched:rw_sem: replace mutex with spinlock [nuttx]

2024-03-13 Thread via GitHub
TaiJuWu commented on PR #11769: URL: https://github.com/apache/nuttx/pull/11769#issuecomment-1996580151 > In the single core, spinlock map to disable/enable irq Oh, I made a mistake. If I want to replace mutex with spinlock, I should use spinlock_irqsave() and spinlock_irqrestore()

Re: [PR] sched:rw_sem: replace mutex with spinlock [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 commented on PR #11769: URL: https://github.com/apache/nuttx/pull/11769#issuecomment-1996538131 In the single core, spinlock map to disable/enable irq -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
rushabhvg commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1996499589 Okay @cederom I will follow this worklplan. ANd, work with @lupyuen . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

(nuttx) branch master updated (e0c18c05e8 -> 6843b26a66)

2024-03-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e0c18c05e8 fs/driver: using nx_unlink to call unlink ops to release some resource add 6843b26a66 binfmt/lo

Re: [PR] binfmt/loadmodule: replace kmm_free() to lib_free() [nuttx]

2024-03-13 Thread via GitHub
pkarashchenko merged PR #11904: URL: https://github.com/apache/nuttx/pull/11904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

Re: [PR] sched:rw_sem: replace mutex with spinlock [nuttx]

2024-03-13 Thread via GitHub
TaiJuWu commented on PR #11769: URL: https://github.com/apache/nuttx/pull/11769#issuecomment-1996383601 > > Hi @xiaoxiang781216, > > Do you know why some platform not config spinlock? Even in 1cpu, in multi-threading environment spinlock is also needed. > > How do you think this path?

Re: [PR] sched:rw_sem: replace mutex with spinlock [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 commented on PR #11769: URL: https://github.com/apache/nuttx/pull/11769#issuecomment-1996350685 > Hi @xiaoxiang781216, > > Do you know why some platform not config spinlock? Even in 1cpu, in multi-threading environment spinlock is also needed. > > How do you thi

(nuttx) branch master updated (3b79363041 -> e0c18c05e8)

2024-03-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3b79363041 mtd_config_fs : optimize nvs add e0c18c05e8 fs/driver: using nx_unlink to call unlink ops to release

Re: [PR] fs/driver: using nx_unlink to call unlink ops to release some resource [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 merged PR #11892: URL: https://github.com/apache/nuttx/pull/11892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] Rpesina/esp32c3 twai [nuttx]

2024-03-13 Thread via GitHub
radek-pesina opened a new pull request, #11913: URL: https://github.com/apache/nuttx/pull/11913 ## Summary Replace ESP32C3 TWAI driver with common SJA1000 CAN driver (in a separate pull request). This pull request depends on the SJA1000 PR. ## Impact Commonises the ESP32C3 TWAI

(nuttx-website) branch asf-site updated: Publishing web: f355c37abb2c2dea4b5ff1c582aacf9520a34e3a docs: 3b7936304183d505f15a3a270fc39277f9da8e60

2024-03-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 548b695ed Publishing web: f355c37

Re: [PR] binfmt/loadmodule: replace kmm_free() to lib_free() [nuttx]

2024-03-13 Thread via GitHub
anchao commented on code in PR #11904: URL: https://github.com/apache/nuttx/pull/11904#discussion_r1524061363 ## binfmt/binfmt_loadmodule.c: ## @@ -194,7 +194,7 @@ int load_module(FAR struct binary_s *bin, FAR const char *filename, /* Free the allocated ful

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
cederom commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1996141398 Hello @rushabhvg and thank you for your interest in NuttX RTOS :-) My suggestions for the workplan in 5 simple steps is presented below :-) 1. Limit Rust use for APPLICATIONS O

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
patacongo commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1996009121 > Where would Rust code be used - approved to be used - though? It is somewhat less concerning if restricted to architecture- or board- specific logic as Alan suggested in an

Re: [PR] sched:rw_sem: replace mutex with spinlock [nuttx]

2024-03-13 Thread via GitHub
TaiJuWu commented on PR #11769: URL: https://github.com/apache/nuttx/pull/11769#issuecomment-1995786249 Ping @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
TimJTi commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1995645101 > > Is this a suggestion that NuttX RTOS itself will move from C to Rust? Or a mix of the two? Sorry if it's a dumb question but I know nothing about rust other than what's on my car.

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
acassis commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1995529738 > Is this a suggestion that NuttX RTOS itself will move from C to Rust? Or a mix of the two? Sorry if it's a dumb question but I know nothing about rust other than what's on my car..

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
patacongo commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1995450368 I would think that a mix of the two could be a maintenance problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
leducp commented on code in PR #11908: URL: https://github.com/apache/nuttx/pull/11908#discussion_r1523754088 ## tools/mkexport.sh: ## @@ -257,6 +257,9 @@ echo "HOSTLDFLAGS = ${HOSTLDFLAGS}" >>"${EXPORTDIR}/scripts/Make.defs" echo "HOSTEXEEXT = ${HOSTEXEEXT}" >>"${E

Re: [PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
leducp commented on code in PR #11908: URL: https://github.com/apache/nuttx/pull/11908#discussion_r1523751503 ## tools/Export.mk: ## @@ -80,6 +80,13 @@ endif @echo "OBJDUMP=\"$(OBJDUMP)\"" >> $(EXPORTDIR)/makeinfo.sh @echo "OBJEXT=\"$(OBJEXT)\"" >> $(EXPORTDIR)/m

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
TimJTi commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1995332604 Is this a suggestion that NuttX RTOS itself will move from C to Rust? Or a mix of the two? Sorry if it's a dumb question but I know nothing about rust other than what's on my car...

Re: [PR] fs/driver: using nx_unlink to call unlink ops to release some resource [nuttx]

2024-03-13 Thread via GitHub
acassis commented on PR #11892: URL: https://github.com/apache/nuttx/pull/11892#issuecomment-1995255593 I just approved it assuming you will do this test to see how much the size increase. @JorgeGzm is trying to create a script to print the NuttX memory size at end of compilation, I

Re: [PR] fs/driver: using nx_unlink to call unlink ops to release some resource [nuttx]

2024-03-13 Thread via GitHub
acassis commented on PR #11892: URL: https://github.com/apache/nuttx/pull/11892#issuecomment-1995247056 Hi @Donny9 understood! I was thinking it was just an improvement to reduce memory size. So in this case I think any configuration that calls unregister_driver() could be used, like the AD

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
acassis commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1995208826 > NuttX doesn't support Rust yet, that's why no Rust coding standard exist in official document. As far as I know, Rust defines an official coding standard, so I would suggest that N

Re: [I] PolarFire SoC - C++ Exception Exits Before Catch [nuttx]

2024-03-13 Thread via GitHub
acassis commented on issue #11912: URL: https://github.com/apache/nuttx/issues/11912#issuecomment-1995200154 @jrosberg did you face similar issue with using C++ on PolarFire? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11908: URL: https://github.com/apache/nuttx/pull/11908#discussion_r1523694292 ## tools/Export.mk: ## @@ -80,6 +80,13 @@ endif @echo "OBJDUMP=\"$(OBJDUMP)\"" >> $(EXPORTDIR)/makeinfo.sh @echo "OBJEXT=\"$(OBJEXT)\"" >> $(EXP

Re: [PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
acassis commented on PR #11908: URL: https://github.com/apache/nuttx/pull/11908#issuecomment-199483 > @acassis the CI is broken but I cannot see how it is related to my changes... Any idea? It is going fine now -- This is an automated message from the Apache Git Service. To res

Re: [PR] mt_config_fs : update nvs to support align size [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 merged PR #11886: URL: https://github.com/apache/nuttx/pull/11886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 01/02: mtd_config_fs : support algin size

2024-03-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit cd80900646dbade1874973e757618d0ea07ca94b Author: xucheng5 AuthorDate: Fri Dec 15 17:59:39 2023 +0800 mtd_config_f

(nuttx) branch master updated (ea7dbdc8ac -> 3b79363041)

2024-03-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ea7dbdc8ac risc-v/k230: fix k230_hart_is_big issue new cd80900646 mtd_config_fs : support algin size new 3

(nuttx) 02/02: mtd_config_fs : optimize nvs

2024-03-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3b7936304183d505f15a3a270fc39277f9da8e60 Author: xucheng5 AuthorDate: Wed Dec 20 11:45:27 2023 +0800 mtd_config_f

(nuttx) branch master updated: risc-v/k230: fix k230_hart_is_big issue

2024-03-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new ea7dbdc8ac risc-v/k230: fix k230_hart_is_big i

Re: [PR] risc-v/k230: fix k230_hart_is_big issue [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 merged PR #11911: URL: https://github.com/apache/nuttx/pull/11911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [I] PolarFire SoC - C++ Exception Exits Before Catch [nuttx]

2024-03-13 Thread via GitHub
sastel commented on issue #11912: URL: https://github.com/apache/nuttx/issues/11912#issuecomment-1994553777 ### Scripts for Debugging with GDB and Renode Here is what I've been using to debug this: These scripts go in `nuttxspace/nuttx`. ``` $ cat gdb.sc target remote :

[I] PolarFire SoC - C++ Exception Exits Before Catch [nuttx]

2024-03-13 Thread via GitHub
sastel opened a new issue, #11912: URL: https://github.com/apache/nuttx/issues/11912 ### Summary On the PolarFire Icicle board, when building from `master` with a config based on `icicle:nsh` (plus config and flag changes detailed below), the cxxtest built-in app exception test fails. It

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
lupyuen commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1994536829 @rushabhvg Let's discuss over email: lu...@appkaki.com. I'm in Singapore (GMT+8) so my response may be slow. Thanks :-) -- This is an automated message from the Apache Git Service.

(nuttx) branch master updated (e93bdfe089 -> 3956a52c58)

2024-03-13 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e93bdfe089 tun: in tun_write, try to release iob before iob_prepare add 3956a52c58 net/tcp: return true only when

Re: [PR] net/tcp: return true only when send window updates [nuttx]

2024-03-13 Thread via GitHub
anchao merged PR #11909: URL: https://github.com/apache/nuttx/pull/11909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) branch master updated: tun: in tun_write, try to release iob before iob_prepare

2024-03-13 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e93bdfe089 tun: in tun_write, try to release iob

Re: [PR] tun: in tun_write, try to release iob before iob_prepare [nuttx]

2024-03-13 Thread via GitHub
anchao merged PR #11910: URL: https://github.com/apache/nuttx/pull/11910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
rushabhvg commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1994494960 Hello @lupyuen then maybe I can start with Rust Apps for Nuttx? How should we communicate? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
leducp commented on PR #11908: URL: https://github.com/apache/nuttx/pull/11908#issuecomment-1994378188 @acassis the CI is broken but I cannot see how it is related to my changes... Any idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] tun: in tun_write, try to release iob before iob_prepare [nuttx]

2024-03-13 Thread via GitHub
zhhyu7 opened a new pull request, #11910: URL: https://github.com/apache/nuttx/pull/11910 ## Summary io_pktlen will incorrect when two packets are received in a row and the packet length decreases. ## Impact ## Testing sim:local -- This is an automated message from

[PR] net/tcp: return true only when send window updates [nuttx]

2024-03-13 Thread via GitHub
zhhyu7 opened a new pull request, #11909: URL: https://github.com/apache/nuttx/pull/11909 ## Summary return true even when window has not changed will cause delayed ack cannot take effect. ## Impact ## Testing sim:local and cortex-m33 -- This is an automated messag

Re: [PR] cmake: Temporary modification, just to verify the CI results [nuttx]

2024-03-13 Thread via GitHub
zhhyu7 closed pull request #11661: cmake: Temporary modification, just to verify the CI results URL: https://github.com/apache/nuttx/pull/11661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Improve export by adding NuttX current target (arch, chip, board) [nuttx]

2024-03-13 Thread via GitHub
leducp opened a new pull request, #11908: URL: https://github.com/apache/nuttx/pull/11908 ## Summary Add variables that describe NuttX current build (board, arch, chip) Fix export: startups files are not added at link step ## Impact ## Testing picopi:usbnsh with an exte

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-13 Thread via GitHub
anchao commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1993892062 > > OK. I understand that sim:citest needs [apache/nuttx-apps#2329](https://github.com/apache/nuttx-apps/pull/2329). > > I confirmed that this PR works with the above PR in apps.

(nuttx) branch master updated: sched/pthread/join: refactor pthread join to support join task

2024-03-13 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new df30a1f8d3 sched/pthread/join: refactor pthread

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-13 Thread via GitHub
masayuki2009 commented on PR #11898: URL: https://github.com/apache/nuttx/pull/11898#issuecomment-1993872567 > OK. I understand that sim:citest needs https://github.com/apache/nuttx-apps/pull/2329. I confirmed that this PR works with the above PR in apps. -- This is an automated me

Re: [PR] sched/pthread/join: refactor pthread join to support join task [nuttx]

2024-03-13 Thread via GitHub
masayuki2009 merged PR #11898: URL: https://github.com/apache/nuttx/pull/11898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx

(nuttx-apps) branch master updated: testing/ostest/cancel: joining a detached/canceled thread should return EINVAL, not ESRCH

2024-03-13 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 69e497f68 testing/ostest/cancel: joining a

Re: [PR] testing/ostest/cancel: joining a detached/canceled thread should return EINVAL, not ESRCH [nuttx-apps]

2024-03-13 Thread via GitHub
masayuki2009 merged PR #2329: URL: https://github.com/apache/nuttx-apps/pull/2329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
lupyuen commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1993843863 Yep sure let's have a chat. I'm more into Rust Apps for NuttX, not so much Rust Kernel for NuttX. But let's talk :-) (Linux Kernel Rust might be a good model to adopt) -- Th

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
ppisa commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1993825274 I think that it would worth to discuss Rust on NuttX with @lupyuen https://lupyuen.github.io/ . I have seen lot of useful information on his site. -- This is an automated message fr

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-13 Thread via GitHub
ppisa commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993816633 > > As for the TWAI code changes, I ma not sure if to change identifier of the type `struct can_bittiming_const` to `to struct sja1000_can_bittiming_const`. > > This prefix was added

Re: [PR] drivers/can/sja1000: Add SJA1000 CAN driver support [nuttx]

2024-03-13 Thread via GitHub
ppisa commented on PR #11868: URL: https://github.com/apache/nuttx/pull/11868#issuecomment-1993800133 > > I expect that you use code with our old SJA1000 FD tolerant design https://gitlab.fel.cvut.cz/canbus/zynq/sja1000-fdtol . I have no time to look at it for years but if you have some enh

Re: [PR] paging: Rename existing CONFIG_PAGING to CONFIG_LEGACY_PAGING and implement page-fault exception and on-demand paging for RISC-V [nuttx]

2024-03-13 Thread via GitHub
lupyuen commented on PR #11824: URL: https://github.com/apache/nuttx/pull/11824#issuecomment-1993793590 @yf13 That looks interesting, though I'm seeing different problems on Ox64: https://github.com/lupyuen2/wip-pinephone-nuttx/blob/on-demand-paging3/README.md#on-demand-paging-stuck-at-0x800

Re: [PR] paging: Rename existing CONFIG_PAGING to CONFIG_LEGACY_PAGING and implement page-fault exception and on-demand paging for RISC-V [nuttx]

2024-03-13 Thread via GitHub
yf13 commented on PR #11824: URL: https://github.com/apache/nuttx/pull/11824#issuecomment-1993784782 @tmedicci Sorry for my late update here, my test with `CONFIG_PAGING=y` doesn't work yet and here is the back trace I collected: ``` #0 _assert (filename=0x704b778 "semaphore/sem_w

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
xiaoxiang781216 commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1993754086 NuttX doesn't support Rust yet, that's why no Rust coding standard exist in official document. As far as I know, Rust defines an official coding standard, so I would sugge

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2024-03-13 Thread via GitHub
rushabhvg commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-1993700202 @xiaoxiang781216 @anchao @raiden00pl Please give your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub