[PR] Remove some macro, merge two header files , add bit flags and add LIN bus-type [nuttx]

2024-08-19 Thread via GitHub
HedongGao opened a new pull request, #13048: URL: https://github.com/apache/nuttx/pull/13048 ## Summary 1. Some macro definitions have already been defined in other header files, redundant macro definitions have been removed, and the code has been optimized. 2. To align with the la

Re: [PR] Remove some macro, merge two header files , add bit flags and add LIN bus-type [nuttx]

2024-08-19 Thread via GitHub
HedongGao closed pull request #13015: Remove some macro, merge two header files , add bit flags and add LIN bus-type URL: https://github.com/apache/nuttx/pull/13015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] nuttx-names.in:add popen & pclose assign to glibc interface [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13047: URL: https://github.com/apache/nuttx/pull/13047 ## Summary modified reason:The library function used by simwifi (host_stystem) to call the popen interface (nuttx's library function) is inconsistent with the library function used to call th

(nuttx-apps) branch master updated (bdc0c006b -> 913792c7b)

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from bdc0c006b lvgl/Makefile: add LV_SYSMON_GET_IDLE and LV_PROFILER porting add 5165ad842 lvgl/cmake: link ext

Re: [PR] Graphics cmakelists [nuttx-apps]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #2495: URL: https://github.com/apache/nuttx-apps/pull/2495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[PR] netdev/ioctl: Setting log level to warning on SIOCGIFHWADDR failure [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13046: URL: https://github.com/apache/nuttx/pull/13046 ## Summary When our apps call getifaddrs on lo frequently, the loopback device will failed in SIOCGIFHWADDR and print too many error logs. ## Impact netdev ioctl ## Testing Manual

(nuttx) branch master updated: wifi_sim.c:fix compile warning

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a18aebc2c6 wifi_sim.c:fix compile warning a18a

Re: [PR] wifi_sim.c:fix compile warning [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #13032: URL: https://github.com/apache/nuttx/pull/13032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] localsocket improvment [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13045: URL: https://github.com/apache/nuttx/pull/13045 ## Summary For udp localsocket current implementation,the sent information only carries the packet info. The receiver receives the information,it don't know who the information comes from.

Re: [PR] netutils/webclient: Fix bug that the socket is not close [nuttx-apps]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on PR #2501: URL: https://github.com/apache/nuttx-apps/pull/2501#issuecomment-2298080465 > Hi @xiaoxiang781216 , @acassis > > Strictly regarding the [C Coding Standard](https://nuttx.apache.org/docs/latest/contributing/coding_style.html), is stated that the:

[PR] apps/audioutils:Add libmad library. [nuttx-apps]

2024-08-19 Thread via GitHub
cuiziwei1 opened a new pull request, #2510: URL: https://github.com/apache/nuttx-apps/pull/2510 ## Summary libmad0-dev and libmad0-dev:i386 cannot be installed simultaneously, which causes conflicts when compiling sim m32 and sim m64. Therefore, the libmad library has been ported to apps

Re: [PR] video/fb: changed circbuf_write assert to warning [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on PR #13030: URL: https://github.com/apache/nuttx/pull/13030#issuecomment-2298072860 Could you please explain more about this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

(nuttx) branch master updated (5fedb1e6de -> 3c4897310b)

2024-08-19 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5fedb1e6de tcp_timer.c:solve Problem of parameter calculation exceeding the boundary add 3c4897310b tcp_in

Re: [PR] tcp_input: if tcp->req > recvreq, send ack only when state is TCP_ESTABLISHED [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko merged PR #12999: URL: https://github.com/apache/nuttx/pull/12999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

Re: [PR] Basic Atomic for NuttX [nuttx]

2024-08-19 Thread via GitHub
xuxin930 commented on code in PR #13044: URL: https://github.com/apache/nuttx/pull/13044#discussion_r1722756066 ## libs/libc/machine/CMakeLists.txt: ## @@ -20,6 +20,6 @@ add_subdirectory(${CONFIG_ARCH}) -if(CONFIG_LIBC_ARCH_ATOMIC) - target_sources(c PRIVATE arch_atomic.c)

Re: [PR] fix build warning to [-Wstringop-overread]. [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on PR #12988: URL: https://github.com/apache/nuttx/pull/12988#issuecomment-2298063949 Please squash the chnages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] simwifi: Add the netlink event of connect/disconnect. [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on code in PR #13042: URL: https://github.com/apache/nuttx/pull/13042#discussion_r1722751101 ## arch/sim/src/sim/sim_wifidriver.c: ## @@ -964,6 +1000,59 @@ static int freq_to_channel(uint16_t freq) return OK; } +static int wifi_send_event(FAR struct

Re: [PR] libc/msic:Implement get_nprocs API [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on code in PR #13013: URL: https://github.com/apache/nuttx/pull/13013#discussion_r1722746921 ## libs/libc/misc/lib_getnprocs.c: ## @@ -0,0 +1,79 @@ +/ + * libs/libc/misc/lib_getnp

Re: [PR] netutils/webclient: Fix bug that the socket is not close [nuttx-apps]

2024-08-19 Thread via GitHub
LuchianMihai commented on PR #2501: URL: https://github.com/apache/nuttx-apps/pull/2501#issuecomment-2298051446 Strictly regarding the [C Coding Standard](https://nuttx.apache.org/docs/latest/contributing/coding_style.html), is stated that the: > Comments to the right of statements i

Re: [PR] nuttx/audio: add offload buffer size config [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on code in PR #13005: URL: https://github.com/apache/nuttx/pull/13005#discussion_r1722732972 ## arch/sim/src/sim/posix/sim_alsa.c: ## @@ -462,9 +462,16 @@ static int sim_audio_configure(struct audio_lowerhalf_s *dev, priv->sample_rate = caps->

Re: [PR] Add ioctl for SIOCGETCONTEXT and SIOCSETCONTEXT [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on code in PR #13027: URL: https://github.com/apache/nuttx/pull/13027#discussion_r1722726825 ## include/nuttx/net/net.h: ## @@ -253,6 +253,26 @@ struct socket FAR const struct sock_intf_s *s_sockif; }; +struct socket_ctx_data_s +{ + uint8_t s_dom

Re: [PR] [Documentation/platforms/xtensa/esp32s3/boards|boards/xtensa/esp32s3]Document and Defconfig for Esp32s3 Sdmmc Support [nuttx]

2024-08-19 Thread via GitHub
Windrow14 commented on PR #13035: URL: https://github.com/apache/nuttx/pull/13035#issuecomment-2298024052 Hi @tmedicci, Sorry to bother you. Could you please verify the default configuration on esp32s3-korvo-2 in your spare time? Many thanks! -- This is an automated message from the Ap

Re: [PR] 12K sample rate support [nuttx]

2024-08-19 Thread via GitHub
jinxiuxu commented on PR #13002: URL: https://github.com/apache/nuttx/pull/13002#issuecomment-2298022823 > @jinxiuxu please fix the issue: > > ``` > audio/cs43l22.c: In function 'cs43l22_getcaps': > Error: audio/cs43l22.c:584:17: error: unsigned conversion from 'int' to 'uint8_

Re: [PR] fix issue about unable to retrieve the next callback after the callback has been deleted [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 closed pull request #13039: fix issue about unable to retrieve the next callback after the callback has been deleted URL: https://github.com/apache/nuttx/pull/13039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] mod devif_dev_callback_free to devif_callback_free [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 closed pull request #13040: mod devif_dev_callback_free to devif_callback_free URL: https://github.com/apache/nuttx/pull/13040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

(nuttx) branch master updated (e15100543f -> 5fedb1e6de)

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e15100543f lib_remove.c:fix code style error add 5fedb1e6de tcp_timer.c:solve Problem of parameter calculation

Re: [PR] solve Problem of tcp parameter calculation exceeding the boundary [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #13029: URL: https://github.com/apache/nuttx/pull/13029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (e6962942cb -> e15100543f)

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e6962942cb net/pkt: fix raw socket send data length is insufficient. new 0a4770b44a lib_remove:Repair the logic

(nuttx) 01/02: lib_remove:Repair the logical judgment

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 0a4770b44a36d64273ba2e5aa9482bdbf011b0b8 Author: chenrun1 AuthorDate: Thu Jul 11 16:44:17 2024 +0800 lib_remove:R

(nuttx) 02/02: lib_remove.c:fix code style error

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit e15100543fa78d4827e6b7e2c8eb58c10380e29f Author: chenrun1 AuthorDate: Tue Aug 20 10:34:44 2024 +0800 lib_remove.c

Re: [PR] lib_remove:Repair the logical judgment [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #12966: URL: https://github.com/apache/nuttx/pull/12966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Fslock optimize [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on PR #12969: URL: https://github.com/apache/nuttx/pull/12969#issuecomment-2298017101 > > if you want, we can add an option to skip the allocation and return NULL directly if the usage exceeds CONFIG_LIBC_MAX_PATHBUFFER. > > Yeah that sounds more logical to m

(nuttx) branch master updated: net/pkt: fix raw socket send data length is insufficient.

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e6962942cb net/pkt: fix raw socket send data l

Re: [PR] net/pkt: fix raw socket send data length is insufficient [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #13010: URL: https://github.com/apache/nuttx/pull/13010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx-apps) branch master updated: lvgl/Makefile: add LV_SYSMON_GET_IDLE and LV_PROFILER porting

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new bdc0c006b lvgl/Makefile: add LV_SYSMON_GE

Re: [PR] lvgl/Makefile: add LV_SYSMON_GET_IDLE and LV_PROFILER porting [nuttx-apps]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #2507: URL: https://github.com/apache/nuttx-apps/pull/2507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #13033: URL: https://github.com/apache/nuttx/pull/13033#discussion_r1722710401 ## net/tcp/Kconfig: ## @@ -93,7 +93,7 @@ config NET_TCP_MAX_CONNS config NET_TCP_NPOLLWAITERS int "Number of TCP poll waiters" - default 1 + defau

Re: [PR] build: Fix rpserver and rpproxy CMake builds [nuttx-apps]

2024-08-19 Thread via GitHub
Jasinsky commented on PR #2508: URL: https://github.com/apache/nuttx-apps/pull/2508#issuecomment-2297994946 @xiaoxiang781216 @xuxin930 - Thank you for your suggestion, applied - df744eb -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] build: Fix rpserver and rpproxy CMake builds [nuttx-apps]

2024-08-19 Thread via GitHub
Jasinsky commented on code in PR #2508: URL: https://github.com/apache/nuttx-apps/pull/2508#discussion_r1722704841 ## system/argtable3/CMakeLists.txt: ## @@ -82,6 +82,11 @@ if(CONFIG_SYSTEM_ARGTABLE3) target_sources(argtable3 PRIVATE ${SRCS}) if(NOT EXISTS ${CMAKE_BINARY

Re: [PR] sched/sched: simplify the implementation of the function nxsched_readytorun_setpriority [nuttx]

2024-08-19 Thread via GitHub
hujun260 commented on PR #13017: URL: https://github.com/apache/nuttx/pull/13017#issuecomment-2297992627 > @hujun260 How did you test the change? As far as I have investigated, the ostest does not test the function. The bug was found during our internal monkey testing. In some cases,

Re: [PR] mod devif_dev_callback_free to devif_callback_free [nuttx]

2024-08-19 Thread via GitHub
anchao commented on PR #13040: URL: https://github.com/apache/nuttx/pull/13040#issuecomment-2297956222 merge to https://github.com/apache/nuttx/pull/13036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] devif:fix issue about devif_callback being released wrongly,resulting in no access to it [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #13036: URL: https://github.com/apache/nuttx/pull/13036#discussion_r1722673230 ## net/devif/devif_callback.c: ## @@ -165,6 +143,48 @@ static void devif_callback_free(FAR struct net_driver_s *dev, } } + /* check if the

Re: [PR] nuttx/note:fix runtime error. [nuttx]

2024-08-19 Thread via GitHub
cuiziwei1 closed pull request #12984: nuttx/note:fix runtime error. URL: https://github.com/apache/nuttx/pull/12984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] note:fix build error. [nuttx]

2024-08-19 Thread via GitHub
cuiziwei1 closed pull request #12982: note:fix build error. URL: https://github.com/apache/nuttx/pull/12982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] note:unified note filtering at runtime. [nuttx]

2024-08-19 Thread via GitHub
cuiziwei1 closed pull request #12979: note:unified note filtering at runtime. URL: https://github.com/apache/nuttx/pull/12979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Basic Atomic for NuttX [nuttx]

2024-08-19 Thread via GitHub
crafcat7 opened a new pull request, #13044: URL: https://github.com/apache/nuttx/pull/13044 ## Summary 1. Added stdatomic for NuttX. When the compiler version is lower than C11/C++17 and Atomic functions are needed, the NuttX stdatomic version will provide atomic support. This is a wrapp

[PR] nuttx/sim:By default, stack-use-after-return is not checked when enabling SIM_ASAN. [nuttx]

2024-08-19 Thread via GitHub
cuiziwei1 opened a new pull request, #13043: URL: https://github.com/apache/nuttx/pull/13043 ## Summary ==263401==ERROR: AddressSanitizer: stack-use-after-return on address 0xf515f260 at pc 0x042434f0 bp 0x9ac24e78 sp 0x9ac24e68 WRITE of size 4 at 0xf515f260 thread T0 #0 0x42434ef

[PR] simwifi: Add the netlink event of connect/disconnect. [nuttx]

2024-08-19 Thread via GitHub
liqinhuixm opened a new pull request, #13042: URL: https://github.com/apache/nuttx/pull/13042 ## Summary Add the netlink event of connect/disconnect for the simwifi function. ## Impact N/A ## Testing The app can receive the corresponding netlink event when the wifi is connect

[PR] arch/EXTRA_LIBS: link all staging library. [nuttx]

2024-08-19 Thread via GitHub
cuiziwei1 opened a new pull request, #13041: URL: https://github.com/apache/nuttx/pull/13041 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] fix build warning to [-Wstringop-overflow=]. [nuttx-apps]

2024-08-19 Thread via GitHub
cuiziwei1 opened a new pull request, #2509: URL: https://github.com/apache/nuttx-apps/pull/2509 ## Summary mbedtls/library/alignment.h:98:5: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow=] 98 | memcpy(p, &x, sizeof(x)); | ^~~~

Re: [PR] netutils/webclient: Fix bug that the socket is not close [nuttx-apps]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on PR #2501: URL: https://github.com/apache/nuttx-apps/pull/2501#issuecomment-2297893398 @acassis and @LuchianMihai does https://github.com/apache/nuttx/pull/12794 change good? -- This is an automated message from the Apache Git Service. To respond to the message

[PR] fix issue about unable to retrieve the next callback after the callback has been deleted [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13039: URL: https://github.com/apache/nuttx/pull/13039 ## Summary devif_callback ## Impact devif callback ## Testing Manual verification -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] usbdev: add USB cdcncm device driver [nuttx]

2024-08-19 Thread via GitHub
zhhyu7 commented on code in PR #12914: URL: https://github.com/apache/nuttx/pull/12914#discussion_r1722634403 ## boards/sim/sim/sim/src/sim_composite.c: ## @@ -210,6 +211,61 @@ static void *board_composite1_connect(int port) return composite_initialize(composite_getdevdescs()

[PR] netdb:netdb code support ffmpeg rtsp(getaddrinfo & getnameinfo) [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13038: URL: https://github.com/apache/nuttx/pull/13038 ## Summary Related Codes: 1.ffmpeg/libavformat/ip.c struct addrinfo *ff_ip_resolve_host(void *log_ctx, const char *hostname, int port,

Re: [PR] mmcsd_sdio:Fix performing read and write in irq [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on PR #12971: URL: https://github.com/apache/nuttx/pull/12971#issuecomment-2297881104 > > This is an optional feature. If you don't invoke write/read inside the irq context, the code still calls nxsig_sleep as before withouut any change. So, I don't see any blockin

Re: [PR] usbdev: add USB cdcncm device driver [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12914: URL: https://github.com/apache/nuttx/pull/12914#discussion_r1722627818 ## boards/sim/sim/sim/src/sim_composite.c: ## @@ -210,6 +211,61 @@ static void *board_composite1_connect(int port) return composite_initialize(composite_getdevdescs()

Re: [PR] [Documentation/platforms/xtensa/esp32s3/boards|boards/xtensa/esp32s3]Document and Defconfig for Esp32s3 Sdmmc Support [nuttx]

2024-08-19 Thread via GitHub
Windrow14 commented on PR #13035: URL: https://github.com/apache/nuttx/pull/13035#issuecomment-2297876994 @JackyCaoYJ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] devif:fix issue about devif_callback being released wrongly,resulting in no access to it [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13036: URL: https://github.com/apache/nuttx/pull/13036 ## Summary modified reason:tcp_shutdown_monitor releases the callback related to the TCP connection. the callback is to be executed nextly by devif_dev_event, therefore devif_dev_event have n

[PR] [Documentation/platforms/xtensa/esp32s3/boards|boards/xtensa/esp32s3]Document and Defconfig for Esp32s3 Sdmmc Support [nuttx]

2024-08-19 Thread via GitHub
Windrow14 opened a new pull request, #13035: URL: https://github.com/apache/nuttx/pull/13035 ## Summary Add documentations and default configurations for sdmmc support feature on esp32s3. See details at https://github.com/apache/nuttx/pull/12898#issuecomment-2296478840. ##

[PR] sim: read the second buffer [nuttx]

2024-08-19 Thread via GitHub
jianglianfang opened a new pull request, #13034: URL: https://github.com/apache/nuttx/pull/13034 ## Summary It can only read the contents of the first buffer, so fblen should be changed to ensure that it can read the second buffer as well. ## Impact sim ## Testing run sim lvgl

[PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13033: URL: https://github.com/apache/nuttx/pull/13033 ## Summary 1.set NET_TCP_NPOLLWAITERS default value from 1 to 2 2. add warning of different events having same event bit ## Impact TCP number of poll to the same fd ## Testing M

Re: [PR] net/pkt: fix raw socket send data length is insufficient [nuttx]

2024-08-19 Thread via GitHub
zhhyu7 commented on PR #13010: URL: https://github.com/apache/nuttx/pull/13010#issuecomment-2297870206 Thanks for the correction, my verification was based on netdev_upperhalf and did not expose this problem... -- This is an automated message from the Apache Git Service. To respond to the

[PR] wifi_sim.c:fix compile warning [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13032: URL: https://github.com/apache/nuttx/pull/13032 ## Summary fix wifi sim compile warning ## Impact wifi sims ## Testing Manual verification -- This is an automated message from the Apache Git Service. To respond to the mess

[PR] video/fb: changed circbuf_write assert to warning [nuttx]

2024-08-19 Thread via GitHub
jianglianfang opened a new pull request, #13030: URL: https://github.com/apache/nuttx/pull/13030 ## Summary changed circbuf_write assert to warning ## Impact fb ## Testing fb demo -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] solve Problem of tcp parameter calculation exceeding the boundary [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13029: URL: https://github.com/apache/nuttx/pull/13029 ## Summary solve Problem of tcp parameter calculation exceeding the boundary ## Impact curl download files ## Testing Manual verification -- This is an automated message from

Re: [PR] lib_remove:Repair the logical judgment [nuttx]

2024-08-19 Thread via GitHub
crafcat7 commented on PR #12966: URL: https://github.com/apache/nuttx/pull/12966#issuecomment-2297853066 > @crafcat7 please fix the style error. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [HELP] FFI compatiblity issues [nuttx]

2024-08-19 Thread via GitHub
lupyuen commented on issue #12960: URL: https://github.com/apache/nuttx/issues/12960#issuecomment-2297852945 @no1wudi That's great thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [HELP] FFI compatiblity issues [nuttx]

2024-08-19 Thread via GitHub
no1wudi commented on issue #12960: URL: https://github.com/apache/nuttx/issues/12960#issuecomment-2297851591 @lupyuen I can add it to the Rust side as https://github.com/rust-lang/rust/pull/127755 does in next patch -- This is an automated message from the Apache Git Service. To respond t

[PR] net_chksum.c:mod process of generating sum to solve checksum error [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13028: URL: https://github.com/apache/nuttx/pull/13028 ## Summary mod process of generating sum to solve checksum error ## Impact packet checksum ## Testing Manual verification -- This is an automated message from the Apache Git

Re: [PR] libc/msic:Implement get_nprocs API [nuttx]

2024-08-19 Thread via GitHub
crafcat7 commented on PR #13013: URL: https://github.com/apache/nuttx/pull/13013#issuecomment-2297845240 > 1. Why do we need to change from macro to function? In some test scenario requirements, it is expected to find a specific function implementation to obtain nproc.So I turned it i

(nuttx) branch master updated: arm: Fix DS1307 initialization for common STM32 logic

2024-08-19 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 86c2e429eb arm: Fix DS1307 initialization for

Re: [PR] arm: Fix DS1307 initialization for common STM32 logic [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 merged PR #13024: URL: https://github.com/apache/nuttx/pull/13024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] Add ioctl for SIOCGETCONTEXT and SIOCSETCONTEXT [nuttx]

2024-08-19 Thread via GitHub
SPRESENSE opened a new pull request, #13027: URL: https://github.com/apache/nuttx/pull/13027 ## Summary Add ioctl for SIOCGETCONTEXT and SIOCSETCONTEXT. These ioctl are for getting and setting the socket context held by the usrsock daemon. ## Impact No impact #

Re: [PR] build: Fix rpserver and rpproxy CMake builds [nuttx-apps]

2024-08-19 Thread via GitHub
xuxin930 commented on PR #2508: URL: https://github.com/apache/nuttx-apps/pull/2508#issuecomment-2297825601 hi @Jasinsky @xiaoxiang781216 nice catch! argtable3/src is set by Make.defs and takes effect in the whole context of apps. lets make it takes effect globally in CMake by. ```c

Re: [I] [HELP] FFI compatiblity issues [nuttx]

2024-08-19 Thread via GitHub
lupyuen commented on issue #12960: URL: https://github.com/apache/nuttx/issues/12960#issuecomment-2297821720 @no1wudi Thanks that sounds good! > if we use `bindgen` solution for `libc`, the entire `libstd` and `libc` need to be build from source with a configured NuttX source tree by

Re: [PR] tcp_input: if tcp->req > recvreq, send ack only when state is TCP_ESTABLISHED [nuttx]

2024-08-19 Thread via GitHub
Meissi-jian commented on code in PR #12999: URL: https://github.com/apache/nuttx/pull/12999#discussion_r1722592143 ## net/tcp/tcp_input.c: ## @@ -1178,7 +1178,7 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain, return; }

[PR] modify the type of the ipv6 parameters to solve runtime error [nuttx]

2024-08-19 Thread via GitHub
wangchen61698 opened a new pull request, #13026: URL: https://github.com/apache/nuttx/pull/13026 ## Summary modify the type of the ipv6 parameters to solve runtime error ## Impact ipv6 ping ## Testing ![image](https://github.com/user-attachments/assets/fee0234a-abd3-4137-976f-

[PR] libc/netdb: Separate IPv4 and IPv6 cache size limit [nuttx]

2024-08-19 Thread via GitHub
SPRESENSE opened a new pull request, #13025: URL: https://github.com/apache/nuttx/pull/13025 ## Summary Some domains have a lot of IPv6 addresses. Because of that, it is not possible to get the IPv4 address with getaddrinfo. This change separate IPv4 and IPv6 cache size limit to enable

Re: [PR] testing/ostest: add nxevent test into ostest [nuttx-apps]

2024-08-19 Thread via GitHub
anchao commented on PR #2458: URL: https://github.com/apache/nuttx-apps/pull/2458#issuecomment-2297818012 > Does it require to adjust testing/ostest/CMakeLists.txt as well? Yes, thanks for review, addressed. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722588430 ## sched/event/event_wait.c: ## @@ -0,0 +1,190 @@ +/ + * sched/event/event_wait.c + * + * Lic

Re: [I] [HELP] FFI compatiblity issues [nuttx]

2024-08-19 Thread via GitHub
no1wudi commented on issue #12960: URL: https://github.com/apache/nuttx/issues/12960#issuecomment-2297806061 @lupyuen @acassis Thanks for your feedback! In my opinion, `bindgen` is very suitable for further package since `libstd` and `libc` only provide the standard library, for the

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722578547 ## sched/event/event_post.c: ## @@ -0,0 +1,155 @@ +/ + * sched/event/event_post.c + * + * Lic

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722578431 ## sched/event/event_wait.c: ## @@ -0,0 +1,191 @@ +/ + * sched/event/event_wait.c + * + * Lic

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722578348 ## sched/event/event_wait.c: ## @@ -0,0 +1,191 @@ +/ + * sched/event/event_wait.c + * + * Lic

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722577803 ## sched/event/event_wait.c: ## @@ -0,0 +1,191 @@ +/ + * sched/event/event_wait.c + * + * Lic

Re: [PR] sched/nxevent: add support of kernel event group [nuttx]

2024-08-19 Thread via GitHub
anchao commented on code in PR #12802: URL: https://github.com/apache/nuttx/pull/12802#discussion_r1722577091 ## sched/event/event_wait.c: ## @@ -0,0 +1,191 @@ +/ + * sched/event/event_wait.c + * + * Lic

Re: [PR] mmcsd_sdio:Fix performing read and write in irq [nuttx]

2024-08-19 Thread via GitHub
xiaoxiang781216 commented on code in PR #12971: URL: https://github.com/apache/nuttx/pull/12971#discussion_r1722565520 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -98,6 +98,19 @@ #define MMCSD_CAPACITY(b, s)((s) >= 10 ? (b) << ((s) - 10) : (b) >> (10 - (s))) +#define MMCSD_US

Re: [PR] fix compile error [nuttx]

2024-08-19 Thread via GitHub
hujun260 closed pull request #13016: fix compile error URL: https://github.com/apache/nuttx/pull/13016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

Re: [PR] netutils/webclient: Fix bug that the socket is not close [nuttx-apps]

2024-08-19 Thread via GitHub
SPRESENSE commented on PR #2501: URL: https://github.com/apache/nuttx-apps/pull/2501#issuecomment-229492 @jerpelea @xiaoxiang781216 I have fixed the style issue. Please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [BUG] sim:citest doesn't compile [nuttx]

2024-08-19 Thread via GitHub
lvanasse commented on issue #12974: URL: https://github.com/apache/nuttx/issues/12974#issuecomment-2297749380 > sim:citest build on pr, please compare your toolchain with: https://ghcr.io/apache/nuttx/apache-nuttx-ci-linux @xiaoxiang781216 I am sorry, and I don't want to look uncooper

[PR] arm: Fix DS1307 initialization for common STM32 logic [nuttx]

2024-08-19 Thread via GitHub
rcsim opened a new pull request, #13024: URL: https://github.com/apache/nuttx/pull/13024 ## Summary Fix DS1307 initialization for common STM32 logic ## Impact Users will be able to build using DS1307 and STM32 common logic. ## Testing - Add DS1307 on bringup for testing

Re: [PR] sched/sched: simplify the implementation of the function nxsched_readytorun_setpriority [nuttx]

2024-08-19 Thread via GitHub
masayuki2009 commented on PR #13017: URL: https://github.com/apache/nuttx/pull/13017#issuecomment-2297670677 @hujun260 How did you test the change? As far as I have investigated, the ostest does not test the function. -- This is an automated message from the Apache Git Service. To

Re: [PR] irq: remove restore_critical_section in irq [nuttx]

2024-08-19 Thread via GitHub
masayuki2009 commented on PR #12935: URL: https://github.com/apache/nuttx/pull/12935#issuecomment-2297652247 @hujun260 Hmm, the commit is still not divided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(nuttx) branch master updated (4b5585a316 -> 4d4d8a6ca5)

2024-08-19 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4b5585a316 netdev/upper: Delay replied packets to prevent TX quota become negated add 4d4d8a6ca5 arch/risc

Re: [I] [BUG] is it typo in esp_wifi_adapter.c ? (ESP32C3) [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko closed issue #13014: [BUG] is it typo in esp_wifi_adapter.c ? (ESP32C3) URL: https://github.com/apache/nuttx/issues/13014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] arch/risc-v/esp32c3: fix AP password memcpy typo [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko merged PR #13023: URL: https://github.com/apache/nuttx/pull/13023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

(nuttx) branch master updated: netdev/upper: Delay replied packets to prevent TX quota become negated

2024-08-19 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4b5585a316 netdev/upper: Delay replied packets to

Re: [PR] netdev/upper: Delay replied packets to prevent TX quota become negated [nuttx]

2024-08-19 Thread via GitHub
anchao merged PR #13008: URL: https://github.com/apache/nuttx/pull/13008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] netlib/route: add length for add/del route-func to reduce caller stack usage [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on code in PR #12994: URL: https://github.com/apache/nuttx/pull/12994#discussion_r1722339029 ## libs/libc/net/lib_addroute.c: ## @@ -47,24 +47,24 @@ * netmask - Network mask defining the external network (required) * router - Router address tha

Re: [PR] espressif: Update internal libraries reference [nuttx]

2024-08-19 Thread via GitHub
pkarashchenko commented on code in PR #13022: URL: https://github.com/apache/nuttx/pull/13022#discussion_r1722335935 ## arch/xtensa/src/esp32/esp32_wireless.c: ## @@ -351,6 +351,85 @@ static void esp_wifi_set_log_level(void) * Public Functions ***

  1   2   3   >