Gary-Hobson commented on PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#issuecomment-2316852165
> > @anchao Do you mean leave_critical_section before all malloc/free?
> > This has been modified, but the functionality of this method seems to
have no difference Because of the ch
yamt commented on PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#issuecomment-2316808622
> Can you also enable SMP for the `psram` defconfig`, please?
why?
how about psram_usrheap?
--
This is an automated message from the Apache Git Service.
To respond to the message,
gneworld commented on PR #13215:
URL: https://github.com/apache/nuttx/pull/13215#issuecomment-2316796986
> Please fill the Summary/Impact/Testing fields. Please include explanation
why to replace CMD12 with CMD23, what is the needs or advantage of doing it.
OK, I will add it in the ne
gneworld commented on PR #13212:
URL: https://github.com/apache/nuttx/pull/13212#issuecomment-2316796426
> @gneworld Please name your PRs so that title is meaningful, Add Summary
that answers: both What and Why,
>
> i.e. Title: stm32:Fix timer race Summary The change reorders the
LuchianMihai commented on PR #2459:
URL: https://github.com/apache/nuttx-apps/pull/2459#issuecomment-2316794776
> @LuchianMihai did you have time to convert the driver to video/camera
interface? Case you don't, maybe we should merge it as normal driver, because
is better to have a driver an
metarutaiga opened a new issue, #13230:
URL: https://github.com/apache/nuttx/issues/13230
### Description
I tested LUATOS ESP32C3 and ESP32-C3-mini
I tried these
1. boardctl(BOARDIOC_RESET, 0);
2. esp_restart();
3. esp_rom_software_reset_cpu(0);
But it sleep alwa
anchao commented on code in PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#discussion_r1735560891
##
sched/task/task_setup.c:
##
@@ -155,14 +170,23 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb)
for (i = 0; i < g_npidhash / 2; i++)
{
+ if (g_pi
anchao commented on code in PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#discussion_r1735560505
##
sched/task/task_setup.c:
##
@@ -140,13 +140,28 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb)
* expand space.
*/
+ temp = g_pidhash;
+
+ /* Callin
anchao commented on code in PR #13217:
URL: https://github.com/apache/nuttx/pull/13217#discussion_r1735558946
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,7 @@ typedef struct cookie_io_functions_t
struct file
{
int f_oflags; /* Open mode flags */
+ int
anchao commented on code in PR #13217:
URL: https://github.com/apache/nuttx/pull/13217#discussion_r173704
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,7 @@ typedef struct cookie_io_functions_t
struct file
{
int f_oflags; /* Open mode flags */
+ int
anchao commented on code in PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#discussion_r1735550960
##
sched/task/task_setup.c:
##
@@ -170,6 +170,16 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb)
for (i = 0; i < g_npidhash / 2; i++)
{
+ if (g_pid
anchao commented on PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#issuecomment-2316687622
> @anchao Do you mean leave_critical_section before all malloc/free?
>
> This has been modified, but the functionality of this method seems to have
no difference Because of the check
fxysunshine commented on code in PR #13211:
URL: https://github.com/apache/nuttx/pull/13211#discussion_r1735538184
##
drivers/syslog/vsyslog.c:
##
@@ -215,7 +215,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR
va_list *ap)
#endif
#if defined(CONFIG_SMP)
-
Gary-Hobson commented on PR #13129:
URL: https://github.com/apache/nuttx/pull/13129#issuecomment-2316659725
@anchao Do you mean leave_critical_section before all malloc/free?
This has been modified, but the functionality of this method seems to have
no difference
Because of the che
hujun260 opened a new pull request, #13228:
URL: https://github.com/apache/nuttx/pull/13228
## Summary
inline restore_critical_section and add parameters to
restore_critical_section
## Impact
none
## Testing
ostest
--
This is an automated message from the Apache
xuxin930 commented on PR #13086:
URL: https://github.com/apache/nuttx/pull/13086#issuecomment-2316572449
Hi @pietroalbini @xiaoxiang781216 nice question!
I think we should deal with an essential problem here.
First, I think the usage of `kconfig-kweak `in the description should be t
Zhangshoukui commented on code in PR #13217:
URL: https://github.com/apache/nuttx/pull/13217#discussion_r1735472149
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,7 @@ typedef struct cookie_io_functions_t
struct file
{
int f_oflags; /* Open mode flags */
+ int
lipengfei28 commented on code in PR #13198:
URL: https://github.com/apache/nuttx/pull/13198#discussion_r1735470747
##
boards/x86_64/intel64/qemu-intel64/configs/pcitest/defconfig:
##
@@ -27,10 +27,6 @@ CONFIG_BOOT_RUNFROMEXTSRAM=y
CONFIG_BUILTIN=y
CONFIG_CONSOLE_SYSLOG=y
CONF
lipengfei28 commented on code in PR #13198:
URL: https://github.com/apache/nuttx/pull/13198#discussion_r1735470874
##
boards/x86_64/intel64/qemu-intel64/configs/earlyfb/defconfig:
##
@@ -58,6 +54,3 @@ CONFIG_SYSTEM_CLE=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_TIME64=y
CONFIG_USEC_
Windrow14 commented on PR #13164:
URL: https://github.com/apache/nuttx/pull/13164#issuecomment-2316562367
> @Windrow14 have you tested this on stm32[f|h][7] arches?
>
> CONFIG_MMCSD=y CONFIG_MMCSD_SDIO=y CONFIG_MMCSD_SDIOWAIT_WRCOMPLETE=y
>
> for both SDMMC1 and 2?
>
> SD
xiaoxiang781216 commented on code in PR #13086:
URL: https://github.com/apache/nuttx/pull/13086#discussion_r1735445517
##
cmake/menuconfig.cmake:
##
@@ -74,6 +74,24 @@ add_custom_target(
${NUTTX_DEFCONFIG}
WORKING_DIRECTORY ${NUTTX_DIR})
+add_custom_target(
+ ol
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from a763ed1e07 espressif: Fix build with RTC
add 1086a05e50 libc/sysconf: add _SC_GETPW_R_SIZE_MAX
No new revision
xiaoxiang781216 merged PR #13220:
URL: https://github.com/apache/nuttx/pull/13220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a763ed1e07 espressif: Fix build with RTC
a763e
xiaoxiang781216 merged PR #13225:
URL: https://github.com/apache/nuttx/pull/13225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
anchao commented on code in PR #13211:
URL: https://github.com/apache/nuttx/pull/13211#discussion_r1735428375
##
drivers/syslog/vsyslog.c:
##
@@ -215,7 +215,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR
va_list *ap)
#endif
#if defined(CONFIG_SMP)
-
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 0dfc304e4 Publishing web: 9b88650
davids5 commented on PR #13212:
URL: https://github.com/apache/nuttx/pull/13212#issuecomment-2316101853
@gneworld Please name your PRs so that title is meaningful, Add Summary that
answers: both What and Why,
i.e.
Title: stm32:Fix timer race
Summary
The change reorders the ..
davids5 commented on PR #13214:
URL: https://github.com/apache/nuttx/pull/13214#issuecomment-2316100366
@gneworld Please name your PRs so that title is meaningful, Add Summary that
answers: both What and Why,
i.e.
Title: `stm32:Fix timer race`
Summary
The change reorders th
FelipeMdeO opened a new issue, #13227:
URL: https://github.com/apache/nuttx/issues/13227
### Description / Steps to reproduce the issue
Hello all.
I cannot use spi slave in esp32 c6 dev kit.
I follower instructions in PR https://github.com/apache/nuttx/pull/3787 and
using t
resyfer opened a new pull request, #13226:
URL: https://github.com/apache/nuttx/pull/13226
## Summary
Adds nand and mnemofs sim configs.
## Impact
Testers and users have default configuration files to use nand device
simulators out of the box.
## Testing
Manual testing
tmedicci opened a new pull request, #13225:
URL: https://github.com/apache/nuttx/pull/13225
## Summary
This commit ensures that RTC data is properly allocated in the RTC segment
in the linker. This fixes the reported problem about using the legacy
bootloader and RTC.
## Impact
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new c8e56ff63a CMake: fix CMake compile errors dur
xiaoxiang781216 merged PR #13171:
URL: https://github.com/apache/nuttx/pull/13171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
TimJTi opened a new pull request, #2540:
URL: https://github.com/apache/nuttx-apps/pull/2540
Silly error in settings.c causing compiler error when settings utility
caching is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
xiaoxiang781216 commented on code in PR #13216:
URL: https://github.com/apache/nuttx/pull/13216#discussion_r1735029658
##
include/nuttx/usb/usbdev.h:
##
@@ -253,8 +253,8 @@ struct usbdev_req_s
{
FAR uint8_t *buf; /* Call: Buffer used for data; Return: Unchanged */
uint8_t
xiaoxiang781216 commented on code in PR #13216:
URL: https://github.com/apache/nuttx/pull/13216#discussion_r1735029658
##
include/nuttx/usb/usbdev.h:
##
@@ -253,8 +253,8 @@ struct usbdev_req_s
{
FAR uint8_t *buf; /* Call: Buffer used for data; Return: Unchanged */
uint8_t
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f526b91165 nuttx/drivers:Modify errcode return
xiaoxiang781216 merged PR #13219:
URL: https://github.com/apache/nuttx/pull/13219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 37e1f5db47 Add spi slave dev to esp32 xtensa
3
xiaoxiang781216 merged PR #13223:
URL: https://github.com/apache/nuttx/pull/13223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
tmedicci commented on PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#issuecomment-2315722427
Hi @yamt
If I set `CONFIG_DEBUG_ASSERTIONS` and `CONFIG_DEBUG_FEATURES` it fails to
boot. I guess it's somehow debug-asserting. Can you take a look at it?
The `defconfig` I
acassis commented on issue #13067:
URL: https://github.com/apache/nuttx/issues/13067#issuecomment-2315664284
Actually the message was to Filipe Cavalcanti that doesn't have the board:
@fdcavalcanti (since you don't have the board) I think you can use the spi
tool to so this test. Just do
mraja-brooks opened a new issue, #13224:
URL: https://github.com/apache/nuttx/issues/13224
### Description
Hello Community,
We have had very interesting issue that we have been struggling for over a
year now as it is intermittent but being in Semiconductor industry, it is not
acassis commented on PR #2459:
URL: https://github.com/apache/nuttx-apps/pull/2459#issuecomment-2315544397
@LuchianMihai did you have time to convert the driver to video/camera
interface? Case you don't, maybe we should merge it as normal driver, because
is better to have a driver anyway be
acassis commented on code in PR #2483:
URL: https://github.com/apache/nuttx-apps/pull/2483#discussion_r1734812388
##
audioutils/alsa-lib/alsa_error.c:
##
@@ -0,0 +1,39 @@
+/
+ * apps/audioutils/alsa-lib/
acassis commented on code in PR #13221:
URL: https://github.com/apache/nuttx/pull/13221#discussion_r1734781136
##
libs/libc/pwd/lib_getspnamr.c:
##
@@ -0,0 +1,183 @@
+/
+ * libs/libc/pwd/lib_getspnamr.c
jerpelea commented on code in PR #13180:
URL: https://github.com/apache/nuttx/pull/13180#discussion_r1734746869
##
libs/libc/string/lib_memrchr.c:
##
@@ -26,6 +26,34 @@
#include
+/
Review Comment:
FelipeMdeO opened a new pull request, #13223:
URL: https://github.com/apache/nuttx/pull/13223
## Summary
Add spi slave dev to esp32 xtensa
## Impact
Add Feature
## Testing
Building
--
This is an automated message from the Apache Git Service.
To respond to the mes
jerpelea commented on code in PR #13180:
URL: https://github.com/apache/nuttx/pull/13180#discussion_r1734746869
##
libs/libc/string/lib_memrchr.c:
##
@@ -26,6 +26,34 @@
#include
+/
Review Comment:
jerpelea commented on PR #13180:
URL: https://github.com/apache/nuttx/pull/13180#issuecomment-2315381887
If there is no license in the file they inherit the license from LICENSE
file.
I would advise to handle with care files that go into the core NuttX since
they may cause legal issues.
raiden00pl commented on PR #13180:
URL: https://github.com/apache/nuttx/pull/13180#issuecomment-2315334391
if this code has a different licence than NuttX then the build of these
files must be guarded by `CONFIG_ALLOW_XXX_COMPONENTS`. Adding copyrights to
the LICENSE file is not sufficient.
FelipeMdeO commented on issue #13067:
URL: https://github.com/apache/nuttx/issues/13067#issuecomment-2315329446
Thank you for you suggestion @acassis, very nice.
I did changes in spi_transfer.c to use SPI_SEND instead SPI_EXCHANGE in the
spi tool.
Transfer is ok, so I don't know w
yamt commented on code in PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#discussion_r1734674038
##
arch/xtensa/src/esp32/esp32_spiram.c:
##
@@ -215,13 +217,14 @@ unsigned int IRAM_ATTR cache_sram_mmu_set(int cpu_no, int
pid,
#ifdef CONFIG_SMP
spi_enable_cache(1)
tmedicci commented on PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#issuecomment-2315315509
Thanks for submitting it, @yamt !
I will test it on our internal CI. Please don't merge it yet.
--
This is an automated message from the Apache Git Service.
To respond to the mes
acassis commented on PR #13216:
URL: https://github.com/apache/nuttx/pull/13216#issuecomment-2315314638
@yangsong8-ai please fix these issues:
```
usbdev/cdcecm.c: In function 'cdcecm_ep0incomplete':
Error: usbdev/cdcecm.c:832:12: error: format '%hu' expects argument of type
'int',
davids5 commented on PR #13164:
URL: https://github.com/apache/nuttx/pull/13164#issuecomment-2315309301
@Windrow14 have you tested this on stm32[f|h][7] arches?
CONFIG_MMCSD=y
CONFIG_MMCSD_SDIO=y
CONFIG_MMCSD_SDIOWAIT_WRCOMPLETE=y
for both SDMMC1 and 2?
SDMMC1 has m
acassis commented on code in PR #13222:
URL: https://github.com/apache/nuttx/pull/13222#discussion_r1734664765
##
arch/xtensa/src/esp32/esp32_spiram.c:
##
@@ -215,13 +217,14 @@ unsigned int IRAM_ATTR cache_sram_mmu_set(int cpu_no, int
pid,
#ifdef CONFIG_SMP
spi_enable_cache
raiden00pl commented on code in PR #13198:
URL: https://github.com/apache/nuttx/pull/13198#discussion_r1734641853
##
boards/x86_64/intel64/qemu-intel64/configs/pcitest/defconfig:
##
@@ -27,10 +27,6 @@ CONFIG_BOOT_RUNFROMEXTSRAM=y
CONFIG_BUILTIN=y
CONFIG_CONSOLE_SYSLOG=y
CONFI
raiden00pl commented on code in PR #13198:
URL: https://github.com/apache/nuttx/pull/13198#discussion_r1734640912
##
boards/x86_64/intel64/qemu-intel64/configs/earlyfb/defconfig:
##
@@ -58,6 +54,3 @@ CONFIG_SYSTEM_CLE=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_TIME64=y
CONFIG_USEC_P
raiden00pl commented on PR #13182:
URL: https://github.com/apache/nuttx/pull/13182#issuecomment-2315257128
> Has been replaced by MIT license.
Then building of this component must be guarded by
`CONFIG_ALLOW_MIT_COMPONENTS` option
--
This is an automated message from the Apache Git
yamt opened a new pull request, #13222:
URL: https://github.com/apache/nuttx/pull/13222
## Summary
this function is called via esp_spiram_init_cache early in the boot.
## Impact
## Testing
esp32-devkitc:psram + smp enabled
--
This is an automated message from the Ap
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 263f8955da fs/procfs: Supports any number of thread displays
add a0a85e5c10 arch/arm64: Move ELF_64BIT sele
pkarashchenko merged PR #13218:
URL: https://github.com/apache/nuttx/pull/13218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
yangguangcai01 commented on PR #13182:
URL: https://github.com/apache/nuttx/pull/13182#issuecomment-2315012176
> > @yangguangcai01 let's add lib_memem.c to
https://github.com/apache/nuttx/blob/master/LICENSE#L6335 since it come from
https://github.com/taleinat/byteshift_strstr.
>
> i
anchao commented on code in PR #13217:
URL: https://github.com/apache/nuttx/pull/13217#discussion_r1734447906
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,7 @@ typedef struct cookie_io_functions_t
struct file
{
int f_oflags; /* Open mode flags */
+ int
Cczj opened a new pull request, #13221:
URL: https://github.com/apache/nuttx/pull/13221
VELAPLATFO-28788
Add pw_passwd member to pass tlpi example:
https://man7.org/tlpi/code/online/dist/users_groups/check_password.c.html
Change-Id: I7e114455b8dff7537cdb19ecf4a3d6a5cba67c
Cczj opened a new pull request, #13220:
URL: https://github.com/apache/nuttx/pull/13220
pass tlpi example:
https://man7.org/tlpi/code/online/dist/users_groups/t_getpwnam_r.c.html
## Summary
## Impact
## Testing
--
This is an automated message from the Apac
Cczj opened a new pull request, #13219:
URL: https://github.com/apache/nuttx/pull/13219
Fixed system function call failure due to return errcode error
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to
pussuw opened a new pull request, #13218:
URL: https://github.com/apache/nuttx/pull/13218
## Summary
Unify the elf file format for the whole arm64 architecture
## Impact
Remove copy&paste
## Testing
CI pass
--
This is an automated message from the Apache Git Serv
Zhangshoukui opened a new pull request, #13217:
URL: https://github.com/apache/nuttx/pull/13217
## Summary
Increase the reference count of filep，fs_getfilep adds +1 to the reference
count. After the call is complete, run the fs_putfilep command to release the
reference count.When the ref
lipengfei28 commented on code in PR #13198:
URL: https://github.com/apache/nuttx/pull/13198#discussion_r1734184974
##
drivers/pci/pci_drivers.c:
##
@@ -0,0 +1,68 @@
+/
+ * drivers/pci/pci_drivers.c
+ *
+
gneworld opened a new pull request, #13215:
URL: https://github.com/apache/nuttx/pull/13215
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
gneworld closed pull request #13214: Work2
URL: https://github.com/apache/nuttx/pull/13214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
gneworld opened a new pull request, #13214:
URL: https://github.com/apache/nuttx/pull/13214
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
75 matches
Mail list logo
