Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]

2025-02-23 Thread via GitHub
lupyuen commented on PR #15873: URL: https://github.com/apache/nuttx/pull/15873#issuecomment-2677322205 Sorry @cederom do we need any more reviews for this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] boards/arm/rp2040/common: Add weak_function to SPI common logic [nuttx]

2025-02-23 Thread via GitHub
lupyuen commented on PR #15894: URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677236562 Please fill in the Commit Description (copy from the PR Summary). And remember to sign-off with `git commit -s`. Thanks! :-) - https://github.com/apache/nuttx/pull/15894/commits/93e0db

(nuttx-website) branch asf-site updated: Publishing web: 405a7126bab3fbbeef1bb95fabd1561c86029fc1 docs: 54954e55b5d5004c1c14f84704168036e20886b1

2025-02-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 6e9401b24 Publishing web: 405a712

Re: [PR] xtensa/esp32: use common Espressif wireless source [nuttx]

2025-02-23 Thread via GitHub
fdcavalcanti commented on PR #15853: URL: https://github.com/apache/nuttx/pull/15853#issuecomment-2677185775 > Thanks @tmedicci for the details !! Sorry for the noise :-) We are trying to work out the real world hardware automation and the problem we saw is security - untrusted code from PR

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-23 Thread via GitHub
FelipeMdeO commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2677177869 > @FelipeMdeO you forgot to run ./tools/checkpatch.sh, there is an error: Long line found Sorry, I will pay more attention in the next PR. -- This is an automated message from

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-23 Thread via GitHub
acassis commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2677171720 @FelipeMdeO you forgot to run ./tools/checkpatch.sh, there is an error: Long line found -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] [HELP] Minimum configuration for CDC ECM to work? [nuttx]

2025-02-23 Thread via GitHub
tao-at-pricer commented on issue #15880: URL: https://github.com/apache/nuttx/issues/15880#issuecomment-2677171320 > Ok, I did a little bit of compiling different versions of NuttX. CDC-ECM networking works for the SAMA5 on the`12.0.0.0` release. SAMA5 with just the basic nsh defconfig (no

Re: [PR] samv7/pwm: fix incorrect write of CMRx register [nuttx]

2025-02-23 Thread via GitHub
pkarashchenko merged PR #15859: URL: https://github.com/apache/nuttx/pull/15859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

(nuttx) branch master updated (8956fc440f -> 54954e55b5)

2025-02-23 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 8956fc440f xtensa/esp32[|s3]: re-enable cache during exception handler add 54954e55b5 samv7/pwm: fix incorr

Re: [I] [HELP] Minimum configuration for CDC ECM to work? [nuttx]

2025-02-23 Thread via GitHub
tao-at-pricer commented on issue #15880: URL: https://github.com/apache/nuttx/issues/15880#issuecomment-2677144640 > [@tao-at-pricer](https://github.com/tao-at-pricer) Does it compile with the unmodified defconfig? Unmodified nsh config works, got error only when I added CDC-ECM and w

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-23 Thread via GitHub
acassis commented on code in PR #15895: URL: https://github.com/apache/nuttx/pull/15895#discussion_r1966886928 ## arch/risc-v/src/common/espressif/esp_usbserial.c: ## @@ -216,6 +216,7 @@ static void esp_shutdown(struct uart_dev_s *dev) * *

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-23 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2677078462 Added a comment to both headers about this driver being currently experimental and breaking changes might happen in the near future. -- This is an automated message from the Apache Git

Re: [PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-23 Thread via GitHub
FelipeMdeO commented on PR #15895: URL: https://github.com/apache/nuttx/pull/15895#issuecomment-2677071564 @tmedicci, @acassis Can review this PR, please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-23 Thread via GitHub
linguini1 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2676979656 > > However, I do think introducing this new API requires some conversation and work with many other developers. This seems outside the scope of this PR. Would that delay the merge of t

[PR] netutils/pppd/ppp.h: Fix build issue when network debug is enabled [nuttx-apps]

2025-02-23 Thread via GitHub
FelipeMdeO opened a new pull request, #3006: URL: https://github.com/apache/nuttx-apps/pull/3006 This commit add include necessary when we enable network debug feature using ppp feature. ## Summary When we enable debug feature : -> Debug Options, Network Debug Feature, [enable a

[PR] riscv/esp32c6: Fix issue related esp32c6 usbserial driver. [nuttx]

2025-02-23 Thread via GitHub
FelipeMdeO opened a new pull request, #15895: URL: https://github.com/apache/nuttx/pull/15895 Ths commit disable code optimization responsible for esp32c6 interruption serial register changes. Without this optimization, usbserial driver doesn't word. This is work around meanwhile we find pr

Re: [I] [FEATURE] Common interface for LORA chips [nuttx]

2025-02-23 Thread via GitHub
keever50 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2676775490 True! In case of struct: **— IOCTL using struct —** ``` Common: WLIOC_COM_PARAMS takes { uint32_t freq_hz; int8_t power_dbm; uint16_t preamble_byt

(nuttx) branch master updated: xtensa/esp32[|s3]: re-enable cache during exception handler

2025-02-23 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8956fc440f xtensa/esp32[|s3]: re-enable cache du

Re: [PR] xtensa/esp32[|s3]: re-enable cache during exception handler [nuttx]

2025-02-23 Thread via GitHub
acassis merged PR #15890: URL: https://github.com/apache/nuttx/pull/15890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]

2025-02-23 Thread via GitHub
acassis merged PR #15850: URL: https://github.com/apache/nuttx/pull/15850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: samv7/pwm: add support for latched fault inputs

2025-02-23 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7ccd6e9041 samv7/pwm: add support for latched fa

Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]

2025-02-23 Thread via GitHub
michallenc commented on PR #15873: URL: https://github.com/apache/nuttx/pull/15873#issuecomment-2676762816 @acassis @lupyuen Hi, is it ok to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] samv7/pwm: fix incorrect write of CMRx register [nuttx]

2025-02-23 Thread via GitHub
michallenc commented on PR #15859: URL: https://github.com/apache/nuttx/pull/15859#issuecomment-2676762788 @acassis @lupyuen Hi, is it ok to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]

2025-02-23 Thread via GitHub
michallenc commented on PR #15850: URL: https://github.com/apache/nuttx/pull/15850#issuecomment-2676762715 @acassis @hartmannathan Hi, is it ok to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] arch/ra4: Add support for Renesas RA4M1 MCU [nuttx]

2025-02-23 Thread via GitHub
acassis commented on PR #15892: URL: https://github.com/apache/nuttx/pull/15892#issuecomment-2676755236 @leocafonso there is a last issue: modified: boards/arm/ra4/arduino-r4-minima/configs/nsh-leds/defconfig modified: boards/arm/ra4/arduino-r4-minima/configs/nsh/defco

Re: [I] [FEATURE] We need a better designed web page [nuttx]

2025-02-23 Thread via GitHub
acassis commented on issue #15893: URL: https://github.com/apache/nuttx/issues/15893#issuecomment-2676748092 Thank @cederom! I agree that we need to use a simpler website, that is also important, but the main point is the design and organization of NuttX site, it is really bad. I lik

Re: [I] [HELP] Minimum configuration for CDC ECM to work? [nuttx]

2025-02-23 Thread via GitHub
TimJTi commented on issue #15880: URL: https://github.com/apache/nuttx/issues/15880#issuecomment-2676715924 I am using the master branch on my SAMA5 board and it works, but when I rebase every few weeks I do sometimes have to run make menuconfig because of random build or K config changes.

Re: [I] [FEATURE] Common interface for LORA chips [nuttx]

2025-02-23 Thread via GitHub
raiden00pl commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2676713189 @keever50 it looks good. > is it a good idea to compact some parameters into a struct? yes, it's ok. It makes sense to limit the ioctl calls needed to configure the r

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-23 Thread via GitHub
keever50 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2676709351 Good idea. The same can be done to my pr. I really just want these to be pushed so that's out of the way now -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-23 Thread via GitHub
raiden00pl commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2676707707 > However, I do think introducing this new API requires some conversation and work with many other developers. This seems outside the scope of this PR. Would that delay the merge of th

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-23 Thread via GitHub
raiden00pl commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1966708637 ## include/nuttx/wireless/ioctl.h: ## @@ -60,13 +60,31 @@ /* output power (in dBm) */ #define WLIOC_GETTXPOWER_WLC