Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2753367465 Updated acc. to comments from @xiaoxiang781216 , no functional change. Still re-tested on qemu rv64-virt:nsh and on real hardware (mpfs & i.MX93). -- This is an automated message f

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2013464934 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/**

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2013464934 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/**

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2013464934 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/**

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2013460983 ## include/nuttx/sem_fast.h: ## @@ -0,0 +1,184 @@ +/ + * include/nuttx/sem_fast.h + * + * S

Re: [PR] drivers/sensors/fakesensor: Add baro sensor type to fakesensor [nuttx]

2025-03-25 Thread via GitHub
raiden00pl merged PR #15990: URL: https://github.com/apache/nuttx/pull/15990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2013297079 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/***

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2013299009 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

(nuttx) branch master updated: driver/mtd/at45db.c: write to page without built-in erase

2025-03-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e0b221016f driver/mtd/at45db.c: write to page

Re: [PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #16072: URL: https://github.com/apache/nuttx/pull/16072#discussion_r2013294599 ## tools/sethost.sh: ## @@ -228,4 +228,8 @@ fi echo " Refreshing..." +if [ "X$wenv" == "Xmsys" ]; then +${MAKECMD} olddefconfig || { echo "ERROR: failed t

Re: [PR] driver/mtd/at45db.c: write to page without built-in erase [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 merged PR #16075: URL: https://github.com/apache/nuttx/pull/16075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] drivertest_uart: Pass in the specified parameters to test [nuttx-apps]

2025-03-25 Thread via GitHub
Zhangshoukui commented on PR #3022: URL: https://github.com/apache/nuttx-apps/pull/3022#issuecomment-2753069382 > Sorry @Zhangshoukui could you fill in the Commit Message for this commit? Just copy from the PR Summary. Thanks :-) > > * [c309be1](https://github.com/apache/nuttx-apps/c

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2013282011 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca9

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
acassis commented on code in PR #16043: URL: https://github.com/apache/nuttx/pull/16043#discussion_r2012144506 ## arch/xtensa/src/esp32/esp32_espnow_pktradio.c: ## @@ -1144,6 +1152,10 @@ static int espnow_ifdown(FAR struct net_driver_s *dev) (void)esp_now_deinit(); +#ifnd

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-25 Thread via GitHub
inochisa commented on PR #12804: URL: https://github.com/apache/nuttx/pull/12804#issuecomment-2753051993 > @inochisa thanks for the help. I can boot FLAT mode NuttX with `-M virt,aia=aplic-imsic` now on QEMU v9.2. Can you teach what the `SxAIA` thing is? I can't find it in AIA spec v1.0.

Re: [PR] {bp-15977] Documentation/uorb: fix typo in uorb chapter [nuttx]

2025-03-25 Thread via GitHub
anchao merged PR #16062: URL: https://github.com/apache/nuttx/pull/16062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) branch releases/12.9 updated: audio/pcm_decode: fix typo in assert condition

2025-03-25 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch releases/12.9 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.9 by this push: new c7dea2b6b7 audio/pcm_decode: fix ty

Re: [PR] {bp-15957} audio/pcm_decode: fix typo in assert condition [nuttx]

2025-03-25 Thread via GitHub
anchao merged PR #16058: URL: https://github.com/apache/nuttx/pull/16058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) branch releases/12.9 updated: Documentation/uorb: fix typo in uorb chapter

2025-03-25 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch releases/12.9 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.9 by this push: new df538db857 Documentation/uorb: fix

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-25 Thread via GitHub
yf13 commented on PR #12804: URL: https://github.com/apache/nuttx/pull/12804#issuecomment-2752863309 @inochisa thanks for the confirmations. I can boot FLAT mode NuttX with `-M virt,aia=aplic-imsic` now on QEMU v9.2. Can you teach what is `SxAIA` thing? I can't find it in AIA spec v1.0 yet

Re: [PR] driver/mtd/at45db.c: write to page without built-in erase [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16075: URL: https://github.com/apache/nuttx/pull/16075#issuecomment-2751764770 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements.

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-25 Thread via GitHub
yangsong8-a1 commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2750493383 For output side, the size of each usb's buf is MAX(CONFIG_CDCACM_BULKIN_REQLEN, CONFIG_CDCACM_EPBULKIN_HSSIZE), so writing multiple bytes at a time is no problem. -- This is

Re: [PR] drivers/mtd/gd55: fix uninitialised variables [nuttx]

2025-03-25 Thread via GitHub
TimJTi commented on PR #16021: URL: https://github.com/apache/nuttx/pull/16021#issuecomment-2743213590 > please use the commit title like in the message I treated your title as an example, which is how you presented it. I will change it later. Is there guidance on commit messa

Re: [PR] {bp-16028} include/nuttx/math.h: add missing HUGE_VALF and HUGE_VALL [nuttx]

2025-03-25 Thread via GitHub
hartmannathan commented on PR #16071: URL: https://github.com/apache/nuttx/pull/16071#issuecomment-2752292811 I'm confused... `git log include/nuttx/lib/math.h` shows that these were already added in [19a99205c2473795ede5b5ab201ba7c2bbea99ba](https://github.com/apache/nuttx/commit/19a99205c

(nuttx) 03/05: boards/szpi-esp32s3: Add support for PCA9557

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit ce6d6b4602324c7c2b290c3169510932843d6ae5 Author: wangjianyu3 AuthorDate: Mon Mar 24 20:00:17 2025 +0800 boards/szpi

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2012000963 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

(nuttx) 02/05: drivers/ioexpander: Add support for PCA9557

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit b73d7f2922ae6c91f3b5cc3320df320a81a65e44 Author: wangjianyu3 AuthorDate: Mon Mar 24 19:48:47 2025 +0800 drivers/ioe

[PR] {bp-15950} 202503 Apache NuttX RTOS Contributing Guidelines update. [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16054: URL: https://github.com/apache/nuttx/pull/16054 ## Summary * This change comes from vast mailing list discussions on low PR/COMMIT quality, breaking changes, code quality, long term self-compatibility and maintenance, review problems, and how t

[PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
6b19) https://github.com/NuttX/nuttx/actions/runs/13475897767/job/37655044076#logs ## Impact Impact on user: No changes to user-facing functionality Impact on build: Build process remains the same ## Testing We tested on the local platform MSYS2 and GitHub

(nuttx) 04/05: boards/szpi-esp32s3: Init config for PCA9557

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit dd1e31b22c22156188550fe1fb86f266d6c23c6e Author: wangjianyu3 AuthorDate: Mon Mar 24 21:08:25 2025 +0800 boards/szpi

Re: [PR] {bp-15952} net/can: fix timestamp [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #16056: URL: https://github.com/apache/nuttx/pull/16056#discussion_r2012736846 ## net/can/can_callback.c: ## @@ -119,20 +119,6 @@ uint16_t can_callback(FAR struct net_driver_s *dev, if (conn) { - /* Try to lock the network w

Re: [PR] {bp-16028} include/nuttx/math.h: add missing HUGE_VALF and HUGE_VALL [nuttx]

2025-03-25 Thread via GitHub
hartmannathan commented on PR #16071: URL: https://github.com/apache/nuttx/pull/16071#issuecomment-2752248687 By the way, what does `{bp-16028}` mean (in the PR title)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] examples/notedump: Add a example to dump trace data by udp [nuttx-apps]

2025-03-25 Thread via GitHub
hartmannathan commented on code in PR #3026: URL: https://github.com/apache/nuttx-apps/pull/3026#discussion_r2012758200 ## examples/notedump/Kconfig: ## @@ -0,0 +1,30 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
acassis merged PR #16042: URL: https://github.com/apache/nuttx/pull/16042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) 05/05: Documentation/szpi-esp32s3: Add doc for PCA9557

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fbf1ccae0efc2bca67e8b11af34789aef9c3e8a1 Author: wangjianyu3 AuthorDate: Tue Mar 25 20:20:44 2025 +0800 Documentati

(nuttx) 01/05: boards/esp32s3: Fix `esp32s3_gpio_init` undefined

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5c2cfe8bac38634f584835174e9d58f8d80842db Author: wangjianyu3 AuthorDate: Mon Mar 24 16:26:56 2025 +0800 boards/esp3

(nuttx) branch master updated (25e7b48c7e -> fbf1ccae0e)

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 25e7b48c7e mpfs/mpfs_rcc: Add stub driver for FPGA clock and reset controller new 5c2cfe8bac boards/esp32s3: Fix

(nuttx-apps) branch master updated: nxlooper: fix typo in nxlooper

2025-03-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 83eba5823 nxlooper: fix typo in nxlooper

Re: [PR] nxlooper: fix typo in nxlooper [nuttx-apps]

2025-03-25 Thread via GitHub
xiaoxiang781216 merged PR #3038: URL: https://github.com/apache/nuttx-apps/pull/3038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: system/nxplayer/nxrecorder: move apb buffer instance to stack

2025-03-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 6d0a039cc system/nxplayer/nxrecorder: mov

Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-25 Thread via GitHub
xiaoxiang781216 merged PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Correct the pthread mutex priority inheritance default setting [nuttx]

2025-03-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #16073: URL: https://github.com/apache/nuttx/pull/16073#discussion_r2012726012 ## include/pthread.h: ## @@ -333,25 +333,46 @@ typedef struct pthread_mutex_s pthread_mutex_t; # endif #endif +#ifndef CONFIG_PTHREAD_MUTEX_DEFAULT_PRIO_IN

Re: [PR] modbus: add an option to disable log [nuttx-apps]

2025-03-25 Thread via GitHub
cederom merged PR #3035: URL: https://github.com/apache/nuttx-apps/pull/3035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] modbus: add an option to disable log [nuttx-apps]

2025-03-25 Thread via GitHub
cederom commented on PR #3035: URL: https://github.com/apache/nuttx-apps/pull/3035#issuecomment-2751954829 @jerpelea backporting to 12.9? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(nuttx-apps) branch master updated (494554618 -> e280e9bdb)

2025-03-25 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 494554618 benchmark/mtd: Add MTD testing/benchmark application add e280e9bdb modbus: add an option to disabl

Re: [PR] modbus: add an option to disable log [nuttx-apps]

2025-03-25 Thread via GitHub
cederom commented on PR #3035: URL: https://github.com/apache/nuttx-apps/pull/3035#issuecomment-2751881471 Will merge when CI finished just to keep things clean :-) Lint fail comes from FreeModBusMixedCaseImplementation :-) -- This is an automated message from the Apache Git Service

(nuttx) branch master updated: mpfs/mpfs_rcc: Add stub driver for FPGA clock and reset controller

2025-03-25 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 25e7b48c7e mpfs/mpfs_rcc: Add stub driver for FP

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2011999621 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

Re: [PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
simbit18 commented on code in PR #16072: URL: https://github.com/apache/nuttx/pull/16072#discussion_r2012399028 ## tools/sethost.sh: ## @@ -228,4 +228,8 @@ fi echo " Refreshing..." +if [ "X$wenv" == "Xmsys" ]; then +${MAKECMD} olddefconfig || { echo "ERROR: failed to refre

Re: [PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
simbit18 commented on code in PR #16072: URL: https://github.com/apache/nuttx/pull/16072#discussion_r2012399028 ## tools/sethost.sh: ## @@ -228,4 +228,8 @@ fi echo " Refreshing..." +if [ "X$wenv" == "Xmsys" ]; then +${MAKECMD} olddefconfig || { echo "ERROR: failed to refre

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
Laczen commented on PR #16043: URL: https://github.com/apache/nuttx/pull/16043#issuecomment-2751738800 @tmedicci thanks for your comment. I seem to have overlooked that there is a config ESPRESSIF_WIRELESS. I will try to modify the code according to your comments (this might require some ch

[I] [BUG] `stat()` does not work flash partition with BCH layer [nuttx]

2025-03-25 Thread via GitHub
michallenc opened a new issue, #16074: URL: https://github.com/apache/nuttx/issues/16074 ### Description / Steps to reproduce the issue Flash partition configured as BCH layer (device driver created with `bchdev_register`) doesn't allow `stat` call to obtain the information about an

Re: [PR] mpfs/mpfs_rcc: Add stub driver for FPGA clock and reset controller [nuttx]

2025-03-25 Thread via GitHub
acassis merged PR #16026: URL: https://github.com/apache/nuttx/pull/16026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [I] [HELP] `select()` never returns a positive value when listening to a TCP socket on SoftAP (ESP32-C6) [nuttx]

2025-03-25 Thread via GitHub
acassis commented on issue #16044: URL: https://github.com/apache/nuttx/issues/16044#issuecomment-2751336840 @tmedicci @fdcavalcanti @eren-terzioglu please take a look? @engdavidiogo some questions: 1) Is this code working in normal WiFi mode (not SoftAP) ? 2) Did you test it

Re: [PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
simbit18 commented on code in PR #16072: URL: https://github.com/apache/nuttx/pull/16072#discussion_r2012399028 ## tools/sethost.sh: ## @@ -228,4 +228,8 @@ fi echo " Refreshing..." +if [ "X$wenv" == "Xmsys" ]; then +${MAKECMD} olddefconfig || { echo "ERROR: failed to refre

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
tmedicci commented on PR #16043: URL: https://github.com/apache/nuttx/pull/16043#issuecomment-2751671066 > IMHO the confusion comes from using ESPRESSIF_WIFI for both the wifi hardware and the wlan device. Yes, you are right! Let's consider that `ESPRESSIF_WIFI` will initialize the W

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-25 Thread via GitHub
michallenc commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2751637869 > > If you set bytes_to_read to something a bit bigger (like 5), you don't get anything out any more. Also the thing keeps crashing. > > In order to reduce the copying of da

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
Laczen commented on PR #16043: URL: https://github.com/apache/nuttx/pull/16043#issuecomment-2751450286 @tmedicci As an additional remark: IMO the wifi subsystem could be reduced by taking into account that ESP32/ESPRESSIF_WLAN is not enabled (allowing the removal of wpa, esp_supplicant) but

Re: [PR] Correct the pthread mutex priority inheritance default setting [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on PR #16073: URL: https://github.com/apache/nuttx/pull/16073#issuecomment-2751341152 Yes, thank you for the comment, I'll come back to this tomorrow and fix the CI and the commit message! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
Laczen commented on PR #16043: URL: https://github.com/apache/nuttx/pull/16043#issuecomment-2751397040 > If I understood correctly, [`esp_wifi_sta_start`](https://github.com/apache/nuttx/pull/16043/files#diff-672ed7dac223e8636b4d2cb199329d75a7d6adaaf91fad2d9ba6156ec44c1cf9R1071) should be c

Re: [PR] arch/xtensa/esp32: Allow enabling espnow without wlan. [nuttx]

2025-03-25 Thread via GitHub
tmedicci commented on code in PR #16043: URL: https://github.com/apache/nuttx/pull/16043#discussion_r2012105738 ## arch/xtensa/src/esp32/esp32_espnow_pktradio.c: ## @@ -1144,6 +1152,10 @@ static int espnow_ifdown(FAR struct net_driver_s *dev) (void)esp_now_deinit(); +#ifn

Re: [PR] boards/arm/ra4 Add support to Seeed Xiao RA4M1 Board [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16039: URL: https://github.com/apache/nuttx/pull/16039#issuecomment-2746479405 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR mostly meets the NuttX requirements, but i

(nuttx) branch master updated (85d9078a98 -> 10d46929b9)

2025-03-25 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 85d9078a98 Documentation/testing: Add MTD transfer rate test app docs new 1f2f910ccd drivers/analog/ads1115: Add

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2751303730 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (milkv_duos:nsh) https://gitlab.co

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
lupyuen commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2751290397 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-25 Thread via GitHub
anchao commented on code in PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023#discussion_r2012122191 ## system/nxplayer/nxplayer.c: ## @@ -819,23 +818,11 @@ static FAR void *nxplayer_playthread(pthread_addr_t pvarg) /* Create array of pointers to buffers */ -

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2751290141 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (avaota-a1:nsh) https://gitlab.com

Re: [PR] Correct the pthread mutex priority inheritance default setting [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16073: URL: https://github.com/apache/nuttx/pull/16073#issuecomment-2751284978 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. T

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
lupyuen commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2751276694 @nuttxpr test avaota-a1:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] nxlooper: fix typo in nxlooper [nuttx-apps]

2025-03-25 Thread via GitHub
anchao opened a new pull request, #3038: URL: https://github.com/apache/nuttx-apps/pull/3038 ## Summary nxlooper: fix typo in nxlooper replace CONFIG_O_MULTI_SESSION to CONFIG_AUDIO_MULTI_SESSION Signed-off-by: chao an ## Impact N/A ## Testing

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-25 Thread via GitHub
jlaitine commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2751273215 The CI build should now be ok, also corrected some comments in the header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] Correct the pthread mutex priority inheritance default setting [nuttx]

2025-03-25 Thread via GitHub
jlaitine opened a new pull request, #16073: URL: https://github.com/apache/nuttx/pull/16073 ## Summary After pthread mutexes changed to nxmutex, the priority inheritance was always set on by default; even if one tries to control it with PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT flag.

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2011998832 ## boards/xtensa/esp32s3/lckfb-szpi-esp32s3/src/esp32s3_pca9557.c: ## @@ -0,0 +1,137 @@ +/***

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2012001962 ## boards/xtensa/esp32s3/lckfb-szpi-esp32s3/src/esp32s3_pca9557.c: ## @@ -0,0 +1,137 @@ +/***

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2012001399 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2011998832 ## boards/xtensa/esp32s3/lckfb-szpi-esp32s3/src/esp32s3_pca9557.c: ## @@ -0,0 +1,137 @@ +/***

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2012000279 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

Re: [PR] Add support for `PCA9557` [nuttx]

2025-03-25 Thread via GitHub
JianyuWang0623 commented on code in PR #16042: URL: https://github.com/apache/nuttx/pull/16042#discussion_r2011995955 ## drivers/ioexpander/pca9557.c: ## @@ -0,0 +1,737 @@ +/ + * drivers/ioexpander/pca95

Re: [PR] arch/xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-25 Thread via GitHub
tmedicci commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2011991890 ## arch/xtensa/src/esp32/esp32_sha.c: ## Review Comment: Hi @PruteanuVlad , I'm sorry for the late response. It's failing because you should add it to be c

Re: [PR] CI: Improved speed to build nuttx on MSYS2 job [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16072: URL: https://github.com/apache/nuttx/pull/16072#issuecomment-2751064607 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description does not fully meet the NuttX requi

Re: [PR] {bp-15993} arch/xtensa/espressif: Fix I2C Slave driver error [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16066: URL: https://github.com/apache/nuttx/pull/16066#issuecomment-2750900752 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR summary does not fully meet the NuttX requi

[PR] {bp-16014} arch/risc-v: Fix wrong source name in make script [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16068: URL: https://github.com/apache/nuttx/pull/16068 ## Summary AIA releted source files in the Make.defs are not right. Replace them with the right source. Fixes: 5f70307111 ("arch/risc-v: introduce AIA support") ## Impact RELEA

Re: [PR] {bp-15992} arch/esp32[c3|c6|h2]: Fix efuse issue on MCUBoot [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16065: URL: https://github.com/apache/nuttx/pull/16065#issuecomment-2750903738 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] [bp-16000} tools/bdf-converter: Fix loop termination condition. [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16067: URL: https://github.com/apache/nuttx/pull/16067#issuecomment-2750897587 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] [bp-16000} tools/bdf-converter: Fix loop termination condition. [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16067: URL: https://github.com/apache/nuttx/pull/16067 ## Summary Changing readingbitmap from bool to int, initializing it to the number of bitmaps allocated, decrementing it each time a bitmap is consumed, and using it as the termination condition fo

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-25 Thread via GitHub
inochisa commented on PR #12804: URL: https://github.com/apache/nuttx/pull/12804#issuecomment-2750865497 > @inochisa How can we try this? > > * for QEMU `-M aia=aplic`, add `ARCH_RV_HAVE_APLIC=y` to defconfig? > > * for QEMU `-M aia=aplic-imsic`, add `ARCH_RV_HAVE_APLIC=

Re: [PR] {bp-15980} net: sixlowpan icmpv6 return from udp_input [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16064: URL: https://github.com/apache/nuttx/pull/16064#issuecomment-2750857945 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX r

[PR] {bp-15993} arch/xtensa/espressif: Fix I2C Slave driver error [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16066: URL: https://github.com/apache/nuttx/pull/16066 ## Summary Fixes https://github.com/apache/nuttx/issues/15983 arch/xtensa/espressif: Fix I2C Slave driver build error Add missing files which are causing I2C Slave driver build err

[PR] arch/arm, risc-v: Fix typos in Code Comments [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16048: URL: https://github.com/apache/nuttx/pull/16048 ## Summary This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - https://github.com/apache/nuttx/pull/15921 ## Impact

[PR] {bp-15992} arch/esp32[c3|c6|h2]: Fix efuse issue on MCUBoot [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16065: URL: https://github.com/apache/nuttx/pull/16065 ## Summary Fix build and initialization issues on EFuses using MCUBoot for RISC-V based Espressif devices ## Impact RELEASE ## Testing CI -- This is an automa

[PR] {bp-15980} net: sixlowpan icmpv6 return from udp_input [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16064: URL: https://github.com/apache/nuttx/pull/16064 ## Summary When a udp frame is processed without a listener a icmp frame is returned indicating that there is no listener. The PR enables sending this icmpv6 response over sixlowpan. ## Imp

[PR] {bp-15952} net/can: fix timestamp [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16056: URL: https://github.com/apache/nuttx/pull/16056 ## Summary Fix timestamp in socket CAN. Right now the timestamp is only generated if there is no reader and the frame is stored in the read ahead list. This is solved by moving the timestamp gener

[PR] {bp-15915} drivers/net: update format specifier on lan9250 driver [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16046: URL: https://github.com/apache/nuttx/pull/16046 ## Summary Fix print statement for uint8 and uint16 types. ## Impact RELEASE ## Testing CI -- This is an automated message from the Apache Git Service. To respond to t

[PR] {bp-15978} net/udp: correct icmp(v6) response from udp_input [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16063: URL: https://github.com/apache/nuttx/pull/16063 ## Summary Ensure that the correct icmp(v6) response is generated from udb_input. ## Impact RELEASE ## Testing CI -- This is an automated message from the Apac

Re: [PR] {bp-15952} net/can: fix timestamp [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16056: URL: https://github.com/apache/nuttx/pull/16056#issuecomment-2750804076 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR summary lacks important details required b

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-25 Thread via GitHub
yf13 commented on PR #12804: URL: https://github.com/apache/nuttx/pull/12804#issuecomment-2750827404 @inochisa How can we try this? - for QEMU `-M aia=aplic`, add `ARCH_RV_HAVE_APLIC=y` to defconfig? - for QEMU `-M aia=aplic-imsic`, add `ARCH_RV_HAVE_APLIC=y`, `ARCH_RV_HAVE_IMSIC=y` a

[PR] {bp-15977] Documentation/uorb: fix typo in uorb chapter [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16062: URL: https://github.com/apache/nuttx/pull/16062 ## Summary fix typo "Two Tpyes" -> "Two Types" ## Impact RELEASE ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] {bp-15950} 202503 Apache NuttX RTOS Contributing Guidelines update. [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16054: URL: https://github.com/apache/nuttx/pull/16054#issuecomment-2750807332 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the documented NuttX requi

[PR] {bp-15976} typo: fix incorrect doc [nuttx]

2025-03-25 Thread via GitHub
jerpelea opened a new pull request, #16061: URL: https://github.com/apache/nuttx/pull/16061 ## Summary ## Impact RELEASE ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] {bp-15922} arch/arm, risc-v: Fix typos in Code Comments [nuttx]

2025-03-25 Thread via GitHub
nuttxpr commented on PR #16048: URL: https://github.com/apache/nuttx/pull/16048#issuecomment-2750820217 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The provided PR information is insufficient. While

  1   2   >