Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
shtirlic commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2903431398 Update: changed the chip name to `rp23xx-rv` and board name to `raspberrypi-pico-2-rv` to me more consistent -- This is an automated message from the Apache Git Service. To respon

[I] [BUG] Signal action handlers executed in critical section [nuttx]

2025-05-22 Thread via GitHub
jlaitine opened a new issue, #16430: URL: https://github.com/apache/nuttx/issues/16430 ### Description / Steps to reproduce the issue **Problem statement** This is an old bug/vulnerability, which has been in NuttX for ages. signal delivery is done from several contexts, and in

[I] [BUG] nat_port_select() returned value not safe [nuttx]

2025-05-22 Thread via GitHub
CosmicRoach opened a new issue, #16429: URL: https://github.com/apache/nuttx/issues/16429 ### Description / Steps to reproduce the issue Returned Value: * External port number on success; 0 on failure In some cases,when the return value is 0, it may indicate success. !

(nuttx) branch master updated (b2315e98c4 -> f4cc2c2628)

2025-05-22 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b2315e98c4 sched/semaphore: Always free mutex holder at nxsem_post add 3ce85ca54e style: fix spelling in code c

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-22 Thread via GitHub
xiaoxiang781216 merged PR #16401: URL: https://github.com/apache/nuttx/pull/16401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] bcm2711/spi: Create interrupt-based SPI driver [nuttx]

2025-05-22 Thread via GitHub
linguini1 opened a new pull request, #16428: URL: https://github.com/apache/nuttx/pull/16428 ## Summary This implements an interrupt-based SPI driver for the BCM2711 SPI interfaces (excluding auxiliary SPI interfaces). Only tested on SPI0 since proprietary firmware does not initializ

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: b2315e98c44e91cfd26de2c8c1e2b1dbe47e06b5

2025-05-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9c09eb256 Publishing web: 16e1777

Re: [I] [BUG] STM32H5 __start failure when debugging and flash banks are swapped [nuttx]

2025-05-22 Thread via GitHub
stbenn commented on issue #16416: URL: https://github.com/apache/nuttx/issues/16416#issuecomment-2902333171 @acassis No, this issue is separate from the flash progmem driver and unrelated to the PR. I just discovered this bug while trying to work on progmem with banks swapped. The bu

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2902205896 @shtirlic I have a suggestion. This could save some big headaches for developers in the future using this config. I suggest increasing the stacksize of nsh_main by changing the def

Re: [I] [BUG] STM32H5 __start failure when debugging and flash banks are swapped [nuttx]

2025-05-22 Thread via GitHub
acassis commented on issue #16416: URL: https://github.com/apache/nuttx/issues/16416#issuecomment-2902187820 @stbenn does the PR #16422 closes this Issue? You case setup a PR to close an issue automatically, just use "closes #123" or "fixes #123" in the Summary -- This is an automa

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2902107172 @shtirlic Nice! I confirmed this works perfectly fine with ostest. The serial output also looks consistent. The problem I had was quite simple. Doing make distclean after chang

Re: [PR] sched: Add max delay tick limitation for wdog/wqueue. [nuttx]

2025-05-22 Thread via GitHub
xiaoxiang781216 commented on PR #16394: URL: https://github.com/apache/nuttx/pull/16394#issuecomment-2902060258 @Fix-Point why ci still fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(nuttx) branch master updated (3cf0abbfee -> b2315e98c4)

2025-05-22 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3cf0abbfee arch/stm32h5: Fix FLASH bank logic during erase operations. add b5a284fd6d sched/semaphore: Fix a bu

Re: [PR] Semaphore corrections [nuttx]

2025-05-22 Thread via GitHub
xiaoxiang781216 merged PR #16423: URL: https://github.com/apache/nuttx/pull/16423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
shtirlic commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901836134 > @shtirlic Nice, the warnings are gone! > > How do i make this using the custom built toolchain? It's targeting the wrong one. > > > riscv32-unknown-elf-ld: /opt/riscv32-g

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901793401 @shtirlic Nice, the warnings are gone! How do i make this using the custom built toolchain? It's targeting the wrong one. > riscv32-unknown-elf-ld: /opt/riscv32-gnu-toolc

[PR] tools/ci/testlist/arm-05.dat: removed missing entries [nuttx]

2025-05-22 Thread via GitHub
simbit18 opened a new pull request, #16427: URL: https://github.com/apache/nuttx/pull/16427 ## Summary Removed from the arm-05.dat file the entries: CMake,nrf52832-dk:buttons CMake,nrf52832-dk:wdog CMake,nrf52840-dk:adc CMake,nrf52840-dk:buttons CMake,nrf52840-dk

[PR] tools/nxstyle.c: fix defined but not used warning [nuttx]

2025-05-22 Thread via GitHub
raiden00pl opened a new pull request, #16426: URL: https://github.com/apache/nuttx/pull/16426 ## Summary fix defined but not used warning from CI: Warning: nxstyle.c:767:13: warning: ‘backslash_to_slash’ defined but not used [-Wunused-function] 767 | static void backslash_

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
shtirlic commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901681984 @keever50 I updated the branch, check pls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901572217 > > Okay manually compiled the toolchain with the correct configuration, but as probably expected, this did not make the nuttx configuration work 🤔 > > It's just a warning(not sort

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
shtirlic commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901456297 > Okay manually compiled the toolchain with the correct configuration, but as probably expected, this did not make the nuttx configuration work :thinking: It's just a warning(not

[PR] drivers/sensors: fix various coding style issues [nuttx]

2025-05-22 Thread via GitHub
raiden00pl opened a new pull request, #16425: URL: https://github.com/apache/nuttx/pull/16425 ## Summary fix various coding style issues for drivers/sensors: - remove redundant `#define CONFIG_XXX` that should be provided from Kconfig - correct section banners - remove emp

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901423761 Okay manually compiled the toolchain with the correct configuration, but as probably expected, this did not make the nuttx configuration work :thinking: -- This is an automated messag

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901315623 Hmm, @shtirlic configuration fails and I am not entirely sure what this means. I cloned your branch. Output of ./tools/configure.sh from NuttX: > mkkconfig in /home/martin

Re: [PR] arch/stm32h5: Fix FLASH bank logic during erase operations. [nuttx]

2025-05-22 Thread via GitHub
stbenn commented on PR #16422: URL: https://github.com/apache/nuttx/pull/16422#issuecomment-2901174117 @acassis When I get some free time, I will gladly create a version worthy of nuttx-apps! Thanks for the suggestion -- This is an automated message from the Apache Git Service. To respond

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
acassis commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2901025104 @shtirlic amazing! Kudos!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
acassis commented on code in PR #16424: URL: https://github.com/apache/nuttx/pull/16424#discussion_r2102410675 ## arch/risc-v/src/rp23xx-riscv/hardware/rp23xx_dreq.h: ## @@ -0,0 +1,98 @@ +/ + * arch/risc

Re: [I] [BUG] Default configuration values hardcoded in code [nuttx]

2025-05-22 Thread via GitHub
acassis commented on issue #16420: URL: https://github.com/apache/nuttx/issues/16420#issuecomment-2900991551 @xiaoxiang781216 I think one downside of removing CONFIG_ is that these macros may become hard to find later. It's better to remove them step by step, adding them to Kconfig. -- T

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
acassis commented on code in PR #16424: URL: https://github.com/apache/nuttx/pull/16424#discussion_r2102410675 ## arch/risc-v/src/rp23xx-riscv/hardware/rp23xx_dreq.h: ## @@ -0,0 +1,98 @@ +/ + * arch/risc

Re: [PR] Semaphore corrections [nuttx]

2025-05-22 Thread via GitHub
jlaitine commented on code in PR #16423: URL: https://github.com/apache/nuttx/pull/16423#discussion_r2102218227 ## sched/semaphore/sem_post.c: ## @@ -197,7 +197,7 @@ int nxsem_post_slow(FAR sem_t *sem) if (mutex) { - uint32_t blocking_bit =

Re: [PR] Semaphore corrections [nuttx]

2025-05-22 Thread via GitHub
jlaitine commented on code in PR #16423: URL: https://github.com/apache/nuttx/pull/16423#discussion_r2102211212 ## sched/semaphore/sem_post.c: ## @@ -197,7 +197,7 @@ int nxsem_post_slow(FAR sem_t *sem) if (mutex) { - uint32_t blocking_bit =

Re: [PR] Semaphore corrections [nuttx]

2025-05-22 Thread via GitHub
xiaoxiang781216 commented on code in PR #16423: URL: https://github.com/apache/nuttx/pull/16423#discussion_r2102113494 ## sched/semaphore/sem_post.c: ## @@ -197,7 +197,7 @@ int nxsem_post_slow(FAR sem_t *sem) if (mutex) { - uint32_t blockin

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-22 Thread via GitHub
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2900563790 > Is there anything else I need to do for this PR? all change need at least two committer approve before merging. -- This is an automated message from the Apache Git Servi

Re: [PR] sched: Add max delay tick limitation for wdog/wqueue. [nuttx]

2025-05-22 Thread via GitHub
jlaitine commented on PR #16394: URL: https://github.com/apache/nuttx/pull/16394#issuecomment-2900554383 Yes, I can confirm that it now works, I had a messed-up environment myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
keever50 commented on PR #16424: URL: https://github.com/apache/nuttx/pull/16424#issuecomment-2900483464 Wow! That's great. I love RISC-V. I did not expect this RP23xx RISC-V to come to NuttX. I will be testing this out today as well, thanks! -- This is an automated message from the

[PR] arch/risc-v/rp23xx-riscv: Initial rp23xx RISC-V support [nuttx]

2025-05-22 Thread via GitHub
shtirlic opened a new pull request, #16424: URL: https://github.com/apache/nuttx/pull/16424 ## Summary ### Changes from arm rp23xx - Updated linker script - Updated start - New irq handling - New timerisr ... ## Testing ``` nsh> cat /proc/cpuinfo

Re: [PR] Fix spelling in comments and strings [nuttx]

2025-05-22 Thread via GitHub
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2900392627 Is there anything else I need to do for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] sched: Add max delay tick limitation for wdog/wqueue. [nuttx]

2025-05-22 Thread via GitHub
jlaitine commented on PR #16394: URL: https://github.com/apache/nuttx/pull/16394#issuecomment-293212 Hm. I am experiencing an assertion in the test on rv-virt:smp, with updated nuttx-apps and this PR still: [CPU1] Assertion failed : at file: wdog.c:312 task(CPU1): ostest process:

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-22 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2101941154 ## fs/inode/fs_files.c: ## @@ -858,6 +1026,342 @@ int fs_putfilep(FAR struct file *filep) } #endif +/