[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support

2020-06-17 Thread GitBox
dakejahl commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645617397 I don't understand how `checkpatch` works. Does it do anything automatically or is the purpose just to show which lines are breaking which rules and then I manually fix

[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support

2020-06-18 Thread GitBox
dakejahl commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646284297 Alright I'll squash and force push as a single commit. I made the extra rcc.c file because I was trying to keep things straight in my head when doing the bringup, and I

[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support

2020-06-19 Thread GitBox
dakejahl commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646863497 I took a quick stab at coalescing the rcc files, I don't have time this week to give the proper focused attention to this task (lots of minor painstaking differences) -

[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support

2020-06-29 Thread GitBox
dakejahl commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-651580166 Thanks everyone! This is an automated message from the Apache Git Service. To respond to the message, p