xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591952795
@patacongo this patch is ready to merege now.
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591931624
> Does not even compile, or am I missing an interim patch?
>
> ```
> syslog/syslog_device.c:
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591872715
@juniskane syslog_dev_uninitialize shouldn't return error in the 2nd patch
if there isn't the
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591832703
@juniskane Ok, the new fix should address your concern, please take a look.
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591810891
> This is completely unacceptable. I have applications that call
syslog_file_channel() based on
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591516186
Sure, let's wait hist feedback until tomorrow.
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591441140
@juniskane Please try this patch.
xiaoxiang781216 commented on issue #382: syslog/file: Remove
syslog_dev_uninitialize in syslog_file_channel
URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591440035
Also fix a build erorr noted here:
https://github.com/apache/incubator-nuttx/pull/366
