[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-594288758 @jerpelea i won't until i understand why it should be (2 * BOARD_XTAL_FREQUENCY). maybe i will try to ask espressif. --

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593887228 @jerpelea there seems to be multiple clock sources available for CPU clock. see esp32_technical_reference_manual_en.pdf 3.2.3 "CPU Clock"

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593819103 @jerpelea why do you think it should be 2 * BOARD_XTAL_FREQUENCY? my understanding is that it should match the bootloader, which seems to har

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593733806 do you mean non-CONFIG_SUPPRESS_CLOCK_CONFIG code can work? i don't think it even compile. i agree it's better to fix it though. i don

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593413057 my thinking is that * the current code is broken at least if you run nuttx with esp-idf bootloader on qemu * the bootloader configures it

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593377800 @jerpelea sorry, i don't understand your comments. do you mean that, for some reasons, BOARD_CLOCK_FREQUENCY should be same as BOARD_XTAL

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593372759 @jerpelea CONFIG_ESP32CORE_XTAL_40MZ is about BOARD_XTAL_FREQUENCY. this change is about BOARD_CLOCK_FREQUENCY. the reason to hardcode

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593322676 @jerpelea it's about BOARD_XTAL_FREQUENCY, isn't it? this 80MHz is hardcoded in the bootloader. see the code referenced by the code comme