Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-17 Thread via GitHub
xiaoxiang781216 merged PR #11301: URL: https://github.com/apache/nuttx/pull/11301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-16 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1859038871 Here is the pr: https://github.com/apache/nuttx/pull/11408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-16 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1859023815 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-16 Thread via GitHub
trns1997 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1858885792 > > > > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tom

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1858706861 > > > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix i

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-15 Thread via GitHub
trns1997 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1858046399 > > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tomorro

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-14 Thread via GitHub
xuxin930 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1855645683 > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tomorrow.

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-13 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1855241323 > @xiaoxiang781216 we the following error: > > ``` > Error: /github/workspace/sources/apps/netutils/jsoncpp/jsoncpp/include/json/config.h:132:45: error: 'template struct

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-13 Thread via GitHub
xuxin930 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1855112399 > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tomorrow.

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-13 Thread via GitHub
trns1997 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1854668446 @xiaoxiang781216 we the following error: ``` Error: /github/workspace/sources/apps/netutils/jsoncpp/jsoncpp/include/json/config.h:132:45: error: 'template struct std::__1::char_tra

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-12 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1852490307 @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tomor

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-11 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1851167997 @trns1997 could you rebase the change again? All ci issues are fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-10 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1848989743 @trns1997 you can rebase your patch again, all ci issue should be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1848251306 ci error is fixed here: https://github.com/apache/nuttx-apps/pull/2225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1847397661 @trns1997 please rebase your patch to the last master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420666929 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: typo

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420559909 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: > let's wai

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420468998 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: let'

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420232335 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @raiden00pl

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420232335 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @raiden00pl

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420188071 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: > we can tr

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420166154 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @raiden00pl

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
raiden00pl commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420165394 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: we can tr

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
raiden00pl commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420160020 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: Or, if I

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-08 Thread via GitHub
raiden00pl commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420151859 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: > Yes we

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420044398 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: The patch c

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420043900 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: Yes we need

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1420037219 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: yes,

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1419951403 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: But,

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1419287359 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1419219131 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1419036452 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: coul

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418944032 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418852417 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: http

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418784021 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: ok,

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418731360 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418731360 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418724983 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: shou

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418720386 ## include/wchar.h: ## @@ -57,6 +57,8 @@ * Reference: Opengroup.org */ +#define _LIBCPP_WCHAR_H Review Comment: if so, it's strange that libcxx can't

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-07 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1418615375 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-06 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1417638625 ## include/wchar.h: ## @@ -57,6 +57,8 @@ * Reference: Opengroup.org */ +#define _LIBCPP_WCHAR_H Review Comment: I am not sure our seach order is necessarily

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-06 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1417610450 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: Merg

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-06 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1417462408 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: @xiaoxiang7

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1415993035 ## include/wchar.h: ## @@ -57,6 +57,8 @@ * Reference: Opengroup.org */ +#define _LIBCPP_WCHAR_H Review Comment: let's change the search order in: /

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-05 Thread via GitHub
trns1997 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1415992684 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: ah ok, i gu

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1415993035 ## include/wchar.h: ## @@ -57,6 +57,8 @@ * Reference: Opengroup.org */ +#define _LIBCPP_WCHAR_H Review Comment: let's change the search order in: /

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #11301: URL: https://github.com/apache/nuttx/pull/11301#discussion_r1415982886 ## libs/libxx/mbstate_t.patch: ## @@ -0,0 +1,17 @@ +--- libs/libxx/libcxx/include/__mbstate_t.h2023-11-28 09:52:28.0 +0100 Review Comment: The