[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1028: cmd_dd:if read nbyte less than bs,must write nbyte

2022-02-23 Thread GitBox
pkarashchenko commented on pull request #1028: URL: https://github.com/apache/incubator-nuttx-apps/pull/1028#issuecomment-1048925186 Should we consider an error if file size is not a multiple of sector size? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1029: mlearning: cmsis: libcmsisdsp: config name update

2022-02-23 Thread GitBox
xiaoxiang781216 merged pull request #1029: URL: https://github.com/apache/incubator-nuttx-apps/pull/1029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1021: hello_rust: changes for target support

2022-02-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1021: URL: https://github.com/apache/incubator-nuttx-apps/pull/1021#discussion_r813116368 ## File path: examples/hello_rust/hello_rust_main.rs ## @@ -33,6 +40,20 @@ extern "C" pub fn printf(format: *const u8, ...) ->

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1028: cmd_dd:if read nbyte less than bs,must write nbyte

2022-02-23 Thread GitBox
xiaoxiang781216 commented on pull request #1028: URL: https://github.com/apache/incubator-nuttx-apps/pull/1028#issuecomment-1049005672 > Should we consider an error if file size is not a multiple of sector size? No, the new behavior conform the Unix counterpart. -- This is an auto

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5503: Replece clock_gettime with clock_systime_timespec if suitable

2022-02-23 Thread GitBox
xiaoxiang781216 merged pull request #5503: URL: https://github.com/apache/incubator-nuttx/pull/5503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813141667 ## File path: net/tcp/tcp_send_buffered.c ## @@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, */

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813150170 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813155589 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813170457 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813175765 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1024: nshlib: add memory dump cmd[ps && memdump]

2022-02-23 Thread GitBox
xiaoxiang781216 merged pull request #1024: URL: https://github.com/apache/incubator-nuttx-apps/pull/1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813181392 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813182320 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813182161 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813192536 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813202678 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813209778 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813210915 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813209778 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813209778 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813209778 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813216948 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813225146 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813229382 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813234224 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813238622 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813243942 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813243942 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813245659 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813254690 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813254748 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813255966 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813255966 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813258714 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813255966 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813264210 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5503: Replece clock_gettime with clock_systime_timespec if suitable

2022-02-23 Thread GitBox
hartmannathan commented on pull request #5503: URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1049238683 My review is late but LGTM. Agreed the kernel should not call userspace. Thanks for taking care of it. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5571: drivers: exclude BSD components from build

2022-02-23 Thread GitBox
hartmannathan commented on pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1049240993 A possibility to consider: Enable ALLOW_BSD_COMPONENTS by default? Since BSD license is not "viral" this will allow developers to disable it if they have a good r

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
hartmannathan commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049244145 > The plan is _not_ to use cargo and automatically download missing crates, as this is not - at least for my understanding - the right path for an embedded system

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5542: xtensa: esp32 : setup software interrupt for esp32chips

2022-02-23 Thread GitBox
Ouss4 commented on pull request #5542: URL: https://github.com/apache/incubator-nuttx/pull/5542#issuecomment-1049286362 @zhuyanlinzyl I'll run a test with an S3 board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5336: xtensa: use swint to swith context

2022-02-23 Thread GitBox
Ouss4 commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1049287533 > @zhuyanlinzyl do we still need this patch? We do, this is the context switching part. The two other PRs have part of this PR, when both are merged this need to b

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1022: import: Make.defs: Do not link thumb-based libraries for BUILD_KERNEL

2022-02-23 Thread GitBox
masayuki2009 commented on pull request #1022: URL: https://github.com/apache/incubator-nuttx-apps/pull/1022#issuecomment-1049294129 @pkarashchenko I will reconsider how to fix the issue. Let me close this PR. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx-apps] masayuki2009 closed pull request #1022: import: Make.defs: Do not link thumb-based libraries for BUILD_KERNEL

2022-02-23 Thread GitBox
masayuki2009 closed pull request #1022: URL: https://github.com/apache/incubator-nuttx-apps/pull/1022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5542: xtensa: esp32 : setup software interrupt for esp32chips

2022-02-23 Thread GitBox
Ouss4 commented on pull request #5542: URL: https://github.com/apache/incubator-nuttx/pull/5542#issuecomment-1049303157 > @zhuyanlinzyl I'll run a test with an S3 board. Actually, since this still doesn't change the context swtiching and only setups up the software interrupt, there i

[GitHub] [incubator-nuttx] Ouss4 merged pull request #5542: xtensa: esp32 : setup software interrupt for esp32chips

2022-02-23 Thread GitBox
Ouss4 merged pull request #5542: URL: https://github.com/apache/incubator-nuttx/pull/5542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5336: xtensa: use swint to swith context

2022-02-23 Thread GitBox
Ouss4 commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1049303943 Both PRs are merged now. @zhuyanlinzyl can you please rebase and fix the conflicts. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5585: mm: Add memory dump function when enable CONFIG_DEBUG_MM

2022-02-23 Thread GitBox
Ouss4 commented on pull request #5585: URL: https://github.com/apache/incubator-nuttx/pull/5585#issuecomment-1049313237 @Donny9 is the parsememdump.py file missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5507: arch: Align the implementation of stack related functions

2022-02-23 Thread GitBox
yamt commented on a change in pull request #5507: URL: https://github.com/apache/incubator-nuttx/pull/5507#discussion_r813442198 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -163,21 +161,31 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_t t

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #5597: boards: lm3s6965-ek: Fix qemu-kostest

2022-02-23 Thread GitBox
masayuki2009 opened a new pull request #5597: URL: https://github.com/apache/incubator-nuttx/pull/5597 ## Summary - I noticed two issues in the previous commit - QEMU setting is missing - The ostest takes longer time (i.e. 6m13s) - This commit fixes these issues ## Imp

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5590: os init_state: add new state OSINIT_IDLELOOP

2022-02-23 Thread GitBox
masayuki2009 commented on pull request #5590: URL: https://github.com/apache/incubator-nuttx/pull/5590#issuecomment-1049383613 @GUIDINGLI I found a new issue with sabre-6quad:netknsh which is not merged to the upstream. Actually, if I run the `getprime` command, `DEBUGASSERT` hap

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5590: os init_state: add new state OSINIT_IDLELOOP

2022-02-23 Thread GitBox
masayuki2009 commented on pull request #5590: URL: https://github.com/apache/incubator-nuttx/pull/5590#issuecomment-1049392280 >It seems that syslog flushes the internal buffers from the Idle task. @GUIDINGLI Actual code is inside `up_addrenv_kstackfre`. So do you mean that

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5590: os init_state: add new state OSINIT_IDLELOOP

2022-02-23 Thread GitBox
masayuki2009 edited a comment on pull request #5590: URL: https://github.com/apache/incubator-nuttx/pull/5590#issuecomment-1049392280 >It seems that syslog flushes the internal buffers from the Idle task. @GUIDINGLI Actual code is inside `up_addrenv_kstackfre`. So do you me

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5590: os init_state: add new state OSINIT_IDLELOOP

2022-02-23 Thread GitBox
masayuki2009 edited a comment on pull request #5590: URL: https://github.com/apache/incubator-nuttx/pull/5590#issuecomment-1049392280 >It seems that syslog flushes the internal buffers from the Idle task. @GUIDINGLI @xiaoxiang781216 Actual code is inside `up_addrenv_kstackfre`

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5590: os init_state: add new state OSINIT_IDLELOOP

2022-02-23 Thread GitBox
masayuki2009 edited a comment on pull request #5590: URL: https://github.com/apache/incubator-nuttx/pull/5590#issuecomment-1049392280 >It seems that syslog flushes the internal buffers from the Idle task. @GUIDINGLI @xiaoxiang781216 Actual code is inside `up_addrenv_kstackfre`

[GitHub] [incubator-nuttx] yamt commented on pull request #5571: drivers: exclude BSD components from build

2022-02-23 Thread GitBox
yamt commented on pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-1049407797 > @yamt the BSD flag in our case is marking all variants of BSD licenses to provide an simplified option ok. thank you. -- This is an automated message from the A

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5336: xtensa: use swint to swith context

2022-02-23 Thread GitBox
zhuyanlinzyl commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1049457068 hi, @masayuki2009 @Ouss4 : I have rebase this patch, and test on qemu esp32 and qemu esp32:smp with ostest. Please review and test again. -- This

[GitHub] [incubator-nuttx] a-lunev opened a new pull request #5598: net/tcp(buffered): upgraded the Fast Retransmit algorithm from RFC 2001 to RFC 5681

2022-02-23 Thread GitBox
a-lunev opened a new pull request #5598: URL: https://github.com/apache/incubator-nuttx/pull/5598 ## Summary net/tcp(buffered): upgraded the Fast Retransmit algorithm from RFC 2001 to RFC 5681. This PR is similar to tcp_send_unbuffered (PR #5137) and tcp_sendfile (PR #5311), howe

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5597: boards: lm3s6965-ek: Fix qemu-kostest

2022-02-23 Thread GitBox
xiaoxiang781216 merged pull request #5597: URL: https://github.com/apache/incubator-nuttx/pull/5597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] Donny9 commented on pull request #5585: mm: Add memory dump function when enable CONFIG_DEBUG_MM

2022-02-23 Thread GitBox
Donny9 commented on pull request #5585: URL: https://github.com/apache/incubator-nuttx/pull/5585#issuecomment-1049459799 > > @Donny9 is the parsememdump.py file missing? @anjiahao1 will commit other PR about parsememdump.py before he needs to modify the coding style fo

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on a change in pull request #5591: power/PM: add domain inner update power state feature

2022-02-23 Thread GitBox
zhuyanlinzyl commented on a change in pull request #5591: URL: https://github.com/apache/incubator-nuttx/pull/5591#discussion_r813518041 ## File path: drivers/power/pm_autoupdate.c ## @@ -0,0 +1,117 @@ +/**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
xiaoxiang781216 commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049463339 > > @ptka Great work, would you create a series of crate like `libc-nuttx' for it ? If that, do you value the interoperability with rust's ecosystem? > >

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813523891 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813527857 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813531989 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
a-lunev commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813531989 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, e

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5598: net/tcp(buffered): upgraded the Fast Retransmit algorithm from RFC 2001 to RFC 5681

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5598: URL: https://github.com/apache/incubator-nuttx/pull/5598#discussion_r813578014 ## File path: net/tcp/tcp_send_buffered.c ## @@ -574,6 +547,37 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813578330 ## File path: net/tcp/tcp_send_buffered.c ## @@ -604,170 +603,116 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, el

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5598: net/tcp(buffered): upgraded the Fast Retransmit algorithm from RFC 2001 to RFC 5681

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5598: URL: https://github.com/apache/incubator-nuttx/pull/5598#discussion_r813578014 ## File path: net/tcp/tcp_send_buffered.c ## @@ -574,6 +547,37 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5589: URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813587276 ## File path: net/tcp/tcp_send_buffered.c ## @@ -528,7 +527,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] freakishness commented on pull request #5499: Add EPSON RX8010SJ I2C RTC timer support

2022-02-23 Thread GitBox
freakishness commented on pull request #5499: URL: https://github.com/apache/incubator-nuttx/pull/5499#issuecomment-1049547538 I'm sorry for causing unnecessary work to everyone because of my carelessness.I reworked the code as suggested and merged the commits -- This is an automated mes

[GitHub] [incubator-nuttx] ptka commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
ptka commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049549930 > > > @ptka Great work, would you create a series of crate like `libc-nuttx' for it ? If that, do you value the interoperability with rust's ecosystem? > > > > >

[GitHub] [incubator-nuttx] ptka commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
ptka commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049550180 > > The plan is _not_ to use cargo and automatically download missing crates, as this is not - at least for my understanding - the right path for an embedded system, where

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5598: net/tcp(buffered): upgraded the Fast Retransmit algorithm from RFC 2001 to RFC 5681

2022-02-23 Thread GitBox
anchao commented on a change in pull request #5598: URL: https://github.com/apache/incubator-nuttx/pull/5598#discussion_r813578014 ## File path: net/tcp/tcp_send_buffered.c ## @@ -574,6 +547,37 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
xiaoxiang781216 commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049573541 > > > > @ptka Great work, would you create a series of crate like `libc-nuttx' for it ? If that, do you value the interoperability with rust's ecosystem? > >

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5507: arch: Align the implementation of stack related functions

2022-02-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5507: URL: https://github.com/apache/incubator-nuttx/pull/5507#discussion_r813616951 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -163,21 +161,31 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size

[GitHub] [incubator-nuttx] jerpelea commented on pull request #5571: drivers: exclude BSD components from build

2022-02-23 Thread GitBox
jerpelea commented on pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#issuecomment-104955 > A possibility to consider: Enable ALLOW_BSD_COMPONENTS by default? Since BSD license is not "viral" this will allow developers to disable it if they have a good reas

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5596: board/esp32: Update esp-wireless-drivers-3rdparty

2022-02-23 Thread GitBox
xiaoxiang781216 commented on pull request #5596: URL: https://github.com/apache/incubator-nuttx/pull/5596#issuecomment-1049585171 @Ouss4 it work now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5566: Introduce HAVE_RUST config.

2022-02-23 Thread GitBox
no1wudi commented on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049585330 It seems cargo is not a problem for "control over what's going into the system" since both the package and its version was controlled by user, if you don't change the p

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5566: Introduce HAVE_RUST config.

2022-02-24 Thread GitBox
no1wudi edited a comment on pull request #5566: URL: https://github.com/apache/incubator-nuttx/pull/5566#issuecomment-1049585330 It seems cargo is not a problem for "control over what's going into the system" since both the package and its version was controlled by user, if you don't chang

[GitHub] [incubator-nuttx] Ouss4 merged pull request #5596: board/esp32: Update esp-wireless-drivers-3rdparty

2022-02-24 Thread GitBox
Ouss4 merged pull request #5596: URL: https://github.com/apache/incubator-nuttx/pull/5596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #5599: Fix libc:machine:xtensa: fix warning

2022-02-24 Thread GitBox
zhuyanlinzyl opened a new pull request #5599: URL: https://github.com/apache/incubator-nuttx/pull/5599 ## Summary patch1 :xtensa: fix `XTHAL_REL_LE` not find patch2:libc:machine:xtensa: fix warning ## Impact ## Testing -- This is an automated message from t

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #5600: Imx6 thumb

2022-02-24 Thread GitBox
masayuki2009 opened a new pull request #5600: URL: https://github.com/apache/incubator-nuttx/pull/5600 ## Summary - This PR contains the following 2 commits - commit1: libs: armv7-a: Add thumb support to arch_elf.c - commit2: arch, board: Add thumb support to i.MX6 ## Imp

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1022: import: Make.defs: Do not link thumb-based libraries for BUILD_KERNEL

2022-02-24 Thread GitBox
masayuki2009 commented on pull request #1022: URL: https://github.com/apache/incubator-nuttx-apps/pull/1022#issuecomment-1049745111 @pkarashchenko @xiaoxiang781216 Finally, I found the root cause of the issue. See https://github.com/apache/incubator-nuttx/pull/5600 -- Thi

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5501: boards/sim: Add adb config for test

2022-02-24 Thread GitBox
masayuki2009 commented on pull request #5501: URL: https://github.com/apache/incubator-nuttx/pull/5501#issuecomment-1049802385 @xiaoxiang781216 ``` Configuration/Tool: sim/adb

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5571: drivers: exclude BSD components from build

2022-02-24 Thread GitBox
masayuki2009 commented on a change in pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813828132 ## File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig ## @@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y CONFIG_NET_STATISTICS=y CONFI

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5571: drivers: exclude BSD components from build

2022-02-24 Thread GitBox
jerpelea commented on a change in pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813831975 ## File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig ## @@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y CONFIG_NET_STATISTICS=y CONFIG_NE

[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #1030: mlearning: cmsis: enable FPU support

2022-02-24 Thread GitBox
jerpelea opened a new pull request #1030: URL: https://github.com/apache/incubator-nuttx-apps/pull/1030 ## Summary In case of HW with FPU we can benefit from the FPU support. # Impact CMSIS ## Testing Spresense -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #5571: drivers: exclude BSD components from build

2022-02-24 Thread GitBox
masayuki2009 commented on a change in pull request #5571: URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r813851214 ## File path: boards/arm/lc823450/lc823450-xgevk/configs/bt/defconfig ## @@ -93,8 +93,6 @@ CONFIG_NET_ROUTE=y CONFIG_NET_STATISTICS=y CONFI

[GitHub] [incubator-nuttx-apps] acassis opened a new pull request #1031: apps: Modify oneshot example to let users see it working

2022-02-24 Thread GitBox
acassis opened a new pull request #1031: URL: https://github.com/apache/incubator-nuttx-apps/pull/1031 ## Summary Modify oneshot example to let users see it working ## Impact Users will see oneshot example waiting for ## Testing ESP32-Devkitc -- This is an automated mes

[GitHub] [incubator-nuttx-apps] acassis merged pull request #1028: cmd_dd:if read nbyte less than bs,must write nbyte

2022-02-24 Thread GitBox
acassis merged pull request #1028: URL: https://github.com/apache/incubator-nuttx-apps/pull/1028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5600: Imx6 thumb

2022-02-24 Thread GitBox
pkarashchenko commented on a change in pull request #5600: URL: https://github.com/apache/incubator-nuttx/pull/5600#discussion_r813873454 ## File path: libs/libc/machine/arm/armv7-a/arch_elf.c ## @@ -163,7 +172,12 @@ int up_relocate(FAR const Elf32_Rel *rel, FAR const Elf32_Sy

[GitHub] [incubator-nuttx-apps] acassis merged pull request #1023: apps/trace: add switch and dump instrumentation

2022-02-24 Thread GitBox
acassis merged pull request #1023: URL: https://github.com/apache/incubator-nuttx-apps/pull/1023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5336: xtensa: use swint to swith context

2022-02-24 Thread GitBox
zhuyanlinzyl commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1049868090 @Ouss4 : Could you please review again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5501: boards/sim: Add adb config for test

2022-02-24 Thread GitBox
xiaoxiang781216 commented on pull request #5501: URL: https://github.com/apache/incubator-nuttx/pull/5501#issuecomment-1049892157 @masayuki2009 we need new libuv to pass the build. @no1wudi will provide the patch soon. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5501: boards/sim: Add adb config for test

2022-02-24 Thread GitBox
no1wudi commented on pull request #5501: URL: https://github.com/apache/incubator-nuttx/pull/5501#issuecomment-1049894844 Yes, I'll update https://github.com/apache/incubator-nuttx-apps/pull/854 tomorrow. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5599: Fix libc:machine:xtensa: fix warning

2022-02-24 Thread GitBox
xiaoxiang781216 merged pull request #5599: URL: https://github.com/apache/incubator-nuttx/pull/5599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5601: xtensa/esp32s3: Add support for Main System Watchdog Timers

2022-02-24 Thread GitBox
gustavonihei opened a new pull request #5601: URL: https://github.com/apache/incubator-nuttx/pull/5601 ## Summary This PR intends to add support for the Main System Watchdog Timers 0 and 1 of ESP32-S3. Support for RTC Watchdog Timer is currently in place, but not yet functional due t

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5602: xtensa/esp32s3: Add support for Timer Groups 0 and 1

2022-02-24 Thread GitBox
gustavonihei opened a new pull request #5602: URL: https://github.com/apache/incubator-nuttx/pull/5602 ## Summary This PR intends to add support for the Timers 0 and 1 from Timer Groups 0 and 1 of ESP32-S3. ## Impact New feature for ESP32-S3 chip. ## Testing `esp32s3-

[GitHub] [incubator-nuttx-apps] acassis merged pull request #1030: mlearning: cmsis: enable FPU support

2022-02-24 Thread GitBox
acassis merged pull request #1030: URL: https://github.com/apache/incubator-nuttx-apps/pull/1030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5585: mm: Add memory dump function when enable CONFIG_DEBUG_MM

2022-02-24 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-nuttx/pull/5585#discussion_r813945987 ## File path: fs/procfs/fs_procfsmeminfo.c ## @@ -382,6 +391,88 @@ static ssize_t meminfo_read(FAR struct file *filep, FAR char *buffer,

<    1   2   3   4   5   6   7   8   9   10   >