[GitHub] [incubator-nuttx] acassis merged pull request #431: include/nuttx/cache.h: Fix a copy-paste error.

2020-03-04 Thread GitBox
acassis merged pull request #431: include/nuttx/cache.h: Fix a copy-paste error. URL: https://github.com/apache/incubator-nuttx/pull/431 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] acassis merged pull request #430: include/nuttx/cache.h: Fix errors in previous commit

2020-03-04 Thread GitBox
acassis merged pull request #430: include/nuttx/cache.h: Fix errors in previous commit URL: https://github.com/apache/incubator-nuttx/pull/430 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo opened a new pull request #430: include/nuttx/cache.h: Fix errors in previous commit

2020-03-04 Thread GitBox
patacongo opened a new pull request #430: include/nuttx/cache.h: Fix errors in previous commit URL: https://github.com/apache/incubator-nuttx/pull/430 Commit 3b53cd1e578de1e6bddfae605452a77323e5a70b, "Fix improper use of inline" missed conversion of several inline functions. Also, some

[GitHub] [incubator-nuttx] patacongo merged pull request #429: arch/x86: correct typo error to fix x86 boards build break

2020-03-04 Thread GitBox
patacongo merged pull request #429: arch/x86: correct typo error to fix x86 boards build break URL: https://github.com/apache/incubator-nuttx/pull/429 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] yamt opened a new pull request #433: Kconfig: Allow DEBUG_BINFMT when LIBC_MODLIB is enabled

2020-03-04 Thread GitBox
yamt opened a new pull request #433: Kconfig: Allow DEBUG_BINFMT when LIBC_MODLIB is enabled URL: https://github.com/apache/incubator-nuttx/pull/433 Because the same set of macros (eg. binfo) are used there as well. This is

[GitHub] [incubator-nuttx] patacongo opened a new pull request #434: sched/group/group_setuptaskfiles.c

2020-03-04 Thread GitBox
patacongo opened a new pull request #434: sched/group/group_setuptaskfiles.c URL: https://github.com/apache/incubator-nuttx/pull/434 Parts of commit d07afc934e272cbbd63e355d9e12db333b2e2978 were previously reverted by it did a forbidden inclusion of a private net/ header file in sched/

[GitHub] [incubator-nuttx] patacongo commented on issue #434: sched/group/group_setuptaskfiles.c

2020-03-04 Thread GitBox
patacongo commented on issue #434: sched/group/group_setuptaskfiles.c URL: https://github.com/apache/incubator-nuttx/pull/434#issuecomment-595003946 @anchao Please review and fix. I don't recommend fixing this change. I think you should re-implement this in a way that does not destroy

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
anchao commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435#discussion_r388059848 ## File path: include/nuttx/net/net.h ## @@ -59,6 +59,32 @@ * Pre-processor Definitions

[GitHub] [incubator-nuttx] patacongo merged pull request #433: Kconfig: Allow DEBUG_BINFMT when LIBC_MODLIB is enabled

2020-03-04 Thread GitBox
patacongo merged pull request #433: Kconfig: Allow DEBUG_BINFMT when LIBC_MODLIB is enabled URL: https://github.com/apache/incubator-nuttx/pull/433 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo commented on issue #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
patacongo commented on issue #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435#issuecomment-595013758 Thanks! I am very happy to have that resolved satisfactorily. I think there is an issue with mixing network socket knowledge

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #434: sched/group/group_setuptaskfiles.c

2020-03-04 Thread GitBox
xiaoxiang781216 commented on issue #434: sched/group/group_setuptaskfiles.c URL: https://github.com/apache/incubator-nuttx/pull/434#issuecomment-595005456 > @anchao Please review and fix. I don't recommend fixing this change. I think you should re-implement this in a way that does not

[GitHub] [incubator-nuttx] anchao opened a new pull request #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
anchao opened a new pull request #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435 Build break caused by 23b8b397999136c61b3c834956ad1da55fb0e072 Change-Id: I4a63ede90fbe3385423a9d88ae811cd596491fec Signed-off-by: chao.an

[GitHub] [incubator-nuttx] patacongo merged pull request #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
patacongo merged pull request #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #436: Fix esp32 smp

2020-03-04 Thread GitBox
masayuki2009 opened a new pull request #436: Fix esp32 smp URL: https://github.com/apache/incubator-nuttx/pull/436 ### Summary - This PR fixes ESP32 SMP features by applying the same logic implemented in other SMP architectures such as Cortex-M/A, RV64GC. - Now ostest works in

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435#discussion_r388057713 ## File path: include/nuttx/net/net.h ## @@ -59,6 +59,32 @@ * Pre-processor Definitions

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #434: sched/group/group_setuptaskfiles.c

2020-03-04 Thread GitBox
xiaoxiang781216 commented on issue #434: sched/group/group_setuptaskfiles.c URL: https://github.com/apache/incubator-nuttx/pull/434#issuecomment-595006819 Let's use this PR to fix the problem: https://github.com/apache/incubator-nuttx/pull/435

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #434: sched/group/group_setuptaskfiles.c

2020-03-04 Thread GitBox
xiaoxiang781216 closed pull request #434: sched/group/group_setuptaskfiles.c URL: https://github.com/apache/incubator-nuttx/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] patacongo opened a new pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion.

2020-03-04 Thread GitBox
patacongo opened a new pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion. URL: https://github.com/apache/incubator-nuttx/pull/432 commit d07afc934e272cbbd63e355d9e12db333b2e2978, "fcntl: add O_CLOEXEC/FD_CLOEXEC support" introduce a compilation error .. a bad

[GitHub] [incubator-nuttx] Ouss4 merged pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion.

2020-03-04 Thread GitBox
Ouss4 merged pull request #432: sched/group/group_setuptaskfiles.c: Fix bad file inclusion. URL: https://github.com/apache/incubator-nuttx/pull/432 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #183: Travis CI configuration

2020-03-04 Thread GitBox
xiaoxiang781216 closed pull request #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595078153 @maht and @yamt , please take a look This is an

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #183: Travis CI configuration

2020-03-04 Thread GitBox
xiaoxiang781216 commented on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-595077818 Let's track CI issue by: https://github.com/apache/incubator-nuttx/pull/261

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388129531 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
xiaoxiang781216 edited a comment on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595078153 @davids5, @maht and @yamt , please take a look

[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595063705 @btashton please help to review. Now use docker container and matrix jobs for parallel builds.

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388123102 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] patacongo merged pull request #436: Fix esp32 smp

2020-03-04 Thread GitBox
patacongo merged pull request #436: Fix esp32 smp URL: https://github.com/apache/incubator-nuttx/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388117632 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388117837 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388118144 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #435: net: move the _SF*/_SS* definitions to net.h

2020-03-04 Thread GitBox
xiaoxiang781216 commented on issue #435: net: move the _SF*/_SS* definitions to net.h URL: https://github.com/apache/incubator-nuttx/pull/435#issuecomment-595066419 Yes, this is also our target: the modularity is very important for NuttX.

[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #113: Initial checkin nuttx-apps github action CI workflow

2020-03-04 Thread GitBox
liuguo09 opened a new pull request #113: Initial checkin nuttx-apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/113 Github action CI workflow steps as below: 1. Use docker container with build essential tools preinstalled 2. nxstyle check pull

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-04 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388125715 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #174: Example of use of tools/Jenkinsfile

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #174: Example of use of tools/Jenkinsfile URL: https://github.com/apache/incubator-nuttx/pull/174#discussion_r388135424 ## File path: tools/Jenkinsfile ## @@ -0,0 +1,11 @@ +#!/usr/bin/env groovy + Review comment:

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388141022 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388140963 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] davids5 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
davids5 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595129348 > @davids5, @maht and @yamt , please take a look Where can we see it running?

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388217577 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the

[GitHub] [incubator-nuttx] igrr edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
igrr edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595138207 > The frequency must match a clock source and if on the board is a 26MHZ quarts it it impossible to get 80MHZ. On the ESP32,

[GitHub] [incubator-nuttx] MasayukiIshikawa commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
MasayukiIshikawa commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595126585 Hi, @yamt > Tested on qemu. Could you tell us how to run nuttx for esp32 with qemu? I'm happy if you update

[GitHub] [incubator-nuttx] igrr edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
igrr edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595168023 By the way, this line: ```c++ #ifdef CONFIG_ESP32CORE_RUN_IRAM # define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #113: Initial checkin nuttx-apps github action CI workflow

2020-03-05 Thread GitBox
xiaoxiang781216 commented on issue #113: Initial checkin nuttx-apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/113#issuecomment-595171782 LGTM. This is an automated message from the

[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595134843 > > @davids5, @maht and @yamt , please take a look > > Where can we see it running? This is one PR check build in

[GitHub] [incubator-nuttx] igrr commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
igrr commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595138207 > The frequency must match a clock source and if on the board is a 26MHZ quarts it it impossible to get 80MHZ. On the ESP32, APB/CPU

[GitHub] [incubator-nuttx] davids5 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
davids5 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595138729 @liuguo09 - Nice! What % of board configs are being built (n of N)? What is the total build time? What is the

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595175257 This is why I usggested that the change should be # define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY) instead of a fixed

[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-05 Thread GitBox
jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-595175257 This is why I usggested that the change should be define BOARD_CLOCK_FREQUENCY (2 * BOARD_XTAL_FREQUENCY) instead of a fixed

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #113: Initial checkin nuttx-apps github action CI workflow

2020-03-05 Thread GitBox
xiaoxiang781216 commented on issue #113: Initial checkin nuttx-apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/113#issuecomment-595172131 The similar change for nuttx side: https://github.com/apache/incubator-nuttx/pull/261

[GitHub] [incubator-nuttx] maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

2020-03-05 Thread GitBox
maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388345251 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp

[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request #440: S32K1xx boards - Remove unused files (should have been renamed)

2020-03-05 Thread GitBox
jarivanewijk opened a new pull request #440: S32K1xx boards - Remove unused files (should have been renamed) URL: https://github.com/apache/incubator-nuttx/pull/440 New S32K boards were added in PR https://github.com/apache/incubator-nuttx/pull/224 That PR was rebased a few times on

[GitHub] [incubator-nuttx] jerpelea commented on issue #439: Video: Correct use of global variable

2020-03-05 Thread GitBox
jerpelea commented on issue #439: Video: Correct use of global variable URL: https://github.com/apache/incubator-nuttx/issues/439#issuecomment-595275166 I am looking into it ASAP This is an automated message from the Apache

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593352351 This means that if there is another bootloader version it may have the other frequency

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added

2020-03-02 Thread GitBox
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386396204 ## File path: boards/renesas/rx65n/rx65n-rsk2mb/src/rx65n_appinit.c ## @@ -0,0 +1,96 @@

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593413057 my thinking is that * the current code is broken at least if you run nuttx with esp-idf bootloader on qemu * the bootloader configures it

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added

2020-03-02 Thread GitBox
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386395546 ## File path: arch/renesas/src/rx65n/rx65n_rtc.h ## @@ -0,0 +1,261 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #414: RX65N RTC Driver added

2020-03-02 Thread GitBox
patacongo commented on a change in pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#discussion_r386395999 ## File path: boards/renesas/rx65n/rx65n-grrose/src/rx65n_appinit.c ## @@ -0,0 +1,96 @@

[GitHub] [incubator-nuttx] patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593465989 The frequency is only hardcoded if CONFIG_SUPPRESS_CLOCK_CONFIG is selected. That is because the actual clock configuration logic is

[GitHub] [incubator-nuttx] davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-03-02 Thread GitBox
davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-593449454 @bjbrandt - when I have a chance I will have to walk thought this and verify it..

[GitHub] [incubator-nuttx] bjbrandt edited a comment on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-03-02 Thread GitBox
bjbrandt edited a comment on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-592500639 @davids5 > I think we need to step back and look at the API. It seems to have become

[GitHub] [incubator-nuttx] patacongo commented on issue #414: RX65N RTC Driver added

2020-03-02 Thread GitBox
patacongo commented on issue #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#issuecomment-593408229 When you change the headers on all of the new files to the new Apache 2.0 license I will be happy to merge the code. Sorry to trouble you with this, but

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593322676 @jerpelea it's about BOARD_XTAL_FREQUENCY, isn't it? this 80MHz is hardcoded in the bootloader. see the code referenced by the code

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 By default it is set to 40MHZ and I do not see the reason for this change

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593374264 -# define BOARD_CLOCK_FREQUENCY BOARD_XTAL_FREQUENCY +# define BOARD_CLOCK_FREQUENCY 8000 this is your change

[GitHub] [incubator-nuttx] jerpelea removed a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea removed a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593352351 This means that if there is another bootloader version it may have the other frequency

[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 By default it is set to 40MHZ and I do not see the reason to hardcode it

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593377800 @jerpelea sorry, i don't understand your comments. do you mean that, for some reasons, BOARD_CLOCK_FREQUENCY should be same as

[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea edited a comment on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593353012 here is the explanation

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593374479 I do not have OpenOCD This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593380150 In your change you replace this line with a hardcoded value I am trying to understand your thinking since nither you or me have the

[GitHub] [incubator-nuttx] RB-tel commented on issue #414: RX65N RTC Driver added

2020-03-03 Thread GitBox
RB-tel commented on issue #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414#issuecomment-593909768 > When you change the headers on all of the new files to the new Apache 2.0 license I will be happy to merge the code. Sorry to trouble you with this, but

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #423: NXP Freedom K28F Board SD-Card support

2020-03-03 Thread GitBox
patacongo commented on a change in pull request #423: NXP Freedom K28F Board SD-Card support URL: https://github.com/apache/incubator-nuttx/pull/423#discussion_r387060209 ## File path: boards/arm/kinetis/freedom-k28f/src/k28_sdhc.c ## @@ -0,0 +1,255 @@

[GitHub] [incubator-nuttx] dagar opened a new pull request #424: stm32: spi_exchange (no dma) available with CONFIG_STM32_SPI_DMATHRESHOLD

2020-03-03 Thread GitBox
dagar opened a new pull request #424: stm32: spi_exchange (no dma) available with CONFIG_STM32_SPI_DMATHRESHOLD URL: https://github.com/apache/incubator-nuttx/pull/424 This is a small followup to https://github.com/apache/incubator-nuttx/pull/420. If SPI_DMATHRESHOLD is set and

[GitHub] [incubator-nuttx] patacongo merged pull request #414: RX65N RTC Driver added

2020-03-03 Thread GitBox
patacongo merged pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] patacongo merged pull request #422: tools/testbuild.sh: prevent grep from exiting in case of nomatch

2020-03-03 Thread GitBox
patacongo merged pull request #422: tools/testbuild.sh: prevent grep from exiting in case of nomatch URL: https://github.com/apache/incubator-nuttx/pull/422 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] patacongo commented on issue #411: Flat address x86_64 port of Nuttx

2020-03-03 Thread GitBox
patacongo commented on issue #411: Flat address x86_64 port of Nuttx URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-593985127 @sonicyang with your permission, I could also help you to change the license headers. The code looks good and I would liked to see this

[GitHub] [incubator-nuttx] patacongo merged pull request #421: mkexport: Deal with ARCHSCRIPT containing multiple files

2020-03-03 Thread GitBox
patacongo merged pull request #421: mkexport: Deal with ARCHSCRIPT containing multiple files URL: https://github.com/apache/incubator-nuttx/pull/421 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] patacongo merged pull request #423: NXP Freedom K28F Board SD-Card support

2020-03-03 Thread GitBox
patacongo merged pull request #423: NXP Freedom K28F Board SD-Card support URL: https://github.com/apache/incubator-nuttx/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #422: tools/testbuild.sh: prevent grep from exiting in case of nomatch

2020-03-03 Thread GitBox
liuguo09 opened a new pull request #422: tools/testbuild.sh: prevent grep from exiting in case of nomatch URL: https://github.com/apache/incubator-nuttx/pull/422 Prevent grep from exiting in case of nomatch for blacklist when testbuild.sh called with -x option which set -e in bash.

[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #423: NXP Freedom K28F Board SD-Card support

2020-03-03 Thread GitBox
johannes-nivus opened a new pull request #423: NXP Freedom K28F Board SD-Card support URL: https://github.com/apache/incubator-nuttx/pull/423 This commit perhaps solves also problems with other Kinetis SD-Card impelementations, because kinetis_blocksetup function was missing. Regards,

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #423: NXP Freedom K28F Board SD-Card support

2020-03-03 Thread GitBox
patacongo commented on a change in pull request #423: NXP Freedom K28F Board SD-Card support URL: https://github.com/apache/incubator-nuttx/pull/423#discussion_r387059763 ## File path: boards/arm/kinetis/freedom-k28f/src/k28_automount.c ## @@ -0,0 +1,325 @@

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593999397 @patacongo yes I will This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
jerpelea commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593999243 @yamt please add the following change (same as TizenRT)so that I can merge the PR #define BOARD_CLOCK_FREQUENCY (2 *

[GitHub] [incubator-nuttx] patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593984233 @jerpelea I am expected that you will merge the change (or close it) after your discussion with @yamt concludes. Since you raise the

[GitHub] [incubator-nuttx] patacongo opened a new pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader

2020-03-02 Thread GitBox
patacongo opened a new pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader URL: https://github.com/apache/incubator-nuttx/pull/415 The SD boot loader was not satisfactory because 1) the SD slot is on an optional board and, hence, cannot be part of a fundamental solution. And 2)

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #416: NFS: Support IPv4 and TCP

2020-03-02 Thread GitBox
xiaoxiang781216 opened a new pull request #416: NFS: Support IPv4 and TCP URL: https://github.com/apache/incubator-nuttx/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] acassis merged pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader

2020-03-02 Thread GitBox
acassis merged pull request #415: boards/z80/ez80/z20x/: Add W25 bootloader URL: https://github.com/apache/incubator-nuttx/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] patacongo merged pull request #424: stm32: spi_exchange (no dma) available with CONFIG_STM32_SPI_DMATHRESHOLD

2020-03-03 Thread GitBox
patacongo merged pull request #424: stm32: spi_exchange (no dma) available with CONFIG_STM32_SPI_DMATHRESHOLD URL: https://github.com/apache/incubator-nuttx/pull/424 This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] patacongo merged pull request #411: Flat address x86_64 port of Nuttx

2020-03-03 Thread GitBox
patacongo merged pull request #411: Flat address x86_64 port of Nuttx URL: https://github.com/apache/incubator-nuttx/pull/411 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] sonicyang commented on issue #411: Flat address x86_64 port of Nuttx

2020-03-03 Thread GitBox
sonicyang commented on issue #411: Flat address x86_64 port of Nuttx URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594219500 @patacongo Sorry, I am moving to another city this week. I won't get a reliable network connection and workable environment until this

[GitHub] [incubator-nuttx] sonicyang edited a comment on issue #411: Flat address x86_64 port of Nuttx

2020-03-03 Thread GitBox
sonicyang edited a comment on issue #411: Flat address x86_64 port of Nuttx URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594219500 @patacongo Sorry, I am moving to another city this week. I won't get a reliable network connection and workable environment until

[GitHub] [incubator-nuttx] patacongo commented on issue #411: Flat address x86_64 port of Nuttx

2020-03-03 Thread GitBox
patacongo commented on issue #411: Flat address x86_64 port of Nuttx URL: https://github.com/apache/incubator-nuttx/pull/411#issuecomment-594223969 Yes, I can make the changes in the licensing for you. This is an automated

[GitHub] [incubator-nuttx] acassis merged pull request #425: z20X: Continued development of the W25 Bootloader.

2020-03-03 Thread GitBox
acassis merged pull request #425: z20X: Continued development of the W25 Bootloader. URL: https://github.com/apache/incubator-nuttx/pull/425 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo opened a new pull request #425: z20X: Continued development of the W25 Bootloader.

2020-03-03 Thread GitBox
patacongo opened a new pull request #425: z20X: Continued development of the W25 Bootloader. URL: https://github.com/apache/incubator-nuttx/pull/425 Kconfig files. Repartition some functionality. Bootloader support will need to be provided in logic under arch/z80/src/ez80 so the

[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-02 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593372759 @jerpelea CONFIG_ESP32CORE_XTAL_40MZ is about BOARD_XTAL_FREQUENCY. this change is about BOARD_CLOCK_FREQUENCY. the reason to hardcode

[GitHub] [incubator-nuttx] RB-tel opened a new pull request #414: RX65N RTC Driver added

2020-03-02 Thread GitBox
RB-tel opened a new pull request #414: RX65N RTC Driver added URL: https://github.com/apache/incubator-nuttx/pull/414 RTC Driver files and related modifications added to the rx65n. This is an automated message from the Apache

[GitHub] [incubator-nuttx] patacongo opened a new pull request #417: boards/z80/ez80/z20x/: Correct naming of project files.

2020-03-02 Thread GitBox
patacongo opened a new pull request #417: boards/z80/ez80/z20x/: Correct naming of project files. URL: https://github.com/apache/incubator-nuttx/pull/417 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop

2020-03-02 Thread GitBox
hartmannathan opened a new pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop URL: https://github.com/apache/incubator-nuttx/pull/419 This PR is from two patches sent by Augusto Fraga Giachero to d...@nuttx.apache.org. See the archived email

[GitHub] [incubator-nuttx] Ouss4 merged pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop

2020-03-02 Thread GitBox
Ouss4 merged pull request #419: arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c: Cancel timeout on i2c stop URL: https://github.com/apache/incubator-nuttx/pull/419 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] patacongo commented on issue #418: include/nuttx: Fix improper use of inline

2020-03-02 Thread GitBox
patacongo commented on issue #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418#issuecomment-593641243 > Wow that is significant!! Yes... the inline functions are not really large. However, almost every C file in system includes

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #418: include/nuttx: Fix improper use of inline

2020-03-02 Thread GitBox
patacongo edited a comment on issue #418: include/nuttx: Fix improper use of inline URL: https://github.com/apache/incubator-nuttx/pull/418#issuecomment-593641243 > Wow that is significant!! Yes... the inline functions are not really large. However, almost every C file in system

<    1   2   3   4   5   6   7   8   9   10   >