[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179: macOS support for sim

2020-01-30 Thread GitBox
yamt commented on a change in pull request #179: macOS support for sim URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372913101 ## File path: arch/sim/src/sim/up_initialstate.c ## @@ -67,6 +67,6 @@ void up_initial_state(struct tcb_s *tcb) {

[GitHub] [incubator-nuttx-apps] patacongo edited a comment on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo edited a comment on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580250205 For pthreads, GNU supports the non-POSIX (_np) function so set affinity and also: int

[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #38: Revert "examples: hello: Show CPU index when running in SMP mode"

2020-01-30 Thread GitBox
jerpelea merged pull request #38: Revert "examples: hello: Show CPU index when running in SMP mode" URL: https://github.com/apache/incubator-nuttx-apps/pull/38 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #38: Revert "examples: hello: Show CPU index when running in SMP mode"

2020-01-30 Thread GitBox
jerpelea opened a new pull request #38: Revert "examples: hello: Show CPU index when running in SMP mode" URL: https://github.com/apache/incubator-nuttx-apps/pull/38 Reverts apache/incubator-nuttx-apps#37 This is an

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#discussion_r372934317 ## File path: examples/hello/hello_main.c ## @@ -50,6 +54,12 @@ int main(int

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#discussion_r372933612 ## File path: examples/hello/hello_main.c ## @@ -50,6 +54,12 @@ int main(int

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580243550 "We need to see the CPU affiliation for SMP"... maybe so (although is it volatile and not reliable in

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580250205 For pthreads, GNU supports the non-POSIX (_np) function so set affinity and also: int

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on a change in pull request #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#discussion_r372894731 ## File path: examples/hello/hello_main.c ## @@ -50,6 +54,12 @@ int main(int

[GitHub] [incubator-nuttx-apps] jerpelea commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
jerpelea commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580246167 I agree and respect your decision This is an

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #37: examples: hello: Show CPU index when running in SMP mode

2020-01-29 Thread GitBox
masayuki2009 opened a new pull request #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37 ### Summary - The hello app now shows cpu index when running in SMP mode. ### Impact - This PR only affects

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #184: boards: spresense: Add posix_spawn configuration

2020-01-29 Thread GitBox
masayuki2009 opened a new pull request #184: boards: spresense: Add posix_spawn configuration URL: https://github.com/apache/incubator-nuttx/pull/184 ### Summary - Added posix_spawn configuration for Sony Spresense board ### Impact - This PR does not affects other

[GitHub] [incubator-nuttx] jerpelea merged pull request #184: boards: spresense: Add posix_spawn configuration

2020-01-30 Thread GitBox
jerpelea merged pull request #184: boards: spresense: Add posix_spawn configuration URL: https://github.com/apache/incubator-nuttx/pull/184 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] jerpelea closed pull request #180: Revert "macOS support for sim"

2020-01-30 Thread GitBox
jerpelea closed pull request #180: Revert "macOS support for sim" URL: https://github.com/apache/incubator-nuttx/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
jerpelea merged pull request #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #179: macOS support for sim

2020-01-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372768107 ## File path: arch/sim/src/Makefile ## @@ -195,8 +195,15 @@ endif # Override in Make.defs if linker is not

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #179: macOS support for sim

2020-01-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372773380 ## File path: arch/sim/src/sim/up_initialstate.c ## @@ -67,6 +67,6 @@ void up_initial_state(struct tcb_s *tcb)

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #48: nettest: Avoid common symbols

2020-02-04 Thread GitBox
patacongo merged pull request #48: nettest: Avoid common symbols URL: https://github.com/apache/incubator-nuttx-apps/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #49: nettest: Avoid conflicts with host definitions

2020-02-04 Thread GitBox
patacongo merged pull request #49: nettest: Avoid conflicts with host definitions URL: https://github.com/apache/incubator-nuttx-apps/pull/49 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #49: nettest: Avoid conflicts with host definitions

2020-02-04 Thread GitBox
yamt opened a new pull request #49: nettest: Avoid conflicts with host definitions URL: https://github.com/apache/incubator-nuttx-apps/pull/49 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #48: nettest: Avoid common symbols

2020-02-04 Thread GitBox
yamt opened a new pull request #48: nettest: Avoid common symbols URL: https://github.com/apache/incubator-nuttx-apps/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #50: Improve telnet

2020-02-04 Thread GitBox
xiaoxiang781216 opened a new pull request #50: Improve telnet URL: https://github.com/apache/incubator-nuttx-apps/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section

2020-02-05 Thread GitBox
davids5 commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section URL: https://github.com/apache/incubator-nuttx/pull/212#discussion_r375488989 ## File path: arch/arm/src/stm32f7/stm32_spi.c ## @@ -2177,6 +2177,7 @@ FAR

[GitHub] [incubator-nuttx] acassis merged pull request #213: Add a few gs2200m debug options

2020-02-05 Thread GitBox
acassis merged pull request #213: Add a few gs2200m debug options URL: https://github.com/apache/incubator-nuttx/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] Ouss4 merged pull request #214: boards: maix-bit: Adjust CONFIG_BOARD_LOOPSPERMSEC

2020-02-05 Thread GitBox
Ouss4 merged pull request #214: boards: maix-bit: Adjust CONFIG_BOARD_LOOPSPERMSEC URL: https://github.com/apache/incubator-nuttx/pull/214 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx-apps] acassis merged pull request #53: gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure

2020-02-05 Thread GitBox
acassis merged pull request #53: gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure URL: https://github.com/apache/incubator-nuttx-apps/pull/53 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx-apps] acassis merged pull request #50: Improve telnet

2020-02-04 Thread GitBox
acassis merged pull request #50: Improve telnet URL: https://github.com/apache/incubator-nuttx-apps/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable

2020-02-04 Thread GitBox
masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable URL: https://github.com/apache/incubator-nuttx/issues/207#issuecomment-582154946 > It has been awhile since I have used the sabre-6quad, > but this historically has not been an issue on real hardware. > I

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #216: spresense module support

2020-02-05 Thread GitBox
masayuki2009 opened a new pull request #216: spresense module support URL: https://github.com/apache/incubator-nuttx/pull/216 ### Summary - Added module configuration for Sony Spresense board ### Impact - This PR does not affect other configurations ### Testing

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #217: Refine Kconfig under drivers folder

2020-02-05 Thread GitBox
xiaoxiang781216 opened a new pull request #217: Refine Kconfig under drivers folder URL: https://github.com/apache/incubator-nuttx/pull/217 1.Move subsystem config into sub folder 2.Remove the duplicated if/endif Change-Id: I0b96ac0570ee1ba62bbb95586381f5410b90bcf0

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable

2020-02-05 Thread GitBox
masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable URL: https://github.com/apache/incubator-nuttx/issues/207#issuecomment-582744877 Hi @patacongo, I also noticed that calling setirqstack in arm_vectors.S destroys $r5 which should be preserved. This might be

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #218: sethost: If no host options are specified, try to guess

2020-02-06 Thread GitBox
xiaoxiang781216 merged pull request #218: sethost: If no host options are specified, try to guess URL: https://github.com/apache/incubator-nuttx/pull/218 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] jerpelea merged pull request #216: spresense module support

2020-02-06 Thread GitBox
jerpelea merged pull request #216: spresense module support URL: https://github.com/apache/incubator-nuttx/pull/216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #160: Nxp drone boards

2020-02-06 Thread GitBox
jarivanewijk commented on issue #160: Nxp drone boards URL: https://github.com/apache/incubator-nuttx/pull/160#issuecomment-582817302 @davids5 - As discussed, the branch was again rebased onto latest master. The defconfigs were still up-to-date and no additional style fixes were needed

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess

2020-02-06 Thread GitBox
xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375698399 ## File path: tools/sethost.sh ## @@ -94,6 +94,19 @@ while [ ! -z "$1" ]; do

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess

2020-02-06 Thread GitBox
xiaoxiang781216 commented on a change in pull request #218: sethost: If no host options are specified, try to guess URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375698654 ## File path: tools/sethost.sh ## @@ -34,7 +34,7 @@ progname=$0 debug=n

[GitHub] [incubator-nuttx] davids5 merged pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section

2020-02-06 Thread GitBox
davids5 merged pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section URL: https://github.com/apache/incubator-nuttx/pull/212 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #218: sethost: If no host options are specified, try to guess

2020-02-06 Thread GitBox
yamt commented on a change in pull request #218: sethost: If no host options are specified, try to guess URL: https://github.com/apache/incubator-nuttx/pull/218#discussion_r375739459 ## File path: tools/sethost.sh ## @@ -94,6 +94,19 @@ while [ ! -z "$1" ]; do shift

[GitHub] [incubator-nuttx] bkueng commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section

2020-02-05 Thread GitBox
bkueng commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section URL: https://github.com/apache/incubator-nuttx/pull/212#discussion_r375668479 ## File path: arch/arm/src/stm32f7/stm32_spi.c ## @@ -2177,6 +2177,7 @@ FAR

[GitHub] [incubator-nuttx] yamt opened a new pull request #218: sethost: If no host options are specified, try to guess

2020-02-05 Thread GitBox
yamt opened a new pull request #218: sethost: If no host options are specified, try to guess URL: https://github.com/apache/incubator-nuttx/pull/218 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI configuration

2020-02-06 Thread GitBox
yamt commented on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582827224 any takers? eventually i want to add windows build which i can't test locally. i guess it's possible as travis ci provides windows env.

[GitHub] [incubator-nuttx] acassis merged pull request #217: Refine Kconfig under drivers folder

2020-02-06 Thread GitBox
acassis merged pull request #217: Refine Kconfig under drivers folder URL: https://github.com/apache/incubator-nuttx/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #183: Travis CI configuration

2020-02-06 Thread GitBox
xiaoxiang781216 edited a comment on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582984912 Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh. Since github could: 1.Provide Linux/MacOS/Windows VM

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-06 Thread GitBox
xiaoxiang781216 edited a comment on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-582971070 > I don't think Ctrl-C functionality should be enabled unless cancelation points are also enabled. >

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #210: Reimplement sim uart on top of serial driver framework

2020-02-06 Thread GitBox
xiaoxiang781216 edited a comment on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-582971070 > I don't think Ctrl-C functionality should be enabled unless cancelation points are also enabled. >

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #183: Travis CI configuration

2020-02-06 Thread GitBox
xiaoxiang781216 edited a comment on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582984912 Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh. Since github could: 1.Provide Linux/MacOS/Windows VM

[GitHub] [incubator-nuttx-apps] maht opened a new pull request #55: Fix error about netlib and gs2200m

2020-02-06 Thread GitBox
maht opened a new pull request #55: Fix error about netlib and gs2200m URL: https://github.com/apache/incubator-nuttx-apps/pull/55 As commented [1] all the code guarded by `CONFIG_NET_HAVE_REUSEADDR` was dead code. The pull request [2] made some of it back to life to "undead" code,

[GitHub] [incubator-nuttx] patacongo merged pull request #187: arch/mips/src/pic32mz-head.S: Show progress during start up.

2020-01-30 Thread GitBox
patacongo merged pull request #187: arch/mips/src/pic32mz-head.S: Show progress during start up. URL: https://github.com/apache/incubator-nuttx/pull/187 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580556356 I want apps/examples/hello/ to remain a pure "Hello, World!" example. It is wrong to mix test data into the pure

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580556832 I am very opposed to all of these changes. The interfaces are useless, Hello, World! must not be modified, the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
xiaoxiang781216 commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580556894 Yes, hello isn't a good place but how about apps/testing/smp/smp_main.c? It's reasonable to query the

[GitHub] [incubator-nuttx-apps] patacongo edited a comment on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo edited a comment on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580556832 I am very opposed to all of these changes. The interfaces are useless, Hello, World! must not be modified,

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580552876 I don't think sched_getcpu() is a good idea. It is a useless application interface and is not POSIX. I will

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580553764 Also, I do not think hello, world! is an appropriate place for that kind of stuff. Please do not modify it.

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580557678 In addition to being just a horrible thing to the to the OS, the interface is useless. I mentioned this above.

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
masayuki2009 commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580517143 Thanks for all of the comments above. I'll consider to implement sched_getcpu() API.

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580560510 "Yes, hello isn't a good place but how about apps/testing/smp/smp_main.c? It's reasonable to query the current cpu

[GitHub] [incubator-nuttx] minabeoki commented on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz.

2020-02-01 Thread GitBox
minabeoki commented on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz. URL: https://github.com/apache/incubator-nuttx/pull/194#issuecomment-581043600 I see. I agree with your proposal to add these special case inline functions that can be used in the common

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz.

2020-02-01 Thread GitBox
patacongo edited a comment on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz. URL: https://github.com/apache/incubator-nuttx/pull/194#issuecomment-581033848 I think another option could be to add and special case inline function to include/strings.h (strings.h,

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #197: Replace #include to #include

2020-02-01 Thread GitBox
xiaoxiang781216 opened a new pull request #197: Replace #include to #include URL: https://github.com/apache/incubator-nuttx/pull/197 since the kernel side should call nxsem_xxx instead and remove the unused inclusion Change-Id: Ib84fb389290905fcc1b5c433fd07aa811e76c281

[GitHub] [incubator-nuttx] patacongo commented on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz.

2020-02-01 Thread GitBox
patacongo commented on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz. URL: https://github.com/apache/incubator-nuttx/pull/194#issuecomment-581034228 The are a couple of coding standard issues with using inline functions. Let me know. I can implement these for

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz.

2020-02-01 Thread GitBox
patacongo edited a comment on issue #194: Optimize gran_alloc() in mm_granalloc.c by using builtin ctz. URL: https://github.com/apache/incubator-nuttx/pull/194#issuecomment-581033848 I think another option could be to add and special case inline function to include/strings.h (strings.h,

[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #42: Append $(APPDIR)/testing/cxxtest to CONFIGURED_APPS

2020-01-31 Thread GitBox
Ouss4 merged pull request #42: Append $(APPDIR)/testing/cxxtest to CONFIGURED_APPS URL: https://github.com/apache/incubator-nuttx-apps/pull/42 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #43: Remove extra space line

2020-01-31 Thread GitBox
xiaoxiang781216 opened a new pull request #43: Remove extra space line URL: https://github.com/apache/incubator-nuttx-apps/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #42: Append $(APPDIR)/testing/cxxtest to CONFIGURED_APPS

2020-01-31 Thread GitBox
xiaoxiang781216 opened a new pull request #42: Append $(APPDIR)/testing/cxxtest to CONFIGURED_APPS URL: https://github.com/apache/incubator-nuttx-apps/pull/42 Signed-off-by: Xiang Xiao This is an automated message from the

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580564661 sched_lock() is made available to applications via a syscall. That was a very bad decision that I made long ago.

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
xiaoxiang781216 commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580561988 Yes, it's better to extend syslog and let smp test call syslog instead of printf. But is it reasonable to

[GitHub] [incubator-nuttx] WaterBirdWayOrigin opened a new pull request #188: Fixed USB RNDIS not to send over MTU packet

2020-01-30 Thread GitBox
WaterBirdWayOrigin opened a new pull request #188: Fixed USB RNDIS not to send over MTU packet URL: https://github.com/apache/incubator-nuttx/pull/188 USB RNDIS sent the packet which has CONFIG_ETH_PKTSIZE + CONFIG_NET_GUARDSIZE. The maximum size of Ethernet packet should be

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #188: Fixed USB RNDIS not to send over MTU packet

2020-01-30 Thread GitBox
xiaoxiang781216 commented on issue #188: Fixed USB RNDIS not to send over MTU packet URL: https://github.com/apache/incubator-nuttx/pull/188#issuecomment-580610226 But GUARD_SIZE is global option, how to handle the case that both ethernet(require guard bytes) driver and rndis driver

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-30 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580563032 "But is it reasonable to follow Linux practice if POSIX doesn't define something but very useful(don't like

[GitHub] [incubator-nuttx] patacongo commented on issue #188: Fixed USB RNDIS not to send over MTU packet

2020-01-30 Thread GitBox
patacongo commented on issue #188: Fixed USB RNDIS not to send over MTU packet URL: https://github.com/apache/incubator-nuttx/pull/188#issuecomment-580601132 No, that is the way that the packet size is configured for all network drivers. We will not make an exception here. The GUARD_SIZE

[GitHub] [incubator-nuttx] patacongo closed pull request #188: Fixed USB RNDIS not to send over MTU packet

2020-01-30 Thread GitBox
patacongo closed pull request #188: Fixed USB RNDIS not to send over MTU packet URL: https://github.com/apache/incubator-nuttx/pull/188 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #199: tools/testbuild.sh: update fail to return the error value instead

2020-02-01 Thread GitBox
liuguo09 opened a new pull request #199: tools/testbuild.sh: update fail to return the error value instead URL: https://github.com/apache/incubator-nuttx/pull/199 Change-Id: I8f2c3c3b2c3a3ac2d3be0330f3c79feb2c775c43 Signed-off-by: liuhaitao

[GitHub] [incubator-nuttx] justinmclean commented on issue #183: Travis CI configuration

2020-02-02 Thread GitBox
justinmclean commented on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-581114694 ASF policy on headers is reasonable clear [1], but if in doubt add a header. BSD headers should not be added to new files ASF ALv2 headers should be

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #198: Improve tun

2020-02-01 Thread GitBox
xiaoxiang781216 opened a new pull request #198: Improve tun URL: https://github.com/apache/incubator-nuttx/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #200: Improve slip

2020-02-01 Thread GitBox
xiaoxiang781216 opened a new pull request #200: Improve slip URL: https://github.com/apache/incubator-nuttx/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #189: Remove exra space line

2020-01-31 Thread GitBox
xiaoxiang781216 opened a new pull request #189: Remove exra space line URL: https://github.com/apache/incubator-nuttx/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] patacongo merged pull request #189: Remove exra space line

2020-01-31 Thread GitBox
patacongo merged pull request #189: Remove exra space line URL: https://github.com/apache/incubator-nuttx/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] davids5 edited a comment on issue #183: Travis CI configuration

2020-01-31 Thread GitBox
davids5 edited a comment on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-580817548 What is the harm in merging this to see how well it works. Is it not completely low-risk?

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode

2020-01-31 Thread GitBox
patacongo commented on issue #37: examples: hello: Show CPU index when running in SMP mode URL: https://github.com/apache/incubator-nuttx-apps/pull/37#issuecomment-580817657 "... but the better approach is expose this information through the offiical API, something lke sched_getcpu:

[GitHub] [incubator-nuttx] davids5 commented on issue #183: Travis CI configuration

2020-01-31 Thread GitBox
davids5 commented on issue #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-580817548 What is the harm in merging this to see how well it works. Is it not completely over low-risk?

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #43: Remove extra space line

2020-01-31 Thread GitBox
patacongo merged pull request #43: Remove extra space line URL: https://github.com/apache/incubator-nuttx-apps/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] patacongo commented on issue #188: Fixed USB RNDIS not to send over MTU packet

2020-01-31 Thread GitBox
patacongo commented on issue #188: Fixed USB RNDIS not to send over MTU packet URL: https://github.com/apache/incubator-nuttx/pull/188#issuecomment-580767263 I just put the above information into a Wiki page at: https://cwiki.apache.org/confluence/display/NUTTX/CONFIG_NET_GUARDSIZE

[GitHub] [incubator-nuttx] patacongo commented on issue #189: Remove exra space line

2020-01-31 Thread GitBox
patacongo commented on issue #189: Remove exra space line URL: https://github.com/apache/incubator-nuttx/pull/189#issuecomment-580776432 This change effects some windows files that should have CR-LF at the end. That is not many files, I will revert the changes for those.

[GitHub] [incubator-nuttx] patacongo removed a comment on issue #189: Remove exra space line

2020-01-31 Thread GitBox
patacongo removed a comment on issue #189: Remove exra space line URL: https://github.com/apache/incubator-nuttx/pull/189#issuecomment-580776432 This change effects some windows files that should have CR-LF at the end. That is not many files, I will revert the changes for those.

[GitHub] [incubator-nuttx] Ouss4 merged pull request #190: Refine the preprocess conditional guard style

2020-01-31 Thread GitBox
Ouss4 merged pull request #190: Refine the preprocess conditional guard style URL: https://github.com/apache/incubator-nuttx/pull/190 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #192: Fix socket layer

2020-01-31 Thread GitBox
xiaoxiang781216 opened a new pull request #192: Fix socket layer URL: https://github.com/apache/incubator-nuttx/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #183: Travis CI configuration

2020-01-31 Thread GitBox
patacongo commented on a change in pull request #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373588071 ## File path: .travis.yml ## @@ -0,0 +1,17 @@ +sudo: required Review comment: Question: Do .yml files require

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #183: Travis CI configuration

2020-01-31 Thread GitBox
patacongo commented on a change in pull request #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373588071 ## File path: .travis.yml ## @@ -0,0 +1,17 @@ +sudo: required Review comment: Question: Do .yml files require

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #174: Example of use of tools/Jenkinsfile

2020-01-31 Thread GitBox
patacongo commented on a change in pull request #174: Example of use of tools/Jenkinsfile URL: https://github.com/apache/incubator-nuttx/pull/174#discussion_r373588992 ## File path: tools/Jenkinsfile ## @@ -0,0 +1,11 @@ +#!/usr/bin/env groovy + Review comment: Is a

[GitHub] [incubator-nuttx] patacongo opened a new pull request #191: sched/sched/sched_getcpu.c: Implement non-standard interface.

2020-01-31 Thread GitBox
patacongo opened a new pull request #191: sched/sched/sched_getcpu.c: Implement non-standard interface. URL: https://github.com/apache/incubator-nuttx/pull/191 If SMP is enabled this function will return the number of the CPU that the thread is running on. This is non-standard but

[GitHub] [incubator-nuttx] patacongo opened a new pull request #193: include/netinet/arp.h: Previous network changes broke the build test

2020-01-31 Thread GitBox
patacongo opened a new pull request #193: include/netinet/arp.h: Previous network changes broke the build test URL: https://github.com/apache/incubator-nuttx/pull/193 Previous PR broke the build. Compilation fails with: include/netinet/arp.h:84:27: error: `IFNAMSIZ`

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #183: Travis CI configuration

2020-01-31 Thread GitBox
patacongo commented on a change in pull request #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373587818 ## File path: tools/travis/travis.sh ## @@ -0,0 +1,46 @@ +#! /bin/sh Review comment: PLEASE FIX: All .sh files

[GitHub] [incubator-nuttx] patacongo merged pull request #192: Fix socket layer

2020-01-31 Thread GitBox
patacongo merged pull request #192: Fix socket layer URL: https://github.com/apache/incubator-nuttx/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #44: Refine the preprocess conditional guard style

2020-01-31 Thread GitBox
patacongo merged pull request #44: Refine the preprocess conditional guard style URL: https://github.com/apache/incubator-nuttx-apps/pull/44 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #183: Travis CI configuration

2020-01-31 Thread GitBox
patacongo commented on a change in pull request #183: Travis CI configuration URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373587235 ## File path: boards/sim/sim/sim/configs/ostest/defconfig ## @@ -10,10 +10,12 @@ CONFIG_ARCH_BOARD="sim"

[GitHub] [incubator-nuttx] patacongo commented on issue #160: Nxp drone boards

2020-01-31 Thread GitBox
patacongo commented on issue #160: Nxp drone boards URL: https://github.com/apache/incubator-nuttx/pull/160#issuecomment-580824562 @davids5 Please merge this when it is ready. This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #190: Refine the preprocess conditional guard style

2020-01-31 Thread GitBox
xiaoxiang781216 opened a new pull request #190: Refine the preprocess conditional guard style URL: https://github.com/apache/incubator-nuttx/pull/190 Change-Id: I0667574133875337facbeb2f8c55d66544491875 Signed-off-by: Xiang Xiao

[GitHub] [incubator-nuttx] Ouss4 merged pull request #191: sched/sched/sched_getcpu.c: Implement non-standard interface.

2020-01-31 Thread GitBox
Ouss4 merged pull request #191: sched/sched/sched_getcpu.c: Implement non-standard interface. URL: https://github.com/apache/incubator-nuttx/pull/191 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] patacongo opened a new pull request #201: Update from BSD to Apache 2.0 License

2020-02-02 Thread GitBox
patacongo opened a new pull request #201: Update from BSD to Apache 2.0 License URL: https://github.com/apache/incubator-nuttx/pull/201 This is an automated message from the Apache Git Service. To respond to the message,

<    5   6   7   8   9   10   11   12   13   14   >