svn commit: r1866952 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/conversion/ base/src/main/java/org/apache/ofbiz/base/metrics/ base/src/main/java/org/apache/o

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 17:11:59 2019 New Revision: 1866952 URL: http://svn.apache.org/viewvc?rev=1866952=rev Log: Fixed: Fix Default or Empty Catch block in Java and Groovy files (OFBIZ-) In many Java and Groovy files we have auto generated catch blocks or empty catch blocks. To

svn commit: r1866940 - in /ofbiz/branches/release16.11/framework/security/src/docs: ./ asciidoc/ asciidoc/_include/ asciidoc/_include/sy-impersonation.adoc asciidoc/_include/sy-password-and-JWT.adoc a

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 11:37:44 2019 New Revision: 1866940 URL: http://svn.apache.org/viewvc?rev=1866940=rev Log: Improved: Document how to store the JWT secret key (OFBIZ-10751) Copy manually all files from trunk because of weird conflicts Added:

svn commit: r1866939 - in /ofbiz/ofbiz-framework/branches/release17.12/framework/security/src/docs/asciidoc: _include/sy-impersonation.adoc _include/sy-password-and-JWT.adoc security.adoc

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 11:37:39 2019 New Revision: 1866939 URL: http://svn.apache.org/viewvc?rev=1866939=rev Log: Improved: Document how to store the JWT secret key (OFBIZ-10751) Copy manually all files from trunk because of weird conflicts Added:

svn commit: r1866938 - in /ofbiz/ofbiz-framework/branches/release18.12/framework/security/src/docs/asciidoc: _include/sy-impersonation.adoc _include/sy-password-and-JWT.adoc security.adoc

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 11:37:37 2019 New Revision: 1866938 URL: http://svn.apache.org/viewvc?rev=1866938=rev Log: Improved: Document how to store the JWT secret key (OFBIZ-10751) Copy manually all files from trunk because of weird conflicts Added:

svn commit: r1866936 - /ofbiz/ofbiz-framework/trunk/framework/security/src/docs/asciidoc/_include/sy-password-and-JWT.adoc

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 10:52:54 2019 New Revision: 1866936 URL: http://svn.apache.org/viewvc?rev=1866936=rev Log: Improved: Document how to store the JWT secret key (OFBIZ-10751) Adds a link to OWASP documentation Modified:

buildbot success in on ofbizTrunkFramework

2019-09-14 Thread buildbot
The Buildbot has detected a restored build on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1056 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf945_ubuntu Build Reason: The

buildbot success in on ofbizTrunkFramework

2019-09-14 Thread buildbot
The Buildbot has detected a restored build on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1054 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf947_ubuntu Build Reason: The

svn commit: r1866931 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/LifoSet.java

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 09:29:06 2019 New Revision: 1866931 URL: http://svn.apache.org/viewvc?rev=1866931=rev Log: Improved: Refactor boolean returns from methods (OFBIZ-10725) Stumbled upon it by chance, a last one Modified:

svn commit: r1866930 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java service/src/main/java/org/apache/ofbiz/service/calendar/RecurrenceRule

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 09:25:03 2019 New Revision: 1866930 URL: http://svn.apache.org/viewvc?rev=1866930=rev Log: Improved: Refactor boolean returns from methods (OFBIZ-10725) Reverts mistakes made in previous commit Modified:

buildbot exception in on ofbizTrunkFramework

2019-09-14 Thread buildbot
The Buildbot has detected a build exception on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1055 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

svn commit: r1866929 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/crypto/ base/src/main/java/org/apache/ofbiz/base/util/ service/src/main/java/org/apache/ofbiz

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 09:19:16 2019 New Revision: 1866929 URL: http://svn.apache.org/viewvc?rev=1866929=rev Log: Improved: Refactor boolean returns from methods (OFBIZ-10725) Stumbled upon it by chance, here are few changes Modified:

svn commit: r1866927 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/FileUtil.java

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:38:13 2019 New Revision: 1866927 URL: http://svn.apache.org/viewvc?rev=1866927=rev Log: Improved: no functional change In my previous commit I forgot I used FileUtile::normalizePath (old name of now normalizeFilePath) in FileUtile::getFile. This is useless,

buildbot exception in on ofbizTrunkFramework

2019-09-14 Thread buildbot
The Buildbot has detected a build exception on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1053 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf947_ubuntu Build Reason: The

svn commit: r1866924 - in /ofbiz/ofbiz-framework/trunk: applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/FrameImage.java framework/base/src/main/java/org/apache/ofbiz/base/u

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:29:45 2019 New Revision: 1866924 URL: http://svn.apache.org/viewvc?rev=1866924=rev Log: Improved: no functional change While working on OFBIZ-11196,I renamed the normalizePath() method in FileUtil class to createFileWithNormalizedPath() and added the

svn commit: r1866921 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ framework/webtools/groovyScripts/labelmanager/ViewFile.groovy framework/webtools/groovyScripts/log/FetchLogs.groovy

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:21:21 2019 New Revision: 1866921 URL: http://svn.apache.org/viewvc?rev=1866921=rev Log: "Applied fix from trunk for revision: 1866920" r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam.

svn commit: r1866923 - in /ofbiz/branches/release16.11: ./ framework/webtools/groovyScripts/labelmanager/ViewFile.groovy framework/webtools/groovyScripts/log/FetchLogs.groovy

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:21:25 2019 New Revision: 1866923 URL: http://svn.apache.org/viewvc?rev=1866923=rev Log: "Applied fix from trunk framework for revision: 1866920" r1866920 | jleroux | 2019-09-14 10:19:18

svn commit: r1866922 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ framework/webtools/groovyScripts/labelmanager/ViewFile.groovy framework/webtools/groovyScripts/log/FetchLogs.groovy

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:21:23 2019 New Revision: 1866922 URL: http://svn.apache.org/viewvc?rev=1866922=rev Log: "Applied fix from trunk for revision: 1866920" r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam.

svn commit: r1866920 - in /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts: labelmanager/ViewFile.groovy log/FetchLogs.groovy

2019-09-14 Thread jleroux
Author: jleroux Date: Sat Sep 14 08:19:18 2019 New Revision: 1866920 URL: http://svn.apache.org/viewvc?rev=1866920=rev Log: Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile (OFBIZ-11196) These are not really path traversal issues. We can't solve them using the traditional way