(ofbiz-framework) branch trunk updated: Fixed: Broken draggable/resizable modals in Helveticus (OFBIZ-12992)

[mleila]

This is an automated email from the ASF dual-hosted git repository.

mleila pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new fc8fcfec43 Fixed: Broken draggable/resizable modals in Helveticus 
(OFBIZ-12992)
fc8fcfec43 is described below

commit fc8fcfec4311f77ea6f273514de756338befbefa
Author: Florian Motteau <florian.mott...@nereide.fr>
AuthorDate: Fri Apr 5 10:17:36 2024 +0200

    Fixed: Broken draggable/resizable modals in Helveticus (OFBIZ-12992)
    
    CSS rules were preventing jQuery UI Dialogs to be draggable
    (!important in CSS overriding top/left inline styles).
    Removes "transition: .5s" on dialog elements : it causes
    slowdowns on drag/resize (a CSS animation is triggered each
    time the user moves/resizes the dialog)
    
    Thanks: Gavinju for reporting and Florian Motteau for providing the PR.
---
 .../helveticus/webapp/helveticus/helveticus-main-theme.less  | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less 
b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
index b8503bce3c..ca2d5094f8 100644
--- a/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
+++ b/themes/helveticus/webapp/helveticus/helveticus-main-theme.less
@@ -97,7 +97,10 @@ span.label{
 }
 
 /*** BUTTON /LINK / NAV STYLES ***/
-a, a:hover, * {
+// * { transition: .5s } is very (too) broad, it causes slowdowns on 
draggable/resizable elements like modals
+// (leads to animations for each new size/position, eventually each pixel...)
+// We should invert the logic here : transitions on chosen elements instead of 
everywhere except some elements.
+a, a:hover, *:not(.ui-dialog, .ui-dialog-content) {
   text-decoration:none;
   -o-transition:.5s;
   -ms-transition:.5s;
@@ -1390,8 +1393,6 @@ form .basic-table,
   }
 }
 .ui-dialog{
-  left: ~"calc(50% - 320px)" !important;
-  top: 2rem !important;
   box-shadow: 0 0 15px 15px @shadow-color !important;
 }
 
@@ -1501,11 +1502,6 @@ form .basic-table,
     }
   }
 }
-.ui-dialog{
-  left: ~"calc(50% - 320px)" !important;
-  top: 2rem !important;
-  box-shadow: 0 0 15px 15px @shadow-color !important;
-}
 
 .hidden{
   display: none;