Author: jleroux Date: Wed Aug 23 08:26:52 2017 New Revision: 1805867 URL: http://svn.apache.org/viewvc?rev=1805867&view=rev Log: Improved: Use auto-attributes in ProductFeatureCategory CRUD services (OFBIZ-9608)
ProductFeatureCategory CRUD services have explicitly mentioned IN/OUT parameters in their service definition, like <attribute name="description" type="string" mode="IN" optional="false"/> Rather, the IN/OUT parameters for this crud services should have been written using auto-attribute, like <auto-attributes include="nonpk" mode="IN" optional="true"/> Thanks: Rohit Rai Modified: ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_feature.xml Modified: ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_feature.xml URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_feature.xml?rev=1805867&r1=1805866&r2=1805867&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_feature.xml (original) +++ ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_feature.xml Wed Aug 23 08:26:52 2017 @@ -28,16 +28,16 @@ under the License. <service name="createProductFeatureCategory" engine="entity-auto" invoke="create" default-entity-name="ProductFeatureCategory" auth="true"> <description>Create a ProductFeatureCategory record</description> <permission-service service-name="productGenericPermission" main-action="CREATE"/> - <attribute name="parentCategoryId" type="String" mode="IN" optional="true"/> - <attribute name="description" type="String" mode="IN" optional="false"/> - <attribute name="productFeatureCategoryId" type="String" mode="OUT" optional="false"/> + <auto-attributes include="pk" mode="OUT" optional="false"/> + <auto-attributes include="nonpk" mode="IN" optional="true"/> + <override name="description" optional="false"/> </service> <service name="updateProductFeatureCategory" engine="entity-auto" invoke="update" default-entity-name="ProductFeatureCategory" auth="true"> <description>Update a ProductFeatureCategory record</description> <permission-service service-name="productGenericPermission" main-action="UPDATE"/> - <attribute name="productFeatureCategoryId" type="String" mode="IN" optional="false"/> - <attribute name="parentCategoryId" type="String" mode="IN" optional="true"/> - <attribute name="description" type="String" mode="IN" optional="false"/> + <auto-attributes include="pk" mode="IN" optional="false"/> + <auto-attributes include="nonpk" mode="IN" optional="true"/> + <override name="description" optional="false"/> </service> <service name="createProductFeature" engine="entity-auto" invoke="create" default-entity-name="ProductFeature" auth="true">