Author: sichen
Date: Mon May 12 13:21:49 2008
New Revision: 655631
URL: http://svn.apache.org/viewvc?rev=655631&view=rev
Log:
Do not throw exception if external shipping estimate service returns failure,
or a change of service errors will prevent all sorts of services like add or
update order item to function properly
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java?rev=655631&r1=655630&r2=655631&view=diff
==============================================================================
---
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java
(original)
+++
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/shipping/ShippingEvents.java
Mon May 12 13:21:49 2008
@@ -307,7 +307,7 @@
} else if (ServiceUtil.isFailure(serviceResp)) {
String errMsg = "Failure getting external shipment cost
estimate: " + ServiceUtil.getErrorMessage(serviceResp);
Debug.logError(errMsg, module);
- throw new GeneralException(errMsg);
+ // should not throw an Exception here, otherwise
getShipGroupEstimate would return an error, causing all sorts of services like
add or update order item to abort
} else {
externalShipAmt = (Double)
serviceResp.get("shippingEstimateAmount");
}
