Re: (ofbiz-framework) branch trunk updated: Improved: FACILITY- Move from hard-coded menu location to parameterized (OFBIZ-12976) (#758)

Hi, Just FYI: I inadvertently pushed /webapp/common-theme/js/package-lock.json which was part of Pierre's PR. It uses lockfileVersion 3. So it was build with npm 9* which is "Backwards compatible to npm v7." Actually it's also "Backwards compatible to v1 lockfiles as I experienced (using Win7

Re: (ofbiz-framework) branch trunk updated: Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) (#471)

: - AgreementScreens.xml - restructured screen EditAgreementRoles to work with permissions - AgreementForms.xml - added grid AgreementRoles for users with VIEW permissions additional cleanup * Update AgreementForms.xml - Co-authored-by: Jacques Le Roux

Re: [ofbiz-plugins] branch trunk updated: Improved: "auth" should be true for all the request url used for Application components

escribed below commit e72e1348c13f892cfbd3ffdb78f536c4e4aa6b68 Author: Jacques Le Roux mailto:jacques.le.r...@les7arts.com>> AuthorDate: Sat Mar 14 08:49:54 2020 +0100     Improved: "auth" should be true for all the request url used for Application     component

Re: [ofbiz-site] branch master updated: Publish did not work, keep it as simple as possible. I guess I should use " whoami: master" but it does not make much sense to me

ow commit e4ffb9914563928d362d616e07d290da11cfddf2 Author: Jacques Le Roux AuthorDate: Thu Dec 12 10:11:50 2019 +0100 Publish did not work, keep it as simple as possible. I guess I should use " whoami: master" but it does not make much sense to me --- .asf.yaml | 1 - 1 file changed, 1 del

Re: [ofbiz-plugins] branch trunk updated: Fixed: double forward slashes in ecommerce emails (OFBIZ-2618)

refs/heads/trunk by this push: new 35c1dac Fixed: double forward slashes in ecommerce emails (OFBIZ-2618) 35c1dac is described below commit 35c1dacdb17dc587326b4e65d7cd936bfdd638eb Author: Jacques Le Roux AuthorDate: Sat Nov 9 23:07:31 2019 +0100 Fixed: double forward slashes in ecomme

Re: svn commit: r1865605 - in /ofbiz/branches/release16.11: README.md README.md.html gradle/init-gradle-wrapper.sh

Le 21/08/2019 à 10:05, jaco...@apache.org a écrit : + +MS Windows: +`\gradle\init-gradle-wrapper.ps1` Hi, Just back and I have not much time yet. I created init-gradle-wrapper.bat in OFBiz home because I'm unsure calling init-gradle-wrapper.ps1 directly like above will work on all Windows

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

Checked locally another "not an issue" Le 29/05/2019 à 22:07, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/828

Re: buildbot failure in on ofbizBranch17Framework

No problem locally, unfortunately another "Buildbot's hiccup" Le 29/05/2019 à 19:08, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizBranch17Framework while building . Full details are available at:

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

Hi Suraj, Since this commit https://ci.apache.org/builders/ofbizTrunkFramework/builds/729 the testAddRequirementTask test fails when done in trunk framework only. https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/ See also

Re: svn commit: r1854306 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonUiLabels.xml

Agreed Deepak, Makes sense, I 'll change that Thanks Jacques Le 12/03/2019 à 10:07, Deepak Dixit a écrit : Hi Jacques, I think instead of adding space in uiLabel it would be food if we add space in the template Thanks & Regards -- Deepak Dixit ofbiz.apache.org

Re: svn commit: r1849514 - /ofbiz/ofbiz-framework/trunk/applications/order/minilang/order/OrderServices.xml

Hi Suraj, Please put an explanation in your comments, I  just did it for you :) Thanks Jacques Le 22/12/2018 à 05:55, sur...@apache.org a écrit : Author: surajk Date: Sat Dec 22 04:55:20 2018 New Revision: 1849514 URL: http://svn.apache.org/viewvc?rev=1849514=rev Log: Fixed: Incorrect

Re: svn commit: r1836141 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/XmlRpcEventHandler.java

Hi Taher, It's actually OFBIZ-10484 ;) Jacques Le 18/07/2018 à 08:30, ta...@apache.org a écrit : Author: taher Date: Wed Jul 18 06:30:15 2018 New Revision: 1836141 URL: http://svn.apache.org/viewvc?rev=1836141=rev Log: Improved: sanitized the output of XML-RPC when errors are reported.

Re: svn commit: r1837462 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/collections: MapContext.java MapStack.java

This is rather OFBIZ-10485 Jacques Le 05/08/2018 à 14:36, ta...@apache.org a écrit : Author: taher Date: Sun Aug 5 12:36:09 2018 New Revision: 1837462 URL: http://svn.apache.org/viewvc?rev=1837462=rev Log: Improved: Further refactor MapContext and MapStack (OFBIZ-10484) This commit applies

Re: buildbot failure in on ofbizTrunkFramework

We have a small problem here. The failure is widgettests testFopMacroLibrary Failure Response contentType isn't good : text/html;charset=UTF-8 expected:<[application/pdf];charset=UTF-8> but was:<[text/html];charset=UTF-8> |junit.framework.ComparisonFailure: Response contentType isn't

Re: svn commit: r1827510 - /ofbiz/tools/rat-excludes.txt

cases. Thanks Jacques Le 22/03/2018 à 18:08, Jacques Le Roux a écrit : Oops, that's not that all which is required. We have already covered the *.adoc files by putting ASL2 license headers in them, we don't want to exclude/hide the next which will come. What is needed is to exclude is docs/as

Re: svn commit: r1827510 - /ofbiz/tools/rat-excludes.txt

Oops, that's not that all which is required. We have already covered the *.adoc files by putting ASL2 license headers in them, we don't want to exclude/hide the next which will come. What is needed is to exclude is docs/asciidoc/images/OFBiz-Logo.svg Please check

Re: buildbot failure in on ofbizTrunkFramework

Hi Michael, Not sure why it went unnoticed so long, but by removing README.md (replacing README.adoc) at http://svn.apache.org/viewvc?view=revision=1827046 you broke testZipReadme Not a big deal, we can just replace the file in the test (from README.md to README.adoc). We could chose a more

Re: buildbot failure in on ofbizTrunkFramework

Checking that Jacques Le 16/03/2018 à 12:13, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/143 Buildbot URL:

Re: buildbot failure in on ofbizTrunkFramework

Not a concern, tests pass locally Jacques Le 12/02/2018 à 11:11, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/78 Buildbot

Re: buildbot success in on ofbizTrunkFrameworkPlugins

It seems it happened again (2 successful build messages, previous attached) when it's normally handled with INFRA-15394 But I think I know why. Those were triggered for different reasons: Here Build Reason: The AnyBranchScheduler scheduler named 'onTrunkPluginsCommit' triggered this build

Re: svn commit: r1818495 [3/4] - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/util/

Le 17/12/2017 à 17:57, mbr...@apache.org a écrit : -//Debug.logInfo("Found Map value that is not Serializable: " + mapEntry.getKey() + "=" + mapEntry.getValue(), module); I wonder if we should not rather put back the comment uncommented out. This can be interesting sometimes

Re: svn commit: r1818291 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/

Le 15/12/2017 à 17:51, Jacques Le Roux a écrit : Le 15/12/2017 à 16:10, mbr...@apache.org a écrit : + Debug.logError("Problems with digital product status change : " + null, module); What is the point of putting null there :) ? Jacques Removed at r1818348 Jacques

Re: svn commit: r1818291 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/

Le 15/12/2017 à 16:10, mbr...@apache.org a écrit : +Debug.logError("Problems with digital product status change : " + null, module); What is the point of putting null there :) ? Jacques

Re: svn commit: r1817559 [2/2] - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/model/

Michael, In this commit I see some changes for fields from protected to public. I understand the idea and I agree, but I wonder if we should really make all fields public when some could be private. For instance see colAlias, and for the rest should we not rather create and use getters (and

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Le 11/12/2017 à 09:31, Jacques Le Roux a écrit : Why all these changes in JavaDoc? Is that related with EOLs? If so then something is wrong because I set the SVN repo to handle that automatically at http://markmail.org/message/gzghk44kyz646e4d. Maybe you and/or Dennis are not using a svn >=

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Hi Michael, I'm not sure about all the other commits for "General refactoring and code improvements" (subtasks of OFBIZ-9836) But here I found a lot of unnecessary changes and this makes things a bit harder to review. Why all these changes in JavaDoc? Is that related with EOLs? If so then

Re: svn commit: r1815192 - /ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apa che/ofbiz/securityext/login/LoginEvents.java

Le 14/11/2017 à 10:33, jler...@apache.org a écrit : Author: jleroux Date: Tue Nov 14 09:33:19 2017 New Revision: 1815192 URL:http://svn.apache.org/viewvc?rev=1815192=rev Log: Improved: Fixing defects reported by FindBugs, package org.apache.ofbiz.securityext.login. (OFBIZ-9637) No functional

Re: svn commit: r1813964 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntityCrypto.java

Done at r1814155 Jacques Le 01/11/2017 à 14:08, Jacques Le Roux a écrit : Hi Deepak, It's minor, but instead of hiding a possible RuntimeException by catching Exception here I'd rather follow this FindBugs advice

Re: svn commit: r1814049 - /ofbiz/ofbiz-framework/trunk/build.gradle

Thanks Deepak, I put them because I initially started in a R13.07 instance (custom project) and did not think about it when porting in trunk, just adapted the whole thing to Gradle. Jacques Le 02/11/2017 à 10:05, dee...@apache.org a écrit : Author: deepak Date: Thu Nov 2 09:05:29 2017 New

Re: svn commit: r1813964 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntityCrypto.java

Hi Deepak, It's minor, but instead of hiding a possible RuntimeException by catching Exception here I'd rather follow this FindBugs advice -- This

Re: svn commit: r1811130 - in /ofbiz/ofbiz-framework/trunk/applications/content: webapp/content/images/contentForum.css webapp/contentimages/css/ webapp/contentimages/css/contentForum.css widget/Commo

Hi Deepak, Must be an error for the Jira: https://issues.apache.org/jira/browse/OFBIZ-6259 Jacques Le 04/10/2017 à 20:56, dee...@apache.org a écrit : Author: deepak Date: Wed Oct 4 18:56:33 2017 New Revision: 1811130 URL: http://svn.apache.org/viewvc?rev=1811130=rev Log: Fixed: Moved

Re: svn commit: r1805459 - in /ofbiz/ofbiz-framework/trunk: applications/order/servicedef/ applications/order/src/main/java/org/apache/ofbiz/order/order/ framework/base/src/main/java/org/apache/ofbiz/

Hi Michael, You introduced attachmentType in this commit but the service sendMailFromScreen does not declare this parameter, nor any other service, same for attachmentTypeList. Please check Thanks Jacques Le 18/08/2017 à 21:10, mbr...@apache.org a écrit : Author: mbrohl Date: Fri Aug 18

Re: svn commit: r1808893 - in /ofbiz/site/template: html.tpl.php page/index.tpl.php region/footer.tpl.php region/head.tpl.php region/header.tpl.php region/scripts.tpl.php

Good point, thanks Taher! Jacques Le 19/09/2017 à 16:55, ta...@apache.org a écrit : Author: taher Date: Tue Sep 19 14:55:59 2017 New Revision: 1808893 URL: http://svn.apache.org/viewvc?rev=1808893=rev Log: Remove executable prop from all templates for added security Modified:

Re: svn commit: r1808651 - /ofbiz/site/php2html.sh

Thanks Taher, Better indeed, so you think we will keep PHP for a moment right? (not a problem with me) Jacques Le 17/09/2017 à 22:33, ta...@apache.org a écrit : Author: taher Date: Sun Sep 17 20:33:25 2017 New Revision: 1808651 URL: http://svn.apache.org/viewvc?rev=1808651=rev Log:

Re: svn commit: r1807996 - /ofbiz/site/images/img-404.jpg

Nice, thanks Sharan :) Jacques Le 11/09/2017 à 09:48, sha...@apache.org a écrit : Author: sharan Date: Mon Sep 11 07:48:41 2017 New Revision: 1807996 URL: http://svn.apache.org/viewvc?rev=1807996=rev Log: Improved:Overwrote existing 404 page image with a customised one based on new OFBiz

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

Good catch Nicolas, Should there not be a related Jira? Thanks Jacques Le 14/08/2017 à 17:47, nma...@apache.org a écrit : Author: nmalin Date: Mon Aug 14 15:47:36 2017 New Revision: 1805011 URL: http://svn.apache.org/viewvc?rev=1805011=rev Log: Fixed: Missing fieldInfo when call

Re: svn commit: r1804635 - in /ofbiz/ofbiz-framework/trunk: applications/order/src/main/java/org/apache/ofbiz/order/order/ framework/base/src/main/java/org/apache/ofbiz/base/container/ framework/start

Weirdly it does not complain about @return. Go figure! But I'll apply the same! Jacques Le 10/08/2017 à 08:31, jler...@apache.org a écrit : Author: jleroux Date: Thu Aug 10 06:31:38 2017 New Revision: 1804635 URL: http://svn.apache.org/viewvc?rev=1804635=rev Log: No functional trivial

Re: svn commit: r1802682 - in /ofbiz/ofbiz-framework/trunk/framework: images/webapp/images/fieldlookup.js widget/dtd/widget-form.xsd

Hi Nicolas, Do we have an example of use at https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples ? If not would be great to have Thanks Jacques Le 22/07/2017 à 14:14, nma...@apache.org a écrit : Author: nmalin Date: Sat Jul 22 12:14:59 2017 New Revision: 1802682 URL:

Re: svn commit: r1803413 - /ofbiz/branches/ofbiz-new-website/getting-involved.html

Ah sorry, my external editor (not Eclipse) is set to remove trailing blanks, a lot of false changes below... Jacques Le 30/07/2017 à 11:20, jler...@apache.org a écrit : Author: jleroux Date: Sun Jul 30 09:20:01 2017 New Revision: 1803413 URL: http://svn.apache.org/viewvc?rev=1803413=rev

Re: svn commit: r1800642 - /ofbiz/site/index.html

Hi Sharan, The real date of release is 29/Jun/17. Not sure if we should fix, I guess your date is about the news? I used it for wrongly updating the doap_OFBiz.rdf then noticed. Jacques Le 03/07/2017 à 13:45, sha...@apache.org a écrit : Author: sharan Date: Mon Jul 3 11:45:34 2017 New

Re: svn commit: r1797160 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntityQuery.java

In this commit the bottom change slipped in and should have been part of r1797161 but anyway it's quite simple and clear Jacques Le 01/06/2017 à 10:14, jler...@apache.org a écrit : Author: jleroux Date: Thu Jun 1 08:14:41 2017 New Revision: 1797160 URL: