This is an automated email from the ASF dual-hosted git repository.
gerdogdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwebbeans.git
The following commit(s) were added to refs/heads/master by this push:
new c2b0738 adding comments and cosmetic
Hi Romain
I am going over each file slowly and commit slowly :) there is no reason
otherwise
Regards.
Gurkan
On Thu, Jun 4, 2020 at 3:04 PM Romain Manni-Bucau
wrote:
> I would even say *it compiles in another project* (since if OWB compiles it
> does not prove it is backward compat cause
I don't see any problem,it compiles perfectly :)
On Thu, Jun 4, 2020 at 1:32 PM Mark Struberg
wrote:
> did you double check compile and runtime bytecode compatibility?
>
> -protected abstract Class getMarkerInterface();
> +protected abstract Class getMarkerInterface();
>
> Always have
I would even say *it compiles in another project* (since if OWB compiles it
does not prove it is backward compat cause i'm not sure we impl it in
another module than the one we define it into ;))
BTW any reason for this kind of commit? If you wantto do a global
comment+generic round trip to do
did you double check compile and runtime bytecode compatibility?
-protected abstract Class getMarkerInterface();
+protected abstract Class getMarkerInterface();
Always have to think hard about those types of changes. Seen some unpleasant
surprises in the past ;)
txs and LieGrue,
strub
This is an automated email from the ASF dual-hosted git repository.
gerdogdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwebbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 91dcbf2 adding comments and cosmetic
