[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5483: Add QueryRequest to replace BrokerRequest in query execution engine

mayankshriv commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r434318564 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/v2/utils/BrokerRequestToQueryRequestConverter.java ## @@ -0,0

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5483: Add QueryRequest to replace BrokerRequest in query execution engine

mayankshriv commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-637964051 Should we solve the issues in BrokerRequest, or move to PinotQuery? Latter would be ideal, except in organizations with large Pinot deployments, moving to SQL may

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5461: Adding Support for SQL CASE Statement

mayankshriv commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r434311036 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] yupeng9 commented on pull request #5487: Add multi-value support to SegmentDumpTool

yupeng9 commented on pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487#issuecomment-637961796 @mayankshriv That's true for better code reuse. Though this PR is for a minor improvement, and I believe we could the refactoring in another PR.

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #5487: Add multi-value support to SegmentDumpTool

yupeng9 commented on a change in pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487#discussion_r434310701 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/SegmentDumpTool.java ## @@ -91,11 +102,27 @@ public void doMain(String[] args)

[GitHub] [incubator-pinot] npawar commented on issue #5390: Improve the experience when adding indexes and reloading

npawar commented on issue #5390: URL: https://github.com/apache/incubator-pinot/issues/5390#issuecomment-637941159 I think one approach could be as simple as: We introduce an API for reading physical segment's metadata files `/segments/index-metadata` (need a better name) 1.

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5489: Upgrade pinotdb version to 0.3.1 to use new pinot sql api

fx19880617 opened a new pull request #5489: URL: https://github.com/apache/incubator-pinot/pull/5489 ## Description Upgrade pypi pinotdb(https://pypi.org/project/pinotdb/) version to 0.3.1 to use new pinot sql api. ## Release Notes No

[incubator-pinot] branch upgrade-superset-pinotdb-version created (now 9d9df06)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade-superset-pinotdb-version in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9d9df06 Upgrade pinotdb version to 0.3.1 to use new pinot sql api No new

[incubator-pinot] branch upgrade-superset-pinotdb-version created (now 9d9df06)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade-superset-pinotdb-version in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9d9df06 Upgrade pinotdb version to 0.3.1 to use new pinot sql api No new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5487: Add multi-value support to SegmentDumpTool

fx19880617 commented on a change in pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487#discussion_r434288816 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/SegmentDumpTool.java ## @@ -91,11 +102,27 @@ public void doMain(String[] args)

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5488: Move bintray target to mvn deploy command

jackjlli opened a new pull request #5488: URL: https://github.com/apache/incubator-pinot/pull/5488 This PR moves LinkedIn bintray target as a parameter in `mvn deploy` command. Reference:

[incubator-pinot] 01/01: Remove bintray target to mvn deploy command

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch bintray-cli in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 870b0b99a3d84d43b0dcc1dff8369c74bbd87fa0 Author: Jack Li(Analytics Engineering) AuthorDate: Tue Jun 2

[incubator-pinot] branch bintray-cli created (now 870b0b9)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch bintray-cli in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 870b0b9 Remove bintray target to mvn deploy command This branch includes the following new commits:

[GitHub] [incubator-pinot] guruguha commented on issue #5390: Improve the experience when adding indexes and reloading

guruguha commented on issue #5390: URL: https://github.com/apache/incubator-pinot/issues/5390#issuecomment-637918220 I have an initial approach to this issue: We can introduce a segment state monitor that keeps track of all the segments and their index version updates. Similar to

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #5487: Add multi-value support to SegmentDumpTool

yupeng9 opened a new pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487 Also, add the segment dump tool as part of the pinot-tool.sh script Currently segment dump tool supports single-value only. This change adds the multi-value support. It also makes

[GitHub] [incubator-pinot] guruguha removed a comment on issue #5390: Improve the experience when adding indexes and reloading

guruguha removed a comment on issue #5390: URL: https://github.com/apache/incubator-pinot/issues/5390#issuecomment-637914979 I have an initial approach to this issue: - provide an end point for users to query for segment status - the end point would need to query the ZK to get the

[GitHub] [incubator-pinot] guruguha commented on issue #5390: Improve the experience when adding indexes and reloading

guruguha commented on issue #5390: URL: https://github.com/apache/incubator-pinot/issues/5390#issuecomment-637914979 I have an initial approach to this issue: - provide an end point for users to query for segment status - the end point would need to query the ZK to get the input

[GitHub] [incubator-pinot] kishoreg commented on pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

kishoreg commented on pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#issuecomment-637897871 @sidd only for scalarfunctions. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

siddharthteotia commented on pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#issuecomment-637875934 Is the plan to use this wrapper solely for invoking scalar functions (like already done in this PR for StringFunctions) or are we expecting follow-ups to

[GitHub] [incubator-pinot] jackjlli commented on issue #5485: Remove LinkedIn config from pom

jackjlli commented on issue #5485: URL: https://github.com/apache/incubator-pinot/issues/5485#issuecomment-637868513 @haibow Thanks for the heads up. I can work on this. This is an automated message from the Apache Git

[GitHub] [incubator-pinot] jamesyfshao commented on pull request #5394: add callback interface for upsert component

jamesyfshao commented on pull request #5394: URL: https://github.com/apache/incubator-pinot/pull/5394#issuecomment-637852570 > @jamesyfshao I looked over your design doc, thanks for adding the section on interfaces you need. I also looked at the repo you mentioned. > It is not clear why

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5483: Add QueryRequest to replace BrokerRequest in query execution engine

Jackie-Jiang commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r434193068 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/v2/ServerQuery.java ## @@ -0,0 +1,181 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5336: [Part 4] Deep-store bypass for LLC: Add a peer to peer segment fetcher.

mcvsubbu commented on a change in pull request #5336: URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r434191769 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/PeerServerSegmentFetcher.java ## @@ -0,0 +1,155 @@ +/** + *

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5394: add callback interface for upsert component

mcvsubbu commented on pull request #5394: URL: https://github.com/apache/incubator-pinot/pull/5394#issuecomment-637813614 @jamesyfshao I looked over your design doc, thanks for adding the section on interfaces you need. I also looked at the repo you mentioned. It is not clear why we

[incubator-pinot] branch master updated: Add a new table config field for peer segment download. (#5478)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8a3eb43 Add a new table config

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5478: Add a new table config field for peer segment download.

mcvsubbu merged pull request #5478: URL: https://github.com/apache/incubator-pinot/pull/5478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5486: Changed the segment commit protocol to send/receive streamPartitionMs…

mcvsubbu opened a new pull request #5486: URL: https://github.com/apache/incubator-pinot/pull/5486 …gOffset Updated the segment commit protocol so that new element streamPartitionMsgOffset is populated in requests (as request parameters) and in response (as JSON string element)

[GitHub] [incubator-pinot] jamesyfshao commented on pull request #5394: add callback interface for upsert component

jamesyfshao commented on pull request #5394: URL: https://github.com/apache/incubator-pinot/pull/5394#issuecomment-637721377 > Hey James, the last we discussed, I thought the only callback needed was after the realtime row was indexed. > > Can you add to your design doc the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5444: Enhance and simplify the filtering

Jackie-Jiang commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r434066870 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5444: Enhance and simplify the filtering

Jackie-Jiang commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r434064515 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5444: Enhance and simplify the filtering

Jackie-Jiang commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r434063565 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ArrayBasedDocIdIterator.java ## @@ -36,37 +35,15 @@

[GitHub] [incubator-pinot] fx19880617 merged pull request #5480: Adding more information into jar manifest

fx19880617 merged pull request #5480: URL: https://github.com/apache/incubator-pinot/pull/5480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (ed26e85 -> aae985f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ed26e85 [TE] fix document for adding new application (#5473) add aae985f Adding more information

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5478: Add a new table config field for peer segment download.

mcvsubbu commented on a change in pull request #5478: URL: https://github.com/apache/incubator-pinot/pull/5478#discussion_r433971348 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java ## @@ -201,4 +207,16 @@ public static void

[GitHub] [incubator-pinot] haibow opened a new issue #5485: Remove LinkedIn config from pom

haibow opened a new issue #5485: URL: https://github.com/apache/incubator-pinot/issues/5485 In #5190, LinkedIn deployment configs were added to the pom file. This caused Apache release to fail, and I had to remove the following lines:

svn commit: r39878 - /dev/incubator/pinot/apache-pinot-incubating-0.4.0-rc2/

Author: haibow Date: Tue Jun 2 06:49:10 2020 New Revision: 39878 Log: Update apache-pinot-incubating-0.4.0-rc2 Added: dev/incubator/pinot/apache-pinot-incubating-0.4.0-rc2/ dev/incubator/pinot/apache-pinot-incubating-0.4.0-rc2/apache-pinot-incubating-0.4.0-bin.tar.gz (with props)

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433647278 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433642778 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ArrayBasedDocIdIterator.java ## @@ -36,37 +35,15 @@ public

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433641032 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */