Jackie-Jiang merged pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9196fcb fetch all columns and datatype
Jackie-Jiang commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452638749
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package org
Jackie-Jiang commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452638076
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package org
Jackie-Jiang commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452636141
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package org
Jackie-Jiang commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452635238
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package org
suvodeep-pyne commented on pull request #5678:
URL: https://github.com/apache/incubator-pinot/pull/5678#issuecomment-656486226
The updated readme is visible here:
https://github.com/suvodeep-pyne/incubator-pinot/tree/tedocsreadme/thirdeye/docs.
suvodeep-pyne opened a new pull request #5678:
URL: https://github.com/apache/incubator-pinot/pull/5678
## Description
Updated Readme.md in ThirdEye Documentation
- Added links to install sphinx which is required to build the docs
- Refactored the readme and added some useful links
yupeng9 commented on pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#issuecomment-656481288
> > > High level question, why are we using JTS library to handle both
geometry as well as geography? Shouldn't we use ESRI for geography?
> >
> >
> > Good cal
fx19880617 closed issue #5663:
URL: https://github.com/apache/incubator-pinot/issues/5663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fx19880617 merged pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b327509 Rewrite non-aggregate group b
siddharthteotia commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452579380
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package
siddharthteotia commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452578944
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package
siddharthteotia commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452579025
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package
siddharthteotia commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-pinot/pull/5665#discussion_r452578914
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/TarGzCompressionUtils.java
##
@@ -18,225 +18,151 @@
*/
package
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch rewrite-non-groupby-to-distinct
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from d5103df Adding tests to DistinctQueriesTest
add 87468d1 Update DistinctQuer
fx19880617 merged pull request #5676:
URL: https://github.com/apache/incubator-pinot/pull/5676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ac08325 Fixing a backward compatible
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 3497cc3 Pinot S3Fs fix (#5670)
add e82e0fa Remove ForwardIndexType and InvertedIndexType. These e
siddharthteotia commented on pull request #5668:
URL: https://github.com/apache/incubator-pinot/pull/5668#issuecomment-656429936
> LGTM. Not sure should we keep the TextIndexType
It is already there part of persistent data so removing it is backward
incompatible (although possible).
siddharthteotia merged pull request #5668:
URL: https://github.com/apache/incubator-pinot/pull/5668
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
siddharthteotia commented on a change in pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#discussion_r452572766
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
##
@@ -347,19 +389,16 @@ private DistinctTable g
siddharthteotia commented on a change in pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#discussion_r452572531
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
##
@@ -179,18 +179,15 @@ private ImmutableSegmen
npawar opened a new issue #5677:
URL: https://github.com/apache/incubator-pinot/issues/5677
In PR https://github.com/apache/incubator-pinot/pull/5484 we introduced the
concept of extracting all fields in the extractor, if the fieldsToRead is
empty/null. However this was done only for JSON
npawar closed issue #5615:
URL: https://github.com/apache/incubator-pinot/issues/5615
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
npawar commented on pull request #5656:
URL: https://github.com/apache/incubator-pinot/pull/5656#issuecomment-656426514
https://github.com/apache/incubator-pinot/issues/5615
This is an automated message from the Apache Git Se
pradeepgv42 commented on pull request #5661:
URL: https://github.com/apache/incubator-pinot/pull/5661#issuecomment-656403593
@Jackie-Jiang I tried with your changes, along with some bug fixes that
went into the master.
I still see the select * from table order by col limit 10 to take si
fx19880617 opened a new pull request #5676:
URL: https://github.com/apache/incubator-pinot/pull/5676
## Description
Presto generates and sends segment level query directly to Pinot Servers.
The BrokerRequest sent only set LIMIT inside the Selections object.
Below is a sample con
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch backward_compatible_presto_select_query
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard e91a6d9 Fixing a backward compatible issue of converting
BrokerRequest t
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch backward_compatible_presto_select_query
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit e91a6d97cd2d8674afe98d5fb8b69cf6b75f5ec8
Author: Xiang Fu
AuthorDate: Thu Jul
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch backward_compatible_presto_select_query
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at e91a6d9 Fixing a backward compatible issue of converting
BrokerRequest t
KKcorps commented on pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673#issuecomment-656367342
@kishoreg can we merge it now?
This is an automated message from the Apache Git Service.
To respond
fx19880617 commented on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656365240
> DistinctQueriesTest
> For completeness, it would be nice to add tests to DistinctQueriesTest
file as well. It has both single column, multi column alo
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch rewrite-non-groupby-to-distinct
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 25d70e4 Rewrite non-aggregate group by query to distinct query
add d5103df
Jackie-Jiang commented on pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#issuecomment-656319848
> > High level question, why are we using JTS library to handle both
geometry as well as geography? Shouldn't we use ESRI for geography?
>
> Good call.
> T
Jackie-Jiang commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#discussion_r452448439
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/geospatial/GeometryType.java
##
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apach
Jackie-Jiang opened a new issue #5675:
URL: https://github.com/apache/incubator-pinot/issues/5675
Use maven plugin to check the code style and fail the build if the check
does not pass
This is an automated message from the A
daniellavoie commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452430603
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSe
yupeng9 commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#discussion_r452419516
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/geospatial/GeometryType.java
##
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Sof
fx19880617 edited a comment on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656267927
> Not related to this PR, but when I had added DISTINCT, I don't think alias
support was there. So alias query tests are not there for DISTINCT. You might
want
yupeng9 edited a comment on pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#issuecomment-656268431
> High level question, why are we using JTS library to handle both geometry
as well as geography? Shouldn't we use ESRI for geography?
Good call.
There a
yupeng9 commented on pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#issuecomment-656268431
> High level question, why are we using JTS library to handle both geometry
as well as geography? Shouldn't we use ESRI for geography?
Good call.
There are two
fx19880617 commented on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656267927
> Not related to this PR, but when I had added DISTINCT, I don't think alias
support was there. So alias query tests are not there for DISTINCT. You might
want to add
fx19880617 commented on a change in pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#discussion_r452391596
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -196,13 +198,25 @@ private static boolean is
yupeng9 commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-pinot/pull/5654#discussion_r452386815
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/geospatial/GeometryType.java
##
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Sof
KKcorps commented on a change in pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673#discussion_r452366492
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
##
@@ -61,6 +63,33 @@ public String
KKcorps commented on a change in pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673#discussion_r452366297
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
##
@@ -61,6 +63,33 @@ public String
kishoreg merged pull request #5670:
URL: https://github.com/apache/incubator-pinot/pull/5670
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 1a420b2 Add integration test for theta sketches (#5514)
add 3497cc3 Pinot S3Fs fix (#5670)
No new
mayankshriv commented on a change in pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#discussion_r452327225
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -331,12 +345,59 @@ private static void quer
daniellavoie commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452329124
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSe
kishoreg commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452326951
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmen
pradeepgv42 commented on pull request #5661:
URL: https://github.com/apache/incubator-pinot/pull/5661#issuecomment-656213872
Will try it out sometime today and let you know
This is an automated message from the Apache Git Ser
mayankshriv merged pull request #5514:
URL: https://github.com/apache/incubator-pinot/pull/5514
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 2ec7dee Optimize selection order-by when not all selected expressions
are ordered (#5661)
add 1a420b
daniellavoie commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452324220
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/env/PinotConfigurationTest.java
##
@@ -24,24 +24,116 @@
import java.nio.file.Fil
mayankshriv commented on a change in pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673#discussion_r452322783
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
##
@@ -61,6 +63,33 @@ public St
mayankshriv commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452321071
##
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/env/PinotConfigurationTest.java
##
@@ -24,24 +24,116 @@
import java.nio.file.File
daniellavoie opened a new pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674
This PR aims to be merge into branch `pinot-fs-bug-fix` to contribute on [PR
5669](https://github.com/apache/incubator-pinot/pull/5669)
-
daniellavoie commented on pull request #5669:
URL: https://github.com/apache/incubator-pinot/pull/5669#issuecomment-656185949
https://github.com/apache/incubator-pinot/pull/5674 can actually be merged
on this PR branch.
This
daniellavoie commented on pull request #5669:
URL: https://github.com/apache/incubator-pinot/pull/5669#issuecomment-656182611
@kishoreg I've added full test coverage on PinotConfiguration. The base
constructor that accepts Commons Configuration was broken and has been fixed. I
also identif
KKcorps opened a new pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673
The patch is needed to provide ResultSet metadata to JDBC driver.
The driver requires a column data type in response and currently there is
not way to fetch that.
-
siddharthteotia commented on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656138929
Not related to this PR, but when I had added DISTINCT, I don't think alias
support was there. So alias query tests are not there for DISTINCT. You might
want to
siddharthteotia edited a comment on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656132865
For completeness, it would be nice to add tests to DistinctQueriesTest file
as well. It has both single column, multi column along with transform function
siddharthteotia commented on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656132865
For completeness, it would be nice to add tests to DistinctQueriesTest file
as well. It has both single column, multi column along with transform function
tests
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch rewrite-non-groupby-to-distinct
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 83adf32 Rewrite non-aggregate group by query to distinct query
add 25d70e4
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch rewrite-non-groupby-to-distinct
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 74f8567 Rewrite non-aggregate group by query to distinct query
add 83adf32
68 matches
Mail list logo
