[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5780: TableCache Enhancement

kishoreg commented on a change in pull request #5780: URL: https://github.com/apache/incubator-pinot/pull/5780#discussion_r463424152 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/helix/TableCache.java ## @@ -18,190 +18,308 @@ */ package org.apache.p

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #5783: Avoid redundant creation & merging of empty sketches.

mayankshriv opened a new pull request #5783: URL: https://github.com/apache/incubator-pinot/pull/5783 For segments where no rows are selected, the intermediate and the final merge steps still create empty Union objects and merge them. This can cause huge latency degradation in cases

[GitHub] [incubator-pinot] snleee opened a new pull request #5782: Enhancing the segment replacement api

snleee opened a new pull request #5782: URL: https://github.com/apache/incubator-pinot/pull/5782 1. Chekcing ONLINE state from the EV when updating the segment lineage. 2. Trigger the routing table rebuild to brokers when updating the segment lineage. ---

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #5781: Lazy initialization of ForwardIndexReaderContext.

mayankshriv opened a new pull request #5781: URL: https://github.com/apache/incubator-pinot/pull/5781 Reader context is currently getting eager-initialized during operator initialization. In certain cases this leads to OOM for direct memory as follows: - Consider a case where we h

[incubator-pinot] branch master updated (0fc0811 -> 2c0b999)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0fc0811 add user info in url to auth header in HTTP getDownloadFileRequest (#5772) add 2c0b999 Add se

[GitHub] [incubator-pinot] snleee commented on pull request #5728: Add segment lineage based segment selector

snleee commented on pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#issuecomment-666903009 #5728 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] snleee merged pull request #5728: Add segment lineage based segment selector

snleee merged pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch table_cache created (now f64b211)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch table_cache in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at f64b211 Refactor TableCache This branch includes the following new commits: new f64b211 Refact

[incubator-pinot] 01/01: Refactor TableCache

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch table_cache in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit f64b211c9980695ac96aba11f67b026aa1f6ec8c Author: Xiaotian (Jackie) Jiang AuthorDate: Thu Jul 30 18:44:04 2

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5780: TableCache Enhancement

Jackie-Jiang opened a new pull request #5780: URL: https://github.com/apache/incubator-pinot/pull/5780 Refactor TableCache with the following enhancement: - Support caching schema - Correctly handle table config and schema change and remove - Significantly reduce the ZK read (only n

[GitHub] [incubator-pinot] akshayrai merged pull request #5779: revert comment-out for merging

akshayrai merged pull request #5779: URL: https://github.com/apache/incubator-pinot/pull/5779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch thirdeye-elr updated (74ca8b6 -> 6a244e2)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch thirdeye-elr in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 74ca8b6 [TE] minor fix (#5777) add 6a244e2 revert comment-out for merging (#5779) No new

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5779: revert comment-out for merging

vincentchenjl opened a new pull request #5779: URL: https://github.com/apache/incubator-pinot/pull/5779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5728: Add segment lineage based segment selector

Jackie-Jiang commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r46041 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463329083 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463328679 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463328679 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463323754 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463326927 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java ## @@ -312,6 +314,8 @@ public synchronized void build

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463323754 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] jasonyanwenl commented on pull request #5769: [TE] add anomaly detection as a service - Phase 1

jasonyanwenl commented on pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#issuecomment-666769896 @suvodeep-pyne Thanks for your feedback! For each of your points: * I think those pieces of code are related to each other so currently there is no plan to separa

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463323754 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] bxji commented on a change in pull request #5778: [TE] The endpoint for searching anomalies and pagination

bxji commented on a change in pull request #5778: URL: https://github.com/apache/incubator-pinot/pull/5778#discussion_r463314454 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearchResource.java ## @@ -0,0

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

jihaozh commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r463308961 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -0,0 +1,756 @@ +/

[incubator-pinot] branch anomalies-pagination updated (a9d4aea -> ee879b1)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch anomalies-pagination in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a9d4aea unit tests discard ffb0c3b new anomalies endpoint add ee879b1 - new anomalies

[GitHub] [incubator-pinot] jihaozh opened a new pull request #5778: [TE] The endpoint for searching anomalies and pagination

jihaozh opened a new pull request #5778: URL: https://github.com/apache/incubator-pinot/pull/5778 This PR creates the endpoints for searching and paginate the anomalies. The endpoint is built for the anomaly page v3. It brings the response time from ~30s to around 300ms. We should see a ~1

[GitHub] [incubator-pinot] kishoreg merged pull request #5772: add user info in url to auth header in HTTP getDownloadFileRequest

kishoreg merged pull request #5772: URL: https://github.com/apache/incubator-pinot/pull/5772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (cb7de23 -> 0fc0811)

This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cb7de23 [TE] Added a backfill start date for Anomaly Detection (#5740) add 0fc0811 add user info in

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5772: add user info in url to auth header in HTTP getDownloadFileRequest

kishoreg commented on a change in pull request #5772: URL: https://github.com/apache/incubator-pinot/pull/5772#discussion_r463227671 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java ## @@ -326,6 +327,11 @@ private static Http

[GitHub] [incubator-pinot] akshayrai merged pull request #5777: [TE] minor fix

akshayrai merged pull request #5777: URL: https://github.com/apache/incubator-pinot/pull/5777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch thirdeye-elr updated (323d1b1 -> 74ca8b6)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch thirdeye-elr in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 323d1b1 [TE] minor fix to trigger ELR (#5776) add 74ca8b6 [TE] minor fix (#5777) No new r

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5777: [TE] minor fix

vincentchenjl opened a new pull request #5777: URL: https://github.com/apache/incubator-pinot/pull/5777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-pinot] branch thirdeye-elr updated (6cd415f -> 323d1b1)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch thirdeye-elr in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6cd415f [TE] remove linkedin bintray from pom and add override (#5773) add 323d1b1 [TE] mi

[GitHub] [incubator-pinot] akshayrai merged pull request #5776: [TE] minor fix to trigger ELR

akshayrai merged pull request #5776: URL: https://github.com/apache/incubator-pinot/pull/5776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5776: [TE] minor fix to trigger ELR

vincentchenjl opened a new pull request #5776: URL: https://github.com/apache/incubator-pinot/pull/5776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5728: Add segment lineage based segment selector

Jackie-Jiang commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r463208420 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentPreSelector.java ## @@ -0

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5774: Config recommendation engine

siddharthteotia commented on pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#issuecomment-666598254 Fantastic work @jasperjiaguo . Really looking forward to using this. Please give me a day or two to finish the review. This is amazing. Thanks -

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5769: [TE] add anomaly detection as a service - Phase 1

suvodeep-pyne commented on pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#issuecomment-666597454 Some thoughts: - It would be great if this PR can be split into smaller PRs: For example, the OnlineDataSource, TaskDriver changes and Resource changes seem like

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5775: [TE] remove linkedin bintray from pom and add override (#5773)

vincentchenjl opened a new pull request #5775: URL: https://github.com/apache/incubator-pinot/pull/5775 Temp PR to test new ELR script of ThirdEye This is an automated message from the Apache Git Service. To respond to the me

[incubator-pinot] branch master updated (10117ae -> cb7de23)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 10117ae Add untar failure server meter (#5768) add cb7de23 [TE] Added a backfill start date for

[GitHub] [incubator-pinot] jasperjiaguo opened a new pull request #5774: Config recommendation engine

jasperjiaguo opened a new pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774 ## Description This is the continuation of the project Pinot-Tuna, issue 4461. In this PR we design an extensible engine that takes an input json with schema, column metadata, qps, etc

[GitHub] [incubator-pinot] akshayrai merged pull request #5740: [TE] Added a backfill start date for Anomaly Detection

akshayrai merged pull request #5740: URL: https://github.com/apache/incubator-pinot/pull/5740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch thirdeye-elr updated: [TE] remove linkedin bintray from pom and add override (#5773)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch thirdeye-elr in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/thirdeye-elr by this push: new 6cd415f [TE] remove l

[GitHub] [incubator-pinot] akshayrai merged pull request #5773: [TE] remove linkedin bintray from pom and add override

akshayrai merged pull request #5773: URL: https://github.com/apache/incubator-pinot/pull/5773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5773: [TE] remove linkedin bintray from pom and add override

vincentchenjl opened a new pull request #5773: URL: https://github.com/apache/incubator-pinot/pull/5773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-pinot] branch thirdeye-elr created (now 10117ae)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch thirdeye-elr in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 10117ae Add untar failure server meter (#5768) No new revisions were added by this update. --

[incubator-pinot] branch add-retry-to-download-segment updated (7c89f3d -> 22f575a)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-retry-to-download-segment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7c89f3d Address PR comment discard bce865a Add retry logic to download segment tar f

[GitHub] [incubator-pinot] jackjlli merged pull request #5768: Add untar failure server meter

jackjlli merged pull request #5768: URL: https://github.com/apache/incubator-pinot/pull/5768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (b1ab891 -> 10117ae)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b1ab891 [TE] Embed cube algorithm results in email (#5770) add 10117ae Add untar failure server meter (

[incubator-pinot] branch add-untar-failure-server-meter updated (ef93477 -> f5bce1a)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-untar-failure-server-meter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ef93477 Add untar failure server meter add f5bce1a Address PR comment No new r

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5768: Add untar failure server meter

mayankshriv commented on a change in pull request #5768: URL: https://github.com/apache/incubator-pinot/pull/5768#discussion_r463124006 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentFetcherAndLoader.java ## @@ -202,18 +206,22 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5764: Add retry logic to download segment tar file in pinot server

mayankshriv commented on a change in pull request #5764: URL: https://github.com/apache/incubator-pinot/pull/5764#discussion_r463123037 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentFetcherAndLoader.java ## @@ -184,39 +186,48 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5772: add user info in url to auth header in HTTP getDownloadFileRequest

mayankshriv commented on pull request #5772: URL: https://github.com/apache/incubator-pinot/pull/5772#issuecomment-666508205 Note, the retention on slack is very limited, so you may want to capture the discussion in this PR as well (instead of link to conversation). --

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r462991298 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentSelector.java ## @@ -0,0 +1,69

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5728: Add segment lineage based segment selector

snleee commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r462991006 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentLineageBasedSegmentSelector.java ## @@ -0,0 +1,69

[GitHub] [incubator-pinot] mr-agrwal opened a new pull request #5772: add user info in url to auth header

mr-agrwal opened a new pull request #5772: URL: https://github.com/apache/incubator-pinot/pull/5772 ## Description Add a description of your PR here. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero down

[GitHub] [incubator-pinot] jasonyanwenl opened a new pull request #5769: [TE] add anomaly detection as a service - Phase 1

jasonyanwenl opened a new pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769 This PR creates three endpoints for providing anomaly detection as the REST API service. Endpoints are provided in a new class called `AnomalyDetectionResource`. - The 1st endpoint is

[GitHub] [incubator-pinot] kishoreg commented on issue #5753: Built-in jobs to move segments of hybrid tables from Realtime Servers to Offline Servers

kishoreg commented on issue #5753: URL: https://github.com/apache/incubator-pinot/issues/5753#issuecomment-665860439 @Jackie-Jiang Interesting idea. I am all for removing the distinction between real-time and offline tables. --

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5744: [Part 2] Add geo support - add a geo aggregate function st_union

Jackie-Jiang commented on a change in pull request #5744: URL: https://github.com/apache/incubator-pinot/pull/5744#discussion_r462487384 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/StUnionAggregationFunction.java ## @@ -0,0 +1,137 @@

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5744: [Part 2] Add geo support - add a geo aggregate function st_union

Jackie-Jiang merged pull request #5744: URL: https://github.com/apache/incubator-pinot/pull/5744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #5744: [Part 2] Add geo support - add a geo aggregate function st_union

yupeng9 commented on a change in pull request #5744: URL: https://github.com/apache/incubator-pinot/pull/5744#discussion_r462486030 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/StUnionAggregationFunction.java ## @@ -0,0 +1,137 @@ +/**

[GitHub] [incubator-pinot] akshayrai merged pull request #5770: [TE] Embed cube algorithm results in email

akshayrai merged pull request #5770: URL: https://github.com/apache/incubator-pinot/pull/5770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] jihaozh merged pull request #5767: [TE] add auto-loading dimension filters on RCA frontend

jihaozh merged pull request #5767: URL: https://github.com/apache/incubator-pinot/pull/5767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5768: Add untar failure server meter

jackjlli opened a new pull request #5768: URL: https://github.com/apache/incubator-pinot/pull/5768 ## Description This PR adds untar failure server meter, so that we know how often this exception happens in production. ---

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5753: Built-in jobs to move segments of hybrid tables from Realtime Servers to Offline Servers

Jackie-Jiang commented on issue #5753: URL: https://github.com/apache/incubator-pinot/issues/5753#issuecomment-665818695 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5770: [TE] Embed cube algorithm results in email

akshayrai opened a new pull request #5770: URL: https://github.com/apache/incubator-pinot/pull/5770 Continuation of #5744 This PR deals with the rendering of the cube api results in the email. This is an automated message

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5559: Table truncate command

mcvsubbu commented on issue #5559: URL: https://github.com/apache/incubator-pinot/issues/5559#issuecomment-665978098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] fx19880617 commented on issue #5753: Built-in jobs to move segments of hybrid tables from Realtime Servers to Offline Servers

fx19880617 commented on issue #5753: URL: https://github.com/apache/incubator-pinot/issues/5753#issuecomment-665945918 > @kishoreg I'm not sure if we should move realtime completed segments to offline servers, or to another set of realtime servers. For a realtime only table, I don't see t

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5764: Add retry logic to download segment tar file in pinot server

jackjlli commented on a change in pull request #5764: URL: https://github.com/apache/incubator-pinot/pull/5764#discussion_r462575993 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentFetcherAndLoader.java ## @@ -184,39 +186,48 @@ private boo

[GitHub] [incubator-pinot] jihaozh merged pull request #5735: [TE] add enpoints to save dimension filter for RCA v2 POC

jihaozh merged pull request #5735: URL: https://github.com/apache/incubator-pinot/pull/5735 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #5771: Improve performance for DISTINCT queries

Jackie-Jiang opened a new issue #5771: URL: https://github.com/apache/incubator-pinot/issues/5771 Optimizations to consider: - Early-termination for DISTINCT without order-by (need to model DISTINCT as a new operator instead of aggregation function) - Store dictIds inner segment to re

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5771: Improve performance for DISTINCT queries

Jackie-Jiang commented on issue #5771: URL: https://github.com/apache/incubator-pinot/issues/5771#issuecomment-666155362 - Use dictionary to solve query without filter - Specialize DISTINCT on single column (store Object instead of Object[] in the set)